Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] New package lcdproc
@ 2012-03-07 18:01 Simon Dawson
  2012-03-07 18:05 ` Simon Dawson
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Dawson @ 2012-03-07 18:01 UTC (permalink / raw)
  To: buildroot

Patch to add lcdproc package (LCD display driver daemon and clients) to
buildroot.

http://lcdproc.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildroot-lcdproc.patch
Type: text/x-patch
Size: 2054 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120307/7d6f3127/attachment-0001.bin>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] New package lcdproc
  2012-03-07 18:01 [Buildroot] New package lcdproc Simon Dawson
@ 2012-03-07 18:05 ` Simon Dawson
  2012-03-07 19:21   ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Dawson @ 2012-03-07 18:05 UTC (permalink / raw)
  To: buildroot

diff --git a/package/Config.in b/package/Config.in
index 41cbb8c..4237e3f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -302,6 +302,7 @@ source "package/gtk2-engines/Config.in"
 source "package/gtk2-themes/Config.in"
 source "package/imlib2/Config.in"
 source "package/jpeg/Config.in"
+source "package/lcdproc/Config.in"
 source "package/libart/Config.in"
 source "package/libdrm/Config.in"
 source "package/libexif/Config.in"
diff --git a/package/lcdproc/Config.in b/package/lcdproc/Config.in
new file mode 100644
index 0000000..68dc46c
--- /dev/null
+++ b/package/lcdproc/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LCDPROC
+	bool "lcdproc"
+	select BR2_PACKAGE_NCURSES
+	help
+	LCD display driver daemon and clients
+
+	 http://lcdproc.org/
diff --git a/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
b/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
new file mode 100644
index 0000000..f5702ff
--- /dev/null
+++ b/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
@@ -0,0 +1,11 @@
+--- lcdproc-0.5.3/LCDd.conf.orig	2009-06-20 14:48:34.000000000 +0100
++++ lcdproc-0.5.3/LCDd.conf	2010-05-11 10:02:21.000000000 +0100
+@@ -34,7 +34,7 @@
+ #            the driver modules and will thus not be able to
+ #            function properly.
+ # NOTE: Always place a slash as last character !
+-DriverPath=server/drivers/
++DriverPath=/usr/lib/lcdproc/
+
+ # Tells the server to load the given drivers. Multiple lines can be given.
+ # The name of the driver is case sensitive and determines the section
diff --git a/package/lcdproc/lcdproc.mk b/package/lcdproc/lcdproc.mk
new file mode 100644
index 0000000..20c43ee
--- /dev/null
+++ b/package/lcdproc/lcdproc.mk
@@ -0,0 +1,16 @@
+#############################################################
+#
+# lcdproc
+#
+#############################################################
+LCDPROC_VERSION = 0.5.5
+
+LCDPROC_AUTORECONF = YES
+LCDPROC_INSTALL_STAGING = NO
+LCDPROC_INSTALL_TARGET = YES
+
+LCDPROC_CONF_OPT = --enable-drivers=all
+
+LCDPROC_DEPENDENCIES = uclibc ncurses
+
+$(eval $(call AUTOTARGETS))

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] New package lcdproc
  2012-03-07 18:05 ` Simon Dawson
@ 2012-03-07 19:21   ` Thomas Petazzoni
  2012-03-07 21:10     ` Simon Dawson
       [not found]     ` <CAHt8ZCMVj5nQ=TZYnBktWHrxqYtwg_1oM5SimyaBFm3uaGZ1Ag@mail.gmail.com>
  0 siblings, 2 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2012-03-07 19:21 UTC (permalink / raw)
  To: buildroot

Hello,

Please add your Signed-off-by line in the commit log.

Le Wed, 7 Mar 2012 18:05:17 +0000,
Simon Dawson <spdawson@gmail.com> a ?crit :

> +++ b/package/lcdproc/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LCDPROC
> +	bool "lcdproc"
> +	select BR2_PACKAGE_NCURSES
> +	help
> +	LCD display driver daemon and clients

Indentation for the help text should be one tab + two spaces.

> diff --git a/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
> b/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
> new file mode 100644
> index 0000000..f5702ff
> --- /dev/null
> +++ b/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
> @@ -0,0 +1,11 @@
> +--- lcdproc-0.5.3/LCDd.conf.orig	2009-06-20
> 14:48:34.000000000 +0100 ++++ lcdproc-0.5.3/LCDd.conf
> 2010-05-11 10:02:21.000000000 +0100 +@@ -34,7 +34,7 @@

For all patches, we require a description and a signed-off-by line.

> --- /dev/null
> +++ b/package/lcdproc/lcdproc.mk
> @@ -0,0 +1,16 @@
> +#############################################################
> +#
> +# lcdproc
> +#
> +#############################################################
> +LCDPROC_VERSION = 0.5.5
> +
> +LCDPROC_AUTORECONF = YES

Do you have a good reason to do this ?

I am surprised to not site any URL for the tarball. Is it because the
tarball is available from Sourceforge (which is the default download
location when no other URL is specified) ?

> +LCDPROC_INSTALL_STAGING = NO
> +LCDPROC_INSTALL_TARGET = YES

You can get rid of those lines, they are the default values.

> +LCDPROC_CONF_OPT = --enable-drivers=all
> +
> +LCDPROC_DEPENDENCIES = uclibc ncurses

The 'uclibc' dependencies is unnecessary. You have the guarantee that
the toolchain has been built and the C library installed before any
package gets built.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] New package lcdproc
  2012-03-07 19:21   ` Thomas Petazzoni
@ 2012-03-07 21:10     ` Simon Dawson
       [not found]     ` <CAHt8ZCMVj5nQ=TZYnBktWHrxqYtwg_1oM5SimyaBFm3uaGZ1Ag@mail.gmail.com>
  1 sibling, 0 replies; 5+ messages in thread
From: Simon Dawson @ 2012-03-07 21:10 UTC (permalink / raw)
  To: buildroot

Hi Thomas.

Thanks for your comments; re-worked patch attached below.

Simon.

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---

diff --git a/package/Config.in b/package/Config.in
index 41cbb8c..4237e3f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -302,6 +302,7 @@ source "package/gtk2-engines/Config.in"
 source "package/gtk2-themes/Config.in"
 source "package/imlib2/Config.in"
 source "package/jpeg/Config.in"
+source "package/lcdproc/Config.in"
 source "package/libart/Config.in"
 source "package/libdrm/Config.in"
 source "package/libexif/Config.in"
diff --git a/package/lcdproc/Config.in b/package/lcdproc/Config.in
new file mode 100644
index 0000000..be3a1f8
--- /dev/null
+++ b/package/lcdproc/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LCDPROC
+       bool "lcdproc"
+       select BR2_PACKAGE_NCURSES
+       help
+         LCD display driver daemon and clients
+
+         http://lcdproc.org/
diff --git a/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
b/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
new file mode 100644
index 0000000..4d6e623
--- /dev/null
+++ b/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
@@ -0,0 +1,18 @@
+Fix the default LCDd configuration file, so that the DriverPath
+is set to the correct lcdproc library install path, rather than
+the dummy/default path.
+
+Signed-off-by: Simon Dawson <spdawson@gmail.com>
+---
+
+--- lcdproc-0.5.3/LCDd.conf.orig       2009-06-20 14:48:34.000000000 +0100
++++ lcdproc-0.5.3/LCDd.conf    2010-05-11 10:02:21.000000000 +0100
+@@ -34,7 +34,7 @@
+ #            the driver modules and will thus not be able to
+ #            function properly.
+ # NOTE: Always place a slash as last character !
+-DriverPath=server/drivers/
++DriverPath=/usr/lib/lcdproc/
+
+ # Tells the server to load the given drivers. Multiple lines can be given.
+ # The name of the driver is case sensitive and determines the section
diff --git a/package/lcdproc/lcdproc.mk b/package/lcdproc/lcdproc.mk
new file mode 100644
index 0000000..3b2b153
--- /dev/null
+++ b/package/lcdproc/lcdproc.mk
@@ -0,0 +1,14 @@
+#############################################################
+#
+# lcdproc
+#
+#############################################################
+LCDPROC_VERSION := 0.5.5
+LCDPROC_SOURCE := lcdproc-$(LCDPROC_VERSION).tar.gz
+LCDPROC_SITE :=
http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/lcdproc/
+
+LCDPROC_CONF_OPT := --enable-drivers=all
+
+LCDPROC_DEPENDENCIES := ncurses
+
+$(eval $(call AUTOTARGETS))

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] New package lcdproc
       [not found]       ` <20120308090516.06e1e329@skate>
@ 2012-03-09 12:44         ` Simon Dawson
  0 siblings, 0 replies; 5+ messages in thread
From: Simon Dawson @ 2012-03-09 12:44 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Simon Dawson <spdawson@gmail.com>

---
 package/Config.in                             |    1 +
 package/lcdproc/Config.in                     |    7 +++++++
 package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch |   18 ++++++++++++++++++
 package/lcdproc/lcdproc.mk                    |   14 ++++++++++++++
 4 files changed, 40 insertions(+), 0 deletions(-)
 create mode 100644 package/lcdproc/Config.in
 create mode 100644 package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
 create mode 100644 package/lcdproc/lcdproc.mk

diff --git a/package/Config.in b/package/Config.in
index 41cbb8c..4237e3f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -302,6 +302,7 @@ source "package/gtk2-engines/Config.in"
 source "package/gtk2-themes/Config.in"
 source "package/imlib2/Config.in"
 source "package/jpeg/Config.in"
+source "package/lcdproc/Config.in"
 source "package/libart/Config.in"
 source "package/libdrm/Config.in"
 source "package/libexif/Config.in"
diff --git a/package/lcdproc/Config.in b/package/lcdproc/Config.in
new file mode 100644
index 0000000..be3a1f8
--- /dev/null
+++ b/package/lcdproc/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LCDPROC
+       bool "lcdproc"
+       select BR2_PACKAGE_NCURSES
+       help
+         LCD display driver daemon and clients
+
+         http://lcdproc.org/
diff --git a/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
b/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
new file mode 100644
index 0000000..4d6e623
--- /dev/null
+++ b/package/lcdproc/lcdproc-0.5.5-LCDd.conf.patch
@@ -0,0 +1,18 @@
+Fix the default LCDd configuration file, so that the DriverPath
+is set to the correct lcdproc library install path, rather than
+the dummy/default path.
+
+Signed-off-by: Simon Dawson <spdawson@gmail.com>
+---
+
+--- lcdproc-0.5.3/LCDd.conf.orig       2009-06-20 14:48:34.000000000 +0100
++++ lcdproc-0.5.3/LCDd.conf    2010-05-11 10:02:21.000000000 +0100
+@@ -34,7 +34,7 @@
+ #            the driver modules and will thus not be able to
+ #            function properly.
+ # NOTE: Always place a slash as last character !
+-DriverPath=server/drivers/
++DriverPath=/usr/lib/lcdproc/
+
+ # Tells the server to load the given drivers. Multiple lines can be given.
+ # The name of the driver is case sensitive and determines the section
diff --git a/package/lcdproc/lcdproc.mk b/package/lcdproc/lcdproc.mk
new file mode 100644
index 0000000..b7c0e23
--- /dev/null
+++ b/package/lcdproc/lcdproc.mk
@@ -0,0 +1,14 @@
+#############################################################
+#
+# lcdproc
+#
+#############################################################
+LCDPROC_VERSION = 0.5.5
+LCDPROC_SOURCE = lcdproc-$(LCDPROC_VERSION).tar.gz
+LCDPROC_SITE =
http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/lcdproc/
+
+LCDPROC_CONF_OPT = --enable-drivers=all
+
+LCDPROC_DEPENDENCIES = ncurses
+
+$(eval $(call AUTOTARGETS))

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-03-09 12:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 18:01 [Buildroot] New package lcdproc Simon Dawson
2012-03-07 18:05 ` Simon Dawson
2012-03-07 19:21   ` Thomas Petazzoni
2012-03-07 21:10     ` Simon Dawson
     [not found]     ` <CAHt8ZCMVj5nQ=TZYnBktWHrxqYtwg_1oM5SimyaBFm3uaGZ1Ag@mail.gmail.com>
     [not found]       ` <20120308090516.06e1e329@skate>
2012-03-09 12:44         ` Simon Dawson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox