* [Buildroot] [PATCH 0/3 v3] Initial support for Panda and PandaES
@ 2012-03-12 22:41 Nicolas Dechesne
2012-03-12 22:41 ` [Buildroot] [PATCH 1/3 v3] uboot: Add support for U-Boot SPL Nicolas Dechesne
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Nicolas Dechesne @ 2012-03-12 22:41 UTC (permalink / raw)
To: buildroot
Here is my 3rd attempt to add support for TI PandaBoard and PandaBoard ES.
v3:
- added more documentation in uboot/Config.in regarding SPL
- added 'acked-by' as per review
- rebased on master branch as of 2012/03/12
v2:
- typo cleanup as per reviews
- introduce BR2_TARGET_UBOOT_FORMAT_IMG to allow use of u-boot.img
on platforms that need it, like OMAP. This is better than v1 since
u-boot.img is not stricly dependent on SPL, so making 2 parameters
makes more sense.
v1:
Because we want to deprecate x-loader in favor of u-boot SPL:
- my first patch adds support for SPL in BR
- SPL is enabled by default in my panda config.
Both Panda and PandaES have been tested, detection is done at run time
in uboot and kernel, so we can have 1 configuration only.
I've used DEVTMPFS by default, as 1) I generally prefer this, and 2) ttyO
was missing from the generic dev table...
Nicolas Dechesne (3):
uboot: Add support for U-Boot SPL
uboot: add a new binary format for u-boot.img
configs: add support for PandaBoard and PandaBoard ES
boot/uboot/Config.in | 12 ++++++++++++
boot/uboot/uboot.mk | 4 ++++
configs/pandaboard_defconfig | 25 +++++++++++++++++++++++++
3 files changed, 41 insertions(+), 0 deletions(-)
create mode 100644 configs/pandaboard_defconfig
--
1.7.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/3 v3] uboot: Add support for U-Boot SPL
2012-03-12 22:41 [Buildroot] [PATCH 0/3 v3] Initial support for Panda and PandaES Nicolas Dechesne
@ 2012-03-12 22:41 ` Nicolas Dechesne
2012-03-18 14:16 ` Arnout Vandecappelle
2012-03-12 22:41 ` [Buildroot] [PATCH 2/3 v3] uboot: add a new binary format for u-boot.img Nicolas Dechesne
2012-03-12 22:41 ` [Buildroot] [PATCH 3/3 v3] configs: add support for PandaBoard and PandaBoard ES Nicolas Dechesne
2 siblings, 1 reply; 6+ messages in thread
From: Nicolas Dechesne @ 2012-03-12 22:41 UTC (permalink / raw)
To: buildroot
SPL is a first stage bootloader. On pandaboard it supercedes x-loader,
and should now be used.
This patch ensures that either SPL or xloader can be selected
Signed-off-by: Nicolas Dechesne <n-dechesne@ti.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
boot/uboot/Config.in | 9 +++++++++
boot/uboot/uboot.mk | 2 ++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index c8db9fb..95187f9 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -137,4 +137,13 @@ config BR2_TARGET_UBOOT_ETH1ADDR
endif # BR2_TARGET_UBOOT_NETWORK
+config BR2_TARGET_UBOOT_SPL
+ bool "U-Boot SPL support"
+ depends on !BR2_TARGET_XLOADER
+ help
+ Enable the U-Boot SPL support. SPL is a first stage
+ bootloader loaded into internal memory in charge of
+ enabling and configuring the external memory (DDR),
+ and load the u-boot program into DDR.
+
endif # BR2_TARGET_UBOOT
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index db9de8d..41745c9 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -88,6 +88,8 @@ endef
define UBOOT_INSTALL_IMAGES_CMDS
cp -dpf $(@D)/$(UBOOT_BIN) $(BINARIES_DIR)/
+ $(if $(BR2_TARGET_UBOOT_SPL),
+ cp -dpf $(@D)/MLO $(BINARIES_DIR)/)
endef
$(eval $(call GENTARGETS))
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/3 v3] uboot: add a new binary format for u-boot.img
2012-03-12 22:41 [Buildroot] [PATCH 0/3 v3] Initial support for Panda and PandaES Nicolas Dechesne
2012-03-12 22:41 ` [Buildroot] [PATCH 1/3 v3] uboot: Add support for U-Boot SPL Nicolas Dechesne
@ 2012-03-12 22:41 ` Nicolas Dechesne
2012-03-12 22:41 ` [Buildroot] [PATCH 3/3 v3] configs: add support for PandaBoard and PandaBoard ES Nicolas Dechesne
2 siblings, 0 replies; 6+ messages in thread
From: Nicolas Dechesne @ 2012-03-12 22:41 UTC (permalink / raw)
To: buildroot
For some platforms like OMAP, a new binary format is now being used
for u-boot: u-boot.img. It is basically u-boot.bin which has been
processed with mkimage.
Signed-off-by: Nicolas Dechesne <n-dechesne@ti.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
boot/uboot/Config.in | 3 +++
boot/uboot/uboot.mk | 2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index 95187f9..5032b19 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -79,6 +79,9 @@ choice
config BR2_TARGET_UBOOT_FORMAT_BIN
bool "u-boot.bin"
+config BR2_TARGET_UBOOT_FORMAT_IMG
+ bool "u-boot.img"
+
config BR2_TARGET_UBOOT_FORMAT_NAND_BIN
bool "u-boot-nand.bin"
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index 41745c9..590eb6f 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -29,6 +29,8 @@ else ifeq ($(BR2_TARGET_UBOOT_FORMAT_LDR),y)
UBOOT_BIN = u-boot.ldr
else ifeq ($(BR2_TARGET_UBOOT_FORMAT_NAND_BIN),y)
UBOOT_BIN = u-boot-nand.bin
+else ifeq ($(BR2_TARGET_UBOOT_FORMAT_IMG),y)
+UBOOT_BIN = u-boot.img
else
UBOOT_BIN = u-boot.bin
endif
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 3/3 v3] configs: add support for PandaBoard and PandaBoard ES
2012-03-12 22:41 [Buildroot] [PATCH 0/3 v3] Initial support for Panda and PandaES Nicolas Dechesne
2012-03-12 22:41 ` [Buildroot] [PATCH 1/3 v3] uboot: Add support for U-Boot SPL Nicolas Dechesne
2012-03-12 22:41 ` [Buildroot] [PATCH 2/3 v3] uboot: add a new binary format for u-boot.img Nicolas Dechesne
@ 2012-03-12 22:41 ` Nicolas Dechesne
2 siblings, 0 replies; 6+ messages in thread
From: Nicolas Dechesne @ 2012-03-12 22:41 UTC (permalink / raw)
To: buildroot
This is a default configuration for Panda and PandaES, tested on both
platforms.
DEVTMPFS is enabled, to use static dev configuration one would need
to update the generic dev table for ttyO driver.
Panda is well supported in mainline kernel with omap2plus_defconfig,
so this should be safe.
U-boot SPL support is enabled by default as x-loader is now
deprecated.
With OMAP platforms u-boot,img format is prefered now, so it's enabled
by default as well.
Signed-off-by: Nicolas Dechesne <n-dechesne@ti.com>
---
configs/pandaboard_defconfig | 25 +++++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
create mode 100644 configs/pandaboard_defconfig
diff --git a/configs/pandaboard_defconfig b/configs/pandaboard_defconfig
new file mode 100644
index 0000000..61d9e00
--- /dev/null
+++ b/configs/pandaboard_defconfig
@@ -0,0 +1,25 @@
+# Architecture
+BR2_arm=y
+BR2_cortex_a9=y
+
+# system
+BR2_TARGET_GENERIC_GETTY=y
+BR2_TARGET_GENERIC_GETTY_PORT="ttyO2"
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS=y
+
+# filesystem
+BR2_TARGET_ROOTFS_EXT2=y
+# BR2_TARGET_ROOTFS_TAR is not set
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_DEFCONFIG="omap2plus"
+
+# GCC
+BR2_GCC_VERSION_4_6_X=y
+
+# Bootloaders
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_FORMAT_IMG=y
+BR2_TARGET_UBOOT_BOARDNAME="omap4_panda"
+BR2_TARGET_UBOOT_SPL=y
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/3 v3] uboot: Add support for U-Boot SPL
2012-03-12 22:41 ` [Buildroot] [PATCH 1/3 v3] uboot: Add support for U-Boot SPL Nicolas Dechesne
@ 2012-03-18 14:16 ` Arnout Vandecappelle
2012-03-18 21:57 ` Dechesne, Nicolas
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2012-03-18 14:16 UTC (permalink / raw)
To: buildroot
On Monday 12 March 2012 23:41:10 Nicolas Dechesne wrote:
> SPL is a first stage bootloader. On pandaboard it supercedes x-loader,
> and should now be used.
>
> This patch ensures that either SPL or xloader can be selected
>
> Signed-off-by: Nicolas Dechesne <n-dechesne@ti.com>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> boot/uboot/Config.in | 9 +++++++++
> boot/uboot/uboot.mk | 2 ++
> 2 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index c8db9fb..95187f9 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -137,4 +137,13 @@ config BR2_TARGET_UBOOT_ETH1ADDR
>
> endif # BR2_TARGET_UBOOT_NETWORK
>
> +config BR2_TARGET_UBOOT_SPL
> + bool "U-Boot SPL support"
> + depends on !BR2_TARGET_XLOADER
> + help
> + Enable the U-Boot SPL support. SPL is a first stage
> + bootloader loaded into internal memory in charge of
> + enabling and configuring the external memory (DDR),
> + and load the u-boot program into DDR.
> +
> endif # BR2_TARGET_UBOOT
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index db9de8d..41745c9 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -88,6 +88,8 @@ endef
>
> define UBOOT_INSTALL_IMAGES_CMDS
> cp -dpf $(@D)/$(UBOOT_BIN) $(BINARIES_DIR)/
> + $(if $(BR2_TARGET_UBOOT_SPL),
> + cp -dpf $(@D)/MLO $(BINARIES_DIR)/)
I didn't realize before, but it's only on OMAP that the SPL is called
MLO. Its normal name is u-boot-spl.bin.
I'm not sure how this could be solved. The simplest way would be
something like (untested, as usual):
ifeq ($(BR2_TARGET_UBOOT_SPL),y)
define UBOOT_INSTALL_IMAGES_SPL
if [ -e $(@D)/MLO ]; then \
cp -dpf $(@D)/MLO $(BINARIES_DIR)/; \
else \
cp -dpf $(@D)/u-boot-spl.bin $(BINARIES_DIR)/; \
fi
endef
endif
The alternative would be to make a separate config entry for MLO and
other SPLs. Which does make some kind of sense, I guess.
Regards,
Arnout
> endef
>
> $(eval $(call GENTARGETS))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/3 v3] uboot: Add support for U-Boot SPL
2012-03-18 14:16 ` Arnout Vandecappelle
@ 2012-03-18 21:57 ` Dechesne, Nicolas
0 siblings, 0 replies; 6+ messages in thread
From: Dechesne, Nicolas @ 2012-03-18 21:57 UTC (permalink / raw)
To: buildroot
On Sun, Mar 18, 2012 at 3:16 PM, Arnout Vandecappelle <arnout@mind.be>wrote:
> I didn't realize before, but it's only on OMAP that the SPL is called
> MLO. Its normal name is u-boot-spl.bin.
>
> I'm not sure how this could be solved. The simplest way would be
> something like (untested, as usual):
>
> ifeq ($(BR2_TARGET_UBOOT_SPL),y)
> define UBOOT_INSTALL_IMAGES_SPL
> if [ -e $(@D)/MLO ]; then \
> cp -dpf $(@D)/MLO $(BINARIES_DIR)/; \
> else \
> cp -dpf $(@D)/u-boot-spl.bin $(BINARIES_DIR)/; \
> fi
> endef
> endif
>
>
> The alternative would be to make a separate config entry for MLO and
> other SPLs. Which does make some kind of sense, I guess.
>
argh.. thx for pointing this out!
i just tried to implement the 2nd option (adding a new CONFIG var), and it
seems to work fine. I am going to send an updated series.
The reason why I think that a variable is better is that the solution is
more scalable, in case others platforms do the same thing... also because i
know that on OMAP5 for SATA boot the 2st bootloader will be called HLO, not
MLO ;-) so this solution is scalable at least for the next gen OMAP5 boards
...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120318/05281dd2/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-18 21:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-12 22:41 [Buildroot] [PATCH 0/3 v3] Initial support for Panda and PandaES Nicolas Dechesne
2012-03-12 22:41 ` [Buildroot] [PATCH 1/3 v3] uboot: Add support for U-Boot SPL Nicolas Dechesne
2012-03-18 14:16 ` Arnout Vandecappelle
2012-03-18 21:57 ` Dechesne, Nicolas
2012-03-12 22:41 ` [Buildroot] [PATCH 2/3 v3] uboot: add a new binary format for u-boot.img Nicolas Dechesne
2012-03-12 22:41 ` [Buildroot] [PATCH 3/3 v3] configs: add support for PandaBoard and PandaBoard ES Nicolas Dechesne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox