From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/6] Fix installation for the lighttpd package
Date: Tue, 20 Mar 2012 13:29:39 +0100 [thread overview]
Message-ID: <201203201329.39513.arnout@mind.be> (raw)
In-Reply-To: <4F68510C.2030306@free-electrons.com>
On Tuesday 20 March 2012 10:42:36 Maxime Ripard wrote:
> Le 20/03/2012 00:51, Arnout Vandecappelle a ?crit :
> > On Monday 19 March 2012 16:59:39 Maxime Ripard wrote:
> >> package/lighttpd/lighttpd.conf | 445 ++++++++++++++++++++++++++++++++++++++++
> >
> > Same remark as for systemd: wouldn't it be better to patch the upstream
> > file instead of copying it? Also, why did you revert the disabling of
> > range requests for pdf documents?
>
> Well, here, the default values are sensible.
> I mean, for a default configuration file, it is a normal behaviour for a
> modern webserver to start it with its own UID/GID and to enable ipv6.
> I don't see why they would accept a patch that disable these.
With 'patching the upstream file' I mean adding a patch to buildroot
that modifies the upstream source file. Although I like Peter's
suggestion to fixup the files with SED as well. But for this one, that
would be difficult.
> For PDF ranges option, it relies on a regex, and we don't always compile
> with pcre, so I turned it down.
That's a good reason.
[snip]
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-03-20 12:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 15:59 [Buildroot] [pull request] Pull request for branch for-2012.05/systemd Maxime Ripard
2012-03-19 15:59 ` [Buildroot] [PATCH 1/6] Change the /etc/mtab symlink to use an absolute path Maxime Ripard
2012-03-19 16:08 ` Peter Korsgaard
2012-03-19 15:59 ` [Buildroot] [PATCH 2/6] Add the systemd package Maxime Ripard
2012-03-19 23:32 ` Arnout Vandecappelle
2012-03-20 8:35 ` Maxime Ripard
2012-03-20 8:46 ` Peter Korsgaard
2012-03-20 18:19 ` Arnout Vandecappelle
2012-03-21 9:33 ` Maxime Ripard
2012-03-19 15:59 ` [Buildroot] [PATCH 3/6] Enable cgroups in Linux if we use systemd Maxime Ripard
2012-03-19 15:59 ` [Buildroot] [PATCH 4/6] Rework of the init system Maxime Ripard
2012-03-19 23:45 ` Arnout Vandecappelle
2012-03-20 8:53 ` Maxime Ripard
2012-03-20 9:15 ` Peter Korsgaard
2012-03-20 9:14 ` Peter Korsgaard
2012-03-19 15:59 ` [Buildroot] [PATCH 5/6] Fix installation for the lighttpd package Maxime Ripard
2012-03-19 23:51 ` Arnout Vandecappelle
2012-03-20 9:42 ` Maxime Ripard
2012-03-20 12:29 ` Arnout Vandecappelle [this message]
2012-03-19 15:59 ` [Buildroot] [PATCH 6/6] Add systemd unit for lighttpd Maxime Ripard
2012-03-19 23:55 ` Arnout Vandecappelle
2012-03-21 9:24 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203201329.39513.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox