Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] Add systemd unit for lighttpd
Date: Wed, 21 Mar 2012 10:24:02 +0100	[thread overview]
Message-ID: <4F699E32.7040400@free-electrons.com> (raw)
In-Reply-To: <201203200055.22903.arnout@mind.be>

Le 20/03/2012 00:55, Arnout Vandecappelle a ?crit :
> On Monday 19 March 2012 16:59:40 Maxime Ripard wrote:
>> +define LIGHTTPD_INSTALL_INIT_SYSTEMD
>> +[ -f $(TARGET_DIR)/etc/systemd/system/lighttpd.service ] || \
>> +       $(INSTALL) -D -m 755 package/lighttpd/lighttpd.service \
>> +               $(TARGET_DIR)/etc/systemd/system/lighttpd.service
>> +
>> +mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
>> +
>> +ln -fs ../lighttpd.service \
>> +       $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/lighttpd.service
>> +endef
> 
>  This should be indented, no?
> 
>  Would it be useful to add this to generic package infrastructure?
> I mean, if systemd is selected and pkgdir/pkgname.service exists,
> install it and enable it in multi-user.

I thought so at first, and in my first proposal, that was indeed the
case, but fact is that not every package doesn't want to be in
multi-user targets, but some will want to be in the sockets one, other
in network, etc.

So that's the reason I only added callbacks and let it up to the package
to install its units where they should be.


-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2012-03-21  9:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 15:59 [Buildroot] [pull request] Pull request for branch for-2012.05/systemd Maxime Ripard
2012-03-19 15:59 ` [Buildroot] [PATCH 1/6] Change the /etc/mtab symlink to use an absolute path Maxime Ripard
2012-03-19 16:08   ` Peter Korsgaard
2012-03-19 15:59 ` [Buildroot] [PATCH 2/6] Add the systemd package Maxime Ripard
2012-03-19 23:32   ` Arnout Vandecappelle
2012-03-20  8:35     ` Maxime Ripard
2012-03-20  8:46       ` Peter Korsgaard
2012-03-20 18:19       ` Arnout Vandecappelle
2012-03-21  9:33         ` Maxime Ripard
2012-03-19 15:59 ` [Buildroot] [PATCH 3/6] Enable cgroups in Linux if we use systemd Maxime Ripard
2012-03-19 15:59 ` [Buildroot] [PATCH 4/6] Rework of the init system Maxime Ripard
2012-03-19 23:45   ` Arnout Vandecappelle
2012-03-20  8:53     ` Maxime Ripard
2012-03-20  9:15       ` Peter Korsgaard
2012-03-20  9:14     ` Peter Korsgaard
2012-03-19 15:59 ` [Buildroot] [PATCH 5/6] Fix installation for the lighttpd package Maxime Ripard
2012-03-19 23:51   ` Arnout Vandecappelle
2012-03-20  9:42     ` Maxime Ripard
2012-03-20 12:29       ` Arnout Vandecappelle
2012-03-19 15:59 ` [Buildroot] [PATCH 6/6] Add systemd unit for lighttpd Maxime Ripard
2012-03-19 23:55   ` Arnout Vandecappelle
2012-03-21  9:24     ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F699E32.7040400@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox