* [Buildroot] [BUILDROOT][PATCH] Add bellagio package
@ 2012-03-20 17:04 Qais Yousef
2012-03-20 23:13 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Qais Yousef @ 2012-03-20 17:04 UTC (permalink / raw)
To: buildroot
Hi,
Attached patch adds Bellagio package. Copy pasted below also for
convenience.
Thanks
Qais
diff --git a/package/multimedia/bellagio/Config.in
b/package/multimedia/bellagio/Config.in
new file mode 100644
index 0000000..21998e9
--- /dev/null
+++ b/package/multimedia/bellagio/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_BELLAGIO
+ bool "bellagio"
+ help
+ Bellagio is an opensource implementation of the OpenMAX IL
API.
+
+ http://omxil.sourceforge.net/
diff --git
a/package/multimedia/bellagio/bellagio-0.9.3-segfault-on-removeFromWaitR
esource.patch
b/package/multimedia/bellagio/bellagio-0.9.3-segfault-on-removeFromWaitR
esource.patch
new file mode 100644
index 0000000..0716eeb
--- /dev/null
+++
b/package/multimedia/bellagio/bellagio-0.9.3-segfault-on-removeFromWaitR
esource.patch
@@ -0,0 +1,32 @@
+--- bellagio-0.9.3/src/omx_reference_resource_manager.c.old
2012-03-13 10:15:25.743940980 +0000
++++ bellagio-0.9.3/src/omx_reference_resource_manager.c
2012-03-13 10:18:02.201971009 +0000
+@@ -485,7 +485,6 @@
+ OMX_ERRORTYPE RM_removeFromWaitForResource(OMX_COMPONENTTYPE
*openmaxStandComp) {
+ omx_base_component_PrivateType* omx_base_component_Private;
+ int i = 0;
+- int indexComponent = -1;
+
+ DEBUG(DEB_LEV_FUNCTION_NAME, "In %s\n", __func__);
+ omx_base_component_Private =
(omx_base_component_PrivateType*)openmaxStandComp->pComponentPrivate;
+@@ -493,16 +492,13 @@
+ while(listOfcomponentRegistered[i].component_name != NULL ) {
+ if (!strcmp(listOfcomponentRegistered[i].component_name,
omx_base_component_Private->name)) {
+ // found component in the list of the resource
manager
+-
removeElemFromList(&globalComponentList[indexComponent],
openmaxStandComp);
+- break;
++ removeElemFromList(&globalComponentList[i],
openmaxStandComp);
++ DEBUG(DEB_LEV_FUNCTION_NAME, "Out of %s\n",
__func__);
++ return OMX_ErrorNone;
+ }
+ i++;
+ }
+- if (indexComponent <0) {
+- // No resource to be handled
+- DEBUG(DEB_LEV_ERR, "In %s No resource to be handled\n",
__func__);
+- return OMX_ErrorNone;
+- }
+- DEBUG(DEB_LEV_FUNCTION_NAME, "Out of %s\n", __func__);
++ // No resource to be handled
++ DEBUG(DEB_LEV_ERR, "In %s No resource to be handled\n",
__func__);
+ return OMX_ErrorNone;
+ }
diff --git a/package/multimedia/bellagio/bellagio.mk
b/package/multimedia/bellagio/bellagio.mk
new file mode 100644
index 0000000..3987a20
--- /dev/null
+++ b/package/multimedia/bellagio/bellagio.mk
@@ -0,0 +1,11 @@
+#############################################################
+#
+# bellagio
+#
+#############################################################
+BELLAGIO_VERSION = 0.9.3
+BELLAGIO_SOURCE = libomxil-bellagio-$(BELLAGIO_VERSION).tar.gz
+BELLAGIO_SITE =
http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/omxil
+BELLAGIO_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS))
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildroot-bellagio.patch
Type: application/octet-stream
Size: 2740 bytes
Desc: buildroot-bellagio.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120320/311000be/attachment.obj>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [BUILDROOT][PATCH] Add bellagio package
2012-03-20 17:04 [Buildroot] [BUILDROOT][PATCH] Add bellagio package Qais Yousef
@ 2012-03-20 23:13 ` Thomas Petazzoni
2012-03-21 10:49 ` Qais Yousef
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2012-03-20 23:13 UTC (permalink / raw)
To: buildroot
Hello Qais,
Thanks for your contribution. See my comments below.
Le Tue, 20 Mar 2012 17:04:02 +0000,
Qais Yousef <Qais.Yousef@imgtec.com> a ?crit :
> Attached patch adds Bellagio package. Copy pasted below also for
> convenience.
Your patch is completely word-wrapped, and therefore cannot be applied.
Of course, you have sent it as an attachment as well, but it would be
much better if it could be sent inline without being word-wrapped. I'd
recommend using "git send-email" to do this, since it ensures that your
patch will be sent correctly.
See http://elinux.org/Buildroot_how_to_contribute for a basic
introduction to Git for Buildroot contribution.
> diff --git a/package/multimedia/bellagio/Config.in
> b/package/multimedia/bellagio/Config.in
> new file mode 100644
> index 0000000..21998e9
> --- /dev/null
> +++ b/package/multimedia/bellagio/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_BELLAGIO
> + bool "bellagio"
> + help
> + Bellagio is an opensource implementation of the OpenMAX IL
> API.
The help text should be wrapped at ~80 columns.
> +
> + http://omxil.sourceforge.net/
> diff --git
> a/package/multimedia/bellagio/bellagio-0.9.3-segfault-on-removeFromWaitR
> esource.patch
> b/package/multimedia/bellagio/bellagio-0.9.3-segfault-on-removeFromWaitR
> esource.patch
> new file mode 100644
> index 0000000..0716eeb
> --- /dev/null
> +++
> b/package/multimedia/bellagio/bellagio-0.9.3-segfault-on-removeFromWaitR
> esource.patch
> @@ -0,0 +1,32 @@
Your patch bellagio-0.9.3-segfault-on-removeFromWaitResource.patch must
include a description + a Signed-off-by line indicating that you are
the author of the patch.
> +++ b/package/multimedia/bellagio/bellagio.mk
> @@ -0,0 +1,11 @@
> +#############################################################
> +#
> +# bellagio
> +#
> +#############################################################
> +BELLAGIO_VERSION = 0.9.3
> +BELLAGIO_SOURCE = libomxil-bellagio-$(BELLAGIO_VERSION).tar.gz
> +BELLAGIO_SITE =
> http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/omxil
> +BELLAGIO_INSTALL_STAGING = YES
> +
> +$(eval $(call AUTOTARGETS))
This looks good.
Maybe you could expand a bit the description of the package in the help
text, to explain in what contexts this package is useful.
Can you repost an updated version with those improvements?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [BUILDROOT][PATCH] Add bellagio package
2012-03-20 23:13 ` Thomas Petazzoni
@ 2012-03-21 10:49 ` Qais Yousef
0 siblings, 0 replies; 3+ messages in thread
From: Qais Yousef @ 2012-03-21 10:49 UTC (permalink / raw)
To: buildroot
Hi Thomas,
Thanks for your response. I'll take your comments into account and repost :)
Cheers,
Qais
> -----Original Message-----
> From: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com]
> Sent: 20 March 2012 23:14
> To: Qais Yousef
> Cc: buildroot at busybox.net
> Subject: Re: [Buildroot] [BUILDROOT][PATCH] Add bellagio package
>
> Hello Qais,
>
> Thanks for your contribution. See my comments below.
>
> Le Tue, 20 Mar 2012 17:04:02 +0000,
> Qais Yousef <Qais.Yousef@imgtec.com> a ?crit :
>
> > Attached patch adds Bellagio package. Copy pasted below also for
> > convenience.
>
> Your patch is completely word-wrapped, and therefore cannot be applied.
> Of course, you have sent it as an attachment as well, but it would be much
> better if it could be sent inline without being word-wrapped. I'd recommend
> using "git send-email" to do this, since it ensures that your patch will be sent
> correctly.
>
> See http://elinux.org/Buildroot_how_to_contribute for a basic introduction
> to Git for Buildroot contribution.
>
>
> > diff --git a/package/multimedia/bellagio/Config.in
> > b/package/multimedia/bellagio/Config.in
> > new file mode 100644
> > index 0000000..21998e9
> > --- /dev/null
> > +++ b/package/multimedia/bellagio/Config.in
> > @@ -0,0 +1,6 @@
> > +config BR2_PACKAGE_BELLAGIO
> > + bool "bellagio"
> > + help
> > + Bellagio is an opensource implementation of the OpenMAX IL
> > API.
>
> The help text should be wrapped at ~80 columns.
>
> > +
> > + http://omxil.sourceforge.net/
> > diff --git
> > a/package/multimedia/bellagio/bellagio-0.9.3-segfault-on-
> removeFromWai
> > tR
> > esource.patch
> > b/package/multimedia/bellagio/bellagio-0.9.3-segfault-on-
> removeFromWai
> > tR
> > esource.patch
> > new file mode 100644
> > index 0000000..0716eeb
> > --- /dev/null
> > +++
> > b/package/multimedia/bellagio/bellagio-0.9.3-segfault-on-
> removeFromWai
> > tR
> > esource.patch
> > @@ -0,0 +1,32 @@
>
> Your patch bellagio-0.9.3-segfault-on-removeFromWaitResource.patch must
> include a description + a Signed-off-by line indicating that you are the author
> of the patch.
>
> > +++ b/package/multimedia/bellagio/bellagio.mk
> > @@ -0,0 +1,11 @@
> >
> +#########################################################
> ####
> > +#
> > +# bellagio
> > +#
> >
> +#########################################################
> ####
> > +BELLAGIO_VERSION = 0.9.3
> > +BELLAGIO_SOURCE = libomxil-bellagio-$(BELLAGIO_VERSION).tar.gz
> > +BELLAGIO_SITE =
> >
> http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/om
> xil
> > +BELLAGIO_INSTALL_STAGING = YES
> > +
> > +$(eval $(call AUTOTARGETS))
>
> This looks good.
>
> Maybe you could expand a bit the description of the package in the help
> text, to explain in what contexts this package is useful.
>
> Can you repost an updated version with those improvements?
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux development, consulting,
> training and support.
> http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-21 10:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-20 17:04 [Buildroot] [BUILDROOT][PATCH] Add bellagio package Qais Yousef
2012-03-20 23:13 ` Thomas Petazzoni
2012-03-21 10:49 ` Qais Yousef
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox