Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] Add dtc (device tree compiler) as host tool
Date: Fri, 23 Mar 2012 15:51:03 +0100	[thread overview]
Message-ID: <20120323155103.54f93fa3@skate> (raw)
In-Reply-To: <0e9c281db61ec6c47a7a.1332513454@beantl019720>

Le Fri, 23 Mar 2012 15:37:34 +0100,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :

> +HOST_DTC_SOURCE =
> +HOST_DTC_DEPENDENCIES = linux
> +
> +define HOST_DTC_INSTALL_CMDS
> +    $(INSTALL) -D -m 0755 $(LINUX_DIR)/scripts/dtc/dtc $(HOST_DIR)/usr/bin/dtc
> +endef

The problem is that this DTC binary is only built if CONFIG_DTC is
selected in the kernel configuration. So if the selected kernel does
not have this option enabled, the installation step of this package is
going to fail.

I am not sure what to do here. Just let the user figure this out? Check
the kernel .config to see if CONFIG_DTC is enabled, and if it isn't
while this package is selected, error out with a nice explanation for
the user? Simply ignore the installation if the dtc binary was not
built?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-03-23 14:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23 14:37 [Buildroot] [PATCH v3] Add dtc (device tree compiler) as host tool Thomas De Schampheleire
2012-03-23 14:51 ` Thomas Petazzoni [this message]
2012-03-23 15:01   ` Thomas De Schampheleire
2012-03-23 15:09     ` Thomas Petazzoni
2012-03-23 15:05   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-23 15:32     ` Thomas Petazzoni
2012-03-23 15:37       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-23 15:54         ` Thomas Petazzoni
2012-03-23 16:27           ` Alexandre Pereira da Silva
2012-03-26  7:15             ` Thomas De Schampheleire
2012-03-26  7:55               ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120323155103.54f93fa3@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox