From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] Add dtc (device tree compiler) as host tool
Date: Fri, 23 Mar 2012 16:09:04 +0100 [thread overview]
Message-ID: <20120323160904.417ade69@skate> (raw)
In-Reply-To: <CAAXf6LX40Or5xSKtDD5M8kb3duhcJ_w4Z7GX8pQo=Vdye9S70A@mail.gmail.com>
Le Fri, 23 Mar 2012 16:01:16 +0100,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :
> I hadn't though about this case.
> One could question whether it is a valid case that someone selects dtc
> in buildroot but not in the kernel.
>
> Probably the nicest way is to not use dtc from the linux kernel
> sources but download the dtc sources explicitly. I thought this was a
> bit overkill, and I'm not sure if there can be inconsistencies between
> these sources and the kernel ones.
I have no strong opinion here. You can just keep what you've done and:
* Add an explanation in the help text about this fact
* Add something like the following to your installation code:
if ! grep -q ^CONFIG_DTC=y $(LINUX_DIR)/.config ; then
echo "Cannot install the Device Tree Compiler since you have
not enabled CONFIG_DTC=y in your kernel configuration.
Aborting".
exit 1
fi
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-03-23 15:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 14:37 [Buildroot] [PATCH v3] Add dtc (device tree compiler) as host tool Thomas De Schampheleire
2012-03-23 14:51 ` Thomas Petazzoni
2012-03-23 15:01 ` Thomas De Schampheleire
2012-03-23 15:09 ` Thomas Petazzoni [this message]
2012-03-23 15:05 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-23 15:32 ` Thomas Petazzoni
2012-03-23 15:37 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-23 15:54 ` Thomas Petazzoni
2012-03-23 16:27 ` Alexandre Pereira da Silva
2012-03-26 7:15 ` Thomas De Schampheleire
2012-03-26 7:55 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323160904.417ade69@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox