From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] lsof: add busybox tweaks
Date: Fri, 27 Apr 2012 02:55:58 +0200 [thread overview]
Message-ID: <20120427005558.GA20161@game.jcrosoft.org> (raw)
In-Reply-To: <20120426164511.2f6e462d@skate>
On 16:45 Thu 26 Apr , Thomas Petazzoni wrote:
> Le Thu, 26 Apr 2012 16:08:40 +0200,
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a ?crit :
>
> > > +if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> > > source "package/lsof/Config.in"
> > put a depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> >
> > in lsof/Config.in
>
> No, that's not what we do for all other packages. Gustavo's patch is
> correct with regard to the current guidelines.
>
> Now, whether we should change those guidelines to something else is a
> different story. But if we change the guideline, it should be changed
> for all packages and not just for lsof.
package/kmod/Config.in is already like this
and it's more clean
Best Regards,
J.
next prev parent reply other threads:[~2012-04-27 0:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 10:15 [Buildroot] [PATCH 1/2] busybox: add new 1.20.0, remove deprecated, mark 1.18.x deprecated Gustavo Zacarias
2012-04-26 10:15 ` [Buildroot] [PATCH 2/2] lsof: add busybox tweaks Gustavo Zacarias
2012-04-26 14:08 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-26 14:45 ` Thomas Petazzoni
2012-04-27 0:55 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-04-27 21:54 ` Arnout Vandecappelle
2012-04-29 8:36 ` Peter Korsgaard
2012-04-29 10:06 ` Arnout Vandecappelle
2012-04-29 10:49 ` Gustavo Zacarias
2012-04-29 8:56 ` Peter Korsgaard
2012-04-29 8:55 ` [Buildroot] [PATCH 1/2] busybox: add new 1.20.0, remove deprecated, mark 1.18.x deprecated Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427005558.GA20161@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox