* [Buildroot] [PATCH v3] Add new package apr-util
@ 2012-04-25 9:53 Rico Bachmann
2012-04-25 10:43 ` Rico Bachmann
0 siblings, 1 reply; 8+ messages in thread
From: Rico Bachmann @ 2012-04-25 9:53 UTC (permalink / raw)
To: buildroot
Add package apr-util
Add the package apr-util to buildroot and adding a patch to
avoid the failing test APU_FIND_APR
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
v1: Add package apr-util
Add patch to remove check for apr
because check for apr search for ./apr and not for defined folder
v2: Change spaces to tab in *.mk
v3: Add Signed-off-by and comments to package-patch
package/Config.in | 1 +
package/apr-util/Config.in | 7 +++++++
.../apr-util/apr-util-1.4.1-remove-checkapr.patch | 17 +++++++++++++++++
package/apr-util/apr-util.mk | 14 ++++++++++++++
4 files changed, 39 insertions(+), 0 deletions(-)
create mode 100644 package/apr-util/Config.in
create mode 100644 package/apr-util/apr-util-1.4.1-remove-checkapr.patch
create mode 100644 package/apr-util/apr-util.mk
diff --git a/package/Config.in b/package/Config.in
index 5ae1c81..805f56a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -375,6 +375,7 @@ endmenu
menu "Other"
source "package/apr/Config.in"
+source "package/apr-util/Config.in"
source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
diff --git a/package/apr-util/Config.in b/package/apr-util/Config.in
new file mode 100644
index 0000000..a4411ba
--- /dev/null
+++ b/package/apr-util/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_APR_UTIL
+ bool "apr-util"
+ select BR2_PACKAGE_APR
+ help
+ The utility library for the apache runtime project
+
+ http://apr.apache.org/
diff --git a/package/apr-util/apr-util-1.4.1-remove-checkapr.patch b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
new file mode 100644
index 0000000..128a1b0
--- /dev/null
+++ b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
@@ -0,0 +1,17 @@
+Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
+---
+disable the check for APU_FIND_APR because the check only looks into folders
+named apr, and our source-tree is called apr-versionnumber (e.g. apr-1.4.6)
+---
+diff -rupN apr-util-1.4.1/configure.in apr-util-1.4.1-fix/configure.in
+--- apr-util-1.4.1/configure.in 2009-12-17 20:15:19.000000000 +0100
++++ apr-util-1.4.1-fix/configure.in 2012-04-24 10:10:32.000000000 +0200
+@@ -99,7 +99,7 @@ fi
+ dnl
+ dnl Find the APR includes directory and (possibly) the source (base) dir.
+ dnl
+-APU_FIND_APR
++dnl APU_FIND_APR
+
+ dnl
+ dnl even though we use apr_rules.mk for building apr-util, we need
diff --git a/package/apr-util/apr-util.mk b/package/apr-util/apr-util.mk
new file mode 100644
index 0000000..f5f4d80
--- /dev/null
+++ b/package/apr-util/apr-util.mk
@@ -0,0 +1,14 @@
+#############################################################
+#
+# apr-util
+#
+#############################################################
+APR_UTIL_VERSION = 1.4.1
+APR_UTIL_SITE = http://archive.apache.org/dist/apr
+APR_UTIL_INSTALL_STAGING = YES
+APR_UTIL_DEPENDENCIES = apr
+APR_UTIL_CONF_OPT = \
+ --prefix=/usr \
+ --with-apr=$(BUILD_DIR)/apr-$(APR_VERSION)
+
+$(eval $(call AUTOTARGETS))
--
1.7.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH v3] Add new package apr-util
2012-04-25 9:53 [Buildroot] [PATCH v3] Add new package apr-util Rico Bachmann
@ 2012-04-25 10:43 ` Rico Bachmann
2012-04-27 21:09 ` Arnout Vandecappelle
0 siblings, 1 reply; 8+ messages in thread
From: Rico Bachmann @ 2012-04-25 10:43 UTC (permalink / raw)
To: buildroot
Add package apr-util
Add the package apr-util to buildroot and adding a patch to
avoid the failing test APU_FIND_APR
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
v1: Add package apr-util
Add patch to remove check for apr
because check for apr search for ./apr and not for defined folder
v2: Change spaces to tab in *.mk
v3: Add Signed-off-by and comments to package-patch
---
package/Config.in | 1 +
package/apr-util/Config.in | 7 ++++++
.../apr-util/apr-util-1.4.1-remove-checkapr.patch | 21 ++++++++++++++++++++
package/apr-util/apr-util.mk | 14 +++++++++++++
4 files changed, 43 insertions(+), 0 deletions(-)
create mode 100644 package/apr-util/Config.in
create mode 100644 package/apr-util/apr-util-1.4.1-remove-checkapr.patch
create mode 100644 package/apr-util/apr-util.mk
diff --git a/package/Config.in b/package/Config.in
index 5ae1c81..805f56a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -375,6 +375,7 @@ endmenu
menu "Other"
source "package/apr/Config.in"
+source "package/apr-util/Config.in"
source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
diff --git a/package/apr-util/Config.in b/package/apr-util/Config.in
new file mode 100644
index 0000000..a4411ba
--- /dev/null
+++ b/package/apr-util/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_APR_UTIL
+ bool "apr-util"
+ select BR2_PACKAGE_APR
+ help
+ The utility library for the apache runtime project
+
+ http://apr.apache.org/
diff --git a/package/apr-util/apr-util-1.4.1-remove-checkapr.patch b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
new file mode 100644
index 0000000..a8af6e9
--- /dev/null
+++ b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
@@ -0,0 +1,21 @@
+remove check apr
+
+this patch removes the check of apr which fails the build
+
+Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
+---
+v1: disable the check for APU_FIND_APR because the check only looks into folders
+named apr, and our source-tree is called apr-versionnumber (e.g. apr-1.4.6)
+
+diff -rupN apr-util-1.4.1/configure.in apr-util-1.4.1-fix/configure.in
+--- apr-util-1.4.1/configure.in 2009-12-17 20:15:19.000000000 +0100
++++ apr-util-1.4.1-fix/configure.in 2012-04-24 10:10:32.000000000 +0200
+@@ -99,7 +99,7 @@ fi
+ dnl
+ dnl Find the APR includes directory and (possibly) the source (base) dir.
+ dnl
+-APU_FIND_APR
++dnl APU_FIND_APR
+
+ dnl
+ dnl even though we use apr_rules.mk for building apr-util, we need
diff --git a/package/apr-util/apr-util.mk b/package/apr-util/apr-util.mk
new file mode 100644
index 0000000..f5f4d80
--- /dev/null
+++ b/package/apr-util/apr-util.mk
@@ -0,0 +1,14 @@
+#############################################################
+#
+# apr-util
+#
+#############################################################
+APR_UTIL_VERSION = 1.4.1
+APR_UTIL_SITE = http://archive.apache.org/dist/apr
+APR_UTIL_INSTALL_STAGING = YES
+APR_UTIL_DEPENDENCIES = apr
+APR_UTIL_CONF_OPT = \
+ --prefix=/usr \
+ --with-apr=$(BUILD_DIR)/apr-$(APR_VERSION)
+
+$(eval $(call AUTOTARGETS))
--
1.7.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH v3] Add new package apr-util
2012-04-25 10:43 ` Rico Bachmann
@ 2012-04-27 21:09 ` Arnout Vandecappelle
2012-05-03 12:22 ` [Buildroot] [PATCH v4] " Rico Bachmann
0 siblings, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2012-04-27 21:09 UTC (permalink / raw)
To: buildroot
On Wednesday 25 April 2012 12:43:36 Rico Bachmann wrote:
> Add package apr-util
>
> Add the package apr-util to buildroot and adding a patch to
> avoid the failing test APU_FIND_APR
This is a bit more verbose than necessary :-)
We usually just have "apr-util: new package" as the subject line and
nothing more in the message.
[snip]
> +APR_UTIL_CONF_OPT = \
> + --prefix=/usr \
> + --with-apr=$(BUILD_DIR)/apr-$(APR_VERSION)
The --prefix=/usr is already added by AUTOTARGETS, so is redundant here.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v4] Add new package apr-util
2012-04-27 21:09 ` Arnout Vandecappelle
@ 2012-05-03 12:22 ` Rico Bachmann
2012-05-03 21:54 ` Peter Korsgaard
0 siblings, 1 reply; 8+ messages in thread
From: Rico Bachmann @ 2012-05-03 12:22 UTC (permalink / raw)
To: buildroot
Add new package apr-util
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
v1: Add package apr-util
Add patch to remove check for apr
because check for apr search for ./apr and not for defined folder
v2: Change spaces to tab in *.mk
v3: Add Signed-off-by and comments to package-patch
v4: remove prefix, is added by buildroot
---
package/Config.in | 1 +
package/apr-util/Config.in | 11 ++++++++++
.../apr-util/apr-util-1.4.1-remove-checkapr.patch | 21 ++++++++++++++++++++
package/apr-util/apr-util.mk | 13 ++++++++++++
4 files changed, 46 insertions(+), 0 deletions(-)
create mode 100644 package/apr-util/Config.in
create mode 100644 package/apr-util/apr-util-1.4.1-remove-checkapr.patch
create mode 100644 package/apr-util/apr-util.mk
diff --git a/package/Config.in b/package/Config.in
index ed66c05..caa618b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -379,6 +379,7 @@ endmenu
menu "Other"
source "package/apr/Config.in"
+source "package/apr-util/Config.in"
source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
diff --git a/package/apr-util/Config.in b/package/apr-util/Config.in
new file mode 100644
index 0000000..45973b2
--- /dev/null
+++ b/package/apr-util/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_APR_UTIL
+ bool "apr-util"
+ select BR2_PACKAGE_APR
+ select BR2_PACKAGE_SQLITE
+ select BR2_PACKAGE_LIBNEON
+ select BR2_PACKAGE_NEON_ZLIB
+ select BR2_PACKAGE_ZLIB
+ help
+ The utility library for the apache runtime project
+
+ http://apr.apache.org/
diff --git a/package/apr-util/apr-util-1.4.1-remove-checkapr.patch b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
new file mode 100644
index 0000000..42ad12f
--- /dev/null
+++ b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
@@ -0,0 +1,21 @@
+remove check apr
+
+this patch removes the check of apr which fails the build
+
+Signed-off-by: Rico Bachmann <bachmann-ahF9wiJNQgNBDgjK7y7TUQ@public.gmane.org>
+---
+v1: disable the check for APU_FIND_APR because the check only looks into folders
+named apr, and our source-tree is called apr-versionnumber (e.g. apr-1.4.6)
+
+diff -rupN apr-util-1.4.1/configure.in apr-util-1.4.1-fix/configure.in
+--- apr-util-1.4.1/configure.in 2009-12-17 20:15:19.000000000 +0100
++++ apr-util-1.4.1-fix/configure.in 2012-04-24 10:10:32.000000000 +0200
+@@ -99,7 +99,7 @@ fi
+ dnl
+ dnl Find the APR includes directory and (possibly) the source (base) dir.
+ dnl
+-APU_FIND_APR
++dnl APU_FIND_APR
+
+ dnl
+ dnl even though we use apr_rules.mk for building apr-util, we need
diff --git a/package/apr-util/apr-util.mk b/package/apr-util/apr-util.mk
new file mode 100644
index 0000000..564b1bb
--- /dev/null
+++ b/package/apr-util/apr-util.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# apr-util
+#
+#############################################################
+APR_UTIL_VERSION = 1.4.1
+APR_UTIL_SITE = http://archive.apache.org/dist/apr
+APR_UTIL_INSTALL_STAGING = YES
+APR_UTIL_DEPENDENCIES = apr sqlite neon zlib
+APR_UTIL_CONF_OPT = \
+ --with-apr=$(BUILD_DIR)/apr-$(APR_VERSION) \
+
+$(eval $(call AUTOTARGETS))
--
1.7.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH v4] Add new package apr-util
2012-05-03 12:22 ` [Buildroot] [PATCH v4] " Rico Bachmann
@ 2012-05-03 21:54 ` Peter Korsgaard
0 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2012-05-03 21:54 UTC (permalink / raw)
To: buildroot
>>>>> "Rico" == Rico Bachmann <bachmann@tofwerk.com> writes:
Rico> Add new package apr-util
Rico> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
Rico> ---
Rico> v1: Add package apr-util
Rico> Add patch to remove check for apr
Rico> because check for apr search for ./apr and not for defined folder
Rico> v2: Change spaces to tab in *.mk
Rico> v3: Add Signed-off-by and comments to package-patch
Rico> v4: remove prefix, is added by buildroot
Rico> ---
Rico> package/Config.in | 1 +
Rico> package/apr-util/Config.in | 11 ++++++++++
Rico> .../apr-util/apr-util-1.4.1-remove-checkapr.patch | 21 ++++++++++++++++++++
Rico> package/apr-util/apr-util.mk | 13 ++++++++++++
Rico> 4 files changed, 46 insertions(+), 0 deletions(-)
Rico> create mode 100644 package/apr-util/Config.in
Rico> create mode 100644 package/apr-util/apr-util-1.4.1-remove-checkapr.patch
Rico> create mode 100644 package/apr-util/apr-util.mk
Rico> diff --git a/package/Config.in b/package/Config.in
Rico> index ed66c05..caa618b 100644
Rico> --- a/package/Config.in
Rico> +++ b/package/Config.in
Rico> @@ -379,6 +379,7 @@ endmenu
Rico> menu "Other"
Rico> source "package/apr/Config.in"
Rico> +source "package/apr-util/Config.in"
Rico> source "package/fftw/Config.in"
Rico> source "package/libargtable2/Config.in"
Rico> source "package/argp-standalone/Config.in"
Rico> diff --git a/package/apr-util/Config.in b/package/apr-util/Config.in
Rico> new file mode 100644
Rico> index 0000000..45973b2
Rico> --- /dev/null
Rico> +++ b/package/apr-util/Config.in
Rico> @@ -0,0 +1,11 @@
Rico> +config BR2_PACKAGE_APR_UTIL
Rico> + bool "apr-util"
Rico> + select BR2_PACKAGE_APR
Rico> + select BR2_PACKAGE_SQLITE
Rico> + select BR2_PACKAGE_LIBNEON
It is BR2_PACKAGE_NEON, not LIBNEON.
Other than that it looks good, committed - Thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3] Add new package apr-util
@ 2012-04-24 11:55 Rico Bachmann
2012-04-24 12:05 ` Thomas Petazzoni
0 siblings, 1 reply; 8+ messages in thread
From: Rico Bachmann @ 2012-04-24 11:55 UTC (permalink / raw)
To: buildroot
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
v1: Add package apr-util
Add patch to remove check for apr
because check for apr search for ./apr and not for defined folder
v2: Change spaces to tab in *.mk
v3: Add Signed-off-by and comments to package-patch
---
---
package/Config.in | 1 +
package/apr-util/Config.in | 7 +++++++
.../apr-util/apr-util-1.4.1-remove-checkapr.patch | 17 +++++++++++++++++
package/apr-util/apr-util.mk | 14 ++++++++++++++
4 files changed, 39 insertions(+), 0 deletions(-)
create mode 100644 package/apr-util/Config.in
create mode 100644 package/apr-util/apr-util-1.4.1-remove-checkapr.patch
create mode 100644 package/apr-util/apr-util.mk
diff --git a/package/Config.in b/package/Config.in
index 5ae1c81..805f56a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -375,6 +375,7 @@ endmenu
menu "Other"
source "package/apr/Config.in"
+source "package/apr-util/Config.in"
source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
diff --git a/package/apr-util/Config.in b/package/apr-util/Config.in
new file mode 100644
index 0000000..a4411ba
--- /dev/null
+++ b/package/apr-util/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_APR_UTIL
+ bool "apr-util"
+ select BR2_PACKAGE_APR
+ help
+ The utility library for the apache runtime project
+
+ http://apr.apache.org/
diff --git a/package/apr-util/apr-util-1.4.1-remove-checkapr.patch b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
new file mode 100644
index 0000000..128a1b0
--- /dev/null
+++ b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
@@ -0,0 +1,17 @@
+Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
+---
+disable the check for APU_FIND_APR because the check only looks into folders
+named apr, and our source-tree is called apr-versionnumber (e.g. apr-1.4.6)
+---
+diff -rupN apr-util-1.4.1/configure.in apr-util-1.4.1-fix/configure.in
+--- apr-util-1.4.1/configure.in 2009-12-17 20:15:19.000000000 +0100
++++ apr-util-1.4.1-fix/configure.in 2012-04-24 10:10:32.000000000 +0200
+@@ -99,7 +99,7 @@ fi
+ dnl
+ dnl Find the APR includes directory and (possibly) the source (base) dir.
+ dnl
+-APU_FIND_APR
++dnl APU_FIND_APR
+
+ dnl
+ dnl even though we use apr_rules.mk for building apr-util, we need
diff --git a/package/apr-util/apr-util.mk b/package/apr-util/apr-util.mk
new file mode 100644
index 0000000..f5f4d80
--- /dev/null
+++ b/package/apr-util/apr-util.mk
@@ -0,0 +1,14 @@
+#############################################################
+#
+# apr-util
+#
+#############################################################
+APR_UTIL_VERSION = 1.4.1
+APR_UTIL_SITE = http://archive.apache.org/dist/apr
+APR_UTIL_INSTALL_STAGING = YES
+APR_UTIL_DEPENDENCIES = apr
+APR_UTIL_CONF_OPT = \
+ --prefix=/usr \
+ --with-apr=$(BUILD_DIR)/apr-$(APR_VERSION)
+
+$(eval $(call AUTOTARGETS))
--
1.7.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH v3] Add new package apr-util
2012-04-24 11:55 [Buildroot] [PATCH v3] " Rico Bachmann
@ 2012-04-24 12:05 ` Thomas Petazzoni
2012-04-25 7:40 ` Rico Bachmann
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2012-04-24 12:05 UTC (permalink / raw)
To: buildroot
Hello Rico,
Le Tue, 24 Apr 2012 13:55:24 +0200,
Rico Bachmann <bachmann@tofwerk.com> a ?crit :
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> ---
> v1: Add package apr-util
> Add patch to remove check for apr
> because check for apr search for ./apr and not for defined folder
> v2: Change spaces to tab in *.mk
> v3: Add Signed-off-by and comments to package-patch
> ---
> ---
Those two lines with '---' are useless.
> diff --git a/package/apr-util/apr-util-1.4.1-remove-checkapr.patch b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
> new file mode 100644
> index 0000000..128a1b0
> --- /dev/null
> +++ b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
> @@ -0,0 +1,17 @@
> +Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> +---
> +disable the check for APU_FIND_APR because the check only looks into folders
> +named apr, and our source-tree is called apr-versionnumber (e.g. apr-1.4.6)
> +---
The description should be *before* the Signed-off-by, and not separated
by ---.
It seems like you misunderstand what the format of a patch should be.
Here is an explanation that I hope will clarify things:
------------------------8<-------------------
This is the title, should be less than ~80 chars
This is a long description that explains what the patch is doing, why,
how, and all other details that are useful. This description (and the
title above, and the above Signed-off-by line) will be part of the
commit log and remain in the Git history. Therefore, it should *not*
contain any changelog information about the patch, or other "personal"
messages. The title and the description must be separated by one empty
line.
Signed-off-by: Foo Bar <foo@bar.com>
---
This is some text that will *not* be included in the Git history, so it
is typically used for the changelog.
package/Config.in | 1 +
package/apr-util/Config.in | 7 +++++++
.../apr-util/apr-util-1.4.1-remove-checkapr.patch | 17 +++++++++++++++++
package/apr-util/apr-util.mk | 14 ++++++++++++++
4 files changed, 39 insertions(+), 0 deletions(-)
create mode 100644 package/apr-util/Config.in
create mode 100644 package/apr-util/apr-util-1.4.1-remove-checkapr.patch
create mode 100644 package/apr-util/apr-util.mk
diff --git a/package/Config.in b/package/Config.in
index 5ae1c81..805f56a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -375,6 +375,7 @@ endmenu
menu "Other"
source "package/apr/Config.in"
+source "package/apr-util/Config.in"
source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
------------------------8<-------------------
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3] Add new package apr-util
2012-04-24 12:05 ` Thomas Petazzoni
@ 2012-04-25 7:40 ` Rico Bachmann
0 siblings, 0 replies; 8+ messages in thread
From: Rico Bachmann @ 2012-04-25 7:40 UTC (permalink / raw)
To: buildroot
Hi Thomas
Am 24.04.2012, 14:05 Uhr, schrieb Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Hello Rico,
>
> Le Tue, 24 Apr 2012 13:55:24 +0200,
> Rico Bachmann <bachmann@tofwerk.com> a ?crit :
>
>> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
>> ---
>> v1: Add package apr-util
>> Add patch to remove check for apr
>> because check for apr search for ./apr and not for defined folder
>> v2: Change spaces to tab in *.mk
>> v3: Add Signed-off-by and comments to package-patch
>> ---
>> ---
>
> Those two lines with '---' are useless.
>
>> diff --git a/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
>> b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
>> new file mode 100644
>> index 0000000..128a1b0
>> --- /dev/null
>> +++ b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch
>> @@ -0,0 +1,17 @@
>> +Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
>> +---
>> +disable the check for APU_FIND_APR because the check only looks into
>> folders
>> +named apr, and our source-tree is called apr-versionnumber (e.g.
>> apr-1.4.6)
>> +---
>
> The description should be *before* the Signed-off-by, and not separated
> by ---.
>
> It seems like you misunderstand what the format of a patch should be.
> Here is an explanation that I hope will clarify things:
I'm really not that into patches... no diffrence if it is the patch
format or patches at all... At the moment, I'm learning by doing...
Thanks for your explanation.
>
> ------------------------8<-------------------
> This is the title, should be less than ~80 chars
>
> This is a long description that explains what the patch is doing, why,
> how, and all other details that are useful. This description (and the
> title above, and the above Signed-off-by line) will be part of the
> commit log and remain in the Git history. Therefore, it should *not*
> contain any changelog information about the patch, or other "personal"
> messages. The title and the description must be separated by one empty
> line.
>
> Signed-off-by: Foo Bar <foo@bar.com>
> ---
> This is some text that will *not* be included in the Git history, so it
> is typically used for the changelog.
>
> package/Config.in | 1 +
> package/apr-util/Config.in | 7 +++++++
> .../apr-util/apr-util-1.4.1-remove-checkapr.patch | 17
> +++++++++++++++++
> package/apr-util/apr-util.mk | 14 ++++++++++++++
> 4 files changed, 39 insertions(+), 0 deletions(-)
> create mode 100644 package/apr-util/Config.in
> create mode 100644 package/apr-util/apr-util-1.4.1-remove-checkapr.patch
> create mode 100644 package/apr-util/apr-util.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 5ae1c81..805f56a 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -375,6 +375,7 @@ endmenu
> menu "Other"
> source "package/apr/Config.in"
> +source "package/apr-util/Config.in"
> source "package/fftw/Config.in"
> source "package/libargtable2/Config.in"
> source "package/argp-standalone/Config.in"
> ------------------------8<-------------------
>
> Regards,
>
> Thomas
I'll try to send a proper formated patch today. As soon as I find time.
And I do my best to get my next patch in the right format from beginning!
so long
Rico
--
Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-05-03 21:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-25 9:53 [Buildroot] [PATCH v3] Add new package apr-util Rico Bachmann
2012-04-25 10:43 ` Rico Bachmann
2012-04-27 21:09 ` Arnout Vandecappelle
2012-05-03 12:22 ` [Buildroot] [PATCH v4] " Rico Bachmann
2012-05-03 21:54 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 11:55 [Buildroot] [PATCH v3] " Rico Bachmann
2012-04-24 12:05 ` Thomas Petazzoni
2012-04-25 7:40 ` Rico Bachmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox