From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] New package: freerdp
Date: Wed, 30 May 2012 21:04:41 +0200 [thread overview]
Message-ID: <20120530210441.0a4711be@skate> (raw)
In-Reply-To: <20120530195334.06a0bad1@jl-desk-LL>
Le Wed, 30 May 2012 19:53:34 +0200,
Julian Lunz <git@jlunz.de> a ?crit :
> True, but I tend to have it stated more explicitly that these options
> could but mustn't be used.
> So it is more a question of how would I buildroot like to behave.
> A lot of other packages use the mechanism you describe, so what about
> merging both like that:
>
> (make "logical or")
>
> ifneq (,$(filter y, $(BR2_PACKAGE_CUPS) \
> $(BR2_PACKAGE_FREERDP_WITHCUPS)))
> ...
> endif
No, please do like we do for all other packages in Buildroot: simply
use them if available, i.e:
ifeq ($(BR2_PACKAGE_CUPS),y)
... do whatever is needed in your package to use cups
yourpkg_DEPENDENCIES += cups
else
... do whatever is needed in your package to not use cups
endif
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-05-30 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 21:45 [Buildroot] [PATCH] New package: freerdp Julian Lunz
2012-05-29 18:34 ` Julian Lunz
2012-05-29 19:12 ` Arnout Vandecappelle
2012-05-30 17:53 ` Julian Lunz
2012-05-30 19:04 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-23 20:51 Julian Lunz
2012-05-23 21:02 ` Peter Korsgaard
2012-05-23 21:49 ` Julian Lunz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530210441.0a4711be@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox