Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] New package: freerdp
Date: Wed, 23 May 2012 23:02:38 +0200	[thread overview]
Message-ID: <87fwaqpq4x.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1337806267-32327-1-git-send-email-git@jlunz.de> (Julian Lunz's message of "Wed, 23 May 2012 22:51:07 +0200")

>>>>> "Julian" == Julian Lunz <git@jlunz.de> writes:

Hi,

 Julian> Signed-off-by: Julian Lunz <git@jlunz.de>
 Julian> ---
 Julian>  package/Config.in          |    1 +
 Julian>  package/freerdp/Config.in  |   11 +++++++++++
 Julian>  package/freerdp/freerdp.mk |   13 +++++++++++++
 Julian>  3 files changed, 25 insertions(+), 0 deletions(-)
 Julian>  create mode 100644 package/freerdp/Config.in
 Julian>  create mode 100644 package/freerdp/freerdp.mk

 Julian> diff --git a/package/Config.in b/package/Config.in
 Julian> index fb1b08f..2d1f18d 100644
 Julian> --- a/package/Config.in
 Julian> +++ b/package/Config.in
 Julian> @@ -152,6 +152,7 @@ source "package/leafpad/Config.in"
 Julian>  source "package/midori/Config.in"
 Julian>  source "package/pcmanfm/Config.in"
 Julian>  source "package/rdesktop/Config.in"
 Julian> +source "package/freerdp/Config.in"


I know it logically belong with rdesktop, but we normally sort these
sort lines alphabetically.


 Julian>  source "package/sylpheed/Config.in"
 Julian>  source "package/synergy/Config.in"
 Julian>  source "package/torsmo/Config.in"
 Julian> diff --git a/package/freerdp/Config.in b/package/freerdp/Config.in
 Julian> new file mode 100644
 Julian> index 0000000..1cc49c9
 Julian> --- /dev/null
 Julian> +++ b/package/freerdp/Config.in
 Julian> @@ -0,0 +1,11 @@
 Julian> +config BR2_PACKAGE_FREERDP
 Julian> +	bool "freerdp"
 Julian> +	select BR2_PACKAGE_OPENSSL
 Julian> +	select BR2_PACKAGE_XLIB_LIBX11
 Julian> +	select BR2_PACKAGE_XLIB_LIBXT
 Julian> +	depends on BR2_PACKAGE_XORG7
 Julian> +	help
 Julian> +	  FreeRDPFreeRDP is a free implementation of the 
 Julian> +	  Remote Desktop Protocol (RDP), released under the Apache license
 Julian> +
 Julian> +	  http://www.freerdp.com/
 Julian> diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk
 Julian> new file mode 100644
 Julian> index 0000000..61b6ca2
 Julian> --- /dev/null
 Julian> +++ b/package/freerdp/freerdp.mk
 Julian> @@ -0,0 +1,13 @@
 Julian> +#############################################################
 Julian> +#
 Julian> +# FreeRDP
 Julian> +#
 Julian> +#############################################################
 Julian> +
 Julian> +FREERDP_VERSION = 1.0.1
 Julian> +FREERDP_SOURCE = freerdp-$(FREERDP_VERSION).tar.gz
 Julian> +FREERDP_SITE = https://github.com/downloads/FreeRDP/FreeRDP
 Julian> +FREERDP_CONF_OPT = -DWITH_CUPS=OFF -DWITH_FFMPEG=OFF -DWITH_ALSA=OFF -DWITH_XINERAMA=OFF

We do have packages for cups, ffmpeg, alsa and libXinerama in buildroot,
so it would be good to add optional support for these - E.G.:

ifeq ($(BR2_PACKAGE_CUPS),y)
FREERDP_DEPENDENCIES += cups
else
FREERDP_CONF_OPT += -DWITH_CUPS=OFF
endif
..

 Julian> +FREERDP_DEPENDENCIES = openssl xlib_libX11 xlib_libXt zlib

You don't select BR2_PACKAGE_ZLIB in Config.in, but you have it here?

Otherwise it looks good. Care to fix and resend?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-05-23 21:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 20:51 [Buildroot] [PATCH] New package: freerdp Julian Lunz
2012-05-23 21:02 ` Peter Korsgaard [this message]
2012-05-23 21:41   ` [Buildroot] (no subject) Julian Lunz
2012-05-23 21:49   ` [Buildroot] [PATCH] New package: freerdp Julian Lunz
  -- strict thread matches above, loose matches on Subject: below --
2012-05-23 21:45 Julian Lunz
2012-05-29 18:34 ` Julian Lunz
2012-05-29 19:12 ` Arnout Vandecappelle
2012-05-30 17:53   ` Julian Lunz
2012-05-30 19:04     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwaqpq4x.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox