* [Buildroot] [PATCH] Add /var/www to device table
@ 2012-06-25 20:02 spdawson at gmail.com
2012-06-30 17:46 ` Arnout Vandecappelle
2012-07-02 8:33 ` Romain Izard
0 siblings, 2 replies; 9+ messages in thread
From: spdawson at gmail.com @ 2012-06-25 20:02 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
The /var/www directory is listed in /etc/passwd in the skeleton target
filesystem as the home directory of the www-data user (uid 33).
In the final target filesystem, /var/www should be owned by www-data. This
is important for the lighttpd package, for example.
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
target/generic/device_table.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/generic/device_table.txt b/target/generic/device_table.txt
index fc397a9..421b357 100644
--- a/target/generic/device_table.txt
+++ b/target/generic/device_table.txt
@@ -10,6 +10,7 @@
/tmp d 1777 0 0 - - - - -
/etc d 755 0 0 - - - - -
/home/default d 2755 1000 1000 - - - - -
+/var/www d 755 33 33 - - - - -
/etc/shadow f 600 0 0 - - - - -
/etc/passwd f 644 0 0 - - - - -
/etc/network/if-up.d d 755 0 0 - - - - -
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add /var/www to device table
2012-06-25 20:02 [Buildroot] [PATCH] Add /var/www to device table spdawson at gmail.com
@ 2012-06-30 17:46 ` Arnout Vandecappelle
2012-07-09 12:51 ` Simon Dawson
2012-07-02 8:33 ` Romain Izard
1 sibling, 1 reply; 9+ messages in thread
From: Arnout Vandecappelle @ 2012-06-30 17:46 UTC (permalink / raw)
To: buildroot
On 06/25/12 22:02, spdawson at gmail.com wrote:
> From: Simon Dawson<spdawson@gmail.com>
>
> The /var/www directory is listed in /etc/passwd in the skeleton target
> filesystem as the home directory of the www-data user (uid 33).
>
> In the final target filesystem, /var/www should be owned by www-data. This
> is important for the lighttpd package, for example.
>
> Signed-off-by: Simon Dawson<spdawson@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
There's a redundant tab in the /var/www line, however.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add /var/www to device table
2012-06-25 20:02 [Buildroot] [PATCH] Add /var/www to device table spdawson at gmail.com
2012-06-30 17:46 ` Arnout Vandecappelle
@ 2012-07-02 8:33 ` Romain Izard
2012-07-03 8:03 ` Thomas Petazzoni
1 sibling, 1 reply; 9+ messages in thread
From: Romain Izard @ 2012-07-02 8:33 UTC (permalink / raw)
To: buildroot
On 2012-06-25, spdawson at gmail.com <spdawson@gmail.com> wrote:
> From: Simon Dawson <spdawson@gmail.com>
>
> The /var/www directory is listed in /etc/passwd in the skeleton target
> filesystem as the home directory of the www-data user (uid 33).
>
> In the final target filesystem, /var/www should be owned by www-data. This
> is important for the lighttpd package, for example.
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
Shouldn't it be changed by using a LIGHTTPD_PERMISSIONS variable,
instead of modifying the common device table ? This makes the
relationship more evident.
See the following example:
---
diff --git a/package/lighttpd/lighttpd.mk b/package/lighttpd/lighttpd.mk
index b8aa310..34f59b2 100644
--- a/package/lighttpd/lighttpd.mk
+++ b/package/lighttpd/lighttpd.mk
@@ -62,4 +62,9 @@ define LIGHTTPD_UNINSTALL_TARGET_CMDS
rm -rf $(TARGET_DIR)/usr/lib/lighttpd
endef
+#<name> <type> <mode> <uid> <gid> <major> <minor> <start> <inc> <count>
+define LIGHTTPD_PERMISSIONS
+var/www d 755 33 33 - - - - -
+endef
+
$(eval $(call AUTOTARGETS))
--
Romain Izard
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add /var/www to device table
2012-07-02 8:33 ` Romain Izard
@ 2012-07-03 8:03 ` Thomas Petazzoni
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2012-07-03 8:03 UTC (permalink / raw)
To: buildroot
Le Mon, 2 Jul 2012 08:33:24 +0000 (UTC),
Romain Izard <romain.izard.pro@gmail.com> a ?crit :
> Shouldn't it be changed by using a LIGHTTPD_PERMISSIONS variable,
> instead of modifying the common device table ? This makes the
> relationship more evident.
I think the point was that /var/www would not only be used by lighttpd,
but also by other web servers, and packages installing Javascript
stuff, etc.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add /var/www to device table
@ 2012-07-09 12:51 spdawson at gmail.com
2012-07-09 20:04 ` Arnout Vandecappelle
0 siblings, 1 reply; 9+ messages in thread
From: spdawson at gmail.com @ 2012-07-09 12:51 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
The /var/www directory is listed in /etc/passwd in the skeleton target
filesystem as the home directory of the www-data user (uid 33).
In the final target filesystem, /var/www should be owned by www-data. This
is important for the lighttpd package, for example.
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
v2: Removed redundant TAB from line added device table file.
target/generic/device_table.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/generic/device_table.txt b/target/generic/device_table.txt
index fc397a9..421728b 100644
--- a/target/generic/device_table.txt
+++ b/target/generic/device_table.txt
@@ -10,6 +10,7 @@
/tmp d 1777 0 0 - - - - -
/etc d 755 0 0 - - - - -
/home/default d 2755 1000 1000 - - - - -
+/var/www d 755 33 33 - - - - -
/etc/shadow f 600 0 0 - - - - -
/etc/passwd f 644 0 0 - - - - -
/etc/network/if-up.d d 755 0 0 - - - - -
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add /var/www to device table
2012-07-09 12:51 spdawson at gmail.com
@ 2012-07-09 20:04 ` Arnout Vandecappelle
2012-07-09 20:20 ` Simon Dawson
0 siblings, 1 reply; 9+ messages in thread
From: Arnout Vandecappelle @ 2012-07-09 20:04 UTC (permalink / raw)
To: buildroot
On 07/09/12 14:51, spdawson at gmail.com wrote:
> The /var/www directory is listed in /etc/passwd in the skeleton target
> filesystem as the home directory of the www-data user (uid 33).
>
> In the final target filesystem, /var/www should be owned by www-data. This
> is important for the lighttpd package, for example.
>
> Signed-off-by: Simon Dawson<spdawson@gmail.com>
You forgot to add my
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> v2: Removed redundant TAB from line added device table file.
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add /var/www to device table
@ 2012-07-09 20:20 spdawson at gmail.com
0 siblings, 0 replies; 9+ messages in thread
From: spdawson at gmail.com @ 2012-07-09 20:20 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
The /var/www directory is listed in /etc/passwd in the skeleton target
filesystem as the home directory of the www-data user (uid 33).
In the final target filesystem, /var/www should be owned by www-data. This
is important for the lighttpd package, for example.
Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
v2: Removed redundant TAB from line added device table file.
v3: Added Acked-by information.
target/generic/device_table.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/generic/device_table.txt b/target/generic/device_table.txt
index fc397a9..421728b 100644
--- a/target/generic/device_table.txt
+++ b/target/generic/device_table.txt
@@ -10,6 +10,7 @@
/tmp d 1777 0 0 - - - - -
/etc d 755 0 0 - - - - -
/home/default d 2755 1000 1000 - - - - -
+/var/www d 755 33 33 - - - - -
/etc/shadow f 600 0 0 - - - - -
/etc/passwd f 644 0 0 - - - - -
/etc/network/if-up.d d 755 0 0 - - - - -
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-07-09 20:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-25 20:02 [Buildroot] [PATCH] Add /var/www to device table spdawson at gmail.com
2012-06-30 17:46 ` Arnout Vandecappelle
2012-07-09 12:51 ` Simon Dawson
2012-07-02 8:33 ` Romain Izard
2012-07-03 8:03 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2012-07-09 12:51 spdawson at gmail.com
2012-07-09 20:04 ` Arnout Vandecappelle
2012-07-09 20:20 ` Simon Dawson
2012-07-09 20:20 spdawson at gmail.com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox