* [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package @ 2012-07-18 16:02 Maxime Ripard 2012-07-18 16:02 ` [Buildroot] [PATCH 2/2] Add MXS bootlets package Maxime Ripard 2012-07-20 22:37 ` [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Thomas Petazzoni 0 siblings, 2 replies; 10+ messages in thread From: Maxime Ripard @ 2012-07-18 16:02 UTC (permalink / raw) To: buildroot From: Eric Jarrige <eric.jarrige@armadeus.org> Elftosb is a Freescale toolset to build binary image files (like U-Boot.sb) to be used with CPUs imx23, imx28, stp37xx Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- package/elftosb/elftosb.mk | 28 ++++++++++++++++++++ .../elftosb/elftosb10.12.01-fixes_includes.patch | 19 +++++++++++++ 2 files changed, 47 insertions(+) create mode 100644 package/elftosb/elftosb.mk create mode 100644 package/elftosb/elftosb10.12.01-fixes_includes.patch diff --git a/package/elftosb/elftosb.mk b/package/elftosb/elftosb.mk new file mode 100644 index 0000000..75b95a5 --- /dev/null +++ b/package/elftosb/elftosb.mk @@ -0,0 +1,28 @@ +############################################################# +# +# elftosb +# +############################################################# +ELFTOSB_VERSION = 10.12.01 +ELFTOSB_SOURCE = elftosb-$(ELFTOSB_VERSION).tar.gz +ELFTOSB_SITE = http://repository.timesys.com/buildsources/e/elftosb/elftosb-$(ELFTOSB_VERSION) + +define HOST_ELFTOSB_BUILD_CMDS + $(HOST_MAKE_ENV) $(MAKE) -C $(@D) all +endef + +define HOST_ELFTOSB_INSTALL_CMDS + $(INSTALL) -D $(@D)/bld/linux/elftosb $(HOST_DIR)/usr/bin/elftosb + $(INSTALL) -D $(@D)/bld/linux/keygen $(HOST_DIR)/usr/bin/keygen + $(INSTALL) -D $(@D)/bld/linux/sbtool $(HOST_DIR)/usr/bin/sbtool +endef + +define HOST_ELFTOSB_CLEAN_CMDS + rm -rf $(@D)/bld/linux + rm -f $(HOST_DIR)/usr/bin/elftosb + rm -f $(HOST_DIR)/usr/bin/keygen + rm -f $(HOST_DIR)/usr/bin/sbtool +endef + +$(eval $(call GENTARGETS,host)) + diff --git a/package/elftosb/elftosb10.12.01-fixes_includes.patch b/package/elftosb/elftosb10.12.01-fixes_includes.patch new file mode 100644 index 0000000..eaf8eba --- /dev/null +++ b/package/elftosb/elftosb10.12.01-fixes_includes.patch @@ -0,0 +1,19 @@ +This patch uses system include files instead of a hard coded system path to fixe +potential compilation failure on systems that do not populate system header +files in /usr/include/.. + +Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> +--- +Index: host-elftosb-10.12.01/common/stdafx.h +=================================================================== +--- host-elftosb-10.12.01.orig/common/stdafx.h 2012-01-30 12:43:35.000000000 +0100 ++++ host-elftosb-10.12.01/common/stdafx.h 2012-01-30 12:43:54.000000000 +0100 +@@ -27,7 +27,7 @@ + // For Linux systems only, types.h only defines the signed + // integer types. This is not professional code. + // Update: They are defined in the header files in the more recent version of redhat enterprise gcc. +-#include "/usr/include/sys/types.h" ++#include <sys/types.h> + #include <stdint.h> + //typedef unsigned long uint32_t; + //typedef unsigned short uint16_t; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/2] Add MXS bootlets package 2012-07-18 16:02 [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Maxime Ripard @ 2012-07-18 16:02 ` Maxime Ripard 2012-07-20 22:37 ` Thomas Petazzoni 2012-07-20 22:37 ` [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Thomas Petazzoni 1 sibling, 1 reply; 10+ messages in thread From: Maxime Ripard @ 2012-07-18 16:02 UTC (permalink / raw) To: buildroot MXS platforms (imx23 and imx28) are relying on bootlets as their first stage bootloaders, that can then either start a regular second stage bootloader or directly a Linux kernel. However, the Makefile allows only to build u-boot and linux images at the same time, which is not very convenient as we will more likely use only one of them, so we need to duplicate a bit what is already done so that we are able to choose what we want to generate. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- boot/Config.in | 1 + boot/common.mk | 2 +- boot/mxs-bootlets/Config.in | 91 ++++++++++++++++++++++++++++++++++ boot/mxs-bootlets/barebox_ivt.bd | 34 +++++++++++++ boot/mxs-bootlets/mxs-bootlets.mk | 97 +++++++++++++++++++++++++++++++++++++ 5 files changed, 224 insertions(+), 1 deletion(-) create mode 100644 boot/mxs-bootlets/Config.in create mode 100644 boot/mxs-bootlets/barebox_ivt.bd create mode 100644 boot/mxs-bootlets/mxs-bootlets.mk diff --git a/boot/Config.in b/boot/Config.in index f8ab1cf..5252a49 100644 --- a/boot/Config.in +++ b/boot/Config.in @@ -5,6 +5,7 @@ source "boot/at91dataflashboot/Config.in" source "boot/barebox/Config.in" source "boot/grub/Config.in" source "boot/lpc32xxcdl/Config.in" +source "boot/mxs-bootlets/Config.in" source "boot/syslinux/Config.in" source "boot/uboot/Config.in" source "boot/xloader/Config.in" diff --git a/boot/common.mk b/boot/common.mk index dc0bfb4..b315fe8 100644 --- a/boot/common.mk +++ b/boot/common.mk @@ -1 +1 @@ -include boot/*/*.mk \ No newline at end of file +include boot/*/*.mk diff --git a/boot/mxs-bootlets/Config.in b/boot/mxs-bootlets/Config.in new file mode 100644 index 0000000..87ca512 --- /dev/null +++ b/boot/mxs-bootlets/Config.in @@ -0,0 +1,91 @@ +config BR2_TARGET_MXS_BOOTLETS + bool "mxs-bootlets" + depends on BR2_arm + select BR2_PACKAGE_ELFTOSB + help + Stage1 bootloaders for Freescale iMX23/iMX28 SoCs + +if BR2_TARGET_MXS_BOOTLETS + +choice + prompt "Source" + default BR2_TARGET_MXS_BOOTLETS_FREESCALE + help + Select the location of the bootlets you want to use + +config BR2_TARGET_MXS_BOOTLETS_FREESCALE + bool "Freescale 10.12.01 version" + +config BR2_TARGET_MXS_BOOTLETS_CUSTOM_TARBALL + bool "Custom tarball" + +config BR2_TARGET_MXS_BOOTLETS_CUSTOM_GIT + bool "Custom Git repository" + +endchoice + +config BR2_TARGET_MXS_BOOTLETS_CUSTOM_TARBALL_URL + depends on BR2_TARGET_MXS_BOOTLETS_CUSTOM_TARBALL + string "URL of custom bootlets tarball" + +if BR2_TARGET_MXS_BOOTLETS_CUSTOM_GIT + +config BR2_TARGET_MXS_BOOTLETS_CUSTOM_GIT_URL + string "URL of custom Git repository" + +config BR2_TARGET_MXS_BOOTLETS_CUSTOM_GIT_VERSION + string "Custom Git version" + +endif + +choice + prompt "Bootstream" + help + Select which bootstream to generate + +config BR2_TARGET_MXS_BOOTLETS_BAREBOX + depends on BR2_TARGET_BAREBOX + bool "Barebox Bootloader" + +config BR2_TARGET_MXS_BOOTLETS_LINUX + depends on BR2_LINUX_KERNEL + bool "Linux Kernel" + +config BR2_TARGET_MXS_BOOTLETS_UBOOT + depends on BR2_TARGET_UBOOT + bool "U-boot bootloader" + +endchoice + +config BR2_TARGET_MXS_BOOTLETS_HAS_IVT + bool "HAB Support" + help + Enable this option if you are building bootlets + for the iMX28 platform that needs to include instructions + for the secure boot mechanism present on these SoCs + +choice + prompt "Board" + help + Select the board to build the bootlets for + +config BR2_TARGET_MXS_BOOTLETS_STMP37xx + bool "Sigmatel ST-MP3-7xx Boards" + +config BR2_TARGET_MXS_BOOTLETS_STMP378x + bool "Sigmatel ST-MP3-78x Boards" + +config BR2_TARGET_MXS_BOOTLETS_IMX28 + bool "Freescale iMX28 Boards" + +config BR2_TARGET_MXS_BOOTLETS_CUSTOM_BOARD + bool "Custom board" +endchoice + +config BR2_TARGET_MXS_BOOTLETS_CUSTOM_BOARD_NAME + string "Custom board name" + depends on BR2_TARGET_MXS_BOOTLETS_CUSTOM_BOARD + help + Name of the board to build the bootlets for + +endif diff --git a/boot/mxs-bootlets/barebox_ivt.bd b/boot/mxs-bootlets/barebox_ivt.bd new file mode 100644 index 0000000..e02ddd6 --- /dev/null +++ b/boot/mxs-bootlets/barebox_ivt.bd @@ -0,0 +1,34 @@ +// STMP378x ROM command script to load and run U-Boot + +sources { + power_prep="./power_prep/power_prep"; + sdram_prep="./boot_prep/boot_prep"; + barebox="./barebox"; +} + +section (0) { + + //---------------------------------------------------------- + // Power Supply initialization + //---------------------------------------------------------- + + load power_prep; + load ivt (entry = power_prep:_start) > 0x8000; + hab call 0x8000; + + //---------------------------------------------------------- + // SDRAM initialization + //---------------------------------------------------------- + + load sdram_prep; + load ivt (entry = sdram_prep:_start) > 0x8000; + hab call 0x8000; + //---------------------------------------------------------- + // Load and call u_boot - ELF ARM image + //---------------------------------------------------------- + + load barebox; + load ivt (entry = barebox:exception_vectors) > 0x8000; + hab call 0x8000; + +} diff --git a/boot/mxs-bootlets/mxs-bootlets.mk b/boot/mxs-bootlets/mxs-bootlets.mk new file mode 100644 index 0000000..4e5986c --- /dev/null +++ b/boot/mxs-bootlets/mxs-bootlets.mk @@ -0,0 +1,97 @@ +ifeq ($(BR2_TARGET_MXS_BOOTLETS_CUSTOM_TARBALL),y) + MXS_BOOTLETS_TARBALL = $(call qstrip,$(BR2_TARGET_MXS_BOOTLETS_CUSTOM_TARBALL_URL)) + MXS_BOOTLETS_SITE = $(dir $(MXS_BOOTLETS_TARBALL)) + MXS_BOOTLETS_SOURCE = $(notdir $(MXS_BOOTLETS_TARBALL)) +else ifeq ($(BR2_TARGET_MXS_BOOTLETS_CUSTOM_GIT),y) + MXS_BOOTLETS_SITE = $(BR2_TARGET_MXS_BOOTLETS_CUSTOM_GIT_URL) + MXS_BOOTLETS_SITE_METHOD = git + MXS_BOOTLETS_VERSION = $(call qstrip,$(BR2_TARGET_MXS_BOOTLETS_CUSTOM_GIT_VERSION)) +else + MXS_BOOTLETS_VERSION = 10.12.01 + MXS_BOOTLETS_SITE = http://download.ossystems.com.br/bsp/freescale/source/ + MXS_BOOTLETS_SOURCE = imx-bootlets-src-$(MXS_BOOTLETS_VERSION).tar.gz +endif + +ifeq ($(BR2_TARGET_MXS_BOOTLETS_STMP37xx),y) + MXS_BOOTLETS_BOARD = stmp37xx_dev +else ifeq ($(BR2_TARGET_MXS_BOOTLETS_STMP378x),y) + MXS_BOOTLETS_BOARD = stmp378x_dev +else ifeq ($(BR2_TARGET_MXS_BOOTLETS_IMX28),y) + MXS_BOOTLETS_BOARD = iMX28_EVK +else ifeq ($(BR2_TARGET_MXS_BOOTLETS_CUSTOM_BOARD),y) + MXS_BOOTLETS_BOARD = $(call qstrip,$(BR2_TARGET_MXS_BOOTLETS_CUSTOM_BOARD_NAME)) +endif + +ifeq ($(BR2_TARGET_MXS_BOOTLETS_HAS_IVT),y) + MXS_BOOTLETS_IVT_SUFFIX = _ivt + MXS_BOOTLETS_ELFTOSB_OPTIONS += -f imx28 +endif + +MXS_BOOTLETS_DEPENDENCIES = host-elftosb + +ifeq ($(BR2_TARGET_MXS_BOOTLETS_BAREBOX),y) +MXS_BOOTLETS_DEPENDENCIES += barebox +MXS_BOOTLETS_BOOTDESC = barebox$(MXS_BOOTLETS_IVT_SUFFIX).bd +MXS_BOOTLETS_BOOTSTREAM = $(MXS_BOOTLETS_BOARD)_barebox$(MXS_BOOTLETS_IVT_SUFFIX).sb + +else ifeq ($(BR2_TARGET_MXS_BOOTLETS_LINUX),y) +MXS_BOOTLETS_DEPENDENCIES += linux +MXS_BOOTLETS_BOOTDESC = linux$(MXS_BOOTLETS_IVT_SUFFIX).bd +MXS_BOOTLETS_BOOTSTREAM = $(MXS_BOOTLETS_BOARD)_linux$(MXS_BOOTLETS_IVT_SUFFIX).sb + +else ifeq ($(BR2_TARGET_MXS_BOOTLETS_UBOOT),y) +MXS_BOOTLETS_DEPENDENCIES += uboot +MXS_BOOTLETS_BOOTDESC = uboot$(MXS_BOOTLETS_IVT_SUFFIX).bd +MXS_BOOTLETS_BOOTSTREAM = $(MXS_BOOTLETS_BOARD)_uboot$(MXS_BOOTLETS_IVT_SUFFIX).sb +endif + +ifeq ($(BR2_TARGET_MXS_BOOTLETS_BAREBOX),y) +define MXS_BOOTLETS_SED_BAREBOX + sed -i 's,[^ *]barebox.*;,\tbarebox="$(BAREBOX_DIR)/barebox";,' $(@D)/$(MXS_BOOTLETS_BOOTDESC) +endef +endif + +ifeq ($(BR2_TARGET_MXS_BOOTLETS_LINUX),y) +define MXS_BOOTLETS_BUILD_LINUX_PREP + BOARD=$(MXS_BOOTLETS_BOARD) CROSS_COMPILE="$(TARGET_CROSS)" \ + $(MAKE1) -C $(@D) linux_prep +endef +define MXS_BOOTLETS_SED_LINUX + sed -i 's,[^ *]linux_prep.*;,\tlinux_prep="$(@D)/linux_prep/output-target/linux_prep";,' $(@D)/$(MXS_BOOTLETS_BOOTDESC) + sed -i 's,[^ *]zImage.*;,\tzImage="$(LINUX_DIR)/arch/arm/boot/zImage";,' $(@D)/$(MXS_BOOTLETS_BOOTDESC) +endef +endif + +ifeq ($(BR2_TARGET_MXS_BOOTLETS_UBOOT),y) +define MXS_BOOTLETS_SED_UBOOT + sed -i 's,[^ *]u_boot.*;,\tu_boot="$(UBOOT_DIR)/u-boot";,' $(@D)/$(MXS_BOOTLETS_BOOTDESC) +endef +endif + +define MXS_BOOTLETS_INSTALL_BAREBOX_BOOTDESC + cp boot/mxs-bootlets/barebox_ivt.bd $(@D)/ +endef + +MXS_BOOTLETS_POST_EXTRACT_HOOKS += MXS_BOOTLETS_INSTALL_BAREBOX_BOOTDESC + +define MXS_BOOTLETS_BUILD_CMDS + BOARD=$(MXS_BOOTLETS_BOARD) CROSS_COMPILE="$(TARGET_CROSS)" \ + $(MAKE1) -C $(@D) power_prep + BOARD=$(MXS_BOOTLETS_BOARD) CROSS_COMPILE="$(TARGET_CROSS)" \ + $(MAKE1) -C $(@D) boot_prep + $(MXS_BOOTLETS_BUILD_LINUX_PREP) + sed -i 's,[^ *]power_prep.*;,\tpower_prep="$(@D)/power_prep/power_prep";,' $(@D)/$(MXS_BOOTLETS_BOOTDESC) + sed -i 's,[^ *]sdram_prep.*;,\tsdram_prep="$(@D)/boot_prep/boot_prep";,' $(@D)/$(MXS_BOOTLETS_BOOTDESC) + $(MXS_BOOTLETS_SED_BAREBOX) + $(MXS_BOOTLETS_SED_LINUX) + $(MXS_BOOTLETS_SED_UBOOT) + $(HOST_DIR)/usr/bin/elftosb $(MXS_BOOTLETS_ELFTOSB_OPTIONS) \ + -z -c $(@D)/$(MXS_BOOTLETS_BOOTDESC) \ + -o $(@D)/$(MXS_BOOTLETS_BOOTSTREAM) +endef + +define MXS_BOOTLETS_INSTALL_TARGET_CMDS + cp $(@D)/$(MXS_BOOTLETS_BOOTSTREAM) $(BINARIES_DIR)/ +endef + +$(eval $(call GENTARGETS)) -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/2] Add MXS bootlets package 2012-07-18 16:02 ` [Buildroot] [PATCH 2/2] Add MXS bootlets package Maxime Ripard @ 2012-07-20 22:37 ` Thomas Petazzoni 0 siblings, 0 replies; 10+ messages in thread From: Thomas Petazzoni @ 2012-07-20 22:37 UTC (permalink / raw) To: buildroot Le Wed, 18 Jul 2012 18:02:43 +0200, Maxime Ripard <maxime.ripard@free-electrons.com> a ?crit : > MXS platforms (imx23 and imx28) are relying on bootlets as their first > stage bootloaders, that can then either start a regular second stage > bootloader or directly a Linux kernel. However, the Makefile allows > only to build u-boot and linux images at the same time, which is > not very convenient as we will more likely use only one of them, > so we need to duplicate a bit what is already done so that we are able > to choose what we want to generate. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Applied with minor fixes. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package 2012-07-18 16:02 [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Maxime Ripard 2012-07-18 16:02 ` [Buildroot] [PATCH 2/2] Add MXS bootlets package Maxime Ripard @ 2012-07-20 22:37 ` Thomas Petazzoni 1 sibling, 0 replies; 10+ messages in thread From: Thomas Petazzoni @ 2012-07-20 22:37 UTC (permalink / raw) To: buildroot Le Wed, 18 Jul 2012 18:02:42 +0200, Maxime Ripard <maxime.ripard@free-electrons.com> a ?crit : > From: Eric Jarrige <eric.jarrige@armadeus.org> > > Elftosb is a Freescale toolset to build binary image files (like U-Boot.sb) > to be used with CPUs imx23, imx28, stp37xx > > Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Applied with minor fixes. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 0/2] add u-boot.sb file format and elftosb tools @ 2012-03-13 12:52 Eric Jarrige 2012-03-13 12:52 ` [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Eric Jarrige 0 siblings, 1 reply; 10+ messages in thread From: Eric Jarrige @ 2012-03-13 12:52 UTC (permalink / raw) To: buildroot These patches add support for the Freescale "Safe Boot" file format: - add elftosb host tools to package the .sb binary files - add u-boot.sb binary format in BR menuconfig Eric Jarrige (2): Add (Freescale) elftosb host package u-boot: add support for u-boot.sb file format boot/uboot/Config.in | 3 ++ boot/uboot/uboot.mk | 4 +++ package/elftosb/elftosb.mk | 28 ++++++++++++++++++++ .../elftosb/elftosb10.12.01-fixes_includes.patch | 19 +++++++++++++ 4 files changed, 54 insertions(+), 0 deletions(-) create mode 100644 package/elftosb/elftosb.mk create mode 100644 package/elftosb/elftosb10.12.01-fixes_includes.patch -- 1.7.2.5 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package 2012-03-13 12:52 [Buildroot] [PATCH 0/2] add u-boot.sb file format and elftosb tools Eric Jarrige @ 2012-03-13 12:52 ` Eric Jarrige 2012-03-13 15:10 ` Thomas Petazzoni 2012-03-14 0:05 ` Arnout Vandecappelle 0 siblings, 2 replies; 10+ messages in thread From: Eric Jarrige @ 2012-03-13 12:52 UTC (permalink / raw) To: buildroot Elftosb is a Freescale toolset to build binary image files (like U-Boot.sb) to be used with CPUs imx23, imx28, stp37xx Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> --- package/elftosb/elftosb.mk | 28 ++++++++++++++++++++ .../elftosb/elftosb10.12.01-fixes_includes.patch | 19 +++++++++++++ 2 files changed, 47 insertions(+), 0 deletions(-) create mode 100644 package/elftosb/elftosb.mk create mode 100644 package/elftosb/elftosb10.12.01-fixes_includes.patch diff --git a/package/elftosb/elftosb.mk b/package/elftosb/elftosb.mk new file mode 100644 index 0000000..75b95a5 --- /dev/null +++ b/package/elftosb/elftosb.mk @@ -0,0 +1,28 @@ +############################################################# +# +# elftosb +# +############################################################# +ELFTOSB_VERSION = 10.12.01 +ELFTOSB_SOURCE = elftosb-$(ELFTOSB_VERSION).tar.gz +ELFTOSB_SITE = http://repository.timesys.com/buildsources/e/elftosb/elftosb-$(ELFTOSB_VERSION) + +define HOST_ELFTOSB_BUILD_CMDS + $(HOST_MAKE_ENV) $(MAKE) -C $(@D) all +endef + +define HOST_ELFTOSB_INSTALL_CMDS + $(INSTALL) -D $(@D)/bld/linux/elftosb $(HOST_DIR)/usr/bin/elftosb + $(INSTALL) -D $(@D)/bld/linux/keygen $(HOST_DIR)/usr/bin/keygen + $(INSTALL) -D $(@D)/bld/linux/sbtool $(HOST_DIR)/usr/bin/sbtool +endef + +define HOST_ELFTOSB_CLEAN_CMDS + rm -rf $(@D)/bld/linux + rm -f $(HOST_DIR)/usr/bin/elftosb + rm -f $(HOST_DIR)/usr/bin/keygen + rm -f $(HOST_DIR)/usr/bin/sbtool +endef + +$(eval $(call GENTARGETS,host)) + diff --git a/package/elftosb/elftosb10.12.01-fixes_includes.patch b/package/elftosb/elftosb10.12.01-fixes_includes.patch new file mode 100644 index 0000000..eaf8eba --- /dev/null +++ b/package/elftosb/elftosb10.12.01-fixes_includes.patch @@ -0,0 +1,19 @@ +This patch uses system include files instead of a hard coded system path to fixe +potential compilation failure on systems that do not populate system header +files in /usr/include/.. + +Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> +--- +Index: host-elftosb-10.12.01/common/stdafx.h +=================================================================== +--- host-elftosb-10.12.01.orig/common/stdafx.h 2012-01-30 12:43:35.000000000 +0100 ++++ host-elftosb-10.12.01/common/stdafx.h 2012-01-30 12:43:54.000000000 +0100 +@@ -27,7 +27,7 @@ + // For Linux systems only, types.h only defines the signed + // integer types. This is not professional code. + // Update: They are defined in the header files in the more recent version of redhat enterprise gcc. +-#include "/usr/include/sys/types.h" ++#include <sys/types.h> + #include <stdint.h> + //typedef unsigned long uint32_t; + //typedef unsigned short uint16_t; -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package 2012-03-13 12:52 ` [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Eric Jarrige @ 2012-03-13 15:10 ` Thomas Petazzoni 2012-03-14 0:05 ` Arnout Vandecappelle 1 sibling, 0 replies; 10+ messages in thread From: Thomas Petazzoni @ 2012-03-13 15:10 UTC (permalink / raw) To: buildroot Le Tue, 13 Mar 2012 13:52:10 +0100, Eric Jarrige <eric.jarrige@armadeus.org> a ?crit : > Elftosb is a Freescale toolset to build binary image files (like > U-Boot.sb) to be used with CPUs imx23, imx28, stp37xx > > Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package 2012-03-13 12:52 ` [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Eric Jarrige 2012-03-13 15:10 ` Thomas Petazzoni @ 2012-03-14 0:05 ` Arnout Vandecappelle 2012-03-14 9:41 ` Thomas Petazzoni 1 sibling, 1 reply; 10+ messages in thread From: Arnout Vandecappelle @ 2012-03-14 0:05 UTC (permalink / raw) To: buildroot On Tuesday 13 March 2012 13:52:10 Eric Jarrige wrote: > +define HOST_ELFTOSB_CLEAN_CMDS > + rm -rf $(@D)/bld/linux > + rm -f $(HOST_DIR)/usr/bin/elftosb > + rm -f $(HOST_DIR)/usr/bin/keygen > + rm -f $(HOST_DIR)/usr/bin/sbtool > +endef These look like UNINSTALL commands, not CLEAN commands. Not that it's terribly important. Regards, Arnout -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package 2012-03-14 0:05 ` Arnout Vandecappelle @ 2012-03-14 9:41 ` Thomas Petazzoni 2012-03-14 11:11 ` Luca Ceresoli 0 siblings, 1 reply; 10+ messages in thread From: Thomas Petazzoni @ 2012-03-14 9:41 UTC (permalink / raw) To: buildroot Hello, Le Wed, 14 Mar 2012 01:05:44 +0100, Arnout Vandecappelle <arnout@mind.be> a ?crit : > On Tuesday 13 March 2012 13:52:10 Eric Jarrige wrote: > > +define HOST_ELFTOSB_CLEAN_CMDS > > + rm -rf $(@D)/bld/linux > > + rm -f $(HOST_DIR)/usr/bin/elftosb > > + rm -f $(HOST_DIR)/usr/bin/keygen > > + rm -f $(HOST_DIR)/usr/bin/sbtool > > +endef > > These look like UNINSTALL commands, not CLEAN commands. Ah right. Actually the first line should be part of CLEAN commands, and the three last lines should be part of the UNINSTALL commands. Are they people who actually care about those CLEAN and UNINSTALL commands? Is it worth keeping support for them? Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package 2012-03-14 9:41 ` Thomas Petazzoni @ 2012-03-14 11:11 ` Luca Ceresoli 2012-03-14 11:57 ` Thomas Petazzoni 0 siblings, 1 reply; 10+ messages in thread From: Luca Ceresoli @ 2012-03-14 11:11 UTC (permalink / raw) To: buildroot Thomas Petazzoni wrote: > Hello, > > Le Wed, 14 Mar 2012 01:05:44 +0100, > Arnout Vandecappelle<arnout@mind.be> a ?crit : > >> On Tuesday 13 March 2012 13:52:10 Eric Jarrige wrote: >>> +define HOST_ELFTOSB_CLEAN_CMDS >>> + rm -rf $(@D)/bld/linux >>> + rm -f $(HOST_DIR)/usr/bin/elftosb >>> + rm -f $(HOST_DIR)/usr/bin/keygen >>> + rm -f $(HOST_DIR)/usr/bin/sbtool >>> +endef >> These look like UNINSTALL commands, not CLEAN commands. > Ah right. Actually the first line should be part of CLEAN commands, and > the three last lines should be part of the UNINSTALL commands. > > Are they people who actually care about those CLEAN and UNINSTALL > commands? Is it worth keeping support for them? IIRC these targets cannot in general work correctly with the Buildroot structure, and making them work would require a massive change, with a big increase in complexity. Moreover, many packages do not implement the CLEAN and UNINSTALL targets: $ git grep -l GENTARGETS package/|grep -E '^package/[a-z]'|wc -l 111 $ git grep -l GENTARGETS package/|grep -E '^package/[a-z]'| \ xargs grep -l '_CLEAN_CMDS'|wc -l 51 $ git grep -l GENTARGETS package/|grep -E '^package/[a-z]'| \ xargs grep -l '_UNINSTALL_.*_CMDS'|wc -l 73 meaning that probably they are not so interesting to everybody out there. As for me, I have never been relying on them. I prefer to distclean and rebuild when necessary. It's reliable, and not that painful with a reasonably recent build machine and ccache enabled. So, my vote for dropping them. (Or should there be a specific thread for this topic?) Luca ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package 2012-03-14 11:11 ` Luca Ceresoli @ 2012-03-14 11:57 ` Thomas Petazzoni 0 siblings, 0 replies; 10+ messages in thread From: Thomas Petazzoni @ 2012-03-14 11:57 UTC (permalink / raw) To: buildroot Le Wed, 14 Mar 2012 12:11:21 +0100, Luca Ceresoli <luca@lucaceresoli.net> a ?crit : > IIRC these targets cannot in general work correctly with the Buildroot > structure, and making them work would require a massive change, with a > big increase in complexity. > > Moreover, many packages do not implement the CLEAN and UNINSTALL targets: > > $ git grep -l GENTARGETS package/|grep -E '^package/[a-z]'|wc -l > 111 > $ git grep -l GENTARGETS package/|grep -E '^package/[a-z]'| \ > xargs grep -l '_CLEAN_CMDS'|wc -l > 51 > $ git grep -l GENTARGETS package/|grep -E '^package/[a-z]'| \ > xargs grep -l '_UNINSTALL_.*_CMDS'|wc -l > 73 > > meaning that probably they are not so interesting to everybody out there. > > As for me, I have never been relying on them. I prefer to distclean and > rebuild when necessary. It's reliable, and not that painful with a > reasonably recent build machine and ccache enabled. > > So, my vote for dropping them. > (Or should there be a specific thread for this topic?) I definitely agree with you here. If they exist, then they should be reliable. But I'm not sure it's going to be easy to make them fully reliable. And then can be dangerous, because they are not recursive: you can remove a given library without removing the other libraries or applications that depend on it. So I would also vote for dropping them. But we should then also drop it from AUTOTARGETS/CMAKETARGETS packages. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-07-20 22:37 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-18 16:02 [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Maxime Ripard 2012-07-18 16:02 ` [Buildroot] [PATCH 2/2] Add MXS bootlets package Maxime Ripard 2012-07-20 22:37 ` Thomas Petazzoni 2012-07-20 22:37 ` [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Thomas Petazzoni -- strict thread matches above, loose matches on Subject: below -- 2012-03-13 12:52 [Buildroot] [PATCH 0/2] add u-boot.sb file format and elftosb tools Eric Jarrige 2012-03-13 12:52 ` [Buildroot] [PATCH 1/2] Add (Freescale) elftosb host package Eric Jarrige 2012-03-13 15:10 ` Thomas Petazzoni 2012-03-14 0:05 ` Arnout Vandecappelle 2012-03-14 9:41 ` Thomas Petazzoni 2012-03-14 11:11 ` Luca Ceresoli 2012-03-14 11:57 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox