From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] lua: remove 3 sub-options, always install all
Date: Mon, 30 Jul 2012 22:56:45 +0200 [thread overview]
Message-ID: <20120730225645.6ed17e9f@skate> (raw)
In-Reply-To: <1343629890-4657-3-git-send-email-francois.perrad@gadz.org>
Le Mon, 30 Jul 2012 08:31:29 +0200,
Francois Perrad <fperrad@gmail.com> a ?crit :
> ---
> package/lua/Config.in | 18 ------------------
> package/lua/lua.mk | 17 +----------------
> 2 files changed, 1 insertion(+), 34 deletions(-)
>
> diff --git a/package/lua/Config.in b/package/lua/Config.in
> index 06f3046..fc6bb4c 100644
> --- a/package/lua/Config.in
> +++ b/package/lua/Config.in
> @@ -32,29 +32,11 @@ endchoice
>
> if BR2_PACKAGE_LUA
>
> -config BR2_PACKAGE_LUA_COMPILER
> - bool "lua compiler"
> - select BR2_PACKAGE_LUA_SHARED_LIBRARY
> - help
> - Install luac binary
> -
> -config BR2_PACKAGE_LUA_INTERPRETER
> - bool "lua interpreter"
> - select BR2_PACKAGE_LUA_SHARED_LIBRARY
> - help
> - Install lua binary
Wouldn't it make sense to keep options for the compiler and
interpreter? I presume using the compiler on the target is fairly
uncommon (you would rather do the compilation at build time, no?).
And Lua can be used as a library without the separate /usr/bin/lua
interpreter, no?
But maybe this last option (the interpreter) is more complicated to
handle with the choice between lua and luajit.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-30 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 6:31 [Buildroot] [PATCH 1/4] luajit: complete replacement for lua v2 Francois Perrad
2012-07-30 6:31 ` [Buildroot] [PATCH 2/4] luajit: allow building for the host Francois Perrad
2012-07-30 20:54 ` Thomas Petazzoni
2012-07-30 6:31 ` [Buildroot] [PATCH 3/4] lua: remove 3 sub-options, always install all Francois Perrad
2012-07-30 20:56 ` Thomas Petazzoni [this message]
2012-07-31 7:56 ` François Perrad
2012-07-30 6:31 ` [Buildroot] [PATCH 4/4] lua: refactor without useless define's Francois Perrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730225645.6ed17e9f@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox