Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libpng: bump version and add apng support (required by firefox)
Date: Fri, 10 Aug 2012 09:02:32 +0200	[thread overview]
Message-ID: <20120810090232.7ca6f885@skate> (raw)
In-Reply-To: <50240DDE.4000901@petroprogram.com>

Hello Stefan,

Le Thu, 09 Aug 2012 22:22:06 +0300,
Stefan Fr?berg <stefan.froberg@petroprogram.com> a ?crit :

> Signed-off-by: Stefan Froberg <stefan.froberg@petroprogram.com>
> ---

Thanks for this patch. A few comments:

 (1) Your patch has been line-wrapped by your e-mail client. Try to use
     git send-email instead, which will guarantee that your patch
     remains intact and can be applied properly.

 (2) As far as I know, the bump from libpng 1.4 to libpng 1.5 changes
     the API, and is therefore causing build failures in other
     packages. Have you tested things like DirectFB and other packages
     that rely on libpng?

 (3) Is this apng feature something that is being integrated in the
     upstream version of libpng? In Buildroot, we don't like carrying
     patches that add features to packages. Imagine we later want to
     bump libpng to version 1.5.10 or 1.5.11, we'd have to refresh the
     patch, which becomes complicated if we accumulate many large
     patches.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-08-10  7:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 19:22 [Buildroot] [PATCH] libpng: bump version and add apng support (required by firefox) Stefan Fröberg
2012-08-10  7:02 ` Thomas Petazzoni [this message]
2012-08-10  9:47   ` Stefan Fröberg
2012-08-10 20:00     ` Thomas Petazzoni
2012-08-10 23:22       ` Stefan Fröberg
2012-08-11  6:50         ` Thomas Petazzoni
2012-08-11 10:54           ` Stefan Fröberg
2012-08-11 11:29           ` Stefan Fröberg
2012-08-21 21:30     ` Arnout Vandecappelle
2012-08-21 22:01       ` Stefan Fröberg
2012-08-26 21:35         ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120810090232.7ca6f885@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox