From: "Stefan Fröberg" <stefan.froberg@petroprogram.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libpng: bump version and add apng support (required by firefox)
Date: Sat, 11 Aug 2012 02:22:33 +0300 [thread overview]
Message-ID: <502597B9.9010705@petroprogram.com> (raw)
In-Reply-To: <20120810220052.6a596ce3@skate>
>> By the way Thomas, how should I split my patches if they become too large ?
>> I have currently eight files for my firefox build and the total number
>> of lines is...well...large.
>>
>> So, should I chunk it to separately patches with git ([PATCH 1/8],
>> [PATCH 2/8] etc ....) ,
>> with each patch containing just one file or how ?
> You can send all the files related to a particular package as a single
> patch, even if it is large. However, we might be a bit reluctant to add
> a package that requires such a number of big patches. We'll wait your
> posting to see what those patches do, and whether they are acceptable
> inside Buildroot.
Not to worry, the patches are actually very small and I was surprised
how little I had to change code.
But the actual build process was very ... messy ... and i had spend most
of the last four months of (and lot's of hair tearing)
finding just the right combination of build switches to make the damn
thing compile and actually run.
Firefox extensions work now and It even plays YouTube videos with gnash
plugin. Yay! :-)
So the biggest files are firefox.mk, which I have commented extensively
so that nobody has to go for this trouble again, and mozconfig file.
I also have added optional feature that when enabled will try to make
Firefox as privacy enhanced as possible
(using NoScript and AdblockPlus extension plus my own about:config
settings)
If the yasm package patch and that little cairo option addition patch
are both okay for you I will then send one final patch (few little
changes needed to sqlite.mk)
and then im ready to send the actual firefox.
Stefan
> Best regards,
>
> Thomas
next prev parent reply other threads:[~2012-08-10 23:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 19:22 [Buildroot] [PATCH] libpng: bump version and add apng support (required by firefox) Stefan Fröberg
2012-08-10 7:02 ` Thomas Petazzoni
2012-08-10 9:47 ` Stefan Fröberg
2012-08-10 20:00 ` Thomas Petazzoni
2012-08-10 23:22 ` Stefan Fröberg [this message]
2012-08-11 6:50 ` Thomas Petazzoni
2012-08-11 10:54 ` Stefan Fröberg
2012-08-11 11:29 ` Stefan Fröberg
2012-08-21 21:30 ` Arnout Vandecappelle
2012-08-21 22:01 ` Stefan Fröberg
2012-08-26 21:35 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502597B9.9010705@petroprogram.com \
--to=stefan.froberg@petroprogram.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox