* [Buildroot] [PATCH] vala: fix documentation build problem
@ 2012-09-17 20:33 Thomas Petazzoni
2012-09-18 20:59 ` Arnout Vandecappelle
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2012-09-17 20:33 UTC (permalink / raw)
To: buildroot
On gcc10, the build of the host-vala documentation causes a
segmentation fault of xsltproc, for some unknown reason. See:
http://autobuild.buildroot.org/results/42fea25ac4fe33a56c02d90c361da1c494f79ba3/build-end.log
Therefore, this patch fixes the problem by:
* Ensuring that host-libxslt is amongst the dependency of vala (vala
for the target) so that we build a well-known version of
libxslt/xsltproc.
* Disabling the build of the documentation for host-vala. Note that
we need to pass ':' as the xsltproc binary name to teach the
configure script that xsltproc is not available.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/vala/vala.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/package/vala/vala.mk b/package/vala/vala.mk
index 984043c..83c45b0 100644
--- a/package/vala/vala.mk
+++ b/package/vala/vala.mk
@@ -9,9 +9,17 @@ VALA_VERSION_MINOR = 6
VALA_VERSION = $(VALA_VERSION_MAJOR).$(VALA_VERSION_MINOR)
VALA_SITE = http://download.gnome.org/sources/vala/$(VALA_VERSION_MAJOR)
VALA_SOURCE = vala-$(VALA_VERSION).tar.xz
+
VALA_DEPENDENCIES = host-flex libglib2 \
$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext libintl)
+ifeq ($(BR2_HAVE_DOCUMENTATION),y)
+VALA_DEPENDENCIES += host-libxslt
+endif
+
HOST_VALA_DEPENDENCIES = host-flex host-libglib2
+# Yes, the autoconf script understands ':' as "xsltproc is not
+# available".
+HOST_VALA_CONF_ENV = ac_cv_path_XSLTPROC=:
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] vala: fix documentation build problem
2012-09-17 20:33 [Buildroot] [PATCH] vala: fix documentation build problem Thomas Petazzoni
@ 2012-09-18 20:59 ` Arnout Vandecappelle
2012-09-19 5:10 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Arnout Vandecappelle @ 2012-09-18 20:59 UTC (permalink / raw)
To: buildroot
On 09/17/12 22:33, Thomas Petazzoni wrote:
> On gcc10, the build of the host-vala documentation causes a
> segmentation fault of xsltproc, for some unknown reason. See:
>
> http://autobuild.buildroot.org/results/42fea25ac4fe33a56c02d90c361da1c494f79ba3/build-end.log
>
> Therefore, this patch fixes the problem by:
>
> * Ensuring that host-libxslt is amongst the dependency of vala (vala
> for the target) so that we build a well-known version of
> libxslt/xsltproc.
>
> * Disabling the build of the documentation for host-vala. Note that
> we need to pass ':' as the xsltproc binary name to teach the
> configure script that xsltproc is not available.
>
> Signed-off-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>
> ---
> package/vala/vala.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/vala/vala.mk b/package/vala/vala.mk
> index 984043c..83c45b0 100644
> --- a/package/vala/vala.mk
> +++ b/package/vala/vala.mk
> @@ -9,9 +9,17 @@ VALA_VERSION_MINOR = 6
> VALA_VERSION = $(VALA_VERSION_MAJOR).$(VALA_VERSION_MINOR)
> VALA_SITE = http://download.gnome.org/sources/vala/$(VALA_VERSION_MAJOR)
> VALA_SOURCE = vala-$(VALA_VERSION).tar.xz
> +
> VALA_DEPENDENCIES = host-flex libglib2 \
> $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext libintl)
> +ifeq ($(BR2_HAVE_DOCUMENTATION),y)
> +VALA_DEPENDENCIES += host-libxslt
Don't you need ac_cv_path_XSLTPROC=: in the else case too?
Regards,
Arnout
> +endif
> +
> HOST_VALA_DEPENDENCIES = host-flex host-libglib2
> +# Yes, the autoconf script understands ':' as "xsltproc is not
> +# available".
> +HOST_VALA_CONF_ENV = ac_cv_path_XSLTPROC=:
>
> $(eval $(autotools-package))
> $(eval $(host-autotools-package))
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] vala: fix documentation build problem
2012-09-18 20:59 ` Arnout Vandecappelle
@ 2012-09-19 5:10 ` Thomas Petazzoni
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2012-09-19 5:10 UTC (permalink / raw)
To: buildroot
Dear Arnout Vandecappelle,
On Tue, 18 Sep 2012 22:59:47 +0200, Arnout Vandecappelle wrote:
> > +ifeq ($(BR2_HAVE_DOCUMENTATION),y)
> > +VALA_DEPENDENCIES += host-libxslt
>
> Don't you need ac_cv_path_XSLTPROC=: in the else case too?
Yes that's what PATCHv2 did.
Thanks for the review!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-19 5:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-17 20:33 [Buildroot] [PATCH] vala: fix documentation build problem Thomas Petazzoni
2012-09-18 20:59 ` Arnout Vandecappelle
2012-09-19 5:10 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox