* [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE
@ 2012-09-21 0:53 Arnout Vandecappelle
2012-09-21 0:53 ` [Buildroot] [PATCH 01/10] diffutils: only needs gettext if locale is selected Arnout Vandecappelle
` (9 more replies)
0 siblings, 10 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:53 UTC (permalink / raw)
To: buildroot
This series cleans up redundant dependencies on gettext, in packages that
select gettext when LOCALE is not enabled.
The first 7 patches really remove the gettext dependency. The last three
are in fact a NOP, because libglib2 selects gettext unconditionally.
I have kept the NEEDS_GETTEXT_IF_LOCALE dependency for these packages,
because they do have i18n code and do require libintl. But the
dependency adds nothing, because libglib2 does the same already.
Regards,
Arnout
PS sorry for my earlier unfinished cover letter: I though I could
still cancel its sending...
---
Arnout Vandecappelle (Essensium/Mind) (10):
diffutils: only needs gettext if locale is selected
flex: only needs gettext if locale is selected
ndisc6: only needs gettext if locale is selected
util-linux: only needs gettext if locale is selected
lshw: fix build with no LOCALE support
avahi: remove double dependency on gettext
pulseaudio: remove dependency on gettext
gdk-pixbuf: remove dependency on gettext
glib-networking: remove redundant dependency on gettext
libsoup: remove redundant dependency on gettext
package/avahi/avahi.mk | 5 +----
package/diffutils/Config.in | 1 +
package/diffutils/diffutils.mk | 3 +--
package/flex/Config.in | 1 +
package/flex/flex.mk | 3 +--
package/gdk-pixbuf/Config.in | 1 -
package/gdk-pixbuf/gdk-pixbuf.mk | 1 -
package/glib-networking/Config.in | 2 +-
package/libsoup/Config.in | 2 +-
package/lshw/Config.in | 2 +-
package/lshw/lshw.mk | 12 +++++++++---
package/multimedia/pulseaudio/Config.in | 2 +-
package/multimedia/pulseaudio/pulseaudio.mk | 2 +-
package/ndisc6/Config.in | 1 +
package/ndisc6/ndisc6.mk | 2 +-
package/util-linux/Config.in | 1 +
package/util-linux/util-linux.mk | 2 +-
17 files changed, 23 insertions(+), 20 deletions(-)
--
Signature
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 01/10] diffutils: only needs gettext if locale is selected
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
@ 2012-09-21 0:53 ` Arnout Vandecappelle
2012-09-21 0:53 ` [Buildroot] [PATCH 02/10] flex: " Arnout Vandecappelle
` (8 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:53 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Also add missing select in Config.in.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/diffutils/Config.in | 1 +
package/diffutils/diffutils.mk | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/diffutils/Config.in b/package/diffutils/Config.in
index 86da5d3..4cc16e2 100644
--- a/package/diffutils/Config.in
+++ b/package/diffutils/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_DIFFUTILS
bool"diffutils"
depends on BR2_USE_WCHAR
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
help
GNU diff. Compare files per line.
diff --git a/package/diffutils/diffutils.mk b/package/diffutils/diffutils.mk
index 168d040..2530763 100644
--- a/package/diffutils/diffutils.mk
+++ b/package/diffutils/diffutils.mk
@@ -6,8 +6,7 @@
DIFFUTILS_VERSION = 3.2
DIFFUTILS_SITE = $(BR2_GNU_MIRROR)/diffutils
-DIFFUTILS_DEPENDENCIES = \
- $(if $(BR2_PACKAGE_GETTEXT),gettext)
+DIFFUTILS_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
ifeq ($(BR2_PACKAGE_BUSYBOX),y)
DIFFUTILS_DEPENDENCIES += busybox
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 02/10] flex: only needs gettext if locale is selected
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
2012-09-21 0:53 ` [Buildroot] [PATCH 01/10] diffutils: only needs gettext if locale is selected Arnout Vandecappelle
@ 2012-09-21 0:53 ` Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 03/10] ndisc6: " Arnout Vandecappelle
` (7 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:53 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Also add missing select in Config.in.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/flex/Config.in | 1 +
package/flex/flex.mk | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/flex/Config.in b/package/flex/Config.in
index b10eb00..8ce4ccd 100644
--- a/package/flex/Config.in
+++ b/package/flex/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_FLEX
bool "flex"
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
help
A fast lexical analyser generator. A tool for generating
programs that perform pattern-matching on text.
diff --git a/package/flex/flex.mk b/package/flex/flex.mk
index 2599cdc..fe21432 100644
--- a/package/flex/flex.mk
+++ b/package/flex/flex.mk
@@ -11,8 +11,7 @@ FLEX_PATCH = flex_$(FLEX_VERSION)-$(FLEX_PATCH_VERSION).diff.gz
FLEX_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/f/flex
FLEX_DIR = $(BUILD_DIR)/flex-$(FLEX_VERSION)
FLEX_INSTALL_STAGING = YES
-FLEX_DEPENDENCIES = \
- $(if $(BR2_PACKAGE_GETTEXT),gettext)
+FLEX_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
# we don't have a host-gettext/libintl
HOST_FLEX_DEPENDENCIES =
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 03/10] ndisc6: only needs gettext if locale is selected
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
2012-09-21 0:53 ` [Buildroot] [PATCH 01/10] diffutils: only needs gettext if locale is selected Arnout Vandecappelle
2012-09-21 0:53 ` [Buildroot] [PATCH 02/10] flex: " Arnout Vandecappelle
@ 2012-09-21 0:54 ` Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 04/10] util-linux: " Arnout Vandecappelle
` (6 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:54 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Also add missing select in Config.in.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/ndisc6/Config.in | 1 +
package/ndisc6/ndisc6.mk | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/ndisc6/Config.in b/package/ndisc6/Config.in
index 126bfa2..6abe4ce 100644
--- a/package/ndisc6/Config.in
+++ b/package/ndisc6/Config.in
@@ -4,6 +4,7 @@ comment "ndisc6 requires a toolchain with IPv6 support"
config BR2_PACKAGE_NDISC6
bool "ndisc6 tools"
depends on BR2_INET_IPV6
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
help
NDisc6 is a small collection of useful tools for IPv6 networking
diff --git a/package/ndisc6/ndisc6.mk b/package/ndisc6/ndisc6.mk
index f58cc13..1d3c0e7 100644
--- a/package/ndisc6/ndisc6.mk
+++ b/package/ndisc6/ndisc6.mk
@@ -10,7 +10,7 @@ NDISC6_SITE = http://www.remlab.net/files/ndisc6/
NDISC6_CONF_ENV = CC="$(TARGET_CC) -std=gnu99"
NDISC6_CONF_OPT = --localstatedir=/var --disable-rpath --disable-suid-install
-ifeq ($(BR2_PACKAGE_GETTEXT),y)
+ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
NDISC6_DEPENDENCIES += gettext
NDISC6_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lintl"
endif
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 04/10] util-linux: only needs gettext if locale is selected
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
` (2 preceding siblings ...)
2012-09-21 0:54 ` [Buildroot] [PATCH 03/10] ndisc6: " Arnout Vandecappelle
@ 2012-09-21 0:54 ` Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 05/10] lshw: fix build with no LOCALE support Arnout Vandecappelle
` (5 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:54 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Also add missing select in Config.in.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/util-linux/Config.in | 1 +
package/util-linux/util-linux.mk | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
index 43a8444..88d08e7 100644
--- a/package/util-linux/Config.in
+++ b/package/util-linux/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_UTIL_LINUX
bool "util-linux"
depends on BR2_LARGEFILE
depends on BR2_USE_WCHAR
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
help
Various useful/essential Linux utilities.
diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
index 71a6c53..a6abbf5 100644
--- a/package/util-linux/util-linux.mk
+++ b/package/util-linux/util-linux.mk
@@ -29,7 +29,7 @@ else
UTIL_LINUX_CONF_OPT += --without-ncurses
endif
-ifeq ($(BR2_PACKAGE_GETTEXT),y)
+ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
UTIL_LINUX_DEPENDENCIES += gettext
UTIL_LINUX_MAKE_OPT += LIBS=-lintl
endif
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 05/10] lshw: fix build with no LOCALE support
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
` (3 preceding siblings ...)
2012-09-21 0:54 ` [Buildroot] [PATCH 04/10] util-linux: " Arnout Vandecappelle
@ 2012-09-21 0:54 ` Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 06/10] avahi: remove double dependency on gettext Arnout Vandecappelle
` (4 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:54 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
lshw doesn't need libintl if -DNONLS is defined.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/lshw/Config.in | 2 +-
package/lshw/lshw.mk | 12 +++++++++---
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/package/lshw/Config.in b/package/lshw/Config.in
index 98beacd..afefa6c 100644
--- a/package/lshw/Config.in
+++ b/package/lshw/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_LSHW
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_LARGEFILE
depends on BR2_USE_WCHAR
- select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
help
lshw (Hardware Lister) is a small tool to provide
detailed information on the hardware configuration of the machine.
diff --git a/package/lshw/lshw.mk b/package/lshw/lshw.mk
index 68daa0d..b3c2214 100644
--- a/package/lshw/lshw.mk
+++ b/package/lshw/lshw.mk
@@ -6,10 +6,16 @@
LSHW_VERSION = B.02.16
LSHW_SITE = http://ezix.org/software/files
+
+LSHW_CFLAGS = $(TARGET_CFLAGS)
+ifeq ($(BR2_ENABLE_LOCALE),)
+LSHW_CFLAGS += -DNONLS
+endif
+
LSHW_MAKE_OPT = CC="$(TARGET_CC)" CXX="$(TARGET_CXX)" AR="$(TARGET_AR)" \
- RPM_OPT_FLAGS="$(TARGET_CFLAGS)" all
-LSHW_MAKE_ENV = LIBS="$(if $(BR2_NEEDS_GETTEXT),-lintl)"
-LSHW_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT),gettext)
+ RPM_OPT_FLAGS="$(LSHW_CFLAGS)" all
+LSHW_MAKE_ENV = LIBS="$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)"
+LSHW_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
define LSHW_BUILD_CMDS
$(LSHW_MAKE_ENV) $(MAKE) -C $(@D)/src $(LSHW_MAKE_OPT)
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 06/10] avahi: remove double dependency on gettext
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
` (4 preceding siblings ...)
2012-09-21 0:54 ` [Buildroot] [PATCH 05/10] lshw: fix build with no LOCALE support Arnout Vandecappelle
@ 2012-09-21 0:54 ` Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 07/10] pulseaudio: remove " Arnout Vandecappelle
` (3 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:54 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/avahi/avahi.mk | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk
index 03dc368..6a6f524 100644
--- a/package/avahi/avahi.mk
+++ b/package/avahi/avahi.mk
@@ -133,10 +133,7 @@ else
AVAHI_CONF_OPT += --disable-python
endif
-ifeq ($(BR2_PACKAGE_GETTEXT),y)
-AVAHI_DEPENDENCIES += gettext
-AVAHI_MAKE_OPT = LIBS=-lintl
-endif
+AVAHI_MAKE_OPT += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),LIBS=-lintl)
define AVAHI_REMOVE_INITSCRIPT
rm -rf $(TARGET_DIR)/etc/init.d/avahi-*
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 07/10] pulseaudio: remove dependency on gettext
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
` (5 preceding siblings ...)
2012-09-21 0:54 ` [Buildroot] [PATCH 06/10] avahi: remove double dependency on gettext Arnout Vandecappelle
@ 2012-09-21 0:54 ` Arnout Vandecappelle
2012-09-21 7:30 ` Thomas Petazzoni
2012-09-21 0:54 ` [Buildroot] [PATCH 08/10] gdk-pixbuf: " Arnout Vandecappelle
` (2 subsequent siblings)
9 siblings, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:54 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
The dependency on gettext is only due to libglib2, not due to
portaudio itself. It works fine without gettext if libglib2 is
not selected.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/multimedia/pulseaudio/Config.in | 2 +-
package/multimedia/pulseaudio/pulseaudio.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/multimedia/pulseaudio/Config.in b/package/multimedia/pulseaudio/Config.in
index 6c767bb..4845ffa 100644
--- a/package/multimedia/pulseaudio/Config.in
+++ b/package/multimedia/pulseaudio/Config.in
@@ -5,7 +5,7 @@ config BR2_PACKAGE_PULSEAUDIO
select BR2_PACKAGE_JSON_C
select BR2_PACKAGE_LIBSNDFILE
select BR2_PACKAGE_SPEEX
- select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
help
PulseAudio is a sound system for POSIX OSes, meaning that it
is a proxy for your sound applications. It allows you to do
diff --git a/package/multimedia/pulseaudio/pulseaudio.mk b/package/multimedia/pulseaudio/pulseaudio.mk
index 406dd8f..8015070 100644
--- a/package/multimedia/pulseaudio/pulseaudio.mk
+++ b/package/multimedia/pulseaudio/pulseaudio.mk
@@ -16,7 +16,7 @@ PULSEAUDIO_CONF_OPT = \
PULSEAUDIO_DEPENDENCIES = \
host-pkg-config libtool json-c libsndfile speex host-intltool \
- $(if $(BR2_NEEDS_GETTEXT),gettext) \
+ $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) \
$(if $(BR2_PACKAGE_LIBATOMIC_OPS),libatomic_ops) \
$(if $(BR2_PACKAGE_LIBSAMPLERATE),libsamplerate) \
$(if $(BR2_PACKAGE_ALSA_LIB),alsa-lib) \
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 08/10] gdk-pixbuf: remove dependency on gettext
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
` (6 preceding siblings ...)
2012-09-21 0:54 ` [Buildroot] [PATCH 07/10] pulseaudio: remove " Arnout Vandecappelle
@ 2012-09-21 0:54 ` Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 09/10] glib-networking: remove redundant " Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 10/10] libsoup: " Arnout Vandecappelle
9 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:54 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
The dependency on gettext comes from libglib2, not from gdk-pixbuf
itself.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/gdk-pixbuf/Config.in | 1 -
package/gdk-pixbuf/gdk-pixbuf.mk | 1 -
2 files changed, 2 deletions(-)
diff --git a/package/gdk-pixbuf/Config.in b/package/gdk-pixbuf/Config.in
index 33b5f7c..f205793 100644
--- a/package/gdk-pixbuf/Config.in
+++ b/package/gdk-pixbuf/Config.in
@@ -2,7 +2,6 @@ config BR2_PACKAGE_GDK_PIXBUF
bool "gdk-pixbuf"
depends on BR2_USE_WCHAR # glib2
select BR2_PACKAGE_LIBGLIB2
- select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
help
Gdk-Pixbuf is an image loader and scaler. It uses GObject
diff --git a/package/gdk-pixbuf/gdk-pixbuf.mk b/package/gdk-pixbuf/gdk-pixbuf.mk
index 92a34bf..7e1dc37 100644
--- a/package/gdk-pixbuf/gdk-pixbuf.mk
+++ b/package/gdk-pixbuf/gdk-pixbuf.mk
@@ -40,7 +40,6 @@ GDK_PIXBUF_DEPENDENCIES += xlib_libX11
endif
GDK_PIXBUF_DEPENDENCIES += \
- $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) \
$(if $(BR2_ENABLE_LOCALE),,libiconv) \
host-pkg-config libglib2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 09/10] glib-networking: remove redundant dependency on gettext
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
` (7 preceding siblings ...)
2012-09-21 0:54 ` [Buildroot] [PATCH 08/10] gdk-pixbuf: " Arnout Vandecappelle
@ 2012-09-21 0:54 ` Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 10/10] libsoup: " Arnout Vandecappelle
9 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:54 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/glib-networking/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/glib-networking/Config.in b/package/glib-networking/Config.in
index dab35ea..f1aa7ee 100644
--- a/package/glib-networking/Config.in
+++ b/package/glib-networking/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_GLIB_NETWORKING
bool "glib-networking"
depends on BR2_USE_WCHAR # glib2
select BR2_PACKAGE_LIBGLIB2
- select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
help
Network-related GIO modules for glib.
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 10/10] libsoup: remove redundant dependency on gettext
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
` (8 preceding siblings ...)
2012-09-21 0:54 ` [Buildroot] [PATCH 09/10] glib-networking: remove redundant " Arnout Vandecappelle
@ 2012-09-21 0:54 ` Arnout Vandecappelle
9 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-09-21 0:54 UTC (permalink / raw)
To: buildroot
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/libsoup/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libsoup/Config.in b/package/libsoup/Config.in
index 57b425f..219f822 100644
--- a/package/libsoup/Config.in
+++ b/package/libsoup/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_LIBSOUP
depends on BR2_USE_WCHAR # glib2 and gnutls
select BR2_PACKAGE_LIBXML2
select BR2_PACKAGE_LIBGLIB2
- select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
help
libsoup is an HTTP client/server library. It uses GObject
and the GLib main loop, to integrate well with GNOME
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 07/10] pulseaudio: remove dependency on gettext
2012-09-21 0:54 ` [Buildroot] [PATCH 07/10] pulseaudio: remove " Arnout Vandecappelle
@ 2012-09-21 7:30 ` Thomas Petazzoni
0 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2012-09-21 7:30 UTC (permalink / raw)
To: buildroot
Dear Arnout Vandecappelle \(Essensium/Mind\),
On Fri, 21 Sep 2012 02:54:22 +0200, Arnout Vandecappelle
\(Essensium/Mind\) wrote:
> From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> The dependency on gettext is only due to libglib2, not due to
> portaudio itself. It works fine without gettext if libglib2 is
> not selected.
This description doesn't match what the patch is doing. The description
says that you remove the gettext dependency, but the patch only changes
the dependency to a _IF_LOCALE dependency.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 06/10] avahi: remove double dependency on gettext
2012-10-14 21:09 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
@ 2012-10-14 21:10 ` Arnout Vandecappelle
2012-10-14 21:27 ` Yann E. MORIN
0 siblings, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-10-14 21:10 UTC (permalink / raw)
To: buildroot
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/avahi/avahi.mk | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk
index 03dc368..6a6f524 100644
--- a/package/avahi/avahi.mk
+++ b/package/avahi/avahi.mk
@@ -133,10 +133,7 @@ else
AVAHI_CONF_OPT += --disable-python
endif
-ifeq ($(BR2_PACKAGE_GETTEXT),y)
-AVAHI_DEPENDENCIES += gettext
-AVAHI_MAKE_OPT = LIBS=-lintl
-endif
+AVAHI_MAKE_OPT += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),LIBS=-lintl)
define AVAHI_REMOVE_INITSCRIPT
rm -rf $(TARGET_DIR)/etc/init.d/avahi-*
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 06/10] avahi: remove double dependency on gettext
2012-10-14 21:10 ` [Buildroot] [PATCH 06/10] avahi: remove double dependency on gettext Arnout Vandecappelle
@ 2012-10-14 21:27 ` Yann E. MORIN
0 siblings, 0 replies; 14+ messages in thread
From: Yann E. MORIN @ 2012-10-14 21:27 UTC (permalink / raw)
To: buildroot
Atnout, All,
On Sunday 14 October 2012 Arnout Vandecappelle (Essensium/Mind) wrote:
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/avahi/avahi.mk | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk
> index 03dc368..6a6f524 100644
> --- a/package/avahi/avahi.mk
> +++ b/package/avahi/avahi.mk
> @@ -133,10 +133,7 @@ else
> AVAHI_CONF_OPT += --disable-python
> endif
>
> -ifeq ($(BR2_PACKAGE_GETTEXT),y)
> -AVAHI_DEPENDENCIES += gettext
> -AVAHI_MAKE_OPT = LIBS=-lintl
> -endif
> +AVAHI_MAKE_OPT += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),LIBS=-lintl)
>
> define AVAHI_REMOVE_INITSCRIPT
> rm -rf $(TARGET_DIR)/etc/init.d/avahi-*
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2012-10-14 21:27 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-21 0:53 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
2012-09-21 0:53 ` [Buildroot] [PATCH 01/10] diffutils: only needs gettext if locale is selected Arnout Vandecappelle
2012-09-21 0:53 ` [Buildroot] [PATCH 02/10] flex: " Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 03/10] ndisc6: " Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 04/10] util-linux: " Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 05/10] lshw: fix build with no LOCALE support Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 06/10] avahi: remove double dependency on gettext Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 07/10] pulseaudio: remove " Arnout Vandecappelle
2012-09-21 7:30 ` Thomas Petazzoni
2012-09-21 0:54 ` [Buildroot] [PATCH 08/10] gdk-pixbuf: " Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 09/10] glib-networking: remove redundant " Arnout Vandecappelle
2012-09-21 0:54 ` [Buildroot] [PATCH 10/10] libsoup: " Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2012-10-14 21:09 [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE Arnout Vandecappelle
2012-10-14 21:10 ` [Buildroot] [PATCH 06/10] avahi: remove double dependency on gettext Arnout Vandecappelle
2012-10-14 21:27 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox