* [Buildroot] [PATCH 1/1] toolchain/uClibc: correct a slip of the pen
@ 2012-10-24 10:54 liaoxinglong at icubecorp.com
2012-10-24 12:47 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: liaoxinglong at icubecorp.com @ 2012-10-24 10:54 UTC (permalink / raw)
To: buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] toolchain/uClibc: correct a slip of the pen
2012-10-24 10:54 [Buildroot] [PATCH 1/1] toolchain/uClibc: correct a slip of the pen liaoxinglong at icubecorp.com
@ 2012-10-24 12:47 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2012-10-24 12:47 UTC (permalink / raw)
To: buildroot
Hello,
Your patch is OK on the idea, but it isn't properly formatted. If you
generate your patch with git format-patch, then could you use git
send-email to send it?
On Wed, 24 Oct 2012 18:54:39 +0800, liaoxinglong at icubecorp.com wrote:
> From 3c5a0047108cb10d8e5e3605f002e12d02c53102 Mon Sep 17 00:00:00 2001
> From: Xinglong Liao <liaoxinglong@icubecorp.com>
> Date: Wed, 24 Oct 2012 18:42:05 +0800
> Subject: [PATCH] toolchain/uClibc: correct a slip of the pen
The spaces between [PATCH] and toolchain/uClibc shouldn't be there
>
> UCLIB_EXTRA_CFLAGS->UCLIBC_EXTRA_CFLAGS
>
> Signed-off-by: Xinglong Liao <liaoxinglong@icubecorp.com>
Those lines shouldn't be indented.
Once this is fixed, your patch gets my:
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] toolchain/uClibc: correct a slip of the pen
@ 2012-10-25 8:30 Xinglong Liao
2012-10-25 9:01 ` Thomas Petazzoni
2012-10-26 11:24 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: Xinglong Liao @ 2012-10-25 8:30 UTC (permalink / raw)
To: buildroot
UCLIB_EXTRA_CFLAGS -> UCLIBC_EXTRA_CFLAGS
Signed-off-by: Xinglong Liao <xinglong.liao@gmail.com>
---
toolchain/uClibc/uclibc.mk | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/toolchain/uClibc/uclibc.mk b/toolchain/uClibc/uclibc.mk
index d1cd718..397cdd4 100644
--- a/toolchain/uClibc/uclibc.mk
+++ b/toolchain/uClibc/uclibc.mk
@@ -379,7 +379,7 @@ $(UCLIBC_DIR)/.config: $(UCLIBC_DIR)/.oldconfig
DEVEL_PREFIX=/usr/ \
RUNTIME_PREFIX=$(TOOLCHAIN_DIR)/uClibc_dev/ \
CROSS_COMPILE="$(TARGET_CROSS)" \
- UCLIB_EXTRA_CFLAGS="$(TARGET_ABI)" \
+ UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \
HOSTCC="$(HOSTCC)" \
oldconfig
touch $@
@@ -398,7 +398,7 @@ $(UCLIBC_DIR)/.configured: $(LINUX_HEADERS_DIR)/.configured $(UCLIBC_DIR)/.confi
DEVEL_PREFIX=/usr/ \
RUNTIME_PREFIX=$(TOOLCHAIN_DIR)/uClibc_dev/ \
CROSS_COMPILE="$(TARGET_CROSS)" \
- UCLIB_EXTRA_CFLAGS="$(TARGET_ABI)" \
+ UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \
HOSTCC="$(HOSTCC)" headers \
lib/crt1.o lib/crti.o lib/crtn.o \
install_headers
@@ -420,7 +420,7 @@ $(UCLIBC_DIR)/lib/libc.a: $(UCLIBC_DIR)/.configured $(gcc_intermediate) $(LIBFLO
DEVEL_PREFIX=/ \
RUNTIME_PREFIX=/ \
CROSS_COMPILE="$(TARGET_CROSS)" \
- UCLIB_EXTRA_CFLAGS="$(TARGET_ABI)" \
+ UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \
HOSTCC="$(HOSTCC)" \
all
touch -c $@
@@ -432,7 +432,7 @@ uclibc-menuconfig: dirs $(UCLIBC_DIR)/.config
DEVEL_PREFIX=/usr/ \
RUNTIME_PREFIX=$(TOOLCHAIN_DIR)/uClibc_dev/ \
CROSS_COMPILE="$(TARGET_CROSS)" \
- UCLIB_EXTRA_CFLAGS="$(TARGET_ABI)" \
+ UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \
HOSTCC="$(HOSTCC)" \
menuconfig && \
touch -c $(UCLIBC_DIR)/.config
@@ -445,7 +445,7 @@ $(STAGING_DIR)/usr/lib/libc.a: $(UCLIBC_DIR)/lib/libc.a
DEVEL_PREFIX=/usr/ \
RUNTIME_PREFIX=/ \
CROSS_COMPILE="$(TARGET_CROSS)" \
- UCLIB_EXTRA_CFLAGS="$(TARGET_ABI)" \
+ UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \
install_runtime install_dev
# Install the kernel headers to the staging dir if necessary
if [ ! -f $(STAGING_DIR)/usr/include/linux/version.h ]; then \
@@ -475,7 +475,7 @@ $(TARGET_DIR)/lib/libc.so.0: $(STAGING_DIR)/usr/lib/libc.a
DEVEL_PREFIX=/usr/ \
RUNTIME_PREFIX=/ \
CROSS_COMPILE="$(TARGET_CROSS)" \
- UCLIB_EXTRA_CFLAGS="$(TARGET_ABI)" \
+ UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \
install_runtime
touch -c $@
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] toolchain/uClibc: correct a slip of the pen
2012-10-25 8:30 Xinglong Liao
@ 2012-10-25 9:01 ` Thomas Petazzoni
2012-10-26 11:24 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2012-10-25 9:01 UTC (permalink / raw)
To: buildroot
Dear Xinglong Liao,
On Thu, 25 Oct 2012 16:30:43 +0800, Xinglong Liao wrote:
> UCLIB_EXTRA_CFLAGS -> UCLIBC_EXTRA_CFLAGS
>
> Signed-off-by: Xinglong Liao <xinglong.liao@gmail.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] toolchain/uClibc: correct a slip of the pen
2012-10-25 8:30 Xinglong Liao
2012-10-25 9:01 ` Thomas Petazzoni
@ 2012-10-26 11:24 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2012-10-26 11:24 UTC (permalink / raw)
To: buildroot
>>>>> "Xinglong" == Xinglong Liao <xinglong.liao@gmail.com> writes:
Xinglong> UCLIB_EXTRA_CFLAGS -> UCLIBC_EXTRA_CFLAGS
Xinglong> Signed-off-by: Xinglong Liao <xinglong.liao@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-26 11:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-24 10:54 [Buildroot] [PATCH 1/1] toolchain/uClibc: correct a slip of the pen liaoxinglong at icubecorp.com
2012-10-24 12:47 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2012-10-25 8:30 Xinglong Liao
2012-10-25 9:01 ` Thomas Petazzoni
2012-10-26 11:24 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox