[Buildroot] [git commit] lcdproc: fix autobuilder failures

[Buildroot] [git commit] lcdproc: fix autobuilder failures

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=ffdb08d2219d2613f3aa9b20c30b20090948dded
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The lcdproc version bump to 0.5.6 has resulted in autobuilder failures such as
the following.

  http://autobuild.buildroot.org/results/9967bc20a6094e836c4c18ff2cd30edef143bb8e/build-end.log

The 0.5.6 release added a new glcd driver, which requires the freetype and zlib
libraries. This patch makes the lcdproc package depend on freetype and zlib.

Signed-off-by: Simon Dawson <spdawson@gmail.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 package/lcdproc/Config.in  |    2 ++
 package/lcdproc/lcdproc.mk |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/package/lcdproc/Config.in b/package/lcdproc/Config.in
index 820f4ea..e0afc44 100644
--- a/package/lcdproc/Config.in
+++ b/package/lcdproc/Config.in
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_LCDPROC
        bool "lcdproc"
+       select BR2_PACKAGE_FREETYPE
        select BR2_PACKAGE_NCURSES
+       select BR2_PACKAGE_ZLIB
        help
          LCD display driver daemon and clients
 
diff --git a/package/lcdproc/lcdproc.mk b/package/lcdproc/lcdproc.mk
index aa204f1..2a80289 100644
--- a/package/lcdproc/lcdproc.mk
+++ b/package/lcdproc/lcdproc.mk
@@ -16,6 +16,6 @@ ifeq ($(BR2_PACKAGE_LCDPROC_MENUS),y)
 LCDPROC_CONF_OPT += --enable-lcdproc-menus
 endif
 
-LCDPROC_DEPENDENCIES = ncurses
+LCDPROC_DEPENDENCIES = freetype ncurses zlib
 
 $(eval $(autotools-package))

[Buildroot] [git commit] lcdproc: fix autobuilder failures

[Thomas Petazzoni]

On Fri, 16 Nov 2012 00:06:10 +0100, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=ffdb08d2219d2613f3aa9b20c30b20090948dded
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> The lcdproc version bump to 0.5.6 has resulted in autobuilder failures such as
> the following.
> 
>   http://autobuild.buildroot.org/results/9967bc20a6094e836c4c18ff2cd30edef143bb8e/build-end.log
> 
> The 0.5.6 release added a new glcd driver, which requires the freetype and zlib
> libraries. This patch makes the lcdproc package depend on freetype and zlib.
> 
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
>  package/lcdproc/Config.in  |    2 ++
>  package/lcdproc/lcdproc.mk |    2 +-
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/package/lcdproc/Config.in b/package/lcdproc/Config.in
> index 820f4ea..e0afc44 100644
> --- a/package/lcdproc/Config.in
> +++ b/package/lcdproc/Config.in
> @@ -1,6 +1,8 @@
>  config BR2_PACKAGE_LCDPROC
>         bool "lcdproc"
> +       select BR2_PACKAGE_FREETYPE
>         select BR2_PACKAGE_NCURSES
> +       select BR2_PACKAGE_ZLIB
>         help
>           LCD display driver daemon and clients
>  
> diff --git a/package/lcdproc/lcdproc.mk b/package/lcdproc/lcdproc.mk
> index aa204f1..2a80289 100644
> --- a/package/lcdproc/lcdproc.mk
> +++ b/package/lcdproc/lcdproc.mk
> @@ -16,6 +16,6 @@ ifeq ($(BR2_PACKAGE_LCDPROC_MENUS),y)
>  LCDPROC_CONF_OPT += --enable-lcdproc-menus
>  endif
>  
> -LCDPROC_DEPENDENCIES = ncurses
> +LCDPROC_DEPENDENCIES = freetype ncurses zlib

Looking at the build failure (which got triggered again today), I am a
bit suspicious about this fix. The build failure is:

/scratch/peko/host/usr/bin/ccache /scratch/peko/host/usr/bin/arm-buildroot-linux-uclibcgnueabi-gcc -I/scratch/peko/host/usr/include/freetype2 -I/scratch/peko/host/usr/include   -fPIC -Wall -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -pipe -Os  -Wno-unused-function -shared  -o glcd.so glcd-glcd_drv.o glcd-glcd-render.o libLCD.a  glcd-t6963.o t6963_low.o -L/scratch/peko/host/usr/lib -lfreetype -lz -lbz2    -ldl 
/scratch/peko/host/usr/lib/libfreetype.so: file not recognized: File format not recognized

The problem here is not a missing dependency on freetype, but rather
the fact that we have -I and -L options pointing to host headers and
libraries, while we are building something on the target. So maybe
adding freetype and zlib as dependencies work around the problem, but I
suspect that those wrong -I and -L lines might still be there, no?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] lcdproc: fix autobuilder failures

[Simon Dawson]

On 15 November 2012 23:44, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Looking at the build failure (which got triggered again today), I am a
> bit suspicious about this fix. The build failure is:
>
> /scratch/peko/host/usr/bin/ccache /scratch/peko/host/usr/bin/arm-buildroot-linux-uclibcgnueabi-gcc -I/scratch/peko/host/usr/include/freetype2 -I/scratch/peko/host/usr/include   -fPIC -Wall -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -pipe -Os  -Wno-unused-function -shared  -o glcd.so glcd-glcd_drv.o glcd-glcd-render.o libLCD.a  glcd-t6963.o t6963_low.o -L/scratch/peko/host/usr/lib -lfreetype -lz -lbz2    -ldl
> /scratch/peko/host/usr/lib/libfreetype.so: file not recognized: File format not recognized
>
> The problem here is not a missing dependency on freetype, but rather
> the fact that we have -I and -L options pointing to host headers and
> libraries, while we are building something on the target. So maybe
> adding freetype and zlib as dependencies work around the problem, but I
> suspect that those wrong -I and -L lines might still be there, no?

Hi Thomas.

If lcdproc finds freetype in the staging area, then the host header
and library search paths do not get added to the build commands. So I
think this patch does more than simply work around the problem.

Simon.

[Buildroot] [git commit] lcdproc: fix autobuilder failures

[Thomas Petazzoni]

On Fri, 16 Nov 2012 09:07:55 +0000, Simon Dawson wrote:

> If lcdproc finds freetype in the staging area, then the host header
> and library search paths do not get added to the build commands. So I
> think this patch does more than simply work around the problem.

Ok, thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] lcdproc: fix autobuilder failures

[Markos Chandras]

On Fri, Nov 16, 2012 at 10:33 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
>
> On Fri, 16 Nov 2012 09:07:55 +0000, Simon Dawson wrote:
>
>> If lcdproc finds freetype in the staging area, then the host header
>> and library search paths do not get added to the build commands. So I
>> think this patch does more than simply work around the problem.
>
> Ok, thanks!
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Hi,

I don't think is fixed. I am still getting this problem in master
branch and the autobuilder reports similar problems too.

http://autobuild.buildroot.net/results/d7f51f07096a68ed5d513466ab3c1719a696cb19/build-end.log

-- 
Regards,
Markos

[Buildroot] [git commit] lcdproc: fix autobuilder failures

[Thomas Petazzoni]

Dear Markos Chandras,

On Wed, 21 Nov 2012 09:23:11 +0000, Markos Chandras wrote:

> I don't think is fixed. I am still getting this problem in master
> branch and the autobuilder reports similar problems too.
> 
> http://autobuild.buildroot.net/results/d7f51f07096a68ed5d513466ab3c1719a696cb19/build-end.log

Indeed there is still a problem.

Simon, do you have the time to look into this?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [git commit] lcdproc: fix autobuilder failures

[Simon Dawson]

Hi Markus, Thomas.

On 21 November 2012 09:33, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Markos Chandras,
>
> On Wed, 21 Nov 2012 09:23:11 +0000, Markos Chandras wrote:
>
>> I don't think is fixed. I am still getting this problem in master
>> branch and the autobuilder reports similar problems too.
>>
>> http://autobuild.buildroot.net/results/d7f51f07096a68ed5d513466ab3c1719a696cb19/build-end.log
>
> Indeed there is still a problem.
>
> Simon, do you have the time to look into this?

Unfortunately, I'm probably not going to get a chance to look at this
for a week or so. It's building correctly for me --- indeed, I don't
even see the problematic host include/library paths in the compiler
commands --- but clearly there is something wrong. I'll investigate as
soon as I can.

Simon.