[Buildroot] Bug report in pkg-autotools.mk

[Buildroot] Bug report in pkg-autotools.mk

[Yvan Roch]

Hi all,

In the pkg-autotools.mk file, line 238 (BR2012.11) or
Makefile.autotools.in line 250 (BR2012.02), there is the following
command:

$$(SED) "s:\(['= ]\)/usr:\\1$(STAGING_DIR)/usr:g" $$$$i; \

This command corrects the bad path for libraries installed in the
staging directory in the libtool .la files.

But, if Buildroot resides in a directory that contains /usr (for
example /usr/local/src/buildroot-2012.11), $(STAGING_DIR) contains
/usr and this command is not idempotent.
Each time an autotools package is built, the paths in .la files are
longer and false.

Regards,

Yvan Roch.

[Buildroot] Bug report in pkg-autotools.mk

[Thomas Petazzoni]

Dear Yvan Roch,

On Wed, 19 Dec 2012 12:32:43 +0100, Yvan Roch wrote:

> In the pkg-autotools.mk file, line 238 (BR2012.11) or
> Makefile.autotools.in line 250 (BR2012.02), there is the following
> command:
> 
> $$(SED) "s:\(['= ]\)/usr:\\1$(STAGING_DIR)/usr:g" $$$$i; \
> 
> This command corrects the bad path for libraries installed in the
> staging directory in the libtool .la files.
> 
> But, if Buildroot resides in a directory that contains /usr (for
> example /usr/local/src/buildroot-2012.11), $(STAGING_DIR) contains
> /usr and this command is not idempotent.
> Each time an autotools package is built, the paths in .la files are
> longer and false.

Indeed. I have a patch fixing that:

-               $$(SED) "s:\(['= ]\)/usr:\\1$(STAGING_DIR)/usr:g" $$$$i; \
+               $$(SED) "\:['= ]$(STAGING_DIR)/usr:!s:\(['= ]\)/usr:\\1$(STAGING_DIR)/usr:g" $$$$i; \

However, using a Buildroot in /usr is still broken after that, due to
libglib2 having .la files with incorrect paths (paths pointing to the
build directory). I haven't managed to fix those, so I didn't yet send
the patch to fix the more general .la files problem.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] Bug report in pkg-autotools.mk

[Yvan Roch]

Hi Thomas,

Many thanks for your quick answer.
I will not use a /usr* path until you publish your general patch for .la files.

There are several other .la files with paths pointing to the build directory.
For example: libdirect.la, libfusion.la, libuuid.la, libblkid.la, libpcre.la
But it's not exhaustive, it's in my own build...

Regards,

Yvan.