From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/8] package/Makefile.in: update/fix HOST_PATH variable
Date: Sun, 30 Dec 2012 23:11:15 +0100 [thread overview]
Message-ID: <20121230231115.7fefabb7@skate> (raw)
In-Reply-To: <0a056ec61043dcada1eab6ab7e7ec4de25743bfd.1356903063.git.s.martin49@gmail.com>
Dear Samuel Martin,
On Sun, 30 Dec 2012 22:33:27 +0100, Samuel Martin wrote:
> ---
> package/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index cc8f320..dd04e25 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -165,7 +165,7 @@ HOST_CFLAGS ?= -O2
> HOST_CFLAGS += $(HOST_CPPFLAGS)
> HOST_CXXFLAGS += $(HOST_CFLAGS)
> HOST_LDFLAGS += -L$(HOST_DIR)/lib -L$(HOST_DIR)/usr/lib -Wl,-rpath,$(HOST_DIR)/usr/lib
> -HOST_PATH=$(HOST_DIR)/bin:$(HOST_DIR)/usr/bin:$(PATH)
> +HOST_PATH="$(HOST_DIR)/bin:$(HOST_DIR)/usr/bin:$(HOST_DIR)/usr/sbin/:$(PATH)"
Why?
For such core changes, a commit message of "update/fix something" is
definitely not enough. A detailed explanation is needed.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-12-30 22:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-30 21:33 [Buildroot] [pull request] Pull request for branch for-master/misc-fixes Samuel Martin
2012-12-30 21:33 ` [Buildroot] [PATCH 1/8] matchbox-lib: fix license info Samuel Martin
2012-12-30 22:09 ` Thomas Petazzoni
2012-12-30 21:33 ` [Buildroot] [PATCH 2/8] fluxbox: fix build against imlib2 Samuel Martin
2012-12-30 21:33 ` [Buildroot] [PATCH 3/8] package/Makefile.in: update/fix HOST_PATH variable Samuel Martin
2012-12-30 22:11 ` Thomas Petazzoni [this message]
2012-12-30 22:41 ` Samuel Martin
2012-12-30 21:33 ` [Buildroot] [PATCH 4/8] package/pkg-cmake.mk: make sure $(HOST_PATH) is in the PATH at configure time Samuel Martin
2012-12-30 22:14 ` Thomas Petazzoni
2012-12-30 22:42 ` Samuel Martin
2012-12-30 21:33 ` [Buildroot] [PATCH 5/8] dependencies: build a host python2 if no suitable one can be found Samuel Martin
2012-12-30 21:33 ` [Buildroot] [PATCH 6/8] scons: add host-python2-if-needed dependency Samuel Martin
2012-12-30 21:33 ` [Buildroot] [PATCH 7/8] scons: ensure $(HOST_DIR)/usr/bin is in the PATH when invoking $(SCONS) Samuel Martin
2012-12-30 21:33 ` [Buildroot] [PATCH 8/8] manual: add host python2 dependency section Samuel Martin
2012-12-30 22:46 ` [Buildroot] [pull request] Pull request for branch for-master/misc-fixes Samuel Martin
-- strict thread matches above, loose matches on Subject: below --
2012-12-30 22:54 Samuel Martin
2012-12-30 22:54 ` [Buildroot] [PATCH 3/8] package/Makefile.in: update/fix HOST_PATH variable Samuel Martin
2013-02-07 7:07 ` Arnout Vandecappelle
2013-02-07 8:27 ` Thomas Petazzoni
2013-02-07 16:48 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121230231115.7fefabb7@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox