Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/8] package/Makefile.in: update/fix HOST_PATH variable
Date: Thu, 7 Feb 2013 09:27:51 +0100	[thread overview]
Message-ID: <20130207092751.61fd256a@skate> (raw)
In-Reply-To: <d29120e810fb080ac4304d6e51b01ec2efda168f.1356907750.git.s.martin49@gmail.com>

Dear Samuel Martin,

On Sun, 30 Dec 2012 23:54:10 +0100, Samuel Martin wrote:
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
>  package/Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/Makefile.in b/package/Makefile.in
> index cc8f320..dd04e25 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -165,7 +165,7 @@ HOST_CFLAGS   ?= -O2
>  HOST_CFLAGS   += $(HOST_CPPFLAGS)
>  HOST_CXXFLAGS += $(HOST_CFLAGS)
>  HOST_LDFLAGS  += -L$(HOST_DIR)/lib -L$(HOST_DIR)/usr/lib
> -Wl,-rpath,$(HOST_DIR)/usr/lib
> -HOST_PATH=$(HOST_DIR)/bin:$(HOST_DIR)/usr/bin:$(PATH)
> +HOST_PATH="$(HOST_DIR)/bin:$(HOST_DIR)/usr/bin:$(HOST_DIR)/usr/sbin/:$(PATH)" 
>  # hostcc version as an integer - E.G. 4.3.2 => 432
>  HOSTCC_VERSION:=$(shell $(HOSTCC_NOCCACHE) --version | \

I am ok with the patch, and also your 4/8, but I really believe you
should be more verbose in the commit log. Here the only information is
"update/fix HOST_PATH variable". But why? What is the reason? What are
the impacts? It is especially true when we look at those patches with a
little bit of delay as is the case now.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2013-02-07  8:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-30 22:54 [Buildroot] [pull request] Pull request for branch for-master/misc-fixes Samuel Martin
2012-12-30 22:54 ` [Buildroot] [PATCH 1/8] matchbox-lib: fix license info Samuel Martin
2012-12-30 22:54 ` [Buildroot] [PATCH 2/8] fluxbox: fix build against imlib2 Samuel Martin
2013-01-03 20:38   ` Peter Korsgaard
2012-12-30 22:54 ` [Buildroot] [PATCH 3/8] package/Makefile.in: update/fix HOST_PATH variable Samuel Martin
2013-02-07  7:07   ` Arnout Vandecappelle
2013-02-07  8:27   ` Thomas Petazzoni [this message]
2013-02-07 16:48     ` Samuel Martin
2012-12-30 22:54 ` [Buildroot] [PATCH 4/8] package/pkg-cmake.mk: make sure $(HOST_PATH) is in the PATH at configure time Samuel Martin
2013-02-07  7:08   ` Arnout Vandecappelle
2012-12-30 22:54 ` [Buildroot] [PATCH 5/8] dependencies: build a host python2 if no suitable one can be found Samuel Martin
2012-12-30 22:54 ` [Buildroot] [PATCH 6/8] scons: add host-python2-if-needed dependency Samuel Martin
2012-12-30 22:54 ` [Buildroot] [PATCH 7/8] scons: ensure $(HOST_DIR)/usr/bin is in the PATH when invoking $(SCONS) Samuel Martin
2012-12-30 22:54 ` [Buildroot] [PATCH 8/8] manual: add host python2 dependency section Samuel Martin
  -- strict thread matches above, loose matches on Subject: below --
2012-12-30 21:33 [Buildroot] [pull request] Pull request for branch for-master/misc-fixes Samuel Martin
2012-12-30 21:33 ` [Buildroot] [PATCH 3/8] package/Makefile.in: update/fix HOST_PATH variable Samuel Martin
2012-12-30 22:11   ` Thomas Petazzoni
2012-12-30 22:41     ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130207092751.61fd256a@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox