Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-05 14:10 [Buildroot] [pull request] Pull request for branch rpi-support Maxime Hadjinlian
@ 2013-01-05 14:10 ` Maxime Hadjinlian
  0 siblings, 0 replies; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-05 14:10 UTC (permalink / raw)
  To: buildroot

replacement for memcpy and memset functionality
This package was originally found at : https://github.com/huceke/buildroot-rbp
By gimli <ebsi4711@gmail.com>

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/Config.in          |    1 +
 package/libcofi/Config.in  |    8 ++++++++
 package/libcofi/libcofi.mk |   17 +++++++++++++++++
 3 files changed, 26 insertions(+)
 create mode 100644 package/libcofi/Config.in
 create mode 100644 package/libcofi/libcofi.mk

diff --git a/package/Config.in b/package/Config.in
index 11ff82d..a3530d7 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -511,6 +511,7 @@ endmenu
 menu "Other"
 source "package/apr/Config.in"
 source "package/apr-util/Config.in"
+source "package/libcofi/Config.in"
 source "package/classpath/Config.in"
 source "package/fftw/Config.in"
 source "package/libargtable2/Config.in"
diff --git a/package/libcofi/Config.in b/package/libcofi/Config.in
new file mode 100644
index 0000000..b900b69
--- /dev/null
+++ b/package/libcofi/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBCOFI
+	bool "libcofi"
+	depends on BR2_arm
+	help
+	  A replacement for memcpy and memset functionality for the Raspberry Pi
+	  with the intention of gaining greater performance.
+
+	  https://github.com/simonjhall/copies-and-fills
diff --git a/package/libcofi/libcofi.mk b/package/libcofi/libcofi.mk
new file mode 100644
index 0000000..4872d1c
--- /dev/null
+++ b/package/libcofi/libcofi.mk
@@ -0,0 +1,17 @@
+#############################################################
+#
+# libcofi
+#
+#############################################################
+LIBCOFI_VERSION = 7313fbe12b0593034d0a1b606bf33c7cf4ababce
+LIBCOFI_SITE = http://github.com/simonjhall/copies-and-fills/tarball/master
+
+define LIBCOFI_BUILD_CMDS
+    $(MAKE1) AS="$(TARGET_AS)" CC="$(TARGET_CC)" -C $(@D) libcofi_rpi.so
+endef
+
+define LIBCOFI_INSTALL_TARGET_CMDS
+    $(INSTALL) -D -m 0755 $(@D)/libcofi_rpi.so* $(TARGET_DIR)/usr/lib
+endef
+
+$(eval $(generic-package))
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [pull request] Pull request for branch rpi-support
@ 2013-01-05 22:55 Maxime Hadjinlian
  2013-01-05 22:55 ` [Buildroot] [PATCH 1/3] libcofi: new package Maxime Hadjinlian
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-05 22:55 UTC (permalink / raw)
  To: buildroot

Hello All!

This is the second version of this series adding some specific RaspberryPi
packages.
The following changes were applied :

    - rpi-fw -> rpi-firmware
        - Now appears in Hardware Handling -> Misc devices fimwares
        - License fixed
        - cmdline.txt files has been merged with config.txt
    - rpi-userland
        - License fixed
        - Applied Samuel Martin's patch to remove most of the cleanup hooks
        - Removed libcofi as a dependency

The following changes since commit 00e1e2aaa881b32f388ddcfcc71224b3c574c0b8:

  xorg-release: ignore some X.org packages (2013-01-05 23:46:52 +0100)

are available in the git repository at:

  http://github.com/maximeh/buildroot.git rpi-support

for you to fetch changes up to 033a0b8264805de1fb670bf727c756b94d4eb34b:

  rpi-firmware: New package (2013-01-05 23:46:52 +0100)

----------------------------------------------------------------
Maxime Hadjinlian (3):
      libcofi: new package
      rpi-userland: new package
      rpi-firmware: New package

 package/Config.in                                  |    3 +++
 package/libcofi/Config.in                          |    8 ++++++
 package/libcofi/libcofi.mk                         |   17 +++++++++++++
 package/rpi-firmware/Config.in                     |    9 +++++++
 package/rpi-firmware/config.txt                    |   13 ++++++++++
 package/rpi-firmware/rpi-firmware.mk               |   21 ++++++++++++++++
 package/rpi-userland/Config.in                     |   11 +++++++++
 ...make-vmcs.cmake-allow-to-override-VMCS_IN.patch |   26 ++++++++++++++++++++
 package/rpi-userland/rpi-userland.mk               |   19 ++++++++++++++
 9 files changed, 127 insertions(+)
 create mode 100644 package/libcofi/Config.in
 create mode 100644 package/libcofi/libcofi.mk
 create mode 100644 package/rpi-firmware/Config.in
 create mode 100644 package/rpi-firmware/config.txt
 create mode 100644 package/rpi-firmware/rpi-firmware.mk
 create mode 100644 package/rpi-userland/Config.in
 create mode 100644 package/rpi-userland/rpi-userland-makefiles-cmake-vmcs.cmake-allow-to-override-VMCS_IN.patch
 create mode 100644 package/rpi-userland/rpi-userland.mk

Regards,
Maxime Hadjinlian

--

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-05 22:55 [Buildroot] [pull request] Pull request for branch rpi-support Maxime Hadjinlian
@ 2013-01-05 22:55 ` Maxime Hadjinlian
  2013-01-06 20:26   ` Thomas Petazzoni
  2013-01-05 22:55 ` [Buildroot] [PATCH 2/3] rpi-userland: " Maxime Hadjinlian
  2013-01-05 22:55 ` [Buildroot] [PATCH 3/3] rpi-firmware: New package Maxime Hadjinlian
  2 siblings, 1 reply; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-05 22:55 UTC (permalink / raw)
  To: buildroot

replacement for memcpy and memset functionality
This package was originally found at : https://github.com/huceke/buildroot-rbp
By gimli <ebsi4711@gmail.com>

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/Config.in          |    1 +
 package/libcofi/Config.in  |    8 ++++++++
 package/libcofi/libcofi.mk |   17 +++++++++++++++++
 3 files changed, 26 insertions(+)
 create mode 100644 package/libcofi/Config.in
 create mode 100644 package/libcofi/libcofi.mk

diff --git a/package/Config.in b/package/Config.in
index 047af8d..9b50f4b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -511,6 +511,7 @@ endmenu
 menu "Other"
 source "package/apr/Config.in"
 source "package/apr-util/Config.in"
+source "package/libcofi/Config.in"
 source "package/classpath/Config.in"
 source "package/fftw/Config.in"
 source "package/libargtable2/Config.in"
diff --git a/package/libcofi/Config.in b/package/libcofi/Config.in
new file mode 100644
index 0000000..b900b69
--- /dev/null
+++ b/package/libcofi/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBCOFI
+	bool "libcofi"
+	depends on BR2_arm
+	help
+	  A replacement for memcpy and memset functionality for the Raspberry Pi
+	  with the intention of gaining greater performance.
+
+	  https://github.com/simonjhall/copies-and-fills
diff --git a/package/libcofi/libcofi.mk b/package/libcofi/libcofi.mk
new file mode 100644
index 0000000..4872d1c
--- /dev/null
+++ b/package/libcofi/libcofi.mk
@@ -0,0 +1,17 @@
+#############################################################
+#
+# libcofi
+#
+#############################################################
+LIBCOFI_VERSION = 7313fbe12b0593034d0a1b606bf33c7cf4ababce
+LIBCOFI_SITE = http://github.com/simonjhall/copies-and-fills/tarball/master
+
+define LIBCOFI_BUILD_CMDS
+    $(MAKE1) AS="$(TARGET_AS)" CC="$(TARGET_CC)" -C $(@D) libcofi_rpi.so
+endef
+
+define LIBCOFI_INSTALL_TARGET_CMDS
+    $(INSTALL) -D -m 0755 $(@D)/libcofi_rpi.so* $(TARGET_DIR)/usr/lib
+endef
+
+$(eval $(generic-package))
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 2/3] rpi-userland: new package
  2013-01-05 22:55 [Buildroot] [pull request] Pull request for branch rpi-support Maxime Hadjinlian
  2013-01-05 22:55 ` [Buildroot] [PATCH 1/3] libcofi: new package Maxime Hadjinlian
@ 2013-01-05 22:55 ` Maxime Hadjinlian
  2013-01-05 22:55 ` [Buildroot] [PATCH 3/3] rpi-firmware: New package Maxime Hadjinlian
  2 siblings, 0 replies; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-05 22:55 UTC (permalink / raw)
  To: buildroot

Introducing a package to build the userland part of the Raspberry,
needed by anyone who would want to build a rootfs for a RaspberryPi.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/Config.in                                  |    1 +
 package/rpi-userland/Config.in                     |   11 +++++++++
 ...make-vmcs.cmake-allow-to-override-VMCS_IN.patch |   26 ++++++++++++++++++++
 package/rpi-userland/rpi-userland.mk               |   19 ++++++++++++++
 4 files changed, 57 insertions(+)
 create mode 100644 package/rpi-userland/Config.in
 create mode 100644 package/rpi-userland/rpi-userland-makefiles-cmake-vmcs.cmake-allow-to-override-VMCS_IN.patch
 create mode 100644 package/rpi-userland/rpi-userland.mk

diff --git a/package/Config.in b/package/Config.in
index 9b50f4b..17205fe 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -580,6 +580,7 @@ source "package/collectd/Config.in"
 source "package/empty/Config.in"
 source "package/googlefontdirectory/Config.in"
 source "package/mobile-broadband-provider-info/Config.in"
+source "package/rpi-userland/Config.in"
 source "package/shared-mime-info/Config.in"
 source "package/snowball-init/Config.in"
 source "package/sound-theme-borealis/Config.in"
diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
new file mode 100644
index 0000000..b596a36
--- /dev/null
+++ b/package/rpi-userland/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_RPI_USERLAND
+	bool "rpi-userland"
+	help
+	  Raspberry Pi Userland contains the necessary library to use the
+	  VideoCore driver.
+
+	  Includes source for the ARM side code to interface to: 
+	  EGL, mmal, GLESv2, vcos, openmaxil, vchiq_arm, bcm_host, WFC, OpenVG.
+
+	  https://github.com/raspberrypi/userland/
+
diff --git a/package/rpi-userland/rpi-userland-makefiles-cmake-vmcs.cmake-allow-to-override-VMCS_IN.patch b/package/rpi-userland/rpi-userland-makefiles-cmake-vmcs.cmake-allow-to-override-VMCS_IN.patch
new file mode 100644
index 0000000..e54d29e
--- /dev/null
+++ b/package/rpi-userland/rpi-userland-makefiles-cmake-vmcs.cmake-allow-to-override-VMCS_IN.patch
@@ -0,0 +1,26 @@
+From fec2560cfcb8d3398e4f1ccc3de7923365873676 Mon Sep 17 00:00:00 2001
+From: Samuel Martin <s.martin49@gmail.com>
+Date: Sat, 5 Jan 2013 16:04:55 +0100
+Subject: [PATCH] makefiles/cmake/vmcs.cmake: allow to override
+ VMCS_INSTALL_PREFIX
+
+Signed-off-by: Samuel Martin <s.martin49@gmail.com>
+---
+ makefiles/cmake/vmcs.cmake | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/makefiles/cmake/vmcs.cmake b/makefiles/cmake/vmcs.cmake
+index 0f8641b..cc70cca 100644
+--- a/makefiles/cmake/vmcs.cmake
++++ b/makefiles/cmake/vmcs.cmake
+@@ -9,7 +9,7 @@ INCLUDE(CPack)
+ # Where shall we install?
+ if (ANDROID)
+   SET(VMCS_INSTALL_PREFIX "/vendor/brcm/islands" CACHE PATH "Prefix prepended to install directories" FORCE)
+-else()
++elseif(NOT DEFINED VMCS_INSTALL_PREFIX)
+   SET(VMCS_INSTALL_PREFIX "/opt/vc" CACHE PATH "Prefix prepended to install directories" FORCE)
+ endif()
+ 
+-- 
+1.8.1
diff --git a/package/rpi-userland/rpi-userland.mk b/package/rpi-userland/rpi-userland.mk
new file mode 100644
index 0000000..2b919ea
--- /dev/null
+++ b/package/rpi-userland/rpi-userland.mk
@@ -0,0 +1,19 @@
+#############################################################
+#
+# rpi-userland
+#
+#############################################################
+RPI_USERLAND_VERSION = 9852ce28826889e50c4d6786b942f51bccccac54
+RPI_USERLAND_SITE = http://github.com/raspberrypi/userland/tarball/master
+RPI_USERLAND_LICENSE = BSD-3c
+RPI_USERLAND_LICENSE_FILE = LICENCE
+RPI_USERLAND_INSTALL_STAGING = YES
+RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr
+
+define RPI_USERLAND_POST_TARGET_CLEANUP
+    rm -Rf $(TARGET_DIR)/usr/src
+endef
+
+RPI_USERLAND_POST_INSTALL_TARGET_HOOKS += RPI_USERLAND_POST_TARGET_CLEANUP
+
+$(eval $(cmake-package))
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 3/3] rpi-firmware: New package
  2013-01-05 22:55 [Buildroot] [pull request] Pull request for branch rpi-support Maxime Hadjinlian
  2013-01-05 22:55 ` [Buildroot] [PATCH 1/3] libcofi: new package Maxime Hadjinlian
  2013-01-05 22:55 ` [Buildroot] [PATCH 2/3] rpi-userland: " Maxime Hadjinlian
@ 2013-01-05 22:55 ` Maxime Hadjinlian
  2013-01-05 23:05   ` Alex Bradbury
  2 siblings, 1 reply; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-05 22:55 UTC (permalink / raw)
  To: buildroot

Introducing a package to install pre-built binaries for the bootloader and the
GPU firmware for the RaspberryPi board.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/Config.in                    |    1 +
 package/rpi-firmware/Config.in       |    9 +++++++++
 package/rpi-firmware/config.txt      |   13 +++++++++++++
 package/rpi-firmware/rpi-firmware.mk |   21 +++++++++++++++++++++
 4 files changed, 44 insertions(+)
 create mode 100644 package/rpi-firmware/Config.in
 create mode 100644 package/rpi-firmware/config.txt
 create mode 100644 package/rpi-firmware/rpi-firmware.mk

diff --git a/package/Config.in b/package/Config.in
index 17205fe..30c39ac 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -202,6 +202,7 @@ menu "Hardware handling"
 menu "Misc devices firmwares"
 source "package/b43-firmware/Config.in"
 source "package/linux-firmware/Config.in"
+source "package/rpi-firmware/Config.in"
 source "package/ux500-firmware/Config.in"
 source "package/zd1211-firmware/Config.in"
 endmenu
diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
new file mode 100644
index 0000000..5723dea
--- /dev/null
+++ b/package/rpi-firmware/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_RPI_FIRMWARE
+	bool "RaspberryPi Firmware"
+	depends on BR2_arm
+	help
+	  RaspberryPi Firmware
+	  Pre-compiled binaries of the current bootloader and GPU firmware
+
+	  https://github.com/raspberrypi/firmware
+
diff --git a/package/rpi-firmware/config.txt b/package/rpi-firmware/config.txt
new file mode 100644
index 0000000..14d320d
--- /dev/null
+++ b/package/rpi-firmware/config.txt
@@ -0,0 +1,13 @@
+# Please note that this is only a sample, we recommend you to change it to fit
+# your needs.
+# You should override this file using a post-build script.
+# See http://buildroot.uclibc.org/downloads/manual/manual.html#rootfs-custom 
+
+arm_freq=700
+core_freq=250
+disable_overscan=1
+gpu_mem_256=100
+gpu_mem_512=100
+sdram_freq=400
+over_voltage=0
+cmdline="dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
new file mode 100644
index 0000000..74a7409
--- /dev/null
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -0,0 +1,21 @@
+#############################################################
+#
+# rpi-firmware
+#
+#############################################################
+RPI_FIRMWARE_VERSION = 76d0ac38f16b6343c6155c80db1e4758b3a5838a
+RPI_FIRMWARE_SITE = http://github.com/raspberrypi/firmware/tarball/master
+RPI_FIRMWARE_LICENSE = BSD-3c
+RPI_FIRMWARE_LICENSE_FILE = boot/LICENCE.broadcom
+
+define RPI_FIRMWARE_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0644 $(@D)/boot/bootcode.bin $(TARGET_DIR)/boot/
+	$(INSTALL) -D -m 0644 $(@D)/boot/start.elf $(TARGET_DIR)/boot/
+	$(INSTALL) -D -m 0644 $(@D)/boot/start_cd.elf $(TARGET_DIR)/boot/
+	$(INSTALL) -D -m 0644 $(@D)/boot/fixup.dat $(TARGET_DIR)/boot/
+	$(INSTALL) -D -m 0644 $(@D)/boot/fixup_cd.dat $(TARGET_DIR)/boot/
+	$(INSTALL) -D -m 0644 package/rpi-fw/cmdline.txt $(TARGET_DIR)/boot/
+	$(INSTALL) -D -m 0644 package/rpi-fw/config.txt $(TARGET_DIR)/boot/
+endef
+
+$(eval $(generic-package))
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 3/3] rpi-firmware: New package
  2013-01-05 22:55 ` [Buildroot] [PATCH 3/3] rpi-firmware: New package Maxime Hadjinlian
@ 2013-01-05 23:05   ` Alex Bradbury
  2013-01-05 23:17     ` Maxime Hadjinlian
  0 siblings, 1 reply; 16+ messages in thread
From: Alex Bradbury @ 2013-01-05 23:05 UTC (permalink / raw)
  To: buildroot

On 5 January 2013 22:55, Maxime Hadjinlian <maxime.hadjinlian@gmail.com> wrote:
> +RPI_FIRMWARE_VERSION = 76d0ac38f16b6343c6155c80db1e4758b3a5838a
> +RPI_FIRMWARE_SITE = http://github.com/raspberrypi/firmware/tarball/master
> +RPI_FIRMWARE_LICENSE = BSD-3c
> +RPI_FIRMWARE_LICENSE_FILE = boot/LICENCE.broadcom

Although at a glance the licence file looks like 3-clause BSD (which
the licence for the Raspberry Pi 'userland' code is), it's actually
not. It only allows distribution without modification and has the
condition "This software may only be used for the purposes of
developing for, running or using a Raspberry Pi device." The license
is of course derived from the BSD license, and looks pretty similar to
the license Intel uses for various wlan firmware.

Regards,

Alex

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 3/3] rpi-firmware: New package
  2013-01-05 23:05   ` Alex Bradbury
@ 2013-01-05 23:17     ` Maxime Hadjinlian
  0 siblings, 0 replies; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-05 23:17 UTC (permalink / raw)
  To: buildroot

On Sun, Jan 6, 2013 at 12:05 AM, Alex Bradbury <asb@asbradbury.org> wrote:
> On 5 January 2013 22:55, Maxime Hadjinlian <maxime.hadjinlian@gmail.com> wrote:
>> +RPI_FIRMWARE_VERSION = 76d0ac38f16b6343c6155c80db1e4758b3a5838a
>> +RPI_FIRMWARE_SITE = http://github.com/raspberrypi/firmware/tarball/master
>> +RPI_FIRMWARE_LICENSE = BSD-3c
>> +RPI_FIRMWARE_LICENSE_FILE = boot/LICENCE.broadcom
>
> Although at a glance the licence file looks like 3-clause BSD (which
> the licence for the Raspberry Pi 'userland' code is), it's actually
> not. It only allows distribution without modification and has the
> condition "This software may only be used for the purposes of
> developing for, running or using a Raspberry Pi device." The license
> is of course derived from the BSD license, and looks pretty similar to
> the license Intel uses for various wlan firmware.
So what should be put as a license for this package then ? I'm
actually pretty ignorant on the subject I must say.
>
> Regards,
>
> Alex

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-05 22:55 ` [Buildroot] [PATCH 1/3] libcofi: new package Maxime Hadjinlian
@ 2013-01-06 20:26   ` Thomas Petazzoni
  2013-01-06 20:39     ` Maxime Hadjinlian
  0 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2013-01-06 20:26 UTC (permalink / raw)
  To: buildroot

Dear Maxime Hadjinlian,

On Sat,  5 Jan 2013 23:55:14 +0100, Maxime Hadjinlian wrote:
> diff --git a/package/libcofi/libcofi.mk b/package/libcofi/libcofi.mk
> new file mode 100644
> index 0000000..4872d1c
> --- /dev/null
> +++ b/package/libcofi/libcofi.mk
> @@ -0,0 +1,17 @@
> +#############################################################
> +#
> +# libcofi
> +#
> +#############################################################
> +LIBCOFI_VERSION = 7313fbe12b0593034d0a1b606bf33c7cf4ababce

One new line between the first variable line and the #### line.

> +LIBCOFI_SITE = http://github.com/simonjhall/copies-and-fills/tarball/master

LIBCOFI_LICENSE ?

> +define LIBCOFI_BUILD_CMDS
> +    $(MAKE1) AS="$(TARGET_AS)" CC="$(TARGET_CC)" -C $(@D) libcofi_rpi.so
> +endef

Seeing the Makefile, I don't see any obvious dependency problem, so I
guess you could use $(MAKE) instead of $(MAKE1).

Also, please use $(TARGET_CONFIGURE_OPTS). And you don't need to
specify the libcofi_rpi.so target since this is the first target of the
Makefile (and hence the default one). So:

	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)

> +define LIBCOFI_INSTALL_TARGET_CMDS
> +    $(INSTALL) -D -m 0755 $(@D)/libcofi_rpi.so* $(TARGET_DIR)/usr/lib
> +endef

Only libcofi_rpi.so is built, so:

	$(INSTALL) -D -m 0755 $(@D)/libcofi_rpi.so $(TARGET_DIR)/usr/lib/libcofi_rpi.so

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-06 20:26   ` Thomas Petazzoni
@ 2013-01-06 20:39     ` Maxime Hadjinlian
  2013-01-06 20:45       ` Thomas Petazzoni
  0 siblings, 1 reply; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-06 20:39 UTC (permalink / raw)
  To: buildroot

On Sun, Jan 6, 2013 at 9:26 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Maxime Hadjinlian,
>
> On Sat,  5 Jan 2013 23:55:14 +0100, Maxime Hadjinlian wrote:
>> diff --git a/package/libcofi/libcofi.mk b/package/libcofi/libcofi.mk
>> new file mode 100644
>> index 0000000..4872d1c
>> --- /dev/null
>> +++ b/package/libcofi/libcofi.mk
>> @@ -0,0 +1,17 @@
>> +#############################################################
>> +#
>> +# libcofi
>> +#
>> +#############################################################
>> +LIBCOFI_VERSION = 7313fbe12b0593034d0a1b606bf33c7cf4ababce
>
> One new line between the first variable line and the #### line.
>
>> +LIBCOFI_SITE = http://github.com/simonjhall/copies-and-fills/tarball/master
>
> LIBCOFI_LICENSE ?
There is absolutely no information whatsoever about license that I
could find, so I really did knew what to put there.
>
>> +define LIBCOFI_BUILD_CMDS
>> +    $(MAKE1) AS="$(TARGET_AS)" CC="$(TARGET_CC)" -C $(@D) libcofi_rpi.so
>> +endef
>
> Seeing the Makefile, I don't see any obvious dependency problem, so I
> guess you could use $(MAKE) instead of $(MAKE1).
>
> Also, please use $(TARGET_CONFIGURE_OPTS). And you don't need to
> specify the libcofi_rpi.so target since this is the first target of the
> Makefile (and hence the default one). So:
>
>         $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
>
>> +define LIBCOFI_INSTALL_TARGET_CMDS
>> +    $(INSTALL) -D -m 0755 $(@D)/libcofi_rpi.so* $(TARGET_DIR)/usr/lib
>> +endef
>
> Only libcofi_rpi.so is built, so:
>
>         $(INSTALL) -D -m 0755 $(@D)/libcofi_rpi.so $(TARGET_DIR)/usr/lib/libcofi_rpi.so
>
Ok
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-06 20:39     ` Maxime Hadjinlian
@ 2013-01-06 20:45       ` Thomas Petazzoni
  0 siblings, 0 replies; 16+ messages in thread
From: Thomas Petazzoni @ 2013-01-06 20:45 UTC (permalink / raw)
  To: buildroot

Dear Maxime Hadjinlian,

On Sun, 6 Jan 2013 21:39:55 +0100, Maxime Hadjinlian wrote:

> > LIBCOFI_LICENSE ?
> There is absolutely no information whatsoever about license that I
> could find, so I really did knew what to put there.

There is actually a lot of information about the license in the
README.md file:

The inner loop of the misalignment path of memcpy is derived from the
GNU libc ARM port. As a result "copies-and-fills" is licensed under the
GNU Lesser General Public License version 2.1. See
http://www.gnu.org/licenses/ for details. To see the original memcpy,
browse it here:
http://sourceware.org/git/?p=glibc-ports.git;a=blob;f=sysdeps/arm/memcpy.S;hb=HEAD

So:
	LIBCOFI_LICENSE = LGPLv2.1
	LIBCOFI_LICENSE_FILES = README.md

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-06 20:56 [Buildroot] [pull request] Pull request for branch rpi-support Maxime Hadjinlian
@ 2013-01-06 20:56 ` Maxime Hadjinlian
  2013-01-06 21:02   ` Peter Korsgaard
  2013-01-06 22:02   ` Peter Korsgaard
  0 siblings, 2 replies; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-06 20:56 UTC (permalink / raw)
  To: buildroot

replacement for memcpy and memset functionality
This package was originally found at : https://github.com/huceke/buildroot-rbp
By gimli <ebsi4711@gmail.com>

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/Config.in          |    1 +
 package/libcofi/Config.in  |    8 ++++++++
 package/libcofi/libcofi.mk |   20 ++++++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 package/libcofi/Config.in
 create mode 100644 package/libcofi/libcofi.mk

diff --git a/package/Config.in b/package/Config.in
index 047af8d..9b50f4b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -511,6 +511,7 @@ endmenu
 menu "Other"
 source "package/apr/Config.in"
 source "package/apr-util/Config.in"
+source "package/libcofi/Config.in"
 source "package/classpath/Config.in"
 source "package/fftw/Config.in"
 source "package/libargtable2/Config.in"
diff --git a/package/libcofi/Config.in b/package/libcofi/Config.in
new file mode 100644
index 0000000..b900b69
--- /dev/null
+++ b/package/libcofi/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBCOFI
+	bool "libcofi"
+	depends on BR2_arm
+	help
+	  A replacement for memcpy and memset functionality for the Raspberry Pi
+	  with the intention of gaining greater performance.
+
+	  https://github.com/simonjhall/copies-and-fills
diff --git a/package/libcofi/libcofi.mk b/package/libcofi/libcofi.mk
new file mode 100644
index 0000000..e2ce702
--- /dev/null
+++ b/package/libcofi/libcofi.mk
@@ -0,0 +1,20 @@
+#############################################################
+#
+# libcofi
+#
+#############################################################
+
+LIBCOFI_VERSION = 7313fbe12b0593034d0a1b606bf33c7cf4ababce
+LIBCOFI_SITE = http://github.com/simonjhall/copies-and-fills/tarball/master
+LIBCOFI_LICENSE = LGPLv2.1
+LIBCOFI_LICENSE_FILES = README.md
+
+define LIBCOFI_BUILD_CMDS
+    $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
+endef
+
+define LIBCOFI_INSTALL_TARGET_CMDS
+    $(INSTALL) -D -m 0755 $(@D)/libcofi_rpi.so $(TARGET_DIR)/usr/lib/libcofi_rpi.so
+endef
+
+$(eval $(generic-package))
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-06 20:56 ` [Buildroot] [PATCH 1/3] libcofi: new package Maxime Hadjinlian
@ 2013-01-06 21:02   ` Peter Korsgaard
  2013-01-06 21:13     ` Maxime Hadjinlian
  2013-01-06 22:02   ` Peter Korsgaard
  1 sibling, 1 reply; 16+ messages in thread
From: Peter Korsgaard @ 2013-01-06 21:02 UTC (permalink / raw)
  To: buildroot

>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 Maxime> replacement for memcpy and memset functionality

 Maxime> This package was originally found at :
 Maxime> https://github.com/huceke/buildroot-rbp By gimli
 Maxime> <ebsi4711@gmail.com>

The package looks ok from a quick look, but how is it supposed to be
used? I wouldn't like to see patches to a bunch of packages to link
against this.

It isn't really rpi specific either.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-06 21:02   ` Peter Korsgaard
@ 2013-01-06 21:13     ` Maxime Hadjinlian
  2013-01-06 21:18       ` Peter Korsgaard
  0 siblings, 1 reply; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-06 21:13 UTC (permalink / raw)
  To: buildroot

On Sun, Jan 6, 2013 at 10:02 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:
>
>  Maxime> replacement for memcpy and memset functionality
>
>  Maxime> This package was originally found at :
>  Maxime> https://github.com/huceke/buildroot-rbp By gimli
>  Maxime> <ebsi4711@gmail.com>
>
> The package looks ok from a quick look, but how is it supposed to be
> used? I wouldn't like to see patches to a bunch of packages to link
> against this.
As the author of the package says, the library is used using
LD_PRELOAD on the target.
So no patch should be needed for any packages.
>
> It isn't really rpi specific either.
I don't know about that, the author says it's rpi specific.
>
> --
> Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-06 21:13     ` Maxime Hadjinlian
@ 2013-01-06 21:18       ` Peter Korsgaard
  2013-01-06 21:21         ` Maxime Hadjinlian
  0 siblings, 1 reply; 16+ messages in thread
From: Peter Korsgaard @ 2013-01-06 21:18 UTC (permalink / raw)
  To: buildroot

>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

Hi,

 >> The package looks ok from a quick look, but how is it supposed to be
 >> used? I wouldn't like to see patches to a bunch of packages to link
 >> against this.
 Maxime> As the author of the package says, the library is used using
 Maxime> LD_PRELOAD on the target.
 Maxime> So no patch should be needed for any packages.

Ok, great.

 >> 
 >> It isn't really rpi specific either.
 Maxime> I don't know about that, the author says it's rpi specific.

The optimizations presumably also applies to other ARM11(76) processors
with similar memory speed.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-06 21:18       ` Peter Korsgaard
@ 2013-01-06 21:21         ` Maxime Hadjinlian
  0 siblings, 0 replies; 16+ messages in thread
From: Maxime Hadjinlian @ 2013-01-06 21:21 UTC (permalink / raw)
  To: buildroot

On Sun, Jan 6, 2013 at 10:18 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:
>
> Hi,
>
>  >> The package looks ok from a quick look, but how is it supposed to be
>  >> used? I wouldn't like to see patches to a bunch of packages to link
>  >> against this.
>  Maxime> As the author of the package says, the library is used using
>  Maxime> LD_PRELOAD on the target.
>  Maxime> So no patch should be needed for any packages.
>
> Ok, great.
>
>  >>
>  >> It isn't really rpi specific either.
>  Maxime> I don't know about that, the author says it's rpi specific.
>
> The optimizations presumably also applies to other ARM11(76) processors
> with similar memory speed.
You're absolutely right, if someone as such a platform, it would be
great to know if it works or not !
>
> --
> Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/3] libcofi: new package
  2013-01-06 20:56 ` [Buildroot] [PATCH 1/3] libcofi: new package Maxime Hadjinlian
  2013-01-06 21:02   ` Peter Korsgaard
@ 2013-01-06 22:02   ` Peter Korsgaard
  1 sibling, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2013-01-06 22:02 UTC (permalink / raw)
  To: buildroot

>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 Maxime> replacement for memcpy and memset functionality
 Maxime> This package was originally found at : https://github.com/huceke/buildroot-rbp
 Maxime> By gimli <ebsi4711@gmail.com>

 Maxime> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
 Maxime> ---
 Maxime>  package/Config.in          |    1 +
 Maxime>  package/libcofi/Config.in  |    8 ++++++++
 Maxime>  package/libcofi/libcofi.mk |   20 ++++++++++++++++++++
 Maxime>  3 files changed, 29 insertions(+)
 Maxime>  create mode 100644 package/libcofi/Config.in
 Maxime>  create mode 100644 package/libcofi/libcofi.mk

 Maxime> diff --git a/package/Config.in b/package/Config.in
 Maxime> index 047af8d..9b50f4b 100644
 Maxime> --- a/package/Config.in
 Maxime> +++ b/package/Config.in
 Maxime> @@ -511,6 +511,7 @@ endmenu
 Maxime>  menu "Other"
 Maxime>  source "package/apr/Config.in"
 Maxime>  source "package/apr-util/Config.in"
 Maxime> +source "package/libcofi/Config.in"
 Maxime>  source "package/classpath/Config.in"
 Maxime>  source "package/fftw/Config.in"
 Maxime>  source "package/libargtable2/Config.in"
 Maxime> diff --git a/package/libcofi/Config.in b/package/libcofi/Config.in
 Maxime> new file mode 100644
 Maxime> index 0000000..b900b69
 Maxime> --- /dev/null
 Maxime> +++ b/package/libcofi/Config.in
 Maxime> @@ -0,0 +1,8 @@
 Maxime> +config BR2_PACKAGE_LIBCOFI
 Maxime> +	bool "libcofi"
 Maxime> +	depends on BR2_arm
 Maxime> +	help
 Maxime> +	  A replacement for memcpy and memset functionality for the Raspberry Pi

I've word wrapped this and committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2013-01-06 22:02 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-05 22:55 [Buildroot] [pull request] Pull request for branch rpi-support Maxime Hadjinlian
2013-01-05 22:55 ` [Buildroot] [PATCH 1/3] libcofi: new package Maxime Hadjinlian
2013-01-06 20:26   ` Thomas Petazzoni
2013-01-06 20:39     ` Maxime Hadjinlian
2013-01-06 20:45       ` Thomas Petazzoni
2013-01-05 22:55 ` [Buildroot] [PATCH 2/3] rpi-userland: " Maxime Hadjinlian
2013-01-05 22:55 ` [Buildroot] [PATCH 3/3] rpi-firmware: New package Maxime Hadjinlian
2013-01-05 23:05   ` Alex Bradbury
2013-01-05 23:17     ` Maxime Hadjinlian
  -- strict thread matches above, loose matches on Subject: below --
2013-01-06 20:56 [Buildroot] [pull request] Pull request for branch rpi-support Maxime Hadjinlian
2013-01-06 20:56 ` [Buildroot] [PATCH 1/3] libcofi: new package Maxime Hadjinlian
2013-01-06 21:02   ` Peter Korsgaard
2013-01-06 21:13     ` Maxime Hadjinlian
2013-01-06 21:18       ` Peter Korsgaard
2013-01-06 21:21         ` Maxime Hadjinlian
2013-01-06 22:02   ` Peter Korsgaard
2013-01-05 14:10 [Buildroot] [pull request] Pull request for branch rpi-support Maxime Hadjinlian
2013-01-05 14:10 ` [Buildroot] [PATCH 1/3] libcofi: new package Maxime Hadjinlian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox