* [Buildroot] [PATCH 1/2] lzop: add host build @ 2012-12-13 10:59 Fabio Porcedda 2012-12-13 10:59 ` [Buildroot] [PATCH 2/2] barebox: needs host-lzop Fabio Porcedda 2013-01-07 12:30 ` [Buildroot] [PATCH 1/2] lzop: add host build Fabio Porcedda 0 siblings, 2 replies; 5+ messages in thread From: Fabio Porcedda @ 2012-12-13 10:59 UTC (permalink / raw) To: buildroot Barebox needs host-lzop. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> --- package/lzop/lzop.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/lzop/lzop.mk b/package/lzop/lzop.mk index 4ab8a4a..1f7c835 100644 --- a/package/lzop/lzop.mk +++ b/package/lzop/lzop.mk @@ -11,3 +11,4 @@ LZOP_LICENSE_FILES = COPYING LZOP_DEPENDENCIES = lzo $(eval $(autotools-package)) +$(eval $(host-autotools-package)) -- 1.8.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] barebox: needs host-lzop 2012-12-13 10:59 [Buildroot] [PATCH 1/2] lzop: add host build Fabio Porcedda @ 2012-12-13 10:59 ` Fabio Porcedda 2013-01-07 12:36 ` Thomas Petazzoni 2013-01-07 12:30 ` [Buildroot] [PATCH 1/2] lzop: add host build Fabio Porcedda 1 sibling, 1 reply; 5+ messages in thread From: Fabio Porcedda @ 2012-12-13 10:59 UTC (permalink / raw) To: buildroot Add host-lzop dependency. Use $(TARGET_MAKE_ENV) when calling $(MAKE) to able to use binaries built for host. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> --- boot/barebox/barebox.mk | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/boot/barebox/barebox.mk b/boot/barebox/barebox.mk index 6cc4976..2aff7e6 100644 --- a/boot/barebox/barebox.mk +++ b/boot/barebox/barebox.mk @@ -20,6 +20,7 @@ BAREBOX_SOURCE = barebox-$(BAREBOX_VERSION).tar.bz2 BAREBOX_SITE = http://www.barebox.org/download/ endif +BAREBOX_DEPENDENCIES = host-lzop BAREBOX_LICENSE = GPLv2 with exceptions BAREBOX_LICENSE_FILES = COPYING @@ -56,7 +57,7 @@ endif define BAREBOX_CONFIGURE_CMDS cp $(BAREBOX_SOURCE_CONFIG) $(@D)/arch/$(BAREBOX_ARCH)/configs/buildroot_defconfig - $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) buildroot_defconfig + $(TARGET_MAKE_ENV) $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) buildroot_defconfig endef ifeq ($(BR2_TARGET_BAREBOX_BAREBOXENV),y) @@ -68,7 +69,7 @@ endif define BAREBOX_BUILD_CMDS $(BAREBOX_BUILD_BAREBOXENV_CMDS) - $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) + $(TARGET_MAKE_ENV) $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) endef define BAREBOX_INSTALL_IMAGES_CMDS @@ -96,12 +97,12 @@ endif endif barebox-menuconfig barebox-xconfig barebox-gconfig barebox-nconfig: barebox-configure - $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(BAREBOX_DIR) \ + $(TARGET_MAKE_ENV) $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(BAREBOX_DIR) \ $(subst barebox-,,$@) rm -f $(BAREBOX_DIR)/.stamp_{built,target_installed,images_installed} barebox-savedefconfig: barebox-configure - $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(BAREBOX_DIR) \ + $(TARGET_MAKE_ENV) $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(BAREBOX_DIR) \ $(subst barebox-,,$@) ifeq ($(BR2_TARGET_BAREBOX_USE_CUSTOM_CONFIG),y) -- 1.8.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] barebox: needs host-lzop 2012-12-13 10:59 ` [Buildroot] [PATCH 2/2] barebox: needs host-lzop Fabio Porcedda @ 2013-01-07 12:36 ` Thomas Petazzoni 2013-01-07 14:52 ` Fabio Porcedda 0 siblings, 1 reply; 5+ messages in thread From: Thomas Petazzoni @ 2013-01-07 12:36 UTC (permalink / raw) To: buildroot Dear Fabio Porcedda, On Thu, 13 Dec 2012 11:59:42 +0100, Fabio Porcedda wrote: > Add host-lzop dependency. > Use $(TARGET_MAKE_ENV) when calling $(MAKE) > to able to use binaries built for host. Does Barebox always need lzop? If not, under what conditions does it need lzop? Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] barebox: needs host-lzop 2013-01-07 12:36 ` Thomas Petazzoni @ 2013-01-07 14:52 ` Fabio Porcedda 0 siblings, 0 replies; 5+ messages in thread From: Fabio Porcedda @ 2013-01-07 14:52 UTC (permalink / raw) To: buildroot Hi Thomas, thanks for the review. On Mon, Jan 7, 2013 at 1:36 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Fabio Porcedda, > > On Thu, 13 Dec 2012 11:59:42 +0100, Fabio Porcedda wrote: >> Add host-lzop dependency. >> Use $(TARGET_MAKE_ENV) when calling $(MAKE) >> to able to use binaries built for host. > > Does Barebox always need lzop? If not, under what conditions does it > need lzop? Barebox doesn't always need lzop. I think the dependency is determined by the barebox configuration (barebox/.config), so I think it's impractical/impossible to know beforehand. We can check the dependency only after the barebox configuration phase it's done. IMHO it's too late. Best regards -- Fabio Porcedda ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] lzop: add host build 2012-12-13 10:59 [Buildroot] [PATCH 1/2] lzop: add host build Fabio Porcedda 2012-12-13 10:59 ` [Buildroot] [PATCH 2/2] barebox: needs host-lzop Fabio Porcedda @ 2013-01-07 12:30 ` Fabio Porcedda 1 sibling, 0 replies; 5+ messages in thread From: Fabio Porcedda @ 2013-01-07 12:30 UTC (permalink / raw) To: buildroot On Thu, Dec 13, 2012 at 11:59 AM, Fabio Porcedda <fabio.porcedda@gmail.com> wrote: > Barebox needs host-lzop. > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > --- > package/lzop/lzop.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/lzop/lzop.mk b/package/lzop/lzop.mk > index 4ab8a4a..1f7c835 100644 > --- a/package/lzop/lzop.mk > +++ b/package/lzop/lzop.mk > @@ -11,3 +11,4 @@ LZOP_LICENSE_FILES = COPYING > LZOP_DEPENDENCIES = lzo > > $(eval $(autotools-package)) > +$(eval $(host-autotools-package)) > -- > 1.8.0 > ping -- Fabio Porcedda ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-07 14:52 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-12-13 10:59 [Buildroot] [PATCH 1/2] lzop: add host build Fabio Porcedda 2012-12-13 10:59 ` [Buildroot] [PATCH 2/2] barebox: needs host-lzop Fabio Porcedda 2013-01-07 12:36 ` Thomas Petazzoni 2013-01-07 14:52 ` Fabio Porcedda 2013-01-07 12:30 ` [Buildroot] [PATCH 1/2] lzop: add host build Fabio Porcedda
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox