[Buildroot] [PATCH v2 5/6] lvm2: Compile and install application library.

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Marek Belisko,

On Mon,  7 Jan 2013 21:43:18 +0100, Marek Belisko wrote:

> +config BR2_PACKAGE_LVM2_APP_LIBRARY
> +	bool "install application library"
> +	depends on BR2_PACKAGE_LVM2
> +	help
> +	  Install application library (liblvm2app2).
> +

> +ifeq ($(BR2_PACKAGE_LVM2_APP_LIBRARY),y)
> +LVM2_MAKE_OPT += liblvm
> +LVM2_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install
> +LVM2_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install
> +endif

I am not quite sure this is correct. Currently, the package works as
follows (if I understand correctly):

 * if BR2_PACKAGE_LVM2=y but BR2_PACKAGE_LVM2_DMSETUP_ONLY is not
   enabled, then LVM2_MAKE_OPT is empty, so it just runs the default
   make target, which presumably builds everything.

 * if BR2_PACKAGE_LVM2=y and BR2_PACKAGE_LVM2_DMSETUP_ONLY=y, then
   LVM2_MAKE_OPT is set to device-mapper, in which case it only builds
   the device mapper code.

So now, you add a third BR2_PACKAGE_LVM2_APP_LIBRARY option. But if I
do BR2_PACKAGE_LVM2=y and BR2_PACKAGE_LVM2_APP_LIBRARY=y, it will only
build the library and not the rest, which is not what we expect.

I'd say that the DMSETUP_ONLY thing is a bad idea from the beginning,
so I'm not sure what's the best way moving forward.

Are you sure liblvm doesn't get build and installed by the default
BR2_PACKAGE_LVM2=y configuration?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com