Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 5/6] lvm2: Compile and install application library.
Date: Sun, 03 Feb 2013 15:20:14 +0100	[thread overview]
Message-ID: <878v755vj5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1357591399-3566-6-git-send-email-marek.belisko@open-nandra.com> (Marek Belisko's message of "Mon, 7 Jan 2013 21:43:18 +0100")

>>>>> "Marek" == Marek Belisko <marek.belisko@open-nandra.com> writes:

 Marek> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
 Marek> ---
 Marek>  package/lvm2/Config.in |    6 ++++++
 Marek>  package/lvm2/lvm2.mk   |    8 +++++++-
 Marek>  2 files changed, 13 insertions(+), 1 deletion(-)

 Marek> diff --git a/package/lvm2/Config.in b/package/lvm2/Config.in
 Marek> index 30af14e..bb41c0a 100644
 Marek> --- a/package/lvm2/Config.in
 Marek> +++ b/package/lvm2/Config.in
 Marek> @@ -21,5 +21,11 @@ config BR2_PACKAGE_LVM2_DMSETUP_ONLY
 Marek>  	help
 Marek>  	  Install dmsetup only and skip the LVM2 suite.
 
 Marek> +config BR2_PACKAGE_LVM2_APP_LIBRARY
 Marek> +	bool "install application library"

This option doesn't make much sense in combination with DMSETUP_ONLY, so
I've made it depend on !DMSETUP_ONLY


 Marek> +	depends on BR2_PACKAGE_LVM2
 Marek> +	help
 Marek> +	  Install application library (liblvm2app2).
 Marek> +
 Marek>  comment "lvm2 requires a toolchain with LARGEFILE support"
 Marek>          depends on !BR2_LARGEFILE
 Marek> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
 Marek> index f54caa4..213ef65 100644
 Marek> --- a/package/lvm2/lvm2.mk
 Marek> +++ b/package/lvm2/lvm2.mk
 Marek> @@ -21,7 +21,7 @@ LVM2_BINS = \
 
 Marek>  # Make sure that binaries and libraries are installed with write
 Marek>  # permissions for the owner.
 Marek> -LVM2_CONF_OPT += --enable-write_install --enable-pkgconfig
 Marek> +LVM2_CONF_OPT += --enable-write_install --enable-pkgconfig --enable-applib

We should only enable it if _APP_LIBRARY is enabled.


 
 Marek>  # LVM2 uses autoconf, but not automake, and the build system does not
 Marek>  # take into account the CC passed at configure time.
 Marek> @@ -41,6 +41,12 @@ LVM2_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install_device-mapper
 Marek>  LVM2_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install_device-mapper
 Marek>  endif
 
 Marek> +ifeq ($(BR2_PACKAGE_LVM2_APP_LIBRARY),y)
 Marek> +LVM2_MAKE_OPT += liblvm
 Marek> +LVM2_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install
 Marek> +LVM2_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install

And then this isn't needed.

Committed with these fixes, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2013-02-03 14:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 20:43 [Buildroot] [PATCH v2 0/6] Add support for udisks package Marek Belisko
2013-01-07 20:43 ` [Buildroot] [PATCH v2 1/6] sg3_utils: new package Marek Belisko
2013-01-07 21:26   ` Thomas Petazzoni
2013-01-07 21:45     ` Belisko Marek
2013-01-07 21:52       ` Thomas Petazzoni
2013-01-07 21:56         ` Yann E. MORIN
2013-01-08  8:05           ` Arnout Vandecappelle
2013-01-15 20:48             ` Belisko Marek
2013-01-15 20:59               ` Yann E. MORIN
2013-01-15 21:04                 ` Belisko Marek
2013-01-15 21:29                   ` Yann E. MORIN
2013-01-16  8:17                     ` Arnout Vandecappelle
2013-01-07 20:43 ` [Buildroot] [PATCH v2 2/6] polkit: " Marek Belisko
2013-01-07 21:26   ` Thomas Petazzoni
2013-01-07 21:31   ` Thomas Petazzoni
2013-01-07 20:43 ` [Buildroot] [PATCH v2 3/6] libatasmart: " Marek Belisko
2013-01-07 21:30   ` Thomas Petazzoni
2013-01-07 21:52     ` Belisko Marek
2013-01-07 21:53       ` Thomas Petazzoni
2013-01-07 20:43 ` [Buildroot] [PATCH v2 4/6] lvm2: Install devmapper.pc to staging/target pkgconfig directory Marek Belisko
2013-01-07 20:43 ` [Buildroot] [PATCH v2 5/6] lvm2: Compile and install application library Marek Belisko
2013-01-07 21:38   ` Thomas Petazzoni
2013-01-07 21:58     ` Belisko Marek
2013-01-15 20:53     ` Belisko Marek
2013-01-16  8:06       ` Thomas Petazzoni
2013-01-16  8:49         ` Belisko Marek
2013-02-03 14:20   ` Peter Korsgaard [this message]
2013-02-03 20:44     ` Belisko Marek
2013-02-03 21:47       ` Peter Korsgaard
2013-01-07 20:43 ` [Buildroot] [PATCH v2 6/6] udisks: new package Marek Belisko
2013-01-07 21:47   ` Thomas Petazzoni
2013-01-07 22:03     ` Belisko Marek
2013-01-07 22:18       ` Thomas Petazzoni
2013-01-07 22:25         ` Belisko Marek
2013-01-07 22:49           ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v755vj5.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox