* [Buildroot] [PATCH 1/1] infozip: new package
@ 2013-01-10 10:41 Jan Pedersen
2013-01-10 11:15 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Jan Pedersen @ 2013-01-10 10:41 UTC (permalink / raw)
To: buildroot
This commit adds a package for infozip, compression and file
packaging/archive utility.
Signed-off-by: Jan Pedersen <jp@jp-embedded.com>
---
package/Config.in | 1 +
package/infozip/Config.in | 10 ++++++++++
package/infozip/infozip.mk | 21 +++++++++++++++++++++
3 files changed, 32 insertions(+)
create mode 100644 package/infozip/Config.in
create mode 100644 package/infozip/infozip.mk
diff --git a/package/Config.in b/package/Config.in
index bd1db6b..1c2b228 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -14,6 +14,7 @@ endif
source "package/lzop/Config.in"
source "package/lzma/Config.in"
source "package/xz/Config.in"
+source "package/infozip/Config.in"
endmenu
menu "Debugging, profiling and benchmark"
diff --git a/package/infozip/Config.in b/package/infozip/Config.in
new file mode 100644
index 0000000..1a4b756
--- /dev/null
+++ b/package/infozip/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_INFOZIP
+ bool "infozip"
+ help
+ Zip is a compression and file packaging/archive utility.
+ Although highly compatible both with PKWARE's PKZIP and
+ PKUNZIP utilities for MS-DOS and with Info-ZIP's own UnZip,
+ our primary objectives have been portability and other-than-MSDOS
+ functionality.
+
+ http://infozip.sourceforge.net/Zip.html
diff --git a/package/infozip/infozip.mk b/package/infozip/infozip.mk
new file mode 100644
index 0000000..ce6e88f
--- /dev/null
+++ b/package/infozip/infozip.mk
@@ -0,0 +1,21 @@
+#############################################################
+#
+# infozip
+#
+#############################################################
+INFOZIP_VERSION = 30
+INFOZIP_SOURCE = zip$(INFOZIP_VERSION).tgz
+INFOZIP_SITE = ftp://ftp.info-zip.org/pub/infozip/src
+INFOZIP_LICENSE = Info-ZIP
+INFOZIP_LICENSE_FILES = LICENCE
+
+define INFOZIP_BUILD_CMDS
+ $(MAKE) -C $(@D) -f unix/Makefile generic CC=$(TARGET_CC)
+endef
+
+define INFOZIP_INSTALL_TARGET_CMDS
+ $(MAKE) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr CC=$(TARGET_CC)
+endef
+
+$(eval $(generic-package))
+
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] infozip: new package
2013-01-10 10:41 [Buildroot] [PATCH 1/1] infozip: new package Jan Pedersen
@ 2013-01-10 11:15 ` Thomas Petazzoni
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2013-01-10 11:15 UTC (permalink / raw)
To: buildroot
Dear Jan Pedersen,
On Thu, 10 Jan 2013 11:41:06 +0100, Jan Pedersen wrote:
> +INFOZIP_LICENSE_FILES = LICENCE
This is not correct, the file is called LICENSE.
You should run "make legal-info" when you create a new package, to
verify that the LICENSE_FILES field is correct.
> +define INFOZIP_BUILD_CMDS
> + $(MAKE) -C $(@D) -f unix/Makefile generic CC=$(TARGET_CC)
> +endef
> +
> +define INFOZIP_INSTALL_TARGET_CMDS
> + $(MAKE) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr CC=$(TARGET_CC)
> +endef
Even though the package does not allow to override CFLAGS, I would
prefer if $(TARGET_CONFIGURE_OPTS) was used. It avoids for example the
mistake of forgetting the quotes around $(TARGET_CC). So, something
like:
define INFOZIP_BUILD_CMDS
$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile generic
endef
define INFOZIP_INSTALL_TARGET_CMDS
$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr
endef
Once this is fixed, you get my Acked-by and Tested-by, as I tested this
package.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] infozip: new package
@ 2013-01-11 9:45 Jan Pedersen
2013-01-11 20:25 ` Arnout Vandecappelle
0 siblings, 1 reply; 7+ messages in thread
From: Jan Pedersen @ 2013-01-11 9:45 UTC (permalink / raw)
To: buildroot
This commit adds a package for infozip, compression and file
packaging/archive utility.
Signed-off-by: Jan Pedersen <jp@jp-embedded.com>
---
package/Config.in | 1 +
package/infozip/Config.in | 10 ++++++++++
package/infozip/infozip.mk | 21 +++++++++++++++++++++
3 files changed, 32 insertions(+)
create mode 100644 package/infozip/Config.in
create mode 100644 package/infozip/infozip.mk
diff --git a/package/Config.in b/package/Config.in
index bd1db6b..1c2b228 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -14,6 +14,7 @@ endif
source "package/lzop/Config.in"
source "package/lzma/Config.in"
source "package/xz/Config.in"
+source "package/infozip/Config.in"
endmenu
menu "Debugging, profiling and benchmark"
diff --git a/package/infozip/Config.in b/package/infozip/Config.in
new file mode 100644
index 0000000..1a4b756
--- /dev/null
+++ b/package/infozip/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_INFOZIP
+ bool "infozip"
+ help
+ Zip is a compression and file packaging/archive utility.
+ Although highly compatible both with PKWARE's PKZIP and
+ PKUNZIP utilities for MS-DOS and with Info-ZIP's own UnZip,
+ our primary objectives have been portability and other-than-MSDOS
+ functionality.
+
+ http://infozip.sourceforge.net/Zip.html
diff --git a/package/infozip/infozip.mk b/package/infozip/infozip.mk
new file mode 100644
index 0000000..5258a7a
--- /dev/null
+++ b/package/infozip/infozip.mk
@@ -0,0 +1,21 @@
+#############################################################
+#
+# infozip
+#
+#############################################################
+INFOZIP_VERSION = 30
+INFOZIP_SOURCE = zip$(INFOZIP_VERSION).tgz
+INFOZIP_SITE = ftp://ftp.info-zip.org/pub/infozip/src
+INFOZIP_LICENSE = Info-ZIP
+INFOZIP_LICENSE_FILES = LICENSE
+
+define INFOZIP_BUILD_CMDS
+ $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile generic
+endef
+
+define INFOZIP_INSTALL_TARGET_CMDS
+ $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr
+endef
+
+$(eval $(generic-package))
+
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] infozip: new package
2013-01-11 9:45 Jan Pedersen
@ 2013-01-11 20:25 ` Arnout Vandecappelle
0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2013-01-11 20:25 UTC (permalink / raw)
To: buildroot
On 11/01/13 10:45, Jan Pedersen wrote:
> This commit adds a package for infozip, compression and file
> packaging/archive utility.
>
> Signed-off-by: Jan Pedersen<jp@jp-embedded.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
(as a reminder to Peter)
Two small remarks below.
> ---
> package/Config.in | 1 +
> package/infozip/Config.in | 10 ++++++++++
> package/infozip/infozip.mk | 21 +++++++++++++++++++++
> 3 files changed, 32 insertions(+)
> create mode 100644 package/infozip/Config.in
> create mode 100644 package/infozip/infozip.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index bd1db6b..1c2b228 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -14,6 +14,7 @@ endif
> source "package/lzop/Config.in"
> source "package/lzma/Config.in"
> source "package/xz/Config.in"
> +source "package/infozip/Config.in"
Packages should be sorted alpabetically, so before lzop.
> endmenu
>
> menu "Debugging, profiling and benchmark"
> diff --git a/package/infozip/Config.in b/package/infozip/Config.in
> new file mode 100644
> index 0000000..1a4b756
> --- /dev/null
> +++ b/package/infozip/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_INFOZIP
> + bool "infozip"
> + help
> + Zip is a compression and file packaging/archive utility.
> + Although highly compatible both with PKWARE's PKZIP and
> + PKUNZIP utilities for MS-DOS and with Info-ZIP's own UnZip,
> + our primary objectives have been portability and other-than-MSDOS
> + functionality.
> +
> + http://infozip.sourceforge.net/Zip.html
> diff --git a/package/infozip/infozip.mk b/package/infozip/infozip.mk
> new file mode 100644
> index 0000000..5258a7a
> --- /dev/null
> +++ b/package/infozip/infozip.mk
> @@ -0,0 +1,21 @@
> +#############################################################
> +#
> +# infozip
> +#
> +#############################################################
> +INFOZIP_VERSION = 30
> +INFOZIP_SOURCE = zip$(INFOZIP_VERSION).tgz
> +INFOZIP_SITE = ftp://ftp.info-zip.org/pub/infozip/src
> +INFOZIP_LICENSE = Info-ZIP
> +INFOZIP_LICENSE_FILES = LICENSE
> +
> +define INFOZIP_BUILD_CMDS
> + $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile generic
> +endef
> +
> +define INFOZIP_INSTALL_TARGET_CMDS
> + $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr
> +endef
> +
> +$(eval $(generic-package))
> +
Redundant empty line at end of file.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] infozip: new package
@ 2013-01-14 13:30 Jan Pedersen
2013-01-14 13:32 ` Thomas Petazzoni
2013-01-14 15:54 ` Peter Korsgaard
0 siblings, 2 replies; 7+ messages in thread
From: Jan Pedersen @ 2013-01-14 13:30 UTC (permalink / raw)
To: buildroot
This commit adds a package for infozip, compression and file
packaging/archive utility.
Signed-off-by: Jan Pedersen <jp@jp-embedded.com>
---
package/Config.in | 1 +
package/infozip/Config.in | 10 ++++++++++
package/infozip/infozip.mk | 20 ++++++++++++++++++++
3 files changed, 31 insertions(+)
create mode 100644 package/infozip/Config.in
create mode 100644 package/infozip/infozip.mk
diff --git a/package/Config.in b/package/Config.in
index 4f05665..ad2a742 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -11,6 +11,7 @@ source "package/bzip2/Config.in"
if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
source "package/gzip/Config.in"
endif
+source "package/infozip/Config.in"
source "package/lzop/Config.in"
source "package/lzma/Config.in"
source "package/xz/Config.in"
diff --git a/package/infozip/Config.in b/package/infozip/Config.in
new file mode 100644
index 0000000..1a4b756
--- /dev/null
+++ b/package/infozip/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_INFOZIP
+ bool "infozip"
+ help
+ Zip is a compression and file packaging/archive utility.
+ Although highly compatible both with PKWARE's PKZIP and
+ PKUNZIP utilities for MS-DOS and with Info-ZIP's own UnZip,
+ our primary objectives have been portability and other-than-MSDOS
+ functionality.
+
+ http://infozip.sourceforge.net/Zip.html
diff --git a/package/infozip/infozip.mk b/package/infozip/infozip.mk
new file mode 100644
index 0000000..fd0c15c
--- /dev/null
+++ b/package/infozip/infozip.mk
@@ -0,0 +1,20 @@
+#############################################################
+#
+# infozip
+#
+#############################################################
+INFOZIP_VERSION = 30
+INFOZIP_SOURCE = zip$(INFOZIP_VERSION).tgz
+INFOZIP_SITE = ftp://ftp.info-zip.org/pub/infozip/src
+INFOZIP_LICENSE = Info-ZIP
+INFOZIP_LICENSE_FILES = LICENSE
+
+define INFOZIP_BUILD_CMDS
+ $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile generic
+endef
+
+define INFOZIP_INSTALL_TARGET_CMDS
+ $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr
+endef
+
+$(eval $(generic-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] infozip: new package
2013-01-14 13:30 Jan Pedersen
@ 2013-01-14 13:32 ` Thomas Petazzoni
2013-01-14 15:54 ` Peter Korsgaard
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2013-01-14 13:32 UTC (permalink / raw)
To: buildroot
On Mon, 14 Jan 2013 14:30:00 +0100, Jan Pedersen wrote:
> This commit adds a package for infozip, compression and file
> packaging/archive utility.
>
> Signed-off-by: Jan Pedersen <jp@jp-embedded.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] infozip: new package
2013-01-14 13:30 Jan Pedersen
2013-01-14 13:32 ` Thomas Petazzoni
@ 2013-01-14 15:54 ` Peter Korsgaard
1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2013-01-14 15:54 UTC (permalink / raw)
To: buildroot
>>>>> "Jan" == Jan Pedersen <jp@jp-embedded.com> writes:
Jan> This commit adds a package for infozip, compression and file
Jan> packaging/archive utility.
Jan> Signed-off-by: Jan Pedersen <jp@jp-embedded.com>
Jan> ---
Jan> package/Config.in | 1 +
Jan> package/infozip/Config.in | 10 ++++++++++
Jan> package/infozip/infozip.mk | 20 ++++++++++++++++++++
Jan> 3 files changed, 31 insertions(+)
Jan> create mode 100644 package/infozip/Config.in
Jan> create mode 100644 package/infozip/infozip.mk
Jan> diff --git a/package/Config.in b/package/Config.in
Jan> index 4f05665..ad2a742 100644
Jan> --- a/package/Config.in
Jan> +++ b/package/Config.in
Jan> @@ -11,6 +11,7 @@ source "package/bzip2/Config.in"
Jan> if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
Jan> source "package/gzip/Config.in"
Jan> endif
Jan> +source "package/infozip/Config.in"
Jan> source "package/lzop/Config.in"
Jan> source "package/lzma/Config.in"
Jan> source "package/xz/Config.in"
Jan> diff --git a/package/infozip/Config.in b/package/infozip/Config.in
Jan> new file mode 100644
Jan> index 0000000..1a4b756
Jan> --- /dev/null
Jan> +++ b/package/infozip/Config.in
Jan> @@ -0,0 +1,10 @@
Jan> +config BR2_PACKAGE_INFOZIP
Jan> + bool "infozip"
Jan> + help
Jan> + Zip is a compression and file packaging/archive utility.
Jan> + Although highly compatible both with PKWARE's PKZIP and
Jan> + PKUNZIP utilities for MS-DOS and with Info-ZIP's own UnZip,
Jan> + our primary objectives have been portability and other-than-MSDOS
Jan> + functionality.
Trailing spaces an strange indentation / long line. I've fixed that up
and committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-01-14 15:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 10:41 [Buildroot] [PATCH 1/1] infozip: new package Jan Pedersen
2013-01-10 11:15 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2013-01-11 9:45 Jan Pedersen
2013-01-11 20:25 ` Arnout Vandecappelle
2013-01-14 13:30 Jan Pedersen
2013-01-14 13:32 ` Thomas Petazzoni
2013-01-14 15:54 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox