From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] cairo : bump version
Date: Sun, 13 Jan 2013 15:07:09 +0100 [thread overview]
Message-ID: <20130113150709.76356160@skate> (raw)
In-Reply-To: <1358084194-16226-1-git-send-email-sagaert.johan@skynet.be>
Dear Sagaert Johan,
On Sun, 13 Jan 2013 14:36:34 +0100, Sagaert Johan wrote:
>
> cairo : bump version
> Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
Thanks for all those version bump patches. Unfortunately, the commit
log is wrong: you repeat two times the same thing.
If you put "cairo: bump version" in the first line of your commit log,
then don't put it again, otherwise it appears twice!
And it is also customary to mention the version to which the package is
being bumped in the commit title.
So, your commit logs should be:
===
cairo: bump version to 1.12.8
Signed-off-by: ...
===
If there are more details to be provided:
===
cairo: bump version to 1.12.8
The patch foobar.patch has become useless due to upstream changes. A
new patch barfoo.patch is introduced in order to fix problem blabla.
Signed-off-by: ...
===
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-01-13 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 13:36 [Buildroot] [PATCH 1/1] cairo : bump version Sagaert Johan
2013-01-13 14:07 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-01-13 13:38 Sagaert Johan
2013-01-13 16:24 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130113150709.76356160@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox