[Buildroot] [PATCH 1/1] cairo : bump version

[Buildroot] [PATCH 1/1] cairo : bump version

[Sagaert Johan]

cairo : bump version
Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
---
 package/cairo/cairo.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/cairo/cairo.mk b/package/cairo/cairo.mk
index 6cf910a..bd670d9 100644
--- a/package/cairo/cairo.mk
+++ b/package/cairo/cairo.mk
@@ -3,8 +3,10 @@
 # cairo
 #
 #############################################################
-CAIRO_VERSION = 1.10.2
-CAIRO_SOURCE = cairo-$(CAIRO_VERSION).tar.gz
+CAIRO_VERSION = 1.12.8
+CAIRO_SOURCE = cairo-$(CAIRO_VERSION).tar.xz
+CAIRO_LICENSE = LGPLv2.1+
+CAIRO_LICENSE_FILES = COPYING
 CAIRO_SITE = http://cairographics.org/releases
 CAIRO_INSTALL_STAGING = YES
 
-- 
1.8.0.1

[Buildroot] [PATCH 1/1] cairo : bump version

[Sagaert Johan]

cairo : bump version
Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
---
 package/cairo/cairo.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/cairo/cairo.mk b/package/cairo/cairo.mk
index 6cf910a..bd670d9 100644
--- a/package/cairo/cairo.mk
+++ b/package/cairo/cairo.mk
@@ -3,8 +3,10 @@
 # cairo
 #
 #############################################################
-CAIRO_VERSION = 1.10.2
-CAIRO_SOURCE = cairo-$(CAIRO_VERSION).tar.gz
+CAIRO_VERSION = 1.12.8
+CAIRO_SOURCE = cairo-$(CAIRO_VERSION).tar.xz
+CAIRO_LICENSE = LGPLv2.1+
+CAIRO_LICENSE_FILES = COPYING
 CAIRO_SITE = http://cairographics.org/releases
 CAIRO_INSTALL_STAGING = YES
 
-- 
1.8.0.1

[Buildroot] [PATCH 1/1] cairo : bump version

[Thomas Petazzoni]

Dear Sagaert Johan,

On Sun, 13 Jan 2013 14:36:34 +0100, Sagaert Johan wrote:
> 
> cairo : bump version
> Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>

Thanks for all those version bump patches. Unfortunately, the commit
log is wrong: you repeat two times the same thing.

If you put "cairo: bump version" in the first line of your commit log,
then don't put it again, otherwise it appears twice!

And it is also customary to mention the version to which the package is
being bumped in the commit title.

So, your commit logs should be:

===
cairo: bump version to 1.12.8

Signed-off-by: ...
===

If there are more details to be provided:

===
cairo: bump version to 1.12.8

The patch foobar.patch has become useless due to upstream changes. A
new patch barfoo.patch is introduced in order to fix problem blabla.

Signed-off-by: ...
===

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/1] cairo : bump version

[Peter Korsgaard]

>>>>> "Sagaert" == Sagaert Johan <sagaert.johan@skynet.be> writes:

 Sagaert> cairo : bump version
 Sagaert> Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
 Sagaert> ---
 Sagaert>  package/cairo/cairo.mk | 6 ++++--
 Sagaert>  1 file changed, 4 insertions(+), 2 deletions(-)

 Sagaert> diff --git a/package/cairo/cairo.mk b/package/cairo/cairo.mk
 Sagaert> index 6cf910a..bd670d9 100644
 Sagaert> --- a/package/cairo/cairo.mk
 Sagaert> +++ b/package/cairo/cairo.mk
 Sagaert> @@ -3,8 +3,10 @@
 Sagaert>  # cairo
 Sagaert>  #
 Sagaert>  #############################################################
 Sagaert> -CAIRO_VERSION = 1.10.2
 Sagaert> -CAIRO_SOURCE = cairo-$(CAIRO_VERSION).tar.gz
 Sagaert> +CAIRO_VERSION = 1.12.8
 Sagaert> +CAIRO_SOURCE = cairo-$(CAIRO_VERSION).tar.xz
 Sagaert> +CAIRO_LICENSE = LGPLv2.1+
 Sagaert> +CAIRO_LICENSE_FILES = COPYING

Next to the comments Thomas mentioned about the commit message, it
doesn't actually work here:

>>> cairo 1.12.8 Extracting
xzcat /var/lib/downloads/cairo-1.12.8.tar.xz | tar --strip-components=1 -C /home/peko/source/buildroot/testcairo/build/cairo-1.12.8  -xf -
>>> cairo 1.12.8 Patching package//cairo

Applying cairo-1.10.2-directfb.patch using patch: 
patching file src/cairo-directfb-surface.c
Hunk #1 FAILED at 700.
Hunk #2 FAILED at 928.
Hunk #3 FAILED at 1584.
Hunk #4 FAILED at 1809.
4 out of 4 hunks FAILED -- saving rejects to file src/cairo-directfb-surface.c.rej
Patch failed!  Please fix cairo-1.10.2-directfb.patch!

Please fix and resubmit.

-- 
Bye, Peter Korsgaard