* [Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target
@ 2013-02-12 10:51 Markos Chandras
2013-02-12 11:23 ` Thomas Petazzoni
2013-02-19 11:42 ` Peter Korsgaard
0 siblings, 2 replies; 8+ messages in thread
From: Markos Chandras @ 2013-02-12 10:51 UTC (permalink / raw)
To: buildroot
From: Markos Chandras <markos.chandras@imgtec.com>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
package/vim/vim.mk | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/package/vim/vim.mk b/package/vim/vim.mk
index fa5f8ae..4e273d4 100644
--- a/package/vim/vim.mk
+++ b/package/vim/vim.mk
@@ -36,8 +36,16 @@ define VIM_INSTALL_RUNTIME_CMDS
$(MAKE) DESTDIR=$(TARGET_DIR) installmacros
endef
+define VIM_REMOVE_DOCS
+ find $(TARGET_DIR)/usr/share/vim -type f -name "*.txt" -delete
+endef
+
ifeq ($(BR2_PACKAGE_VIM_RUNTIME),y)
VIM_POST_INSTALL_TARGET_HOOKS += VIM_INSTALL_RUNTIME_CMDS
endif
+ifneq ($(BR2_HAVE_DOCUMENTATION),y)
+VIM_POST_INSTALL_TARGET_HOOKS += VIM_REMOVE_DOCS
+endif
+
$(eval $(autotools-package))
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target
2013-02-12 10:51 [Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target Markos Chandras
@ 2013-02-12 11:23 ` Thomas Petazzoni
2013-02-12 11:59 ` Markos Chandras
2013-02-19 11:42 ` Peter Korsgaard
1 sibling, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2013-02-12 11:23 UTC (permalink / raw)
To: buildroot
Dear Markos Chandras,
On Tue, 12 Feb 2013 10:51:39 +0000, Markos Chandras wrote:
> From: Markos Chandras <markos.chandras@imgtec.com>
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
We often try to keep the define ... endef block within the ifneq
condition, since there is no reason for the VIM_REMOVE_DOCS variable to
be defined if it is useless. But it's not something that has been done
systematically in the entire code base (for example, the
VIM_INSTALL_RUNTIME_CMDS just above your patch, doesn't follow this
rule).
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target
2013-02-12 11:23 ` Thomas Petazzoni
@ 2013-02-12 11:59 ` Markos Chandras
2013-02-12 12:08 ` Thomas Petazzoni
0 siblings, 1 reply; 8+ messages in thread
From: Markos Chandras @ 2013-02-12 11:59 UTC (permalink / raw)
To: buildroot
On 12 February 2013 11:23, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Markos Chandras,
>
> On Tue, 12 Feb 2013 10:51:39 +0000, Markos Chandras wrote:
>> From: Markos Chandras <markos.chandras@imgtec.com>
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> We often try to keep the define ... endef block within the ifneq
> condition, since there is no reason for the VIM_REMOVE_DOCS variable to
> be defined if it is useless. But it's not something that has been done
> systematically in the entire code base (for example, the
> VIM_INSTALL_RUNTIME_CMDS just above your patch, doesn't follow this
> rule).
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
Hi Thomas,
I agree but seeing how the VIM_INSTALL_RUMTIME_CMDS is implemented, I
figured this was the recommended practice.
If you need me to submit a new patch please let me know.
--
Regards,
Markos Chandras
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target
2013-02-12 11:59 ` Markos Chandras
@ 2013-02-12 12:08 ` Thomas Petazzoni
2013-02-19 10:58 ` Markos Chandras
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2013-02-12 12:08 UTC (permalink / raw)
To: buildroot
Dear Markos Chandras,
On Tue, 12 Feb 2013 11:59:16 +0000, Markos Chandras wrote:
> I agree but seeing how the VIM_INSTALL_RUMTIME_CMDS is implemented, I
> figured this was the recommended practice.
> If you need me to submit a new patch please let me know.
For me, the patch is fine as is, since it's a rule we haven't been
enforcing everywhere.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target
2013-02-12 12:08 ` Thomas Petazzoni
@ 2013-02-19 10:58 ` Markos Chandras
0 siblings, 0 replies; 8+ messages in thread
From: Markos Chandras @ 2013-02-19 10:58 UTC (permalink / raw)
To: buildroot
On 12 February 2013 12:08, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Markos Chandras,
>
> On Tue, 12 Feb 2013 11:59:16 +0000, Markos Chandras wrote:
>
>> I agree but seeing how the VIM_INSTALL_RUMTIME_CMDS is implemented, I
>> figured this was the recommended practice.
>> If you need me to submit a new patch please let me know.
>
> For me, the patch is fine as is, since it's a rule we haven't been
> enforcing everywhere.
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
Friendly reminder, just making sure this fix will be included in the
2013.02 release.
--
Regards,
Markos Chandras
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target
2013-02-12 10:51 [Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target Markos Chandras
2013-02-12 11:23 ` Thomas Petazzoni
@ 2013-02-19 11:42 ` Peter Korsgaard
2013-02-19 15:19 ` Peter Korsgaard
1 sibling, 1 reply; 8+ messages in thread
From: Peter Korsgaard @ 2013-02-19 11:42 UTC (permalink / raw)
To: buildroot
>>>>> "Markos" == Markos Chandras <markos.chandras@gmail.com> writes:
Markos> From: Markos Chandras <markos.chandras@imgtec.com>
Markos> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-02-19 15:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-12 10:51 [Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target Markos Chandras
2013-02-12 11:23 ` Thomas Petazzoni
2013-02-12 11:59 ` Markos Chandras
2013-02-12 12:08 ` Thomas Petazzoni
2013-02-19 10:58 ` Markos Chandras
2013-02-19 11:42 ` Peter Korsgaard
2013-02-19 15:19 ` Peter Korsgaard
2013-02-19 15:30 ` Markos Chandras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox