Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/5] Add python3 config directory simlink
Date: Wed, 13 Feb 2013 10:33:19 +0100	[thread overview]
Message-ID: <20130213103319.678c7948@skate> (raw)
In-Reply-To: <1360747237-30048-3-git-send-email-kpa_info@yahoo.fr>

Dear Patrick Gerber,

On Wed, 13 Feb 2013 10:20:34 +0100, Patrick Gerber wrote:
> Add a simlink to alias the python3.3/config-3.3m directory to python3.3/config
> in the staging directory

This description doesn't match what the code is doing. The code creates
a symbolic link in $(HOST_DIR), not $(STAGING_DIR).

Also, this commit log doesn't explain *why* this is needed in the first
place. The commit log only explains what the patch is doing (which we
can easily find out by reading the code), but lacks an explanation of
the underlying reasons.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-02-13  9:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13  9:20 [Buildroot] [PATCH v3 0/5] Python 3, simple, external package support Patrick Gerber
2013-02-13  9:20 ` [Buildroot] [PATCH v3 1/5] Python menu reorganization Patrick Gerber
2013-02-13  9:20 ` [Buildroot] [PATCH v3 2/5] Add python3 config directory simlink Patrick Gerber
2013-02-13  9:33   ` Thomas Petazzoni [this message]
2013-02-13 10:07     ` Patrick
2013-02-13 10:13       ` Thomas Petazzoni
2013-02-13 10:20         ` Patrick
2013-02-13  9:20 ` [Buildroot] [PATCH v3 3/5] Add common declaration to ease the support of both version Patrick Gerber
2013-02-13  9:20 ` [Buildroot] [PATCH v3 4/5] python-bottle: Convert package to be used with python2 or python3 Patrick Gerber
2013-02-13  9:20 ` [Buildroot] [PATCH v3 5/5] python-serial: " Patrick Gerber
2013-02-13  9:40 ` [Buildroot] [PATCH v3 0/5] Python 3, simple, external package support Maxime Ripard
2013-02-13 10:20   ` Patrick
2013-02-13 12:33     ` Patrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130213103319.678c7948@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox