Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick <kpa_info@yahoo.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 0/5] Python 3, simple, external package support
Date: Wed, 13 Feb 2013 11:20:31 +0100	[thread overview]
Message-ID: <511B68EF.2000409@yahoo.fr> (raw)
In-Reply-To: <511B5FA7.9050501@free-electrons.com>

Hi Maxime,

On 02/13/2013 10:40 AM, Maxime Ripard wrote:
> Hi Patrick,
>
> Le 13/02/2013 10:20, Patrick Gerber a ?crit :
>> This patch series refactor python support in buildroot to enable the
>> use of external package with both; python2 and python3. The packages
>> python-bottle and python-serial have been adapted as examples.
>>
>> To support others external package more work is needed as they are
>> based on python setuptools. It's no more supported by python3 and
>> should be replaced by "Distribute". This should be done in another
>> patch series.
>
> I don't get why this python-common directory is needed. If the two
> python are mutually exclusive, why can't we just declare the PYTHON
> variable in their respective package makefiles?

You are right it could be done as suggested.

The Config.in file is
> useless as well, just make a depends on !PYTHON3 in python, and !PYTHON
> in python3, like Thomas suggested.

As  I replied to Thomas this result in strange behaviour of the menu. 
When selecting/deselecting one of the python entry the menu do not 
handle properly the "circular reference" and it's almost unusable.

> Moreover, I'm pretty concerned about the breakage of many
> configurations. You seem to assume here that all external modules can
> build on both python and python3, and I'm really not sure about that.

No. All the package that don't support python3 have in their Config.in a 
line like this: depends on BR2_PACKAGE_PYTHON
The same way potential package that support only python3 could have: 
depends on BR2_PACKAGE_PYTHON3

> Maxime
>

Patrick

  reply	other threads:[~2013-02-13 10:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13  9:20 [Buildroot] [PATCH v3 0/5] Python 3, simple, external package support Patrick Gerber
2013-02-13  9:20 ` [Buildroot] [PATCH v3 1/5] Python menu reorganization Patrick Gerber
2013-02-13  9:20 ` [Buildroot] [PATCH v3 2/5] Add python3 config directory simlink Patrick Gerber
2013-02-13  9:33   ` Thomas Petazzoni
2013-02-13 10:07     ` Patrick
2013-02-13 10:13       ` Thomas Petazzoni
2013-02-13 10:20         ` Patrick
2013-02-13  9:20 ` [Buildroot] [PATCH v3 3/5] Add common declaration to ease the support of both version Patrick Gerber
2013-02-13  9:20 ` [Buildroot] [PATCH v3 4/5] python-bottle: Convert package to be used with python2 or python3 Patrick Gerber
2013-02-13  9:20 ` [Buildroot] [PATCH v3 5/5] python-serial: " Patrick Gerber
2013-02-13  9:40 ` [Buildroot] [PATCH v3 0/5] Python 3, simple, external package support Maxime Ripard
2013-02-13 10:20   ` Patrick [this message]
2013-02-13 12:33     ` Patrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511B68EF.2000409@yahoo.fr \
    --to=kpa_info@yahoo.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox