* [Buildroot] [PATCH 1/1] Added lcms2 package
@ 2013-03-02 18:47 Olivier Schonken
2013-03-03 16:11 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Olivier Schonken @ 2013-03-02 18:47 UTC (permalink / raw)
To: buildroot
Little CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.
Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
---
package/Config.in | 1 +
package/lcms2/Config.in | 12 ++++++++++++
package/lcms2/lcms2.mk | 23 +++++++++++++++++++++++
3 files changed, 36 insertions(+)
create mode 100644 package/lcms2/Config.in
create mode 100644 package/lcms2/lcms2.mk
diff --git a/package/Config.in b/package/Config.in
index 8a02506..ce9c6be 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in"
source "package/gtk2-themes/Config.in"
source "package/imlib2/Config.in"
source "package/jpeg/Config.in"
+source "package/lcms2/Config.in"
source "package/libart/Config.in"
source "package/libdmtx/Config.in"
source "package/libdrm/Config.in"
diff --git a/package/lcms2/Config.in b/package/lcms2/Config.in
new file mode 100644
index 0000000..d648d24
--- /dev/null
+++ b/package/lcms2/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_LCMS2
+ bool "lcms2"
+ help
+ Little Color Management Software
+ Little CMS intends to be an OPEN SOURCE small-footprint color
+ management engine, with special focus on accuracy and performance.
+ It uses the International Color Consortium standard (ICC), which is
+ the modern standard when regarding to color management.
+
+ http://www.littlecms.com/
+
+
diff --git a/package/lcms2/lcms2.mk b/package/lcms2/lcms2.mk
new file mode 100644
index 0000000..be14554
--- /dev/null
+++ b/package/lcms2/lcms2.mk
@@ -0,0 +1,23 @@
+#############################################################
+#
+# lcms2-2.4.tar.gz
+#
+#############################################################
+LCMS2_VERSION = 2.4
+LCMS2_SITE = http://prdownloads.sourceforge.net/LCMS2/LCMS2/
+LCMS2_SOURCE = lcms2-$(LCMS2_VERSION).tar.gz
+LCMS2_INSTALL_STAGING = YES
+LCMS2_LIBTOOL_PATCH = YES
+LCMS2_AUTORECONF = NO
+LCMS2_CONF_OPT =
+
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+ LCMS2_CONF_OPT += --disable-shared
+else
+ LCMS2_CONF_OPT += --enable-shared
+endif
+
+LCMS2_DEPENDENCIES = host-lcms2
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 1/1] Added lcms2 package
2013-03-02 18:47 [Buildroot] [PATCH 1/1] Added lcms2 package Olivier Schonken
@ 2013-03-03 16:11 ` Thomas Petazzoni
2013-03-03 21:43 ` [Buildroot] [PATCHv2] " Olivier Schonken
2013-03-16 12:12 ` [Buildroot] [PATCHv3] " Olivier Schonken
2013-03-16 12:42 ` [Buildroot] [PATCH 1/1] " Olivier Schonken
2 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2013-03-03 16:11 UTC (permalink / raw)
To: buildroot
Dear Olivier Schonken,
Thanks for your contribution! A few comments below.
On Sat, 2 Mar 2013 20:47:27 +0200, Olivier Schonken wrote:
> Little CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.
This should be wrapped at ~80 columns.
> diff --git a/package/lcms2/lcms2.mk b/package/lcms2/lcms2.mk
> new file mode 100644
> index 0000000..be14554
> --- /dev/null
> +++ b/package/lcms2/lcms2.mk
> @@ -0,0 +1,23 @@
> +#############################################################
> +#
> +# lcms2-2.4.tar.gz
Should be just "lcms2"
> +#
> +#############################################################
> +LCMS2_VERSION = 2.4
One line between the comment header and the first variable line.
> +LCMS2_SITE = http://prdownloads.sourceforge.net/LCMS2/LCMS2/
This should use http://downloads.sourceforge.net instead, see other
packages. downloads.sourceforge.net automatically redirects to a
working SourceForge mirror.
> +LCMS2_SOURCE = lcms2-$(LCMS2_VERSION).tar.gz
This is not needed, that's the default.
> +LCMS2_INSTALL_STAGING = YES
> +LCMS2_LIBTOOL_PATCH = YES
This is not needed, that's the default (for LIBTOOL_PATCH).
> +LCMS2_AUTORECONF = NO
This is not needed, that's the default.
> +LCMS2_CONF_OPT =
Not needed.
> +
> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> + LCMS2_CONF_OPT += --disable-shared
> +else
> + LCMS2_CONF_OPT += --enable-shared
> +endif
Not needed, that's already done by the common autotools infrastructure,
see:
http://git.buildroot.net/buildroot/tree/package/pkg-autotools.mk#n112,
where SHARED_STATIC_LIBS_OPTS is defined at
http://git.buildroot.net/buildroot/tree/package/Makefile.in#n321.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCHv2] Added lcms2 package
2013-03-03 16:11 ` Thomas Petazzoni
@ 2013-03-03 21:43 ` Olivier Schonken
2013-03-04 8:22 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Olivier Schonken @ 2013-03-03 21:43 UTC (permalink / raw)
To: buildroot
Little CMS intends to be an OPEN SOURCE small-footprint color management engine,
with special focus on accuracy and performance.
Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
---
package/Config.in | 1 +
package/lcms2/Config.in | 12 ++++++++++++
package/lcms2/lcms2.mk | 13 +++++++++++++
3 files changed, 26 insertions(+)
create mode 100644 package/lcms2/Config.in
create mode 100644 package/lcms2/lcms2.mk
diff --git a/package/Config.in b/package/Config.in
index 646dd68..b88afd0 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in"
source "package/gtk2-themes/Config.in"
source "package/imlib2/Config.in"
source "package/jpeg/Config.in"
+source "package/lcms2/Config.in"
source "package/libart/Config.in"
source "package/libdmtx/Config.in"
source "package/libdrm/Config.in"
diff --git a/package/lcms2/Config.in b/package/lcms2/Config.in
new file mode 100644
index 0000000..d648d24
--- /dev/null
+++ b/package/lcms2/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_LCMS2
+ bool "lcms2"
+ help
+ Little Color Management Software
+ Little CMS intends to be an OPEN SOURCE small-footprint color
+ management engine, with special focus on accuracy and performance.
+ It uses the International Color Consortium standard (ICC), which is
+ the modern standard when regarding to color management.
+
+ http://www.littlecms.com/
+
+
diff --git a/package/lcms2/lcms2.mk b/package/lcms2/lcms2.mk
new file mode 100644
index 0000000..239fcac
--- /dev/null
+++ b/package/lcms2/lcms2.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# lcms2
+#
+#############################################################
+
+LCMS2_VERSION = 2.4
+LCMS2_SITE = http://downloads.sourceforge.net/LCMS2/LCMS2/
+
+LCMS2_DEPENDENCIES = host-lcms2
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCHv2] Added lcms2 package
2013-03-03 21:43 ` [Buildroot] [PATCHv2] " Olivier Schonken
@ 2013-03-04 8:22 ` Thomas Petazzoni
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2013-03-04 8:22 UTC (permalink / raw)
To: buildroot
Dear Olivier Schonken,
On Sun, 3 Mar 2013 23:43:04 +0200, Olivier Schonken wrote:
> Little CMS intends to be an OPEN SOURCE small-footprint color management engine,
> with special focus on accuracy and performance.
>
> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
(visual inspection only).
I have only one very minor nit, that I think doesn't prevent the patch
from being applied.
> diff --git a/package/lcms2/Config.in b/package/lcms2/Config.in
> new file mode 100644
> index 0000000..d648d24
> --- /dev/null
> +++ b/package/lcms2/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_LCMS2
> + bool "lcms2"
> + help
> + Little Color Management Software
> + Little CMS intends to be an OPEN SOURCE small-footprint color
> + management engine, with special focus on accuracy and performance.
> + It uses the International Color Consortium standard (ICC), which is
> + the modern standard when regarding to color management.
> +
> + http://www.littlecms.com/
> +
> +
One two many empty newline.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCHv3] Added lcms2 package
2013-03-02 18:47 [Buildroot] [PATCH 1/1] Added lcms2 package Olivier Schonken
2013-03-03 16:11 ` Thomas Petazzoni
@ 2013-03-16 12:12 ` Olivier Schonken
2013-03-16 12:42 ` [Buildroot] [PATCH 1/1] " Olivier Schonken
2 siblings, 0 replies; 7+ messages in thread
From: Olivier Schonken @ 2013-03-16 12:12 UTC (permalink / raw)
To: buildroot
Little CMS intends to be an OPEN SOURCE small-footprint color management engine,
with special focus on accuracy and performance.
Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
---
Changelog:
Removed excess empty lines from Config.in
Added licensing info to lcms2.mk
package/Config.in | 1 +
package/lcms2/Config.in | 11 +++++++++++
package/lcms2/lcms2.mk | 14 ++++++++++++++
3 files changed, 26 insertions(+)
create mode 100644 package/lcms2/Config.in
create mode 100644 package/lcms2/lcms2.mk
diff --git a/package/Config.in b/package/Config.in
index 21c3ec9..4cf71d6 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in"
source "package/gtk2-themes/Config.in"
source "package/imlib2/Config.in"
source "package/jpeg/Config.in"
+source "package/lcms2/Config.in"
source "package/libart/Config.in"
source "package/libdmtx/Config.in"
source "package/libdrm/Config.in"
diff --git a/package/lcms2/Config.in b/package/lcms2/Config.in
new file mode 100644
index 0000000..33999fa
--- /dev/null
+++ b/package/lcms2/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LCMS2
+ bool "lcms2"
+ help
+ Little Color Management Software
+ Little CMS intends to be an OPEN SOURCE small-footprint color
+ management engine, with special focus on accuracy and performance.
+ It uses the International Color Consortium standard (ICC), which is
+ the modern standard when regarding to color management.
+
+ http://www.littlecms.com/
+
diff --git a/package/lcms2/lcms2.mk b/package/lcms2/lcms2.mk
new file mode 100644
index 0000000..89ba03f
--- /dev/null
+++ b/package/lcms2/lcms2.mk
@@ -0,0 +1,14 @@
+#############################################################
+#
+# lcms2
+#
+#############################################################
+
+LCMS2_VERSION = 2.4
+LCMS2_SITE = http://downloads.sourceforge.net/LCMS2/LCMS2/
+LCMS2_LICENSE = MIT
+LCMS2_LICENSE_FILES = COPYING
+LCMS2_DEPENDENCIES = host-lcms2
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] Added lcms2 package
2013-03-02 18:47 [Buildroot] [PATCH 1/1] Added lcms2 package Olivier Schonken
2013-03-03 16:11 ` Thomas Petazzoni
2013-03-16 12:12 ` [Buildroot] [PATCHv3] " Olivier Schonken
@ 2013-03-16 12:42 ` Olivier Schonken
2013-03-18 20:40 ` Peter Korsgaard
2 siblings, 1 reply; 7+ messages in thread
From: Olivier Schonken @ 2013-03-16 12:42 UTC (permalink / raw)
To: buildroot
Little CMS intends to be an OPEN SOURCE small-footprint color management engine,
with special focus on accuracy and performance.
Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
---
Changelog:
Removed excess empty lines from Config.in
Added licensing info to lcms2.mk
Chaned LCMS2_SITE to correct url
Added options to include support for zlib, jpeg and tiff
Removed dependency on host-lcms2
package/Config.in | 1 +
package/lcms2/Config.in | 11 +++++++++++
package/lcms2/lcms2.mk | 35 +++++++++++++++++++++++++++++++++++
3 files changed, 47 insertions(+)
create mode 100644 package/lcms2/Config.in
create mode 100644 package/lcms2/lcms2.mk
diff --git a/package/Config.in b/package/Config.in
index 21c3ec9..4cf71d6 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in"
source "package/gtk2-themes/Config.in"
source "package/imlib2/Config.in"
source "package/jpeg/Config.in"
+source "package/lcms2/Config.in"
source "package/libart/Config.in"
source "package/libdmtx/Config.in"
source "package/libdrm/Config.in"
diff --git a/package/lcms2/Config.in b/package/lcms2/Config.in
new file mode 100644
index 0000000..33999fa
--- /dev/null
+++ b/package/lcms2/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LCMS2
+ bool "lcms2"
+ help
+ Little Color Management Software
+ Little CMS intends to be an OPEN SOURCE small-footprint color
+ management engine, with special focus on accuracy and performance.
+ It uses the International Color Consortium standard (ICC), which is
+ the modern standard when regarding to color management.
+
+ http://www.littlecms.com/
+
diff --git a/package/lcms2/lcms2.mk b/package/lcms2/lcms2.mk
new file mode 100644
index 0000000..1766bec
--- /dev/null
+++ b/package/lcms2/lcms2.mk
@@ -0,0 +1,35 @@
+#############################################################
+#
+# lcms2
+#
+#############################################################
+
+LCMS2_VERSION = 2.4
+LCMS2_SITE = http://downloads.sourceforge.net/lcms/lcms
+LCMS2_LICENSE = MIT
+LCMS2_LICENSE_FILES = COPYING
+
+LCMS2_CONF_OPT = \
+
+ifeq ($(BR2_PACKAGE_JPEG),y)
+ LCMS2_CONF_OPT += --with-jpeg
+ LCMS2_DEPENDENCIES += jpeg
+else
+ LCMS2_CONF_OPT += --without-jpeg
+endif
+
+ifeq ($(BR2_PACKAGE_TIFF),y)
+ LCMS2_CONF_OPT += --with-tiff
+ LCMS2_DEPENDENCIES += tiff
+else
+ LCMS2_CONF_OPT += --without-tiff
+endif
+
+ifeq ($(BR2_PACKAGE_ZLIB),y)
+ LCMS2_CONF_OPT += --with-zlib
+ LCMS2_DEPENDENCIES += zlib
+else
+ LCMS2_CONF_OPT += --without-zlib
+endif
+
+$(eval $(autotools-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 1/1] Added lcms2 package
2013-03-16 12:42 ` [Buildroot] [PATCH 1/1] " Olivier Schonken
@ 2013-03-18 20:40 ` Peter Korsgaard
0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2013-03-18 20:40 UTC (permalink / raw)
To: buildroot
>>>>> "Olivier" == Olivier Schonken <olivier.schonken@gmail.com> writes:
Olivier> Little CMS intends to be an OPEN SOURCE small-footprint color management engine,
Olivier> with special focus on accuracy and performance.
Olivier> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
Olivier> ---
Olivier> Changelog:
Olivier> Removed excess empty lines from Config.in
Olivier> Added licensing info to lcms2.mk
Olivier> Chaned LCMS2_SITE to correct url
Olivier> Added options to include support for zlib, jpeg and tiff
Olivier> Removed dependency on host-lcms2
Olivier> package/Config.in | 1 +
Olivier> package/lcms2/Config.in | 11 +++++++++++
Olivier> package/lcms2/lcms2.mk | 35 +++++++++++++++++++++++++++++++++++
Olivier> 3 files changed, 47 insertions(+)
Olivier> create mode 100644 package/lcms2/Config.in
Olivier> create mode 100644 package/lcms2/lcms2.mk
Olivier> diff --git a/package/Config.in b/package/Config.in
Olivier> index 21c3ec9..4cf71d6 100644
Olivier> --- a/package/Config.in
Olivier> +++ b/package/Config.in
Olivier> @@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in"
Olivier> source "package/gtk2-themes/Config.in"
Olivier> source "package/imlib2/Config.in"
Olivier> source "package/jpeg/Config.in"
Olivier> +source "package/lcms2/Config.in"
Olivier> source "package/libart/Config.in"
Olivier> source "package/libdmtx/Config.in"
Olivier> source "package/libdrm/Config.in"
Olivier> diff --git a/package/lcms2/Config.in b/package/lcms2/Config.in
Olivier> new file mode 100644
Olivier> index 0000000..33999fa
Olivier> --- /dev/null
Olivier> +++ b/package/lcms2/Config.in
Olivier> @@ -0,0 +1,11 @@
Olivier> +config BR2_PACKAGE_LCMS2
Olivier> + bool "lcms2"
Olivier> + help
Olivier> + Little Color Management Software
Olivier> + Little CMS intends to be an OPEN SOURCE small-footprint color
Olivier> + management engine, with special focus on accuracy and performance.
Olivier> + It uses the International Color Consortium standard (ICC), which is
Olivier> + the modern standard when regarding to color management.
Olivier> +
Olivier> + http://www.littlecms.com/
Olivier> +
You have trailing spaces and an empty line at the end.
Olivier> diff --git a/package/lcms2/lcms2.mk b/package/lcms2/lcms2.mk
Olivier> new file mode 100644
Olivier> index 0000000..1766bec
Olivier> --- /dev/null
Olivier> +++ b/package/lcms2/lcms2.mk
Olivier> @@ -0,0 +1,35 @@
Olivier> +#############################################################
Olivier> +#
Olivier> +# lcms2
Olivier> +#
Olivier> +#############################################################
Olivier> +
Olivier> +LCMS2_VERSION = 2.4
Olivier> +LCMS2_SITE = http://downloads.sourceforge.net/lcms/lcms
Olivier> +LCMS2_LICENSE = MIT
Olivier> +LCMS2_LICENSE_FILES = COPYING
Olivier> +
Olivier> +LCMS2_CONF_OPT = \
Olivier> +
Olivier> +ifeq ($(BR2_PACKAGE_JPEG),y)
Olivier> + LCMS2_CONF_OPT += --with-jpeg
Olivier> + LCMS2_DEPENDENCIES += jpeg
And the same here (multiple places).
Committed with those fixed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-03-18 20:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-02 18:47 [Buildroot] [PATCH 1/1] Added lcms2 package Olivier Schonken
2013-03-03 16:11 ` Thomas Petazzoni
2013-03-03 21:43 ` [Buildroot] [PATCHv2] " Olivier Schonken
2013-03-04 8:22 ` Thomas Petazzoni
2013-03-16 12:12 ` [Buildroot] [PATCHv3] " Olivier Schonken
2013-03-16 12:42 ` [Buildroot] [PATCH 1/1] " Olivier Schonken
2013-03-18 20:40 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox