[Buildroot] [PATCH 1/2 V3] Add bzip2 to host-python when it is selected (aids in compiling nodejs)

[Buildroot] [PATCH 1/2 V3] Add bzip2 to host-python when it is selected (aids in compiling nodejs)

[Daniel Price]

Based off of patches posted by (and Signed-off-by): Jonathan Liu <net147@gmail.com>

Signed-off-by: Daniel Price <daniel.price@gmail.com>
---
 package/python/python.mk |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/package/python/python.mk b/package/python/python.mk
index 71591b7..91496e1 100644
--- a/package/python/python.mk
+++ b/package/python/python.mk
@@ -30,7 +30,6 @@ HOST_PYTHON_CONF_OPT += 	\
 	--disable-gdbm		\
 	--disable-bsddb		\
 	--disable-test-modules	\
-	--disable-bz2		\
 	--disable-ssl
 
 HOST_PYTHON_MAKE_ENV = \
@@ -49,7 +48,7 @@ HOST_PYTHON_MAKE = $(MAKE1)
 
 PYTHON_DEPENDENCIES  = host-python libffi
 
-HOST_PYTHON_DEPENDENCIES = host-expat host-zlib
+HOST_PYTHON_DEPENDENCIES = host-expat host-zlib host-bzip2
 
 PYTHON_INSTALL_STAGING = YES
 
-- 
1.7.6.5

[Buildroot] [PATCH 1/2 V3] Add bzip2 to host-python when it is selected (aids in compiling nodejs)

[Thomas Petazzoni]

Dear Daniel Price,

On Thu, 28 Feb 2013 17:05:40 -0800, Daniel Price wrote:
> Based off of patches posted by (and Signed-off-by): Jonathan Liu <net147@gmail.com>
> 
> Signed-off-by: Daniel Price <daniel.price@gmail.com>

If you add the attached patch to the nodejs package, then we no longer
need the bz2 module in Python, at least not in the default nodejs build.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nodejs-remove-python-bz2-dependency.patch
Type: text/x-patch
Size: 824 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130304/ba1efdd2/attachment.bin>

[Buildroot] [PATCH 1/2 V3] Add bzip2 to host-python when it is selected (aids in compiling nodejs)

[Daniel Price]

Ok.  I'm agnostic about how we solve this.  I can incorporate your
patch.  So do I append your "Signed-off-by" to mine?   I don't want to
do it the wrong way.

        -dp

On Mon, Mar 4, 2013 at 12:52 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Daniel Price,
>
> On Thu, 28 Feb 2013 17:05:40 -0800, Daniel Price wrote:
>> Based off of patches posted by (and Signed-off-by): Jonathan Liu <net147@gmail.com>
>>
>> Signed-off-by: Daniel Price <daniel.price@gmail.com>
>
> If you add the attached patch to the nodejs package, then we no longer
> need the bz2 module in Python, at least not in the default nodejs build.
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com



--
Daniel.Price at gmail.com; Twitter: @danielbprice

[Buildroot] [PATCH 1/2 V3] Add bzip2 to host-python when it is selected (aids in compiling nodejs)

[Thomas Petazzoni]

Dear Daniel Price,

On Mon, 4 Mar 2013 17:07:33 -0800, Daniel Price wrote:

> Ok.  I'm agnostic about how we solve this.  I can incorporate your
> patch.  So do I append your "Signed-off-by" to mine?   I don't want to
> do it the wrong way.

Yes, you can keep my Signed-off-by inside the
nodejs-remove-python-bz2-dependency.patch file, and add your own after
mine. No need to append my Signed-off-by on the global nodejs patch,
though.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com