Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] rpi-firmware: Fixup config.txt
Date: Mon, 29 Apr 2013 22:48:59 +0200	[thread overview]
Message-ID: <20130429224859.484e28f9@skate> (raw)
In-Reply-To: <1358087034-2706-1-git-send-email-maxime.hadjinlian@gmail.com>

Dear Maxime Hadjinlian,

On Sun, 13 Jan 2013 15:23:53 +0100, Maxime Hadjinlian wrote:
> The default name of the kernel binary for the RaspberryPi is kernel.img, it's a
> only a zImage kernel renamed.
> Since Buildroot will build a zImage, the default config uses that should use it
> instead of forcing the user to rename a file.
> 
> Also, remove the cmdline argument rootfstype, as ext4 is a builtin driver,
> there is no need to specify it on the cmdline.

I don't think this justification is correct. If ext4 is a module, then
rootfstype=ext4 doesn't make it work better. Specifying rootfstype=
tells the kernel what is the root filesystem, so that it doesn't have
to test the different available filesystem drivers.

I'm ok with the change, but I think the commit log is not correct.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2013-04-29 20:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 14:23 [Buildroot] [PATCH 1/2] rpi-firmware: Fixup config.txt Maxime Hadjinlian
2013-01-13 14:23 ` [Buildroot] [PATCH 2/2] configs: add RaspberryPi defconfig Maxime Hadjinlian
2013-01-13 16:17   ` Samuel Martin
2013-03-22 12:06     ` Maxime Hadjinlian
2013-03-22 12:58   ` Thomas Petazzoni
2013-03-22 23:04     ` [Buildroot] [PATCH] " Maxime Hadjinlian
2013-03-25  4:33   ` [Buildroot] [PATCH 2/2] " Vivien Didelot
2013-03-22 12:05 ` [Buildroot] [PATCH 1/2] rpi-firmware: Fixup config.txt Maxime Hadjinlian
2013-04-29  8:31   ` Alexey Brodkin
2013-04-29 20:23     ` Arnout Vandecappelle
2013-04-29 20:48 ` Thomas Petazzoni [this message]
2013-04-29 22:00   ` Maxime Hadjinlian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130429224859.484e28f9@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox