Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] rpi-firmware: Fixup config.txt
Date: Mon, 29 Apr 2013 12:31:39 +0400	[thread overview]
Message-ID: <517E2FEB.2080009@synopsys.com> (raw)
In-Reply-To: <CAGduivyOfFJ=mu8Y-_O_saXTBXPsn58N8YCZ6RZDFAGaskhWcg@mail.gmail.com>

On 03/22/2013 04:05 PM, Maxime Hadjinlian wrote:
> ping ?

Seems like this patch has never been even reviewed since last January.
Even though it helps to use buildroot-built projects on RPi.

Is there a chance to get it reviewed/accepted?

Or is it supposed to be re-sent together with modifications in "[PATCH 
2/2] configs: add RaspberryPi defconfig"?

-Alexey

> On Sun, Jan 13, 2013 at 3:23 PM, Maxime Hadjinlian
> <maxime.hadjinlian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> The default name of the kernel binary for the RaspberryPi is kernel.img, it's a
>> only a zImage kernel renamed.
>> Since Buildroot will build a zImage, the default config uses that should use it
>> instead of forcing the user to rename a file.
>>
>> Also, remove the cmdline argument rootfstype, as ext4 is a builtin driver,
>> there is no need to specify it on the cmdline.
>>
>> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>   package/rpi-firmware/config.txt |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/rpi-firmware/config.txt b/package/rpi-firmware/config.txt
>> index 2cabd68..a818762 100644
>> --- a/package/rpi-firmware/config.txt
>> +++ b/package/rpi-firmware/config.txt
>> @@ -6,9 +6,10 @@
>>
>>   arm_freq=700
>>   core_freq=250
>> +kernel=zImage
>>   disable_overscan=1
>>   gpu_mem_256=100
>>   gpu_mem_512=100
>>   sdram_freq=400
>>   over_voltage=0
>> -cmdline="dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
>> +cmdline="dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootwait"
>> --
>> 1.7.10.4
>>

  reply	other threads:[~2013-04-29  8:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 14:23 [Buildroot] [PATCH 1/2] rpi-firmware: Fixup config.txt Maxime Hadjinlian
2013-01-13 14:23 ` [Buildroot] [PATCH 2/2] configs: add RaspberryPi defconfig Maxime Hadjinlian
2013-01-13 16:17   ` Samuel Martin
2013-03-22 12:06     ` Maxime Hadjinlian
2013-03-22 12:58   ` Thomas Petazzoni
2013-03-22 23:04     ` [Buildroot] [PATCH] " Maxime Hadjinlian
2013-03-25  4:33   ` [Buildroot] [PATCH 2/2] " Vivien Didelot
2013-03-22 12:05 ` [Buildroot] [PATCH 1/2] rpi-firmware: Fixup config.txt Maxime Hadjinlian
2013-04-29  8:31   ` Alexey Brodkin [this message]
2013-04-29 20:23     ` Arnout Vandecappelle
2013-04-29 20:48 ` Thomas Petazzoni
2013-04-29 22:00   ` Maxime Hadjinlian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517E2FEB.2080009@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox