[Buildroot] [PATCH v2 0/3] barebox new option and new boards

[Buildroot] [PATCH v2 0/3] barebox new option and new boards

[Fabio Porcedda]

Hi all,
this patch set is for adding to barebox a custom version option
and use this new option to add suppport for two new boards.

v2:
  - Telit EVK-PRO3: use barebox custom version option

Best regards
Fabio Porcedda (3):
  barebox: add custom version option
  configs: add defconfig for Telit EVK-PRO3
  configs: add defconfig for Atmel AT91SAM9260-EK Nand Flash Boot

 .../linux-ARM-at91-enable-nand-ubifs-boot.patch    |  44 ++++
 ...04.0-0001-watchdog-add-keep-alive-support.patch |  88 ++++++++
 ...02-watchdog-add-at91sam9-watchdog-support.patch | 228 +++++++++++++++++++++
 ...0003-at91sam9260-9g20-add-wathdog-support.patch |  40 ++++
 ...0004-at91sam9260-9g20-fix-wathdog-support.patch |  26 +++
 ...13.04.0-0005-watchdog-enable-for-evk-pro3.patch |  26 +++
 ...t91-at91_dt_defconfig-update-for-evk-pro3.patch |  44 ++++
 board/telit/evk-pro3/readme.txt                    |  28 +++
 boot/barebox/Config.in                             |  26 ++-
 configs/at91sam9260eknf_defconfig                  |  15 ++
 configs/telit_evk_pro3_defconfig                   |  16 ++
 11 files changed, 567 insertions(+), 14 deletions(-)
 create mode 100644 board/atmel/at91sam9260ek/linux-ARM-at91-enable-nand-ubifs-boot.patch
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0001-watchdog-add-keep-alive-support.patch
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0002-watchdog-add-at91sam9-watchdog-support.patch
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0003-at91sam9260-9g20-add-wathdog-support.patch
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0004-at91sam9260-9g20-fix-wathdog-support.patch
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0005-watchdog-enable-for-evk-pro3.patch
 create mode 100644 board/telit/evk-pro3/linux-0001-ARM-at91-at91_dt_defconfig-update-for-evk-pro3.patch
 create mode 100644 board/telit/evk-pro3/readme.txt
 create mode 100644 configs/at91sam9260eknf_defconfig
 create mode 100644 configs/telit_evk_pro3_defconfig

-- 
1.8.1.4

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Fabio Porcedda]

Add custom version option as used in the linux kernel.
This way we can easily specify newer and older version.
Remove the list of the older versions because is obsoleted
by the new custom version option that is more flexible.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 boot/barebox/Config.in | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/boot/barebox/Config.in b/boot/barebox/Config.in
index 581cc52..af97be7 100644
--- a/boot/barebox/Config.in
+++ b/boot/barebox/Config.in
@@ -12,18 +12,14 @@ choice
 	help
 	  Select the specific Barebox version you want to use
 
-config BR2_TARGET_BAREBOX_2013_01
-	bool "2013.01.0"
-
-config BR2_TARGET_BAREBOX_2013_02
-	bool "2013.02.0"
-
-config BR2_TARGET_BAREBOX_2013_03
-	bool "2013.03.0"
-
-config BR2_TARGET_BAREBOX_2013_04
+config BR2_TARGET_BAREBOX_LATEST_VERSION
 	bool "2013.04.0"
 
+config BR2_TARGET_BAREBOX_CUSTOM_VERSION
+	bool "Custom version"
+	help
+	  This option allows to use a specific official versions
+
 config BR2_TARGET_BAREBOX_CUSTOM_TARBALL
 	bool "Custom tarball"
 
@@ -32,6 +28,10 @@ config BR2_TARGET_BAREBOX_CUSTOM_GIT
 
 endchoice
 
+config BR2_TARGET_BAREBOX_CUSTOM_VERSION_VALUE
+	string "Barebox version"
+	depends on BR2_TARGET_BAREBOX_CUSTOM_VERSION
+
 if BR2_TARGET_BAREBOX_CUSTOM_TARBALL
 
 config BR2_TARGET_BAREBOX_CUSTOM_TARBALL_LOCATION
@@ -41,10 +41,8 @@ endif
 
 config BR2_TARGET_BAREBOX_VERSION
 	string
-	default "2013.01.0"	if BR2_TARGET_BAREBOX_2013_01
-	default "2013.02.0"	if BR2_TARGET_BAREBOX_2013_02
-	default "2013.03.0"	if BR2_TARGET_BAREBOX_2013_03
-	default "2013.04.0"	if BR2_TARGET_BAREBOX_2013_04
+	default "2013.04.0"	if BR2_TARGET_BAREBOX_LATEST_VERSION
+	default $BR2_TARGET_BAREBOX_CUSTOM_VERSION_VALUE if BR2_TARGET_BAREBOX_CUSTOM_VERSION
 	default "custom"	if BR2_TARGET_BAREBOX_CUSTOM_TARBALL
 	default $BR2_TARGET_BAREBOX_CUSTOM_GIT_VERSION if BR2_TARGET_BAREBOX_CUSTOM_GIT
 
-- 
1.8.1.4

[Buildroot] [PATCH v2 2/3] configs: add defconfig for Telit EVK-PRO3

[Fabio Porcedda]

For more info, please find board/telit/evk-pro3/readme.txt

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 ...04.0-0001-watchdog-add-keep-alive-support.patch |  88 ++++++++
 ...02-watchdog-add-at91sam9-watchdog-support.patch | 228 +++++++++++++++++++++
 ...0003-at91sam9260-9g20-add-wathdog-support.patch |  40 ++++
 ...0004-at91sam9260-9g20-fix-wathdog-support.patch |  26 +++
 ...13.04.0-0005-watchdog-enable-for-evk-pro3.patch |  26 +++
 ...t91-at91_dt_defconfig-update-for-evk-pro3.patch |  44 ++++
 board/telit/evk-pro3/readme.txt                    |  28 +++
 configs/telit_evk_pro3_defconfig                   |  16 ++
 8 files changed, 496 insertions(+)
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0001-watchdog-add-keep-alive-support.patch
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0002-watchdog-add-at91sam9-watchdog-support.patch
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0003-at91sam9260-9g20-add-wathdog-support.patch
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0004-at91sam9260-9g20-fix-wathdog-support.patch
 create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0005-watchdog-enable-for-evk-pro3.patch
 create mode 100644 board/telit/evk-pro3/linux-0001-ARM-at91-at91_dt_defconfig-update-for-evk-pro3.patch
 create mode 100644 board/telit/evk-pro3/readme.txt
 create mode 100644 configs/telit_evk_pro3_defconfig

diff --git a/board/telit/evk-pro3/barebox-2013.04.0-0001-watchdog-add-keep-alive-support.patch b/board/telit/evk-pro3/barebox-2013.04.0-0001-watchdog-add-keep-alive-support.patch
new file mode 100644
index 0000000..1551546
--- /dev/null
+++ b/board/telit/evk-pro3/barebox-2013.04.0-0001-watchdog-add-keep-alive-support.patch
@@ -0,0 +1,88 @@
+From b5e57a9f158a293b1151638336478af8a5aad0f0 Mon Sep 17 00:00:00 2001
+From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
+Date: Wed, 14 Nov 2012 19:16:35 +0800
+Subject: [PATCH 1/5] watchdog: add keep alive support
+
+this will allow to ping the watchdog via poller
+
+Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
+---
+ drivers/watchdog/Kconfig   |  1 +
+ drivers/watchdog/wd_core.c | 21 +++++++++++++++++++++
+ include/watchdog.h         |  2 ++
+ 3 files changed, 24 insertions(+)
+
+diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
+index 2e2900c..0b4dc84 100644
+--- a/drivers/watchdog/Kconfig
++++ b/drivers/watchdog/Kconfig
+@@ -4,6 +4,7 @@ config WATCHDOG_IMX_RESET_SOURCE
+ 
+ menuconfig WATCHDOG
+ 	bool "Watchdog support"
++	select GENERIC_POLLER
+ 	help
+ 	  Many platforms support a watchdog to keep track of a working machine.
+ 	  This framework provides routines to handle these watchdogs.
+diff --git a/drivers/watchdog/wd_core.c b/drivers/watchdog/wd_core.c
+index 3d0cfc6..a1b9e28 100644
+--- a/drivers/watchdog/wd_core.c
++++ b/drivers/watchdog/wd_core.c
+@@ -17,18 +17,39 @@
+ #include <errno.h>
+ #include <linux/ctype.h>
+ #include <watchdog.h>
++#include <poller.h>
+ 
+ /*
+  * Note: this simple framework supports one watchdog only.
+  */
+ static struct watchdog *watchdog;
+ 
++static void watchdog_poller_func(struct poller_struct *poller)
++{
++	watchdog->keep_alive(watchdog);
++}
++
++static struct poller_struct watchdog_poller = {
++	.func = watchdog_poller_func,
++};
++
+ int watchdog_register(struct watchdog *wd)
+ {
+ 	if (watchdog != NULL)
+ 		return -EBUSY;
+ 
+ 	watchdog = wd;
++
++	if (watchdog->keep_alive) {
++		int ret;
++
++		ret = poller_register(&watchdog_poller);
++		if (ret) {
++			watchdog = NULL;
++			return ret;
++		}
++	}
++
+ 	return 0;
+ }
+ EXPORT_SYMBOL(watchdog_register);
+diff --git a/include/watchdog.h b/include/watchdog.h
+index 3e2d08e..d5ecf2f 100644
+--- a/include/watchdog.h
++++ b/include/watchdog.h
+@@ -13,8 +13,10 @@
+ #ifndef INCLUDE_WATCHDOG_H
+ # define INCLUDE_WATCHDOG_H
+ 
++
+ struct watchdog {
+ 	int (*set_timeout)(struct watchdog *, unsigned);
++	void (*keep_alive)(struct watchdog *);
+ };
+ 
+ int watchdog_register(struct watchdog *);
+-- 
+1.8.1.4
+
diff --git a/board/telit/evk-pro3/barebox-2013.04.0-0002-watchdog-add-at91sam9-watchdog-support.patch b/board/telit/evk-pro3/barebox-2013.04.0-0002-watchdog-add-at91sam9-watchdog-support.patch
new file mode 100644
index 0000000..1ca8769
--- /dev/null
+++ b/board/telit/evk-pro3/barebox-2013.04.0-0002-watchdog-add-at91sam9-watchdog-support.patch
@@ -0,0 +1,228 @@
+From e1d54ffb987c346c45c20968be34c50c62a91c07 Mon Sep 17 00:00:00 2001
+From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
+Date: Wed, 14 Nov 2012 19:17:47 +0800
+Subject: [PATCH 2/5] watchdog: add at91sam9 watchdog support
+
+with keep alive support
+
+Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
+---
+ drivers/watchdog/Kconfig        |   7 +++
+ drivers/watchdog/Makefile       |   1 +
+ drivers/watchdog/at91sam9_wdt.c | 131 ++++++++++++++++++++++++++++++++++++++++
+ drivers/watchdog/at91sam9_wdt.h |  38 ++++++++++++
+ 4 files changed, 177 insertions(+)
+ create mode 100644 drivers/watchdog/at91sam9_wdt.c
+ create mode 100644 drivers/watchdog/at91sam9_wdt.h
+
+diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
+index 0b4dc84..98a21d7 100644
+--- a/drivers/watchdog/Kconfig
++++ b/drivers/watchdog/Kconfig
+@@ -11,6 +11,13 @@ menuconfig WATCHDOG
+ 
+ if WATCHDOG
+ 
++config WATCHDOG_AT91SAM9X
++	tristate "AT91SAM9X / AT91CAP9 watchdog"
++	depends on ARCH_AT91
++	help
++	  Watchdog timer embedded into AT91SAM9X and AT91CAP9 chips. This will
++	  reboot your system when the timeout is reached.
++
+ config WATCHDOG_MXS28
+ 	bool "i.MX28"
+ 	depends on ARCH_IMX28
+diff --git a/drivers/watchdog/Makefile b/drivers/watchdog/Makefile
+index f522b88..3d15d52 100644
+--- a/drivers/watchdog/Makefile
++++ b/drivers/watchdog/Makefile
+@@ -1,3 +1,4 @@
+ obj-$(CONFIG_WATCHDOG) += wd_core.o
++obj-$(CONFIG_WATCHDOG_AT91SAM9X) += at91sam9_wdt.o
+ obj-$(CONFIG_WATCHDOG_MXS28) += im28wd.o
+ obj-$(CONFIG_WATCHDOG_IMX_RESET_SOURCE) += imxwd.o
+diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
+new file mode 100644
+index 0000000..203d83a
+--- /dev/null
++++ b/drivers/watchdog/at91sam9_wdt.c
+@@ -0,0 +1,131 @@
++/*
++ * (c) 2012 Juergen Beisert <kernel@pengutronix.de>
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU General Public License as published by
++ * the Free Software Foundation; either version 2 of the License, or
++ * (at your option) any later version.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU General Public License for more details.
++ *
++ * Note: this driver works for the i.MX28 SoC. It might work for the
++ * i.MX23 Soc as well, but is not tested yet.
++ */
++
++#include <common.h>
++#include <init.h>
++#include <io.h>
++#include <errno.h>
++#include <malloc.h>
++#include <watchdog.h>
++
++#include "at91sam9_wdt.h"
++
++struct at91sam9_wdt {
++	struct watchdog wdt;
++	void __iomem *base;
++};
++
++#define to_at91sam9_wdt(h) container_of(h, struct at91sam9_wdt, wdt)
++
++#define wdt_read(at91wdt, field) \
++	__raw_readl(at91wdt->base + field)
++#define wdt_write(at91wdt, field, val) \
++	__raw_writel((val), at91wdt->base + field)
++
++static void at91sam9_wdt_keep_alive(struct watchdog *wdt)
++{
++	struct at91sam9_wdt *at91wdt = to_at91sam9_wdt(wdt);
++
++	wdt_write(at91wdt, AT91_WDT_CR, AT91_WDT_KEY | AT91_WDT_WDRSTT);
++}
++
++static int at91sam9_wdt_settimeout(struct watchdog *wdt, unsigned int timeout)
++{
++	struct at91sam9_wdt *at91wdt = to_at91sam9_wdt(wdt);
++	unsigned int reg;
++	unsigned int mr;
++
++	/* Check if disabled */
++	mr = wdt_read(at91wdt, AT91_WDT_MR);
++	if (mr & AT91_WDT_WDDIS) {
++		pr_err("sorry, watchdog is disabled\n");
++		return -EIO;
++	}
++
++	if (!timeout) {
++		wdt_write(at91wdt, AT91_WDT_MR, AT91_WDT_WDDIS);
++		return 0;
++	}
++
++	/*
++	 * All counting occurs at SLOW_CLOCK / 128 = 256 Hz
++	 *
++	 * Since WDV is a 12-bit counter, the maximum period is
++	 * 4096 / 256 = 16 seconds.
++	 */
++	reg = AT91_WDT_WDRSTEN	/* causes watchdog reset */
++		/* | AT91_WDT_WDRPROC	causes processor reset only */
++		| AT91_WDT_WDDBGHLT	/* disabled in debug mode */
++		| AT91_WDT_WDD		/* restart at any time */
++		| (timeout & AT91_WDT_WDV);  /* timer value */
++	wdt_write(at91wdt, AT91_WDT_MR, reg);
++
++	return 0;
++}
++
++static int at91sam9_wdt_probe(struct device_d *dev)
++{
++	struct at91sam9_wdt *priv;
++	struct watchdog *wdt;
++	int ret;
++	unsigned int mr;
++
++	priv = xzalloc(sizeof(struct at91sam9_wdt));
++	priv->base = dev_request_mem_region(dev, 0);
++	wdt = &priv->wdt;
++
++	wdt->set_timeout = at91sam9_wdt_settimeout;
++	wdt->keep_alive = at91sam9_wdt_keep_alive;
++
++	/* Check if disabled */
++	mr = wdt_read(priv, AT91_WDT_MR);
++	if (mr & AT91_WDT_WDDIS) {
++		dev_err(dev, "sorry, watchdog is disabled\n");
++		ret = -EIO;
++		goto err;
++	}
++
++	ret = watchdog_register(wdt);
++	if (ret != 0)
++		goto err;
++
++	dev->priv = priv;
++	return 0;
++
++err:
++	free(priv);
++	return ret;
++}
++
++static void at91sam9_wdt_remove(struct device_d *dev)
++{
++	struct at91sam9_wdt *priv= dev->priv;
++	watchdog_deregister(&priv->wdt);
++	free(priv);
++}
++
++static struct driver_d at91sam9_wdt_driver = {
++	.name	= "at91sam9_wdt",
++	.probe	= at91sam9_wdt_probe,
++	.remove = at91sam9_wdt_remove,
++};
++
++static int at91sam9_wdt_init(void)
++{
++	return platform_driver_register(&at91sam9_wdt_driver);
++}
++coredevice_initcall(at91sam9_wdt_init);
+diff --git a/drivers/watchdog/at91sam9_wdt.h b/drivers/watchdog/at91sam9_wdt.h
+new file mode 100644
+index 0000000..2b68c1a
+--- /dev/null
++++ b/drivers/watchdog/at91sam9_wdt.h
+@@ -0,0 +1,38 @@
++/*
++ * drivers/watchdog/at91sam9_wdt.h
++ *
++ * Copyright (C) 2007 Andrew Victor
++ * Copyright (C) 2007 Atmel Corporation.
++ *
++ * Watchdog Timer (WDT) - System peripherals regsters.
++ * Based on AT91SAM9261 datasheet revision D.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU General Public License as published by
++ * the Free Software Foundation; either version 2 of the License, or
++ * (at your option) any later version.
++ */
++
++#ifndef AT91_WDT_H
++#define AT91_WDT_H
++
++#define AT91_WDT_CR		0x00			/* Watchdog Control Register */
++#define		AT91_WDT_WDRSTT		(1    << 0)		/* Restart */
++#define		AT91_WDT_KEY		(0xa5 << 24)		/* KEY Password */
++
++#define AT91_WDT_MR		0x04			/* Watchdog Mode Register */
++#define		AT91_WDT_WDV		(0xfff << 0)		/* Counter Value */
++#define		AT91_WDT_WDFIEN		(1     << 12)		/* Fault Interrupt Enable */
++#define		AT91_WDT_WDRSTEN	(1     << 13)		/* Reset Processor */
++#define		AT91_WDT_WDRPROC	(1     << 14)		/* Timer Restart */
++#define		AT91_WDT_WDDIS		(1     << 15)		/* Watchdog Disable */
++#define		AT91_WDT_WDD		(0xfff << 16)		/* Delta Value */
++#define		AT91_WDT_WDDBGHLT	(1     << 28)		/* Debug Halt */
++#define		AT91_WDT_WDIDLEHLT	(1     << 29)		/* Idle Halt */
++
++#define AT91_WDT_SR		0x08			/* Watchdog Status Register */
++#define		AT91_WDT_WDUNF		(1 << 0)		/* Watchdog Underflow */
++#define		AT91_WDT_WDERR		(1 << 1)		/* Watchdog Error */
++
++
++#endif
+-- 
+1.8.1.4
+
diff --git a/board/telit/evk-pro3/barebox-2013.04.0-0003-at91sam9260-9g20-add-wathdog-support.patch b/board/telit/evk-pro3/barebox-2013.04.0-0003-at91sam9260-9g20-add-wathdog-support.patch
new file mode 100644
index 0000000..bf97200
--- /dev/null
+++ b/board/telit/evk-pro3/barebox-2013.04.0-0003-at91sam9260-9g20-add-wathdog-support.patch
@@ -0,0 +1,40 @@
+From 3338bcb05479f1149420d4a0ea3904cb9e42eef5 Mon Sep 17 00:00:00 2001
+From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
+Date: Wed, 14 Nov 2012 19:18:22 +0800
+Subject: [PATCH 3/5] at91sam9260/9g20: add wathdog support
+
+Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
+---
+ arch/arm/mach-at91/at91sam9260_devices.c | 12 ++++++++++++
+ 1 file changed, 12 insertions(+)
+
+diff --git a/arch/arm/mach-at91/at91sam9260_devices.c b/arch/arm/mach-at91/at91sam9260_devices.c
+index 1c375ee..5885f91 100644
+--- a/arch/arm/mach-at91/at91sam9260_devices.c
++++ b/arch/arm/mach-at91/at91sam9260_devices.c
+@@ -10,6 +10,7 @@
+  *
+  */
+ #include <common.h>
++#include <init.h>
+ #include <sizes.h>
+ #include <asm/armlinux.h>
+ #include <asm/hardware.h>
+@@ -397,3 +398,14 @@ void at91_add_device_mci(short mmc_id, struct atmel_mci_platform_data *data)
+ #else
+ void at91_add_device_mci(short mmc_id, struct atmel_mci_platform_data *data) {}
+ #endif
++
++#ifdef CONFIG_WATCHDOG_AT91SAM9X
++static int at91_add_device_watchdog(void)
++{
++	add_generic_device("at91sam9_wdt", DEVICE_ID_SINGLE, NULL,
++		AT91_WDT + AT91_BASE_SYS, 16, IORESOURCE_MEM, NULL);
++
++	return 0;
++}
++coredevice_initcall(at91_add_device_watchdog);
++#endif
+-- 
+1.8.1.4
+
diff --git a/board/telit/evk-pro3/barebox-2013.04.0-0004-at91sam9260-9g20-fix-wathdog-support.patch b/board/telit/evk-pro3/barebox-2013.04.0-0004-at91sam9260-9g20-fix-wathdog-support.patch
new file mode 100644
index 0000000..cdfd026
--- /dev/null
+++ b/board/telit/evk-pro3/barebox-2013.04.0-0004-at91sam9260-9g20-fix-wathdog-support.patch
@@ -0,0 +1,26 @@
+From e03bf0e3ad24898019b89eb9a6935d159c60268f Mon Sep 17 00:00:00 2001
+From: Fabio Porcedda <fabio.porcedda@gmail.com>
+Date: Thu, 17 Jan 2013 11:32:35 +0100
+Subject: [PATCH 4/5] at91sam9260/9g20: fix wathdog support
+
+Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
+---
+ arch/arm/mach-at91/at91sam9260_devices.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/arch/arm/mach-at91/at91sam9260_devices.c b/arch/arm/mach-at91/at91sam9260_devices.c
+index 5885f91..df675d2 100644
+--- a/arch/arm/mach-at91/at91sam9260_devices.c
++++ b/arch/arm/mach-at91/at91sam9260_devices.c
+@@ -403,7 +403,7 @@ void at91_add_device_mci(short mmc_id, struct atmel_mci_platform_data *data) {}
+ static int at91_add_device_watchdog(void)
+ {
+ 	add_generic_device("at91sam9_wdt", DEVICE_ID_SINGLE, NULL,
+-		AT91_WDT + AT91_BASE_SYS, 16, IORESOURCE_MEM, NULL);
++		AT91_BASE_WDT, 16, IORESOURCE_MEM, NULL);
+ 
+ 	return 0;
+ }
+-- 
+1.8.1.4
+
diff --git a/board/telit/evk-pro3/barebox-2013.04.0-0005-watchdog-enable-for-evk-pro3.patch b/board/telit/evk-pro3/barebox-2013.04.0-0005-watchdog-enable-for-evk-pro3.patch
new file mode 100644
index 0000000..837e8c6
--- /dev/null
+++ b/board/telit/evk-pro3/barebox-2013.04.0-0005-watchdog-enable-for-evk-pro3.patch
@@ -0,0 +1,26 @@
+From 98c96ea36a4b3bb9b92dde849db5e8d6918b5168 Mon Sep 17 00:00:00 2001
+From: Fabio Porcedda <fabio.porcedda@gmail.com>
+Date: Thu, 17 Jan 2013 11:32:59 +0100
+Subject: [PATCH 5/5] watchdog: enable for evk-pro3
+
+Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
+---
+ arch/arm/configs/telit_evk_pro3_defconfig | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/arch/arm/configs/telit_evk_pro3_defconfig b/arch/arm/configs/telit_evk_pro3_defconfig
+index 050d176..436cecf 100644
+--- a/arch/arm/configs/telit_evk_pro3_defconfig
++++ b/arch/arm/configs/telit_evk_pro3_defconfig
+@@ -68,6 +68,8 @@ CONFIG_MCI_ATMEL=y
+ CONFIG_LED=y
+ CONFIG_LED_GPIO=y
+ CONFIG_LED_TRIGGERS=y
++CONFIG_WATCHDOG=y
++CONFIG_WATCHDOG_AT91SAM9X=y
+ CONFIG_FS_TFTP=y
+ CONFIG_FS_FAT=y
+ CONFIG_FS_FAT_LFN=y
+-- 
+1.8.1.4
+
diff --git a/board/telit/evk-pro3/linux-0001-ARM-at91-at91_dt_defconfig-update-for-evk-pro3.patch b/board/telit/evk-pro3/linux-0001-ARM-at91-at91_dt_defconfig-update-for-evk-pro3.patch
new file mode 100644
index 0000000..ef1c6d5
--- /dev/null
+++ b/board/telit/evk-pro3/linux-0001-ARM-at91-at91_dt_defconfig-update-for-evk-pro3.patch
@@ -0,0 +1,44 @@
+From fb5e64e2f3aae7189f6d40f1d24570c092f13afd Mon Sep 17 00:00:00 2001
+From: Fabio Porcedda <fabio.porcedda@gmail.com>
+Date: Tue, 25 Sep 2012 09:47:58 +0200
+Subject: [PATCH] ARM: at91: at91_dt_defconfig: update for evk-pro3
+
+- enable ubifs
+- enable /sys/class/gpio
+- choose lzo decompression
+
+Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
+---
+ arch/arm/configs/at91_dt_defconfig | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
+index 047f2a4..295aabe 100644
+--- a/arch/arm/configs/at91_dt_defconfig
++++ b/arch/arm/configs/at91_dt_defconfig
+@@ -1,5 +1,6 @@
+ CONFIG_EXPERIMENTAL=y
+ # CONFIG_LOCALVERSION_AUTO is not set
++CONFIG_KERNEL_LZO=y
+ # CONFIG_SWAP is not set
+ CONFIG_SYSVIPC=y
+ CONFIG_LOG_BUF_SHIFT=14
+@@ -113,6 +114,7 @@ CONFIG_I2C_GPIO=y
+ CONFIG_SPI=y
+ CONFIG_SPI_ATMEL=y
+ CONFIG_PINCTRL_AT91=y
++CONFIG_GPIO_SYSFS=y
+ # CONFIG_HWMON is not set
+ CONFIG_WATCHDOG=y
+ CONFIG_AT91SAM9X_WATCHDOG=y
+@@ -172,6 +174,7 @@ CONFIG_EXT2_FS=y
+ CONFIG_FANOTIFY=y
+ CONFIG_VFAT_FS=y
+ CONFIG_TMPFS=y
++CONFIG_UBIFS_FS=y
+ CONFIG_NFS_FS=y
+ CONFIG_NFS_V3=y
+ CONFIG_ROOT_NFS=y
+-- 
+1.8.1.4
+
diff --git a/board/telit/evk-pro3/readme.txt b/board/telit/evk-pro3/readme.txt
new file mode 100644
index 0000000..ace9dd4
--- /dev/null
+++ b/board/telit/evk-pro3/readme.txt
@@ -0,0 +1,28 @@
+Buildroot board support for Telit EVK-PRO3 with Telit GE863-PRO3
+
+Official site:
+  http://www.telit.com/en/products.php?p_id=3&p_ac=show&p=10
+
+Build images:
+    make telit_evk_pro3_defconfig
+    make
+
+  images built:
+  - output/images/barebox.bin
+  - output/images/zImage
+  - output/images/rootfs.ubi
+
+
+Flash built images:
+  The first time you need to bootstrap from Telit Official Release 221.07.1007,
+  at the U-Boot prompt type:
+    U-Boot> loadb
+  send buildroot/output/images/barebox.bin
+    U-Boot> go 0x20200000
+
+  flash updated images using barebox through tftp:
+    barebox:/ erase dev/self0; cp /mnt/tftp/barebox.bin /dev/self0
+    barebox:/ erase /dev/nand0.kernel.bb; cp /mnt/tftp/zImage /dev/nand0.kernel.bb
+    barebox:/ erase /dev/nand0.rootfs.bb; cp /mnt/tftp/rootfs.ubi /dev/nand0.rootfs.bb
+    barebox:/ erase dev/env0
+    barebox:/ reset
diff --git a/configs/telit_evk_pro3_defconfig b/configs/telit_evk_pro3_defconfig
new file mode 100644
index 0000000..f7df1e4
--- /dev/null
+++ b/configs/telit_evk_pro3_defconfig
@@ -0,0 +1,16 @@
+BR2_arm=y
+BR2_PREFER_STATIC_LIB=y
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS=y
+BR2_PACKAGE_BUSYBOX_WATCHDOG=y
+BR2_TARGET_ROOTFS_UBIFS=y
+BR2_TARGET_ROOTFS_UBI=y
+BR2_TARGET_BAREBOX=y
+BR2_TARGET_BAREBOX_CUSTOM_VERSION=y
+BR2_TARGET_BAREBOX_CUSTOM_VERSION_VALUE="2013.04.0"
+BR2_TARGET_BAREBOX_CUSTOM_PATCH_DIR="board/telit/evk-pro3"
+BR2_TARGET_BAREBOX_BOARD_DEFCONFIG="telit_evk_pro3"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_PATCH="board/telit/evk-pro3"
+BR2_LINUX_KERNEL_DEFCONFIG="at91_dt"
+BR2_LINUX_KERNEL_APPENDED_ZIMAGE=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="evk-pro3"
-- 
1.8.1.4

[Buildroot] [PATCH v2 3/3] configs: add defconfig for Atmel AT91SAM9260-EK Nand Flash Boot

[Fabio Porcedda]

This is a configuration that provides a basic setup for generating
bootable nandflash images:
- at91bootstrap
- barebox
- kernel
- rootfs

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 .../linux-ARM-at91-enable-nand-ubifs-boot.patch    | 44 ++++++++++++++++++++++
 configs/at91sam9260eknf_defconfig                  | 15 ++++++++
 2 files changed, 59 insertions(+)
 create mode 100644 board/atmel/at91sam9260ek/linux-ARM-at91-enable-nand-ubifs-boot.patch
 create mode 100644 configs/at91sam9260eknf_defconfig

diff --git a/board/atmel/at91sam9260ek/linux-ARM-at91-enable-nand-ubifs-boot.patch b/board/atmel/at91sam9260ek/linux-ARM-at91-enable-nand-ubifs-boot.patch
new file mode 100644
index 0000000..e71a487
--- /dev/null
+++ b/board/atmel/at91sam9260ek/linux-ARM-at91-enable-nand-ubifs-boot.patch
@@ -0,0 +1,44 @@
+From 17f439282c3fc92587e60935ff9efd13ea78e353 Mon Sep 17 00:00:00 2001
+From: Fabio Porcedda <fabio.porcedda@gmail.com>
+Date: Tue, 15 Jan 2013 11:17:42 +0100
+Subject: [PATCH] ARM: at91: enable nand ubifs boot
+
+Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
+---
+ arch/arm/configs/at91sam9260_defconfig | 7 +++++++
+ 1 file changed, 7 insertions(+)
+
+diff --git a/arch/arm/configs/at91sam9260_defconfig b/arch/arm/configs/at91sam9260_defconfig
+index 505b376..a438192 100644
+--- a/arch/arm/configs/at91sam9260_defconfig
++++ b/arch/arm/configs/at91sam9260_defconfig
+@@ -1,5 +1,6 @@
+ CONFIG_EXPERIMENTAL=y
+ # CONFIG_LOCALVERSION_AUTO is not set
++CONFIG_KERNEL_LZO=y
+ # CONFIG_SWAP is not set
+ CONFIG_SYSVIPC=y
+ CONFIG_LOG_BUF_SHIFT=14
+@@ -43,6 +44,11 @@ CONFIG_IP_PNP_BOOTP=y
+ # CONFIG_INET_LRO is not set
+ # CONFIG_IPV6 is not set
+ CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
++CONFIG_MTD=y
++CONFIG_MTD_CMDLINE_PARTS=y
++CONFIG_MTD_NAND=y
++CONFIG_MTD_NAND_ATMEL=y
++CONFIG_MTD_UBI=y
+ CONFIG_BLK_DEV_RAM=y
+ CONFIG_BLK_DEV_RAM_SIZE=8192
+ CONFIG_SCSI=y
+@@ -82,6 +88,7 @@ CONFIG_RTC_DRV_AT91SAM9=y
+ CONFIG_EXT2_FS=y
+ CONFIG_VFAT_FS=y
+ CONFIG_TMPFS=y
++CONFIG_UBIFS_FS=y
+ CONFIG_CRAMFS=y
+ CONFIG_NLS_CODEPAGE_437=y
+ CONFIG_NLS_CODEPAGE_850=y
+-- 
+1.8.0.3
+
diff --git a/configs/at91sam9260eknf_defconfig b/configs/at91sam9260eknf_defconfig
new file mode 100644
index 0000000..5d26798
--- /dev/null
+++ b/configs/at91sam9260eknf_defconfig
@@ -0,0 +1,15 @@
+BR2_arm=y
+BR2_PREFER_STATIC_LIB=y
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS=y
+BR2_PACKAGE_HOST_SAM_BA=y
+BR2_TARGET_ROOTFS_UBIFS=y
+BR2_TARGET_ROOTFS_UBI=y
+BR2_TARGET_AT91BOOTSTRAP=y
+BR2_TARGET_AT91BOOTSTRAP_BOARD="at91sam9260ek"
+BR2_TARGET_AT91BOOTSTRAP_NANDFLASH=y
+BR2_TARGET_BAREBOX=y
+BR2_TARGET_BAREBOX_BOARD_DEFCONFIG="at91sam9260ek"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_PATCH="board/atmel/at91sam9260ek"
+BR2_LINUX_KERNEL_DEFCONFIG="at91sam9260"
+BR2_LINUX_KERNEL_ZIMAGE=y
-- 
1.8.1.4

[Buildroot] [PATCH v2 0/3] barebox new option and new boards

[Fabio Porcedda]

On Wed, Apr 17, 2013 at 9:41 AM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> Hi all,
> this patch set is for adding to barebox a custom version option
> and use this new option to add suppport for two new boards.
>
> v2:
>   - Telit EVK-PRO3: use barebox custom version option
>
> Best regards
> Fabio Porcedda (3):
>   barebox: add custom version option
>   configs: add defconfig for Telit EVK-PRO3
>   configs: add defconfig for Atmel AT91SAM9260-EK Nand Flash Boot
>
>  .../linux-ARM-at91-enable-nand-ubifs-boot.patch    |  44 ++++
>  ...04.0-0001-watchdog-add-keep-alive-support.patch |  88 ++++++++
>  ...02-watchdog-add-at91sam9-watchdog-support.patch | 228 +++++++++++++++++++++
>  ...0003-at91sam9260-9g20-add-wathdog-support.patch |  40 ++++
>  ...0004-at91sam9260-9g20-fix-wathdog-support.patch |  26 +++
>  ...13.04.0-0005-watchdog-enable-for-evk-pro3.patch |  26 +++
>  ...t91-at91_dt_defconfig-update-for-evk-pro3.patch |  44 ++++
>  board/telit/evk-pro3/readme.txt                    |  28 +++
>  boot/barebox/Config.in                             |  26 ++-
>  configs/at91sam9260eknf_defconfig                  |  15 ++
>  configs/telit_evk_pro3_defconfig                   |  16 ++
>  11 files changed, 567 insertions(+), 14 deletions(-)
>  create mode 100644 board/atmel/at91sam9260ek/linux-ARM-at91-enable-nand-ubifs-boot.patch
>  create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0001-watchdog-add-keep-alive-support.patch
>  create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0002-watchdog-add-at91sam9-watchdog-support.patch
>  create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0003-at91sam9260-9g20-add-wathdog-support.patch
>  create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0004-at91sam9260-9g20-fix-wathdog-support.patch
>  create mode 100644 board/telit/evk-pro3/barebox-2013.04.0-0005-watchdog-enable-for-evk-pro3.patch
>  create mode 100644 board/telit/evk-pro3/linux-0001-ARM-at91-at91_dt_defconfig-update-for-evk-pro3.patch
>  create mode 100644 board/telit/evk-pro3/readme.txt
>  create mode 100644 configs/at91sam9260eknf_defconfig
>  create mode 100644 configs/telit_evk_pro3_defconfig
>
> --
> 1.8.1.4
>

Ping

Best regards
--
Fabio Porcedda

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Thomas Petazzoni]

Dear Fabio Porcedda,

On Wed, 17 Apr 2013 09:41:41 +0200, Fabio Porcedda wrote:

> -config BR2_TARGET_BAREBOX_2013_01
> -	bool "2013.01.0"
> -
> -config BR2_TARGET_BAREBOX_2013_02
> -	bool "2013.02.0"
> -
> -config BR2_TARGET_BAREBOX_2013_03
> -	bool "2013.03.0"
> -
> -config BR2_TARGET_BAREBOX_2013_04
> +config BR2_TARGET_BAREBOX_LATEST_VERSION
>  	bool "2013.04.0"
>  
> +config BR2_TARGET_BAREBOX_CUSTOM_VERSION
> +	bool "Custom version"
> +	help
> +	  This option allows to use a specific official versions
> +

We need to have something that is consistent between U-Boot, Barebox
and the kernel. Currently U-Boot has a version selection, the Linux
kernel allows to chose the latest version (but with an option named
after the version itself, so the name of the option changes when the
version changes) or a custom version, and now for Barebox you're
proposing yet another solution: select the latest version (with an
option name that never changes) or a custom version.

So, I'm fine doing changes on this, but they should be consistent
across packages.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2 2/3] configs: add defconfig for Telit EVK-PRO3

[Thomas Petazzoni]

Dear Fabio Porcedda,

On Wed, 17 Apr 2013 09:41:42 +0200, Fabio Porcedda wrote:
> For more info, please find board/telit/evk-pro3/readme.txt
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  ...04.0-0001-watchdog-add-keep-alive-support.patch |  88 ++++++++
>  ...02-watchdog-add-at91sam9-watchdog-support.patch | 228 +++++++++++++++++++++
>  ...0003-at91sam9260-9g20-add-wathdog-support.patch |  40 ++++
>  ...0004-at91sam9260-9g20-fix-wathdog-support.patch |  26 +++
>  ...13.04.0-0005-watchdog-enable-for-evk-pro3.patch |  26 +++
>  ...t91-at91_dt_defconfig-update-for-evk-pro3.patch |  44 ++++

That's quite a number of patches. I suppose they are all already
upstream, correct? If so, then maybe using a Git version would allow to
get rid of those patches in Buildroot, and then you could later on
submit a patch to update Barebox to the next stable version that
contains those patches? Maybe even Barebox 2013.05 will be released
soon with those patches?

> diff --git a/configs/telit_evk_pro3_defconfig b/configs/telit_evk_pro3_defconfig
> new file mode 100644
> index 0000000..f7df1e4
> --- /dev/null
> +++ b/configs/telit_evk_pro3_defconfig
> @@ -0,0 +1,16 @@
> +BR2_arm=y
> +BR2_PREFER_STATIC_LIB=y

This choice shouldn't be part of the defconfig.

> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS=y

This one generally isn't either, but I think we can be flexible on this
one.

> +BR2_PACKAGE_BUSYBOX_WATCHDOG=y
> +BR2_TARGET_ROOTFS_UBIFS=y
> +BR2_TARGET_ROOTFS_UBI=y
> +BR2_TARGET_BAREBOX=y
> +BR2_TARGET_BAREBOX_CUSTOM_VERSION=y
> +BR2_TARGET_BAREBOX_CUSTOM_VERSION_VALUE="2013.04.0"
> +BR2_TARGET_BAREBOX_CUSTOM_PATCH_DIR="board/telit/evk-pro3"
> +BR2_TARGET_BAREBOX_BOARD_DEFCONFIG="telit_evk_pro3"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_PATCH="board/telit/evk-pro3"
> +BR2_LINUX_KERNEL_DEFCONFIG="at91_dt"
> +BR2_LINUX_KERNEL_APPENDED_ZIMAGE=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="evk-pro3"

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2 3/3] configs: add defconfig for Atmel AT91SAM9260-EK Nand Flash Boot

[Thomas Petazzoni]

Dear Fabio Porcedda,

On Wed, 17 Apr 2013 09:41:43 +0200, Fabio Porcedda wrote:
> This is a configuration that provides a basic setup for generating
> bootable nandflash images:
> - at91bootstrap
> - barebox
> - kernel
> - rootfs
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  .../linux-ARM-at91-enable-nand-ubifs-boot.patch    | 44 ++++++++++++++++++++++

I think we generally prefer to store a kernel defconfig, rather than a
patch against one of the intree kernel defconfigs.


> diff --git a/configs/at91sam9260eknf_defconfig b/configs/at91sam9260eknf_defconfig
> new file mode 100644
> index 0000000..5d26798
> --- /dev/null
> +++ b/configs/at91sam9260eknf_defconfig
> @@ -0,0 +1,15 @@
> +BR2_arm=y
> +BR2_PREFER_STATIC_LIB=y

This shouldn't be in a defconfig.

> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS=y
> +BR2_PACKAGE_HOST_SAM_BA=y
> +BR2_TARGET_ROOTFS_UBIFS=y
> +BR2_TARGET_ROOTFS_UBI=y
> +BR2_TARGET_AT91BOOTSTRAP=y
> +BR2_TARGET_AT91BOOTSTRAP_BOARD="at91sam9260ek"
> +BR2_TARGET_AT91BOOTSTRAP_NANDFLASH=y
> +BR2_TARGET_BAREBOX=y
> +BR2_TARGET_BAREBOX_BOARD_DEFCONFIG="at91sam9260ek"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_PATCH="board/atmel/at91sam9260ek"
> +BR2_LINUX_KERNEL_DEFCONFIG="at91sam9260"
> +BR2_LINUX_KERNEL_ZIMAGE=y

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2 3/3] configs: add defconfig for Atmel AT91SAM9260-EK Nand Flash Boot

[Fabio Porcedda]

On Wed, May 1, 2013 at 11:14 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Fabio Porcedda,

Hi Thomas,
thanks for reviewing.

> On Wed, 17 Apr 2013 09:41:43 +0200, Fabio Porcedda wrote:
>> This is a configuration that provides a basic setup for generating
>> bootable nandflash images:
>> - at91bootstrap
>> - barebox
>> - kernel
>> - rootfs
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> ---
>>  .../linux-ARM-at91-enable-nand-ubifs-boot.patch    | 44 ++++++++++++++++++++++
>
> I think we generally prefer to store a kernel defconfig, rather than a
> patch against one of the intree kernel defconfigs.

I prefer to modify the defconfig intree kernel to be able to use newer
versions of
the kernel smoothly with little effort if not any effort.

IMHO if i store a custom defconfig i need to change it more often
(maybe for every new kernel version),
instead patching the intree kernel defconfig is less work for me and
for the buildroot maintainers.

IMHO storing a kernel defconfig is better when someone want to use a
specific kernel version
and not the latest upstream version with little modifications.

>
>> diff --git a/configs/at91sam9260eknf_defconfig b/configs/at91sam9260eknf_defconfig
>> new file mode 100644
>> index 0000000..5d26798
>> --- /dev/null
>> +++ b/configs/at91sam9260eknf_defconfig
>> @@ -0,0 +1,15 @@
>> +BR2_arm=y
>> +BR2_PREFER_STATIC_LIB=y
>
> This shouldn't be in a defconfig.

Ok i will send a corrected version without it.

>
>> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS=y
>> +BR2_PACKAGE_HOST_SAM_BA=y
>> +BR2_TARGET_ROOTFS_UBIFS=y
>> +BR2_TARGET_ROOTFS_UBI=y
>> +BR2_TARGET_AT91BOOTSTRAP=y
>> +BR2_TARGET_AT91BOOTSTRAP_BOARD="at91sam9260ek"
>> +BR2_TARGET_AT91BOOTSTRAP_NANDFLASH=y
>> +BR2_TARGET_BAREBOX=y
>> +BR2_TARGET_BAREBOX_BOARD_DEFCONFIG="at91sam9260ek"
>> +BR2_LINUX_KERNEL=y
>> +BR2_LINUX_KERNEL_PATCH="board/atmel/at91sam9260ek"
>> +BR2_LINUX_KERNEL_DEFCONFIG="at91sam9260"
>> +BR2_LINUX_KERNEL_ZIMAGE=y
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com


Best regards
--
Fabio Porcedda

[Buildroot] [PATCH v2 2/3] configs: add defconfig for Telit EVK-PRO3

[Fabio Porcedda]

On Wed, May 1, 2013 at 11:13 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Fabio Porcedda,
>

Hi Thomas,
thanks for reviewing.

> On Wed, 17 Apr 2013 09:41:42 +0200, Fabio Porcedda wrote:
>> For more info, please find board/telit/evk-pro3/readme.txt
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> ---
>>  ...04.0-0001-watchdog-add-keep-alive-support.patch |  88 ++++++++
>>  ...02-watchdog-add-at91sam9-watchdog-support.patch | 228 +++++++++++++++++++++
>>  ...0003-at91sam9260-9g20-add-wathdog-support.patch |  40 ++++
>>  ...0004-at91sam9260-9g20-fix-wathdog-support.patch |  26 +++
>>  ...13.04.0-0005-watchdog-enable-for-evk-pro3.patch |  26 +++
>>  ...t91-at91_dt_defconfig-update-for-evk-pro3.patch |  44 ++++
>
> That's quite a number of patches. I suppose they are all already
> upstream, correct? If so, then maybe using a Git version would allow to
> get rid of those patches in Buildroot, and then you could later on
> submit a patch to update Barebox to the next stable version that
> contains those patches? Maybe even Barebox 2013.05 will be released
> soon with those patches?

Unfortunately they are not upstream, the original author is still working on it.
If possible I will try to help the original author, but i don't know
when those patches will be
included upstream.
Anyway If using a git version is the preferred solution,
I will create and use a git repostiory on github.com.

>> diff --git a/configs/telit_evk_pro3_defconfig b/configs/telit_evk_pro3_defconfig
>> new file mode 100644
>> index 0000000..f7df1e4
>> --- /dev/null
>> +++ b/configs/telit_evk_pro3_defconfig
>> @@ -0,0 +1,16 @@
>> +BR2_arm=y
>> +BR2_PREFER_STATIC_LIB=y
>
> This choice shouldn't be part of the defconfig.

Ok.

>> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS=y
>
> This one generally isn't either, but I think we can be flexible on this
> one.
>
>> +BR2_PACKAGE_BUSYBOX_WATCHDOG=y
>> +BR2_TARGET_ROOTFS_UBIFS=y
>> +BR2_TARGET_ROOTFS_UBI=y
>> +BR2_TARGET_BAREBOX=y
>> +BR2_TARGET_BAREBOX_CUSTOM_VERSION=y
>> +BR2_TARGET_BAREBOX_CUSTOM_VERSION_VALUE="2013.04.0"
>> +BR2_TARGET_BAREBOX_CUSTOM_PATCH_DIR="board/telit/evk-pro3"
>> +BR2_TARGET_BAREBOX_BOARD_DEFCONFIG="telit_evk_pro3"
>> +BR2_LINUX_KERNEL=y
>> +BR2_LINUX_KERNEL_PATCH="board/telit/evk-pro3"
>> +BR2_LINUX_KERNEL_DEFCONFIG="at91_dt"
>> +BR2_LINUX_KERNEL_APPENDED_ZIMAGE=y
>> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="evk-pro3"
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com


Best regards
--
Fabio Porcedda

[Buildroot] [PATCH v2 2/3] configs: add defconfig for Telit EVK-PRO3

[Thomas Petazzoni]

Dear Fabio Porcedda,

On Thu, 2 May 2013 00:14:49 +0200, Fabio Porcedda wrote:

> > That's quite a number of patches. I suppose they are all already
> > upstream, correct? If so, then maybe using a Git version would
> > allow to get rid of those patches in Buildroot, and then you could
> > later on submit a patch to update Barebox to the next stable
> > version that contains those patches? Maybe even Barebox 2013.05
> > will be released soon with those patches?
> 
> Unfortunately they are not upstream, the original author is still
> working on it. If possible I will try to help the original author,
> but i don't know when those patches will be
> included upstream.
> Anyway If using a git version is the preferred solution,
> I will create and use a git repostiory on github.com.

No, in this case, keeping patches is preferred, until they get merged
upstream.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2 3/3] configs: add defconfig for Atmel AT91SAM9260-EK Nand Flash Boot

[Thomas Petazzoni]

Dear Fabio Porcedda,

On Thu, 2 May 2013 00:04:41 +0200, Fabio Porcedda wrote:

> > I think we generally prefer to store a kernel defconfig, rather
> > than a patch against one of the intree kernel defconfigs.
> 
> I prefer to modify the defconfig intree kernel to be able to use newer
> versions of
> the kernel smoothly with little effort if not any effort.
> 
> IMHO if i store a custom defconfig i need to change it more often
> (maybe for every new kernel version),
> instead patching the intree kernel defconfig is less work for me and
> for the buildroot maintainers.
> 
> IMHO storing a kernel defconfig is better when someone want to use a
> specific kernel version
> and not the latest upstream version with little modifications.

Well, fair enough. I'm not sure it's really easier to maintain, but I
don't have a strong opinion on this.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Fabio Porcedda]

On Wed, May 1, 2013 at 11:10 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Fabio Porcedda,

Hi Thomas,
thanks for reviewing.

> On Wed, 17 Apr 2013 09:41:41 +0200, Fabio Porcedda wrote:
>
>> -config BR2_TARGET_BAREBOX_2013_01
>> -     bool "2013.01.0"
>> -
>> -config BR2_TARGET_BAREBOX_2013_02
>> -     bool "2013.02.0"
>> -
>> -config BR2_TARGET_BAREBOX_2013_03
>> -     bool "2013.03.0"
>> -
>> -config BR2_TARGET_BAREBOX_2013_04
>> +config BR2_TARGET_BAREBOX_LATEST_VERSION
>>       bool "2013.04.0"
>>
>> +config BR2_TARGET_BAREBOX_CUSTOM_VERSION
>> +     bool "Custom version"
>> +     help
>> +       This option allows to use a specific official versions
>> +
>
> We need to have something that is consistent between U-Boot, Barebox
> and the kernel. Currently U-Boot has a version selection, the Linux
> kernel allows to chose the latest version (but with an option named
> after the version itself, so the name of the option changes when the
> version changes) or a custom version, and now for Barebox you're
> proposing yet another solution: select the latest version (with an
> option name that never changes) or a custom version.

I think it's easier to have a option name that doesn't change.
If there isn't a specific reason to have a option name that changes then
I will send a patch to change the linux kernel option name.

BR2_LINUX_KERNEL_3_9 -> BR2_LINUX_KERNEL_LATEST_VERSION

Best regards
Fabio Porcedda

>
> So, I'm fine doing changes on this, but they should be consistent
> across packages.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com



--
Fabio Porcedda

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Fabio Porcedda]

On Fri, May 3, 2013 at 8:49 AM, Fabio Porcedda <fabio.porcedda@gmail.com> wrote:
> On Wed, May 1, 2013 at 11:10 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Dear Fabio Porcedda,
>
> Hi Thomas,
> thanks for reviewing.
>
>> On Wed, 17 Apr 2013 09:41:41 +0200, Fabio Porcedda wrote:
>>
>>> -config BR2_TARGET_BAREBOX_2013_01
>>> -     bool "2013.01.0"
>>> -
>>> -config BR2_TARGET_BAREBOX_2013_02
>>> -     bool "2013.02.0"
>>> -
>>> -config BR2_TARGET_BAREBOX_2013_03
>>> -     bool "2013.03.0"
>>> -
>>> -config BR2_TARGET_BAREBOX_2013_04
>>> +config BR2_TARGET_BAREBOX_LATEST_VERSION
>>>       bool "2013.04.0"
>>>
>>> +config BR2_TARGET_BAREBOX_CUSTOM_VERSION
>>> +     bool "Custom version"
>>> +     help
>>> +       This option allows to use a specific official versions
>>> +
>>
>> We need to have something that is consistent between U-Boot, Barebox
>> and the kernel. Currently U-Boot has a version selection, the Linux
>> kernel allows to chose the latest version (but with an option named
>> after the version itself, so the name of the option changes when the
>> version changes) or a custom version, and now for Barebox you're
>> proposing yet another solution: select the latest version (with an
>> option name that never changes) or a custom version.
>
> I think it's easier to have a option name that doesn't change.
> If there isn't a specific reason to have a option name that changes then
> I will send a patch to change the linux kernel option name.
>
> BR2_LINUX_KERNEL_3_9 -> BR2_LINUX_KERNEL_LATEST_VERSION

In the toolchain/kernel-headers/Config.in
there are many BR2_KERNEL_HEADERS_3_X options,
for headers is impossible to change the option names and use only one.

So I must use BR2_TARGET_BAREBOX_2013_04 for barebox?

Best regards
Fabio Porcedda

> Best regards
> Fabio Porcedda
>
>>
>> So, I'm fine doing changes on this, but they should be consistent
>> across packages.
>>
>> Best regards,
>>
>> Thomas
>> --
>> Thomas Petazzoni, Free Electrons
>> Kernel, drivers, real-time and embedded Linux
>> development, consulting, training and support.
>> http://free-electrons.com
>
>
>
> --
> Fabio Porcedda



--
Fabio Porcedda

[Buildroot] [PATCH v2 0/3] barebox new option and new boards

[Fabio Porcedda]

I've sent the v3

Best regards
--
Fabio Porcedda

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Thomas Petazzoni]

Dear Fabio Porcedda,

On Fri, 3 May 2013 08:49:04 +0200, Fabio Porcedda wrote:

> > On Wed, 17 Apr 2013 09:41:41 +0200, Fabio Porcedda wrote:
> >
> >> -config BR2_TARGET_BAREBOX_2013_01
> >> -     bool "2013.01.0"
> >> -
> >> -config BR2_TARGET_BAREBOX_2013_02
> >> -     bool "2013.02.0"
> >> -
> >> -config BR2_TARGET_BAREBOX_2013_03
> >> -     bool "2013.03.0"
> >> -
> >> -config BR2_TARGET_BAREBOX_2013_04
> >> +config BR2_TARGET_BAREBOX_LATEST_VERSION
> >>       bool "2013.04.0"
> >>
> >> +config BR2_TARGET_BAREBOX_CUSTOM_VERSION
> >> +     bool "Custom version"
> >> +     help
> >> +       This option allows to use a specific official versions
> >> +
> >
> > We need to have something that is consistent between U-Boot, Barebox
> > and the kernel. Currently U-Boot has a version selection, the Linux
> > kernel allows to chose the latest version (but with an option named
> > after the version itself, so the name of the option changes when the
> > version changes) or a custom version, and now for Barebox you're
> > proposing yet another solution: select the latest version (with an
> > option name that never changes) or a custom version.
> 
> I think it's easier to have a option name that doesn't change.
> If there isn't a specific reason to have a option name that changes
> then I will send a patch to change the linux kernel option name.
> 
> BR2_LINUX_KERNEL_3_9 -> BR2_LINUX_KERNEL_LATEST_VERSION

I don't really have a strong opinion about this thing, probably Peter
and Arnout have more ideas than I do on this.

The only thing I care about is to not make modifications specifically
on Barebox that are inconsistent with what is done on U-Boot, the
kernel, or other version-selectable components. For example, U-Boot
still allows to chose between several recent versions, which would make
it inconsistent with the patches you're proposing, and that's the thing
I don't like.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Fabio Porcedda]

On Fri, May 3, 2013 at 10:55 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Fabio Porcedda,
>
> On Fri, 3 May 2013 08:49:04 +0200, Fabio Porcedda wrote:
>
>> > On Wed, 17 Apr 2013 09:41:41 +0200, Fabio Porcedda wrote:
>> >
>> >> -config BR2_TARGET_BAREBOX_2013_01
>> >> -     bool "2013.01.0"
>> >> -
>> >> -config BR2_TARGET_BAREBOX_2013_02
>> >> -     bool "2013.02.0"
>> >> -
>> >> -config BR2_TARGET_BAREBOX_2013_03
>> >> -     bool "2013.03.0"
>> >> -
>> >> -config BR2_TARGET_BAREBOX_2013_04
>> >> +config BR2_TARGET_BAREBOX_LATEST_VERSION
>> >>       bool "2013.04.0"
>> >>
>> >> +config BR2_TARGET_BAREBOX_CUSTOM_VERSION
>> >> +     bool "Custom version"
>> >> +     help
>> >> +       This option allows to use a specific official versions
>> >> +
>> >
>> > We need to have something that is consistent between U-Boot, Barebox
>> > and the kernel. Currently U-Boot has a version selection, the Linux
>> > kernel allows to chose the latest version (but with an option named
>> > after the version itself, so the name of the option changes when the
>> > version changes) or a custom version, and now for Barebox you're
>> > proposing yet another solution: select the latest version (with an
>> > option name that never changes) or a custom version.
>>
>> I think it's easier to have a option name that doesn't change.
>> If there isn't a specific reason to have a option name that changes
>> then I will send a patch to change the linux kernel option name.
>>
>> BR2_LINUX_KERNEL_3_9 -> BR2_LINUX_KERNEL_LATEST_VERSION
>
> I don't really have a strong opinion about this thing, probably Peter
> and Arnout have more ideas than I do on this.
>
> The only thing I care about is to not make modifications specifically
> on Barebox that are inconsistent with what is done on U-Boot, the
> kernel, or other version-selectable components. For example, U-Boot
> still allows to chose between several recent versions, which would make
> it inconsistent with the patches you're proposing, and that's the thing
> I don't like.

In the patch set v3 barebox is consistent with the kernel.

If you are speaking just about consistency, I can send a patch for U-Boot too.
IMHO the kernel way is more flexible, so if we must choose only one method,
the kernel way is better.

A problem with having only the latest three version available
is that barebox and u-boot release frequency are very different.
Barebox have 12 release per year, U-Boot only 4.
The latest three release of U-Boot cover nine months but the latest
three release of barebox cover only three months.
So if a defconfig use a specific barebox version, that defconfig can
be used only for three months.
I think that three months is not enough.

It's better if i send patch for U-Boot too?

Best regards
Fabio Porcedda

> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

--
Fabio Porcedda

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Thomas Petazzoni]

Dear Fabio Porcedda,

On Fri, 3 May 2013 11:17:32 +0200, Fabio Porcedda wrote:

> In the patch set v3 barebox is consistent with the kernel.
> 
> If you are speaking just about consistency, I can send a patch for
> U-Boot too. IMHO the kernel way is more flexible, so if we must
> choose only one method, the kernel way is better.
> 
> A problem with having only the latest three version available
> is that barebox and u-boot release frequency are very different.
> Barebox have 12 release per year, U-Boot only 4.
> The latest three release of U-Boot cover nine months but the latest
> three release of barebox cover only three months.
> So if a defconfig use a specific barebox version, that defconfig can
> be used only for three months.
> I think that three months is not enough.

I think what you say makes sense.

> It's better if i send patch for U-Boot too?

Yes. I would however maybe wait for the opinion of others like Arnout,
Peter or Gustavo. Maybe they disagree with my opinion, and I don't want
you to do extra work that may not be accepted in the end.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Peter Korsgaard]

>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

Hi,

 Fabio> I think it's easier to have a option name that doesn't change.
 Fabio> If there isn't a specific reason to have a option name that
 Fabio> changes then I will send a patch to change the linux kernel
 Fabio> option name.

 Fabio> BR2_LINUX_KERNEL_3_9 -> BR2_LINUX_KERNEL_LATEST_VERSION

Agreed. With the _3_9 option people often don't realize that it will
only exist for a few months, and that they should use the CUSTOM_VERSION
stuff to really fix the version.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Fabio Porcedda]

On Fri, May 3, 2013 at 12:50 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:
>
> Hi,
>
>  Fabio> I think it's easier to have a option name that doesn't change.
>  Fabio> If there isn't a specific reason to have a option name that
>  Fabio> changes then I will send a patch to change the linux kernel
>  Fabio> option name.
>
>  Fabio> BR2_LINUX_KERNEL_3_9 -> BR2_LINUX_KERNEL_LATEST_VERSION
>
> Agreed. With the _3_9 option people often don't realize that it will
> only exist for a few months, and that they should use the CUSTOM_VERSION
> stuff to really fix the version.
>
> --
> Bye, Peter Korsgaard

Ok good, I will send a v4 adding that patch.

Best regards
--
Fabio Porcedda

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Arnout Vandecappelle]

On 03/05/13 11:17, Fabio Porcedda wrote:
> On Fri, May 3, 2013 at 10:55 AM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
[snip]
>> I don't really have a strong opinion about this thing, probably Peter
>> and Arnout have more ideas than I do on this.

  I don't. I started to reply this morning, then realized that I couldn't 
formulate it consistently, so I gave up.

  The _LATEST symbol name has the disadvantage that your build is not 
reproducible when you update buildroot, because the meaning of "latest" 
will have changed. However, this is already the case for all other 
packages (which don't allow choosing the version).

  With the version number in the symbol name, at least you are warned by 
make oldconfig when the version has changed, because it will offer the 
choice again.

  That said, I find this disadvantage so minor that it is not worth the 
effort of changing the symbol name all the time. So either option is fine 
for me.


>> The only thing I care about is to not make modifications specifically
>> on Barebox that are inconsistent with what is done on U-Boot, the
>> kernel, or other version-selectable components. For example, U-Boot
>> still allows to chose between several recent versions, which would make
>> it inconsistent with the patches you're proposing, and that's the thing
>> I don't like.
>
> In the patch set v3 barebox is consistent with the kernel.
>
> If you are speaking just about consistency, I can send a patch for U-Boot too.
> IMHO the kernel way is more flexible, so if we must choose only one method,
> the kernel way is better.
>
> A problem with having only the latest three version available
> is that barebox and u-boot release frequency are very different.
> Barebox have 12 release per year, U-Boot only 4.
> The latest three release of U-Boot cover nine months but the latest
> three release of barebox cover only three months.
> So if a defconfig use a specific barebox version, that defconfig can
> be used only for three months.
> I think that three months is not enough.

  I agree with that one.  In fact, I don't think it makes much sense to 
have the option to go for an earlier version, also for U-Boot. If you 
need an earlier version (e.g. because you have patches that won't apply 
to the current version), chances are that it is not one of the few that 
are offered by buildroot. BTW, a nice addition would be to require 
_CUSTOM_VERSION before you can specify a patch directory, so that this 
consistency is guaranteed to some extent.

  So I think that Fabio's basic approach (offer only the latest version, 
but also have the option to specify the version) is the best one.

> It's better if i send patch for U-Boot too?

  I would say yes, that would be nice.


  But let's hear what Peter has to say as well.

  Regards,
  Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH v2 1/3] barebox: add custom version option

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> It's better if i send patch for U-Boot too?

 Arnout>  I would say yes, that would be nice.

 Arnout>  But let's hear what Peter has to say as well.

I agree completely. _LATEST + custom version makes sense.

-- 
Bye, Peter Korsgaard