Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] freescale-imx directory patches
@ 2013-05-10  8:30 Henk Fijnvandraat
  2013-05-10  8:30 ` [Buildroot] [PATCH 1/3] Add package directory freescale-imx Henk Fijnvandraat
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Henk Fijnvandraat @ 2013-05-10  8:30 UTC (permalink / raw)
  To: buildroot

Ok, next attempt at getting this right ;-)

Henk

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 1/3] Add package directory freescale-imx
  2013-05-10  8:30 [Buildroot] freescale-imx directory patches Henk Fijnvandraat
@ 2013-05-10  8:30 ` Henk Fijnvandraat
  2013-05-10 22:31   ` Arnout Vandecappelle
  2013-05-10  8:30 ` [Buildroot] [PATCH 2/3] Move and refactor package imx-lib to the freescale-imx directory Henk Fijnvandraat
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: Henk Fijnvandraat @ 2013-05-10  8:30 UTC (permalink / raw)
  To: buildroot

The freescale-imx directory is intended to contain all freescale i.MXyy
related packages, together with their download site and version info

Signed-off-by: Henk Fijnvandraat <h.fijnvandraat@inter.nl.net>
---
 package/Config.in                  |    1 +
 package/freescale-imx/Config.in    |   14 ++++++++++++++
 package/freescale-imx/freescale.mk |   13 +++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/freescale-imx/Config.in
 create mode 100644 package/freescale-imx/freescale.mk

diff --git a/package/Config.in b/package/Config.in
index d980871..368be44 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -212,6 +212,7 @@ source "package/xfsprogs/Config.in"
 endmenu
 
 menu "Hardware handling"
+source "package/freescale-imx/Config.in"
 menu "Misc devices firmwares"
 source "package/b43-firmware/Config.in"
 source "package/firmware-imx/Config.in"
diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
new file mode 100644
index 0000000..4f09ec7
--- /dev/null
+++ b/package/freescale-imx/Config.in
@@ -0,0 +1,14 @@
+comment "freescale-imx is only relevant for the i.MXxx series from Freescale"
+	depends on BR2_arm
+
+menuconfig BR2_PACKAGE_IMX
+	bool "freescale-imx"
+	depends on BR2_arm
+	help
+	  This option enables the selection of some packages specific for
+	  the i.MXxx series of processors from Freescale.
+	  freescale-imx needs an imx-specific kernel to be built
+
+
+if BR2_PACKAGE_IMX
+endif
diff --git a/package/freescale-imx/freescale.mk b/package/freescale-imx/freescale.mk
new file mode 100644
index 0000000..945c51c
--- /dev/null
+++ b/package/freescale-imx/freescale.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# freescale-imx
+#
+#############################################################
+
+IMX_VERSION_LEVEL = 1.1.0
+
+# No official download site from freescale, just this mirror
+IMX_MIRROR_SITE   = http://download.ossystems.com.br/bsp/freescale/source
+
+include package/freescale-imx/*/*.mk
+
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 2/3] Move and refactor package imx-lib to the freescale-imx directory
  2013-05-10  8:30 [Buildroot] freescale-imx directory patches Henk Fijnvandraat
  2013-05-10  8:30 ` [Buildroot] [PATCH 1/3] Add package directory freescale-imx Henk Fijnvandraat
@ 2013-05-10  8:30 ` Henk Fijnvandraat
  2013-05-10 13:55   ` Thomas Petazzoni
  2013-05-10 22:35   ` Arnout Vandecappelle
  2013-05-10  8:30 ` [Buildroot] [PATCH 3/3] Move and refactor package firmware-imx " Henk Fijnvandraat
  2013-05-26 18:58 ` [Buildroot] freescale-imx directory patches Thomas Petazzoni
  3 siblings, 2 replies; 9+ messages in thread
From: Henk Fijnvandraat @ 2013-05-10  8:30 UTC (permalink / raw)
  To: buildroot

When moved, the version and download site are set to those specified in the
freescale-imx.mk file.
This means that the version is bumped from 12.09.01 to 1.1.0

Signed-off-by: Henk Fijnvandraat <h.fijnvandraat@inter.nl.net>
---
 package/Config.in                              |    1 -
 package/freescale-imx/Config.in                |    1 +
 package/{ => freescale-imx}/imx-lib/Config.in  |    0
 package/{ => freescale-imx}/imx-lib/imx-lib.mk |    5 ++---
 4 files changed, 3 insertions(+), 4 deletions(-)
 rename package/{ => freescale-imx}/imx-lib/Config.in (100%)
 rename package/{ => freescale-imx}/imx-lib/imx-lib.mk (86%)

diff --git a/package/Config.in b/package/Config.in
index 368be44..da422fb 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -460,7 +460,6 @@ endmenu
 
 menu "Hardware handling"
 source "package/ccid/Config.in"
-source "package/imx-lib/Config.in"
 source "package/lcdapi/Config.in"
 source "package/libaio/Config.in"
 source "package/libatasmart/Config.in"
diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
index 4f09ec7..a391014 100644
--- a/package/freescale-imx/Config.in
+++ b/package/freescale-imx/Config.in
@@ -11,4 +11,5 @@ menuconfig BR2_PACKAGE_IMX
 
 
 if BR2_PACKAGE_IMX
+source "package/imx-lib/Config.in"
 endif
diff --git a/package/imx-lib/Config.in b/package/freescale-imx/imx-lib/Config.in
similarity index 100%
rename from package/imx-lib/Config.in
rename to package/freescale-imx/imx-lib/Config.in
diff --git a/package/imx-lib/imx-lib.mk b/package/freescale-imx/imx-lib/imx-lib.mk
similarity index 86%
rename from package/imx-lib/imx-lib.mk
rename to package/freescale-imx/imx-lib/imx-lib.mk
index c168c80..f87ef0d 100644
--- a/package/imx-lib/imx-lib.mk
+++ b/package/freescale-imx/imx-lib/imx-lib.mk
@@ -4,9 +4,8 @@
 #
 #############################################################
 
-IMX_LIB_VERSION = 12.09.01
-# No official download site from freescale, just this mirror
-IMX_LIB_SITE    = http://download.ossystems.com.br/bsp/freescale/source
+FIRMWARE_IMX_VERSION = $(IMX_VERSION_LEVEL)
+FIRMWARE_IMX_SITE    = $(IMX_MIRROR_SITE)
 IMX_LIB_LICENSE = LGPLv2.1+
 # No license file included
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 3/3] Move and refactor package firmware-imx to the freescale-imx directory
  2013-05-10  8:30 [Buildroot] freescale-imx directory patches Henk Fijnvandraat
  2013-05-10  8:30 ` [Buildroot] [PATCH 1/3] Add package directory freescale-imx Henk Fijnvandraat
  2013-05-10  8:30 ` [Buildroot] [PATCH 2/3] Move and refactor package imx-lib to the freescale-imx directory Henk Fijnvandraat
@ 2013-05-10  8:30 ` Henk Fijnvandraat
  2013-05-10 22:36   ` Arnout Vandecappelle
  2013-05-26 18:58 ` [Buildroot] freescale-imx directory patches Thomas Petazzoni
  3 siblings, 1 reply; 9+ messages in thread
From: Henk Fijnvandraat @ 2013-05-10  8:30 UTC (permalink / raw)
  To: buildroot

When moved, the version and download site are set to those specified in the
freescale-imx.mk file.
This means that the version is bumped from 12.09.01 to 1.1.0

Signed-off-by: Henk Fijnvandraat <h.fijnvandraat@inter.nl.net>
---
 package/Config.in                                        |    1 -
 package/freescale-imx/Config.in                          |    1 +
 package/{ => freescale-imx}/firmware-imx/Config.in       |    0
 package/{ => freescale-imx}/firmware-imx/firmware-imx.mk |    7 +++----
 4 files changed, 4 insertions(+), 5 deletions(-)
 rename package/{ => freescale-imx}/firmware-imx/Config.in (100%)
 rename package/{ => freescale-imx}/firmware-imx/firmware-imx.mk (85%)

diff --git a/package/Config.in b/package/Config.in
index da422fb..6a27455 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -215,7 +215,6 @@ menu "Hardware handling"
 source "package/freescale-imx/Config.in"
 menu "Misc devices firmwares"
 source "package/b43-firmware/Config.in"
-source "package/firmware-imx/Config.in"
 source "package/linux-firmware/Config.in"
 source "package/rpi-firmware/Config.in"
 source "package/ux500-firmware/Config.in"
diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
index a391014..1f60192 100644
--- a/package/freescale-imx/Config.in
+++ b/package/freescale-imx/Config.in
@@ -12,4 +12,5 @@ menuconfig BR2_PACKAGE_IMX
 
 if BR2_PACKAGE_IMX
 source "package/imx-lib/Config.in"
+source "package/freescale-imx/firmware-imx/Config.in"
 endif
diff --git a/package/firmware-imx/Config.in b/package/freescale-imx/firmware-imx/Config.in
similarity index 100%
rename from package/firmware-imx/Config.in
rename to package/freescale-imx/firmware-imx/Config.in
diff --git a/package/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk
similarity index 85%
rename from package/firmware-imx/firmware-imx.mk
rename to package/freescale-imx/firmware-imx/firmware-imx.mk
index 3b43bef..062c6f9 100644
--- a/package/firmware-imx/firmware-imx.mk
+++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
@@ -1,12 +1,11 @@
 #############################################################
 #
-# buildroot makefile for firmware-imx
+# firmware-imx
 #
 #############################################################
 
-FIRMWARE_IMX_VERSION = 12.09.01
-# No official download site from freescale, just this mirror
-FIRMWARE_IMX_SITE = http://download.ossystems.com.br/bsp/freescale/source
+FIRMWARE_IMX_VERSION = $(IMX_VERSION_LEVEL)
+FIRMWARE_IMX_SITE    = $(IMX_MIRROR_SITE)
 FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin
 FIRMWARE_IMX_LICENSE = Freescale Semiconductor Software License Agreement, \
 	Atheros license (ath6k)
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 2/3] Move and refactor package imx-lib to the freescale-imx directory
  2013-05-10  8:30 ` [Buildroot] [PATCH 2/3] Move and refactor package imx-lib to the freescale-imx directory Henk Fijnvandraat
@ 2013-05-10 13:55   ` Thomas Petazzoni
  2013-05-10 22:35   ` Arnout Vandecappelle
  1 sibling, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2013-05-10 13:55 UTC (permalink / raw)
  To: buildroot

Dear Henk Fijnvandraat,

On Fri, 10 May 2013 10:30:12 +0200, Henk Fijnvandraat wrote:
> -IMX_LIB_VERSION = 12.09.01
> -# No official download site from freescale, just this mirror
> -IMX_LIB_SITE    = http://download.ossystems.com.br/bsp/freescale/source
> +FIRMWARE_IMX_VERSION = $(IMX_VERSION_LEVEL)
> +FIRMWARE_IMX_SITE    = $(IMX_MIRROR_SITE)

This is wrong, it should be IMX_LIB_VERSION and IMX_LIB_SITE.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 1/3] Add package directory freescale-imx
  2013-05-10  8:30 ` [Buildroot] [PATCH 1/3] Add package directory freescale-imx Henk Fijnvandraat
@ 2013-05-10 22:31   ` Arnout Vandecappelle
  0 siblings, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2013-05-10 22:31 UTC (permalink / raw)
  To: buildroot

On 10/05/13 10:30, Henk Fijnvandraat wrote:
> The freescale-imx directory is intended to contain all freescale i.MXyy
> related packages, together with their download site and version info
>
> Signed-off-by: Henk Fijnvandraat <h.fijnvandraat@inter.nl.net>
> ---
>   package/Config.in                  |    1 +
>   package/freescale-imx/Config.in    |   14 ++++++++++++++
>   package/freescale-imx/freescale.mk |   13 +++++++++++++
>   3 files changed, 28 insertions(+)
>   create mode 100644 package/freescale-imx/Config.in
>   create mode 100644 package/freescale-imx/freescale.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index d980871..368be44 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -212,6 +212,7 @@ source "package/xfsprogs/Config.in"
>   endmenu
>
>   menu "Hardware handling"
> +source "package/freescale-imx/Config.in"
>   menu "Misc devices firmwares"
>   source "package/b43-firmware/Config.in"
>   source "package/firmware-imx/Config.in"
> diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
> new file mode 100644
> index 0000000..4f09ec7
> --- /dev/null
> +++ b/package/freescale-imx/Config.in
> @@ -0,0 +1,14 @@
> +comment "freescale-imx is only relevant for the i.MXxx series from Freescale"
> +	depends on BR2_arm

  This comment is not needed, the fact that it's called freescale-imx is 
pretty self-explanatory.

> +
> +menuconfig BR2_PACKAGE_IMX
> +	bool "freescale-imx"

  Also here it can be a more verbose prompt, like:

	bool "Freescale i.MX specific packages"

> +	depends on BR2_arm
> +	help
> +	  This option enables the selection of some packages specific for
> +	  the i.MXxx series of processors from Freescale.
> +	  freescale-imx needs an imx-specific kernel to be built
> +
> +
> +if BR2_PACKAGE_IMX
> +endif
> diff --git a/package/freescale-imx/freescale.mk b/package/freescale-imx/freescale.mk
> new file mode 100644
> index 0000000..945c51c
> --- /dev/null
> +++ b/package/freescale-imx/freescale.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# freescale-imx
> +#
> +#############################################################
> +
> +IMX_VERSION_LEVEL = 1.1.0
> +
> +# No official download site from freescale, just this mirror
> +IMX_MIRROR_SITE   = http://download.ossystems.com.br/bsp/freescale/source

  We normally give let make variables begin with the uppercase'd package 
(or directory) name - though there are exceptions. But in this case, I 
think it's a good idea to call it

FREESCALE_IMX_VERSION = 1.1.0
FREESCALE_IMX_SITE    = ...

  Regards,
  Arnout

> +
> +include package/freescale-imx/*/*.mk
> +
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 2/3] Move and refactor package imx-lib to the freescale-imx directory
  2013-05-10  8:30 ` [Buildroot] [PATCH 2/3] Move and refactor package imx-lib to the freescale-imx directory Henk Fijnvandraat
  2013-05-10 13:55   ` Thomas Petazzoni
@ 2013-05-10 22:35   ` Arnout Vandecappelle
  1 sibling, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2013-05-10 22:35 UTC (permalink / raw)
  To: buildroot

On 10/05/13 10:30, Henk Fijnvandraat wrote:
> When moved, the version and download site are set to those specified in the
> freescale-imx.mk file.
> This means that the version is bumped from 12.09.01 to 1.1.0

  That version bump should be in the first line of the commit message. So 
something like:

imx-lib: refactor to freescale-imx directory and bump version

Use the freescale-imx version and download site, which implicitly bumps 
the version from 12.09.01 to 1.1.0.

>
> Signed-off-by: Henk Fijnvandraat<h.fijnvandraat@inter.nl.net>

  With that done and after modifying the variables as I suggested, you 
can add my

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


  Regards,
  Arnout
-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 3/3] Move and refactor package firmware-imx to the freescale-imx directory
  2013-05-10  8:30 ` [Buildroot] [PATCH 3/3] Move and refactor package firmware-imx " Henk Fijnvandraat
@ 2013-05-10 22:36   ` Arnout Vandecappelle
  0 siblings, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2013-05-10 22:36 UTC (permalink / raw)
  To: buildroot

On 10/05/13 10:30, Henk Fijnvandraat wrote:
> When moved, the version and download site are set to those specified in the
> freescale-imx.mk file.
> This means that the version is bumped from 12.09.01 to 1.1.0
>
> Signed-off-by: Henk Fijnvandraat<h.fijnvandraat@inter.nl.net>

  Same comment as for imx-lib, and also my

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

(after changing variable names).

  Regards,
  Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] freescale-imx directory patches
  2013-05-10  8:30 [Buildroot] freescale-imx directory patches Henk Fijnvandraat
                   ` (2 preceding siblings ...)
  2013-05-10  8:30 ` [Buildroot] [PATCH 3/3] Move and refactor package firmware-imx " Henk Fijnvandraat
@ 2013-05-26 18:58 ` Thomas Petazzoni
  3 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2013-05-26 18:58 UTC (permalink / raw)
  To: buildroot

Dear Henk Fijnvandraat,

On Fri, 10 May 2013 10:30:10 +0200, Henk Fijnvandraat wrote:
> Ok, next attempt at getting this right ;-)

I've taken your patches, made a few minor modifications, built-tested
them against a Freescale i.MX6 kernel. They are now part of a branch
that I will push to Peter at the end of the day.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2013-05-26 18:58 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-10  8:30 [Buildroot] freescale-imx directory patches Henk Fijnvandraat
2013-05-10  8:30 ` [Buildroot] [PATCH 1/3] Add package directory freescale-imx Henk Fijnvandraat
2013-05-10 22:31   ` Arnout Vandecappelle
2013-05-10  8:30 ` [Buildroot] [PATCH 2/3] Move and refactor package imx-lib to the freescale-imx directory Henk Fijnvandraat
2013-05-10 13:55   ` Thomas Petazzoni
2013-05-10 22:35   ` Arnout Vandecappelle
2013-05-10  8:30 ` [Buildroot] [PATCH 3/3] Move and refactor package firmware-imx " Henk Fijnvandraat
2013-05-10 22:36   ` Arnout Vandecappelle
2013-05-26 18:58 ` [Buildroot] freescale-imx directory patches Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox