Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Standardisation of $(BUILD)/.root name
Date: Tue, 14 May 2013 17:07:21 +0200	[thread overview]
Message-ID: <20130514170721.622fc086@skate> (raw)
In-Reply-To: <1368541851-31089-1-git-send-email-jezz@sysmic.org>

Dear J?r?me Pouiller,

On Tue, 14 May 2013 16:30:50 +0200, J?r?me Pouiller wrote:

> -$(BUILD_DIR)/.root:
> +$(STAMP_DIR)/skeleton-target-installed:
>  	mkdir -p $(TARGET_DIR)
>  	rsync -a \
>  		--exclude .empty --exclude .svn --exclude .git \
>  		--exclude .hg --exclude=CVS --exclude '*~' \
>  		$(TARGET_SKELETON)/ $(TARGET_DIR)/
>  	cp support/misc/target-dir-warning.txt $(TARGET_DIR_WARNING_FILE)
> +	mkdir -p $(STAMP_DIR)
>  	touch $@

I'm generally ok with the idea, but I don't like this mkdir. There is
already a mkdir that creates the stamp file directory, in the main
Makefile.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-05-14 15:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 11:04 [Buildroot] Target rebuilding Jérôme Pouiller
2013-01-17 13:27 ` Stephan Hoffmann
2013-01-18  9:43   ` Jérôme Pouiller
2013-01-19 16:32 ` Arnout Vandecappelle
2013-05-14 14:30   ` [Buildroot] [PATCH] Standardisation of $(BUILD)/.root name Jérôme Pouiller
2013-05-14 15:07     ` Thomas Petazzoni [this message]
2013-05-14 15:27       ` Jérôme Pouiller
2013-05-14 22:23         ` Yann E. MORIN
2013-05-15  6:19           ` Jérôme Pouiller
2013-05-15  6:27             ` Jérôme Pouiller
2013-05-15 21:01               ` Yann E. MORIN
2013-05-15 20:59             ` Yann E. MORIN
2013-05-14 21:52       ` Arnout Vandecappelle
2013-05-14 22:06         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130514170721.622fc086@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox