[Buildroot] [PATCH 1/2] graph-depends: ignore the 'target-generic-dont-remount-rw' target

[Buildroot] [PATCH 1/2] graph-depends: ignore the 'target-generic-dont-remount-rw' target

[Luca Ceresoli]

The graph-depends script tries to call 'make target-generic-dont-remount-rw',
which doesn't exist since 'target-generic-dont-remount-rw' is not a package.

See also the comments for commit 72bd61e5b8c2094378.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---

I guess we could compute the TARGET_EXCEPTIONS automatically and avoid the
need to update it every time. But it would be a longer work, so for now I
would just fix it manually.

 support/scripts/graph-depends |    1 +
 1 file changed, 1 insertion(+)

diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
index 180c81d..8d81969 100755
--- a/support/scripts/graph-depends
+++ b/support/scripts/graph-depends
@@ -164,6 +164,7 @@ TARGET_EXCEPTIONS = [
     "target-generic-issue",
     "target-generic-getty-busybox",
     "target-generic-do-remount-rw",
+    "target-generic-dont-remount-rw",
     "target-finalize",
     "erase-fakeroots",
     "target-generic-hostname",
-- 
1.7.10.4

[Buildroot] [PATCH 2/2] graph-depends: fix program path in comment

[Luca Ceresoli]

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 support/scripts/graph-depends |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
index 8d81969..790e24e 100755
--- a/support/scripts/graph-depends
+++ b/support/scripts/graph-depends
@@ -1,7 +1,7 @@
 #!/usr/bin/python
 
 # Usage (the graphviz package must be installed in your distribution)
-#  ./scripts/graph-depends [package-name] > test.dot
+#  ./support/scripts/graph-depends [package-name] > test.dot
 #  dot -Tpdf test.dot -o test.pdf
 #
 # With no arguments, graph-depends will draw a complete graph of
-- 
1.7.10.4

[Buildroot] [PATCH 1/2] graph-depends: ignore the 'target-generic-dont-remount-rw' target

[Thomas Petazzoni]

Dear Luca Ceresoli,

On Wed, 15 May 2013 10:11:02 +0200, Luca Ceresoli wrote:
> The graph-depends script tries to call 'make target-generic-dont-remount-rw',
> which doesn't exist since 'target-generic-dont-remount-rw' is not a package.
> 
> See also the comments for commit 72bd61e5b8c2094378.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

> I guess we could compute the TARGET_EXCEPTIONS automatically and avoid the
> need to update it every time. But it would be a longer work, so for now I
> would just fix it manually.

I agree. For example, target-generic-getty-sysvinit is still missing
from the list.

I see two ways to handle that automatically:

 * Have all those special targets starting with "target-" and have
   graph-depends exclude them automatically. Simple, but not nice if we
   have a real package named "target-<something>".

 * Instead of registering all packages into the make variable called
   TARGETS, register them into a variable called PACKAGES, which will
   get appended (at the right place) to the TARGETS variable. This way,
   the 'show-targets' thing can be turned into a 'show-packages' that
   will only display the value of the PACKAGES variable. This solution
   is probably cleaner than the previous one.

What do you think?

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2/2] graph-depends: fix program path in comment

[Thomas Petazzoni]

Dear Luca Ceresoli,

On Wed, 15 May 2013 10:11:03 +0200, Luca Ceresoli wrote:
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>  support/scripts/graph-depends |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/2] graph-depends: ignore the 'target-generic-dont-remount-rw' target

[Luca Ceresoli]

Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
>
> On Wed, 15 May 2013 10:11:02 +0200, Luca Ceresoli wrote:
>> The graph-depends script tries to call 'make target-generic-dont-remount-rw',
>> which doesn't exist since 'target-generic-dont-remount-rw' is not a package.
>>
>> See also the comments for commit 72bd61e5b8c2094378.
>>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
>> I guess we could compute the TARGET_EXCEPTIONS automatically and avoid the
>> need to update it every time. But it would be a longer work, so for now I
>> would just fix it manually.
> I agree. For example, target-generic-getty-sysvinit is still missing
> from the list.
>
> I see two ways to handle that automatically:
>
>   * Have all those special targets starting with "target-" and have
>     graph-depends exclude them automatically. Simple, but not nice if we
>     have a real package named "target-<something>".
>
>   * Instead of registering all packages into the make variable called
>     TARGETS, register them into a variable called PACKAGES, which will
>     get appended (at the right place) to the TARGETS variable. This way,
>     the 'show-targets' thing can be turned into a 'show-packages' that
>     will only display the value of the PACKAGES variable. This solution
>     is probably cleaner than the previous one.
>
> What do you think?

The second option looks much better to me, too.

Luca

[Buildroot] [PATCH 2/2] graph-depends: fix program path in comment

[Peter Korsgaard]

>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:

 Luca> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] graph-depends: ignore the 'target-generic-dont-remount-rw' target

[Peter Korsgaard]

>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:

 Luca> The graph-depends script tries to call 'make
 Luca> target-generic-dont-remount-rw', which doesn't exist since
 Luca> 'target-generic-dont-remount-rw' is not a package.

 Luca> See also the comments for commit 72bd61e5b8c2094378.

Committed, thanks.

-- 
Bye, Peter Korsgaard