Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] poco: not available for all architectures
Date: Thu, 16 May 2013 14:41:28 +0200	[thread overview]
Message-ID: <20130516144128.6735cb45@skate> (raw)
In-Reply-To: <5194D04F.7050406@zacarias.com.ar>

Dear Gustavo Zacarias,

On Thu, 16 May 2013 09:25:51 -0300, Gustavo Zacarias wrote:
> On 05/16/2013 09:23 AM, Thomas Petazzoni wrote:
> 
> >> I'm actually disabling the comment if it's not a supported architecture
> >> with that line (same as the option itself).
> > 
> > I believe that what Baruch says is that the comment is useless when
> > you're on an architecture that poco doesn't support.
> > 
> > So it should actually be:
> > 
> > 	depends on (BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)
> > 
> > No?
> 
> Maybe it's because i'm out of coffee, but i don't see that holding.
> So comment "hey you lack toolchain X" when ARCH = aarch64 || arc .. ?
> So it shows up if any of those arches == true ?

Doh, I must be the one needing more coffee it seems. Yeah, if the
package is not available on some arches, we need to do "depends
on !(some arches)" on both the package itself and the comment, which is
what you did.

Got confused, sorry.

Confusingly-acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-05-16 12:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-16 11:40 [Buildroot] [PATCH] poco: not available for all architectures Gustavo Zacarias
2013-05-16 11:54 ` Baruch Siach
2013-05-16 12:02   ` Gustavo Zacarias
2013-05-16 12:05     ` Baruch Siach
2013-05-16 12:07       ` Gustavo Zacarias
2013-05-16 12:23     ` Thomas Petazzoni
2013-05-16 12:25       ` Gustavo Zacarias
2013-05-16 12:41         ` Thomas Petazzoni [this message]
2013-05-23 21:36 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516144128.6735cb45@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox