[Buildroot] [PATCH] package/attr: fix building out-of-tree

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Yann E. MORIN,

On Thu, 23 May 2013 12:25:28 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> This needs touching a m4 macro, so requires autoreconf.
> 
> But since this is not a true autotools-package, autoreconf whines
> about missing macros. So we have to explicitly pass '-I m4'.
> 
> But since this is not a true autotools-package, the build then fails
> with missing definition for _() as the configure scripts gets confused.
> So, we just call autoconf, not autoreconf.

If it's not a true autotools-package, then it shouldn't be using the
autotools-package infrastructure, I'd say.

And making a change to the source code at the configure step (such
as autoconf or autoreconf) is fundamentally going into the wrong
direction with regard to out-of-tree support. All steps until configure
are done only once, on the source tree, and then all steps starting
from the configure step are done for both the target build and the host
build.

Therefore, autoreconf/autoconf should not be part of the configure
step anymore. I'm sending an e-mail about that in a moment.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com