[Buildroot] [PATCH 1/5] dvb-apps utilities: needs threads

[Buildroot] [PATCH 1/5] dvb-apps utilities: needs threads

[Gilles Talis]

Fixes:
http://autobuild.buildroot.org/results/b62/b62289809221b6455fe3db501e869271a64ea454
Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/dvb-apps/Config.in |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/dvb-apps/Config.in b/package/dvb-apps/Config.in
index 7f76330..a77064e 100644
--- a/package/dvb-apps/Config.in
+++ b/package/dvb-apps/Config.in
@@ -8,12 +8,13 @@ config BR2_PACKAGE_DVB_APPS
 
 if BR2_PACKAGE_DVB_APPS
 
-comment "dvb-apps utils needs LARGEFILE support in the toolchain"
-	depends on !BR2_LARGEFILE
+comment "dvb-apps utils needs a toolchain with LARGEFILE and THREADS support"
+	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_DVB_APPS_UTILS
 	bool "dvb-apps utilities"
 	depends on BR2_LARGEFILE
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	help
 	  A small number of DVB test and utility programs,
-- 
1.7.4.1

[Buildroot] [PATCH 2/5] tvheadend: needs threads

[Gilles Talis]

Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/tvheadend/Config.in |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/tvheadend/Config.in b/package/tvheadend/Config.in
index 19ab276..7083b01 100644
--- a/package/tvheadend/Config.in
+++ b/package/tvheadend/Config.in
@@ -1,9 +1,10 @@
-comment "tvheadend requires a toolchain with LARGEFILE and IPv6 support"
-    depends on !BR2_LARGEFILE || !BR2_INET_IPV6
+comment "tvheadend needs a toolchain with LARGEFILE, IPv6 and THREADS support"
+    depends on !BR2_LARGEFILE || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_TVHEADEND
 	bool "tvheadend"
 	depends on BR2_LARGEFILE && BR2_INET_IPV6
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	# tvheadend requires an atomic_add operation. Either you have
 	# a gcc >= 4.3 toolchain and it uses the gcc intrinsics, or it
 	# has special code for x86, x86-64, PPC and ARM. So in the
-- 
1.7.4.1

[Buildroot] [PATCH 3/5] portaudio: needs threads

[Gilles Talis]

Fixes:
http://autobuild.buildroot.org/results/ba2/ba2d3832cb6838b2126e0f7db223305eab579d59

Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/portaudio/Config.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/package/portaudio/Config.in b/package/portaudio/Config.in
index df884a7..0a4d71b 100644
--- a/package/portaudio/Config.in
+++ b/package/portaudio/Config.in
@@ -1,11 +1,15 @@
 config BR2_PACKAGE_PORTAUDIO
 	bool "portaudio"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  PortAudio is a free, cross-platform, open-source,
 	  audio I/O library.
 
 	  http://www.portaudio.com/
 
+comment "portaudio needs a toolchain threads support"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
 if BR2_PACKAGE_PORTAUDIO
 
 config BR2_PACKAGE_PORTAUDIO_ALSA
-- 
1.7.4.1

[Buildroot] [PATCH 4/5] portaudio: add license information

[Gilles Talis]

Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/portaudio/portaudio.mk |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/package/portaudio/portaudio.mk b/package/portaudio/portaudio.mk
index 34b0bd9..917702e 100644
--- a/package/portaudio/portaudio.mk
+++ b/package/portaudio/portaudio.mk
@@ -9,6 +9,8 @@ PORTAUDIO_SITE = http://www.portaudio.com/archives
 PORTAUDIO_SOURCE = pa_stable_$(PORTAUDIO_VERSION).tgz
 PORTAUDIO_INSTALL_STAGING = YES
 PORTAUDIO_MAKE = $(MAKE1)
+PORTAUDIO_LICENSE = MIT
+PORTAUDIO_LICENSE_FILES = LICENSE.txt
 
 PORTAUDIO_DEPENDENCIES = \
 	$(if $(BR2_PACKAGE_PORTAUDIO_WITH_ALSA),alsa-lib)
-- 
1.7.4.1

[Buildroot] [PATCH 5/5] libatomic_ops: fix build failure seen with toolchain without threads support

[Gilles Talis]

Fixes:
http://autobuild.buildroot.net/results/58c188ad59c62c7897381e110fe3518ccc17867e

Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 .../libatomic_ops-nothread-build-failure-fix.patch |   41 ++++++++++++++++++++
 1 files changed, 41 insertions(+), 0 deletions(-)
 create mode 100644 package/libatomic_ops/libatomic_ops-nothread-build-failure-fix.patch

diff --git a/package/libatomic_ops/libatomic_ops-nothread-build-failure-fix.patch b/package/libatomic_ops/libatomic_ops-nothread-build-failure-fix.patch
new file mode 100644
index 0000000..cc14b1e
--- /dev/null
+++ b/package/libatomic_ops/libatomic_ops-nothread-build-failure-fix.patch
@@ -0,0 +1,41 @@
+From 7e940ce34ff4de254d460344f1a1a486a14fb045 Mon Sep 17 00:00:00 2001
+From: Gilles Talis <gilles.talis@gmail.com>
+Date: Wed, 22 May 2013 16:21:26 -0700
+Subject: [PATCH] Fix build failure seen when using toolchain without threads support
+
+Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
+---
+ src/atomic_ops.c |    4 ++++
+ 1 files changed, 4 insertions(+), 0 deletions(-)
+
+diff --git a/src/atomic_ops.c b/src/atomic_ops.c
+index b6731a2..5769643 100644
+--- a/src/atomic_ops.c
++++ b/src/atomic_ops.c
+@@ -48,7 +48,9 @@
+ 
+ #undef AO_REQUIRE_CAS
+ 
++#if defined(AO_USE_PTHREAD_DEFS)
+ #include <pthread.h>
++#endif
+ 
+ #ifndef AO_USE_NO_SIGNALS
+ # include <signal.h>
+@@ -72,11 +74,13 @@
+ # include "atomic_ops/sysdeps/standard_ao_double_t.h"
+ #endif
+ 
++#if defined(AO_USE_PTHREAD_DEFS)
+ /*
+  * Lock for pthreads-based implementation.
+  */
+ 
+ pthread_mutex_t AO_pt_lock = PTHREAD_MUTEX_INITIALIZER;
++#endif
+ 
+ /*
+  * Out of line compare-and-swap emulation based on test and set.
+-- 
+1.7.4.1
+
-- 
1.7.4.1

[Buildroot] [PATCH 1/5] dvb-apps utilities: needs threads

[Yann E. MORIN]

Gilles, All,

On 2013-05-22 17:24 -0700, Gilles Talis spake thusly:
> Fixes:
> http://autobuild.buildroot.org/results/b62/b62289809221b6455fe3db501e869271a64ea454
> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  package/dvb-apps/Config.in |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/dvb-apps/Config.in b/package/dvb-apps/Config.in
> index 7f76330..a77064e 100644
> --- a/package/dvb-apps/Config.in
> +++ b/package/dvb-apps/Config.in
> @@ -8,12 +8,13 @@ config BR2_PACKAGE_DVB_APPS
>  
>  if BR2_PACKAGE_DVB_APPS
>  
> -comment "dvb-apps utils needs LARGEFILE support in the toolchain"
> -	depends on !BR2_LARGEFILE
> +comment "dvb-apps utils needs a toolchain with LARGEFILE and THREADS support"
> +	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS

That's where I made a mistake in my patch... :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/5] tvheadend: needs threads

[Yann E. MORIN]

Gilles, All,

On 2013-05-22 17:24 -0700, Gilles Talis spake thusly:
> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> ---
>  package/tvheadend/Config.in |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/tvheadend/Config.in b/package/tvheadend/Config.in
> index 19ab276..7083b01 100644
> --- a/package/tvheadend/Config.in
> +++ b/package/tvheadend/Config.in
> @@ -1,9 +1,10 @@
> -comment "tvheadend requires a toolchain with LARGEFILE and IPv6 support"
> -    depends on !BR2_LARGEFILE || !BR2_INET_IPV6
> +comment "tvheadend needs a toolchain with LARGEFILE, IPv6 and THREADS support"
> +    depends on !BR2_LARGEFILE || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
>  
>  config BR2_PACKAGE_TVHEADEND
>  	bool "tvheadend"
>  	depends on BR2_LARGEFILE && BR2_INET_IPV6
> +	depends on BR2_TOOLCHAIN_HAS_THREADS

Is it because tvheadend selects dvb-apps that it requires threads, or
does it itself require threads?

If the former, then:
	depends on BR2_TOOLCHAIN_HAS_THREADS # dvb-apps

If the latter, then OK.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 4/5] portaudio: add license information

[Yann E. MORIN]

On 2013-05-22 17:24 -0700, Gilles Talis spake thusly:
> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> ---
>  package/portaudio/portaudio.mk |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/package/portaudio/portaudio.mk b/package/portaudio/portaudio.mk
> index 34b0bd9..917702e 100644
> --- a/package/portaudio/portaudio.mk
> +++ b/package/portaudio/portaudio.mk
> @@ -9,6 +9,8 @@ PORTAUDIO_SITE = http://www.portaudio.com/archives
>  PORTAUDIO_SOURCE = pa_stable_$(PORTAUDIO_VERSION).tgz
>  PORTAUDIO_INSTALL_STAGING = YES
>  PORTAUDIO_MAKE = $(MAKE1)
> +PORTAUDIO_LICENSE = MIT

This is not really MIT, since there is additional text:

 ---8<---
 * The text above constitutes the entire PortAudio license; however, 
 * the PortAudio community also makes the following non-binding
 * requests:
 *
 * Any person wishing to distribute modifications to the Software is
 * requested to send the modifications to the original developer so that
 * they can be incorporated into the canonical version. It is also 
 * requested that these non-binding requests be included along with the 
 * license above.
 ---8<---

So I'd say:
    PORTAUDIO_LICENSE = portaudio license (MIT-like plus special clause)

(which by the way makes it non-free software.)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 4/5] portaudio: add license information

[Baruch Siach]

Hi Yann,

On Thu, May 23, 2013 at 08:59:04AM +0200, Yann E. MORIN wrote:
> On 2013-05-22 17:24 -0700, Gilles Talis spake thusly:
> > Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> > ---
> >  package/portaudio/portaudio.mk |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/package/portaudio/portaudio.mk b/package/portaudio/portaudio.mk
> > index 34b0bd9..917702e 100644
> > --- a/package/portaudio/portaudio.mk
> > +++ b/package/portaudio/portaudio.mk
> > @@ -9,6 +9,8 @@ PORTAUDIO_SITE = http://www.portaudio.com/archives
> >  PORTAUDIO_SOURCE = pa_stable_$(PORTAUDIO_VERSION).tgz
> >  PORTAUDIO_INSTALL_STAGING = YES
> >  PORTAUDIO_MAKE = $(MAKE1)
> > +PORTAUDIO_LICENSE = MIT
> 
> This is not really MIT, since there is additional text:
> 
>  ---8<---
>  * The text above constitutes the entire PortAudio license; however, 
>  * the PortAudio community also makes the following non-binding
>  * requests:
>  *
>  * Any person wishing to distribute modifications to the Software is
>  * requested to send the modifications to the original developer so that
>  * they can be incorporated into the canonical version. It is also 
>  * requested that these non-binding requests be included along with the 
>  * license above.
>  ---8<---
> 
> So I'd say:
>     PORTAUDIO_LICENSE = portaudio license (MIT-like plus special clause)
> 
> (which by the way makes it non-free software.)

Well, the text you cite says explicitly that these are "non-binding requests".  
Would you still consider this non-free?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 4/5] portaudio: add license information

[Yann E. MORIN]

Baruch, All,

On 2013-05-23 10:09 +0300, Baruch Siach spake thusly:
> On Thu, May 23, 2013 at 08:59:04AM +0200, Yann E. MORIN wrote:
[--SNIP--]
> > This is not really MIT, since there is additional text:
> > 
> >  ---8<---
> >  * The text above constitutes the entire PortAudio license; however, 
> >  * the PortAudio community also makes the following non-binding
> >  * requests:
> >  *
> >  * Any person wishing to distribute modifications to the Software is
> >  * requested to send the modifications to the original developer so that
> >  * they can be incorporated into the canonical version. It is also 
> >  * requested that these non-binding requests be included along with the 
> >  * license above.
> >  ---8<---
> > 
> > So I'd say:
> >     PORTAUDIO_LICENSE = portaudio license (MIT-like plus special clause)
> > 
> > (which by the way makes it non-free software.)
> 
> Well, the text you cite says explicitly that these are "non-binding requests".  
> Would you still consider this non-free?

Well, I poundered that, yes. But the way it is phrased is dubious.

First, it states that it is a non-binding clause. But then the clause
states "[a]ny person [doing changes] is requested to send modifications
[upstream]." The term "requested" is a bit strong for a non-binding
clause.

So, let me rephrase:
    (which by the way *may* make it non-free software.)

But the final word should come from a legal counsel, of course. :-)

Anyway, this is not "MIT" per-se.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/5] tvheadend: needs threads

[Gilles Talis]

Yann, all,

2013/5/22 Yann E. MORIN <yann.morin.1998@free.fr>:
> Gilles, All,
>
> Is it because tvheadend selects dvb-apps that it requires threads, or
> does it itself require threads?
>
It is tvheadend that needs threads. It is not dvb-apps that requires
threads, but dvb-apps utils.
By the way, thanks for the ack on my dvb-apps utils patch.

Regards,
Gilles.

[Buildroot] [PATCH 4/5] portaudio: add license information

[Gilles Talis]

Yann, Baruch, all

2013/5/23 Yann E. MORIN <yann.morin.1998@free.fr>:
> Baruch, All,
>
> On 2013-05-23 10:09 +0300, Baruch Siach spake thusly:
>> On Thu, May 23, 2013 at 08:59:04AM +0200, Yann E. MORIN wrote:
> [--SNIP--]
>> > This is not really MIT, since there is additional text:
>> >
>> >  ---8<---
>> >  * The text above constitutes the entire PortAudio license; however,
>> >  * the PortAudio community also makes the following non-binding
>> >  * requests:
>> >  *
>> >  * Any person wishing to distribute modifications to the Software is
>> >  * requested to send the modifications to the original developer so that
>> >  * they can be incorporated into the canonical version. It is also
>> >  * requested that these non-binding requests be included along with the
>> >  * license above.
>> >  ---8<---
>> >
>> > So I'd say:
>> >     PORTAUDIO_LICENSE = portaudio license (MIT-like plus special clause)
>> >
>> > (which by the way makes it non-free software.)
>>
>> Well, the text you cite says explicitly that these are "non-binding requests".
>> Would you still consider this non-free?
>
> Well, I poundered that, yes. But the way it is phrased is dubious.
>
> First, it states that it is a non-binding clause. But then the clause
> states "[a]ny person [doing changes] is requested to send modifications
> [upstream]." The term "requested" is a bit strong for a non-binding
> clause.
>
> So, let me rephrase:
>     (which by the way *may* make it non-free software.)
>
> But the final word should come from a legal counsel, of course. :-)
>
> Anyway, this is not "MIT" per-se.
>
> Regards,
> Yann E. MORIN.

I actually had the same assumption as Baruch. I felt like the
"non-binding requests" was the most important information in the text.
Anyway, as you say, let's wait for a license expert to give final word
on this.
I'll send a patch later when we get confirmation that license type
needs to be modified.

Thanks
Regards,
Gilles.

[Buildroot] [PATCH 2/5] tvheadend: needs threads

[Yann E. MORIN]

Gilles, All,

On 2013-05-23 07:44 -0700, Gilles Talis spake thusly:
> 2013/5/22 Yann E. MORIN <yann.morin.1998@free.fr>:
> > Gilles, All,
> >
> > Is it because tvheadend selects dvb-apps that it requires threads, or
> > does it itself require threads?
> >
> It is tvheadend that needs threads.

OK.

> It is not dvb-apps that requires
> threads, but dvb-apps utils.

Yep, I meant dvb-apps utils.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 4/5] portaudio: add license information

[Yann E. MORIN]

Gilles, Baruch, All,

On 2013-05-23 07:49 -0700, Gilles Talis spake thusly:
> 2013/5/23 Yann E. MORIN <yann.morin.1998@free.fr>:
> > Baruch, All,
> >
> > On 2013-05-23 10:09 +0300, Baruch Siach spake thusly:
> >> On Thu, May 23, 2013 at 08:59:04AM +0200, Yann E. MORIN wrote:
> > [--SNIP--]
> >> > This is not really MIT, since there is additional text:
> >> >
> >> >  ---8<---
> >> >  * The text above constitutes the entire PortAudio license; however,
> >> >  * the PortAudio community also makes the following non-binding
> >> >  * requests:
> >> >  *
> >> >  * Any person wishing to distribute modifications to the Software is
> >> >  * requested to send the modifications to the original developer so that
> >> >  * they can be incorporated into the canonical version. It is also
> >> >  * requested that these non-binding requests be included along with the
> >> >  * license above.
> >> >  ---8<---
> >> >
> >> > So I'd say:
> >> >     PORTAUDIO_LICENSE = portaudio license (MIT-like plus special clause)
> >> >
> >> > (which by the way makes it non-free software.)
> >>
> >> Well, the text you cite says explicitly that these are "non-binding requests".
> >> Would you still consider this non-free?
> >
> > Well, I poundered that, yes. But the way it is phrased is dubious.
> >
> > First, it states that it is a non-binding clause. But then the clause
> > states "[a]ny person [doing changes] is requested to send modifications
> > [upstream]." The term "requested" is a bit strong for a non-binding
> > clause.
> >
> > So, let me rephrase:
> >     (which by the way *may* make it non-free software.)
> >
> > But the final word should come from a legal counsel, of course. :-)
> >
> > Anyway, this is not "MIT" per-se.
> >
> > Regards,
> > Yann E. MORIN.
> 
> I actually had the same assumption as Baruch. I felt like the
> "non-binding requests" was the most important information in the text.
> Anyway, as you say, let's wait for a license expert to give final word
> on this.

What I meant by "legal counsel" was about the end-user contacting *his*
legal counsel, not us. We do not have such ressources.

> I'll send a patch later when we get confirmation that license type
> needs to be modified.

My proposal is still to have:
    PORTAUDIO_LICENSE = portaudio license (MIT-like plus special clause)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 4/5] portaudio: add license information

[Gilles Talis]

Yann,

2013/5/23 Yann E. MORIN <yann.morin.1998@free.fr>:
> Gilles, Baruch, All,
>
> On 2013-05-23 07:49 -0700, Gilles Talis spake thusly:
>> 2013/5/23 Yann E. MORIN <yann.morin.1998@free.fr>:
>> > Baruch, All,
>> >
>> > On 2013-05-23 10:09 +0300, Baruch Siach spake thusly:
>> >> On Thu, May 23, 2013 at 08:59:04AM +0200, Yann E. MORIN wrote:
>> > [--SNIP--]
>> >> > This is not really MIT, since there is additional text:
>> >> >
>> >> >  ---8<---
>> >> >  * The text above constitutes the entire PortAudio license; however,
>> >> >  * the PortAudio community also makes the following non-binding
>> >> >  * requests:
>> >> >  *
>> >> >  * Any person wishing to distribute modifications to the Software is
>> >> >  * requested to send the modifications to the original developer so that
>> >> >  * they can be incorporated into the canonical version. It is also
>> >> >  * requested that these non-binding requests be included along with the
>> >> >  * license above.
>> >> >  ---8<---
>> >> >
>> >> > So I'd say:
>> >> >     PORTAUDIO_LICENSE = portaudio license (MIT-like plus special clause)
>> >> >
>> >> > (which by the way makes it non-free software.)
>> >>
>> >> Well, the text you cite says explicitly that these are "non-binding requests".
>> >> Would you still consider this non-free?
>> >
>> > Well, I poundered that, yes. But the way it is phrased is dubious.
>> >
>> > First, it states that it is a non-binding clause. But then the clause
>> > states "[a]ny person [doing changes] is requested to send modifications
>> > [upstream]." The term "requested" is a bit strong for a non-binding
>> > clause.
>> >
>> > So, let me rephrase:
>> >     (which by the way *may* make it non-free software.)
>> >
>> > But the final word should come from a legal counsel, of course. :-)
>> >
>> > Anyway, this is not "MIT" per-se.
>> >
>> > Regards,
>> > Yann E. MORIN.
>>
>> I actually had the same assumption as Baruch. I felt like the
>> "non-binding requests" was the most important information in the text.
>> Anyway, as you say, let's wait for a license expert to give final word
>> on this.
>
> What I meant by "legal counsel" was about the end-user contacting *his*
> legal counsel, not us. We do not have such ressources.
Ooops... all apologies. Misunderstood that.

>> I'll send a patch later when we get confirmation that license type
>> needs to be modified.
>
> My proposal is still to have:
>     PORTAUDIO_LICENSE = portaudio license (MIT-like plus special clause)
Yeah, I think you're right. Let me send a new patch.

Thanks
Regards
Gilles.

[Buildroot] [PATCH 1/5] dvb-apps utilities: needs threads

[Peter Korsgaard]

>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:

 Gilles> Fixes:
 Gilles> http://autobuild.buildroot.org/results/b62/b62289809221b6455fe3db501e869271a64ea454
 Gilles> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 2/5] tvheadend: needs threads

[Peter Korsgaard]

>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:

 Gilles> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 3/5] portaudio: needs threads

[Peter Korsgaard]

>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:

 Gilles> Fixes:
 Gilles> http://autobuild.buildroot.org/results/ba2/ba2d3832cb6838b2126e0f7db223305eab579d59

 Gilles> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
 Gilles> ---
 Gilles>  package/portaudio/Config.in |    4 ++++
 Gilles>  1 files changed, 4 insertions(+), 0 deletions(-)

 Gilles> diff --git a/package/portaudio/Config.in b/package/portaudio/Config.in
 Gilles> index df884a7..0a4d71b 100644
 Gilles> --- a/package/portaudio/Config.in
 Gilles> +++ b/package/portaudio/Config.in
 Gilles> @@ -1,11 +1,15 @@
 Gilles>  config BR2_PACKAGE_PORTAUDIO
 Gilles>  	bool "portaudio"
 Gilles> +	depends on BR2_TOOLCHAIN_HAS_THREADS
 Gilles>  	help
 Gilles>  	  PortAudio is a free, cross-platform, open-source,
 Gilles>  	  audio I/O library.
 
 Gilles>  	  http://www.portaudio.com/
 
 Gilles> +comment "portaudio needs a toolchain threads support"
 Gilles> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
 Gilles> +

This needs to go either above BR2_PACKAGE_PORTAUDIO or all the way at
the bottom, otherwise the suboptions doesn't get properly indented in
menuconfig.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 5/5] libatomic_ops: fix build failure seen with toolchain without threads support

[Peter Korsgaard]

>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:

 Gilles> Fixes:
 Gilles> http://autobuild.buildroot.net/results/58c188ad59c62c7897381e110fe3518ccc17867e

Committed, thanks.

Please don't forget to send patch upstream.

-- 
Bye, Peter Korsgaard