From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] skeleton: add default login port to /etc/securetty
Date: Sun, 26 May 2013 22:30:51 +0200 [thread overview]
Message-ID: <20130526223051.4c440f36@skate> (raw)
In-Reply-To: <1369599269-18876-1-git-send-email-spenser@gillilanding.com>
Dear Spenser Gilliland,
On Sun, 26 May 2013 15:14:29 -0500, Spenser Gilliland wrote:
> Change-Id: Ifb1239c80eb86528345b24eb8d04b52b67aa1209
Please remove this.
> +target-generic-securetty:
> + grep -q ^$(TARGET_GENERIC_GETTY)$ $(TARGET_DIR)/etc/securetty || \
> + echo $(TARGET_GENERIC_GETTY) >> $(TARGET_DIR)/etc/securetty
I'm not a make/shell expansion guru. Does the ^ and $ propagate all the
well to the shell and into the regexp matched by grep?
> +ifneq ($(TARGET_GENERIC_GETTY), )
No space for the test:
ifneq ($(TARGET_GENERIC_GETTY),)
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-05-26 20:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 3:19 [Buildroot] [PATCH 1/1] skeleton: add default login port to /etc/securetty roylee17 at gmail.com
2012-07-14 16:56 ` Arnout Vandecappelle
2012-07-14 17:15 ` Thomas Petazzoni
2012-07-14 21:20 ` Arnout Vandecappelle
2012-07-14 23:08 ` Thomas Petazzoni
2012-07-15 0:28 ` Arnout Vandecappelle
2012-07-30 15:13 ` Tzu-Jung Lee
2013-05-26 20:14 ` Spenser Gilliland
2013-05-26 20:30 ` Thomas Petazzoni [this message]
2013-05-26 20:40 ` Spenser Gilliland
2013-05-26 20:43 ` Spenser Gilliland
2013-05-26 21:00 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2013-05-21 9:56 Tzu-Jung Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130526223051.4c440f36@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox