* [Buildroot] [PATCH] opengl: correct detection of virtual packages having no dependencies
@ 2013-05-30 13:08 Will Wagner
2013-05-30 13:26 ` Thomas Petazzoni
2013-05-30 13:43 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Will Wagner @ 2013-05-30 13:08 UTC (permalink / raw)
To: buildroot
I believe the original intent was to make it that the configure step
for the opengl virtual packages fails if there is not at least one
dependency. This patch fixes the logic so that it actually fails if
dependency list is empty
Signed-off-by: Will Wagner <will_wagner@carallon.com>
---
package/opengl/libegl/libegl.mk | 2 +-
package/opengl/libgles/libgles.mk | 2 +-
package/opengl/libopenvg/libopenvg.mk | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/opengl/libegl/libegl.mk
b/package/opengl/libegl/libegl.mk
index c495496..8ff24e8 100644
--- a/package/opengl/libegl/libegl.mk
+++ b/package/opengl/libegl/libegl.mk
@@ -10,7 +10,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
LIBEGL_DEPENDENCIES += rpi-userland
endif
-ifeq ($(LIBEGL_DEPENDENCIES),y)
+ifeq ($(LIBEGL_DEPENDENCIES),)
define LIBEGL_CONFIGURE_CMDS
echo "No libEGL implementation selected. Configuration error."
exit 1
diff --git a/package/opengl/libgles/libgles.mk
b/package/opengl/libgles/libgles.mk
index f0d0eec..675d11f 100644
--- a/package/opengl/libgles/libgles.mk
+++ b/package/opengl/libgles/libgles.mk
@@ -10,7 +10,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
LIBGLES_DEPENDENCIES += rpi-userland
endif
-ifeq ($(LIBGLES_DEPENDENCIES),y)
+ifeq ($(LIBGLES_DEPENDENCIES),)
define LIBGLES_CONFIGURE_CMDS
echo "No libGLES implementation selected. Configuration error."
exit 1
diff --git a/package/opengl/libopenvg/libopenvg.mk
b/package/opengl/libopenvg/libopenvg.mk
index 573fa78..746b52c 100644
--- a/package/opengl/libopenvg/libopenvg.mk
+++ b/package/opengl/libopenvg/libopenvg.mk
@@ -10,7 +10,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
LIBOPENVG_DEPENDENCIES += rpi-userland
endif
-ifeq ($(LIBOPENVG_DEPENDENCIES),y)
+ifeq ($(LIBOPENVG_DEPENDENCIES),)
define LIBOPENVG_CONFIGURE_CMDS
echo "No libOpenVG implementation selected. Configuration error."
exit 1
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] opengl: correct detection of virtual packages having no dependencies
2013-05-30 13:08 [Buildroot] [PATCH] opengl: correct detection of virtual packages having no dependencies Will Wagner
@ 2013-05-30 13:26 ` Thomas Petazzoni
2013-05-30 13:43 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2013-05-30 13:26 UTC (permalink / raw)
To: buildroot
Dear Will Wagner,
On Thu, 30 May 2013 14:08:05 +0100, Will Wagner wrote:
> I believe the original intent was to make it that the configure step
> for the opengl virtual packages fails if there is not at least one
> dependency. This patch fixes the logic so that it actually fails if
> dependency list is empty
>
> Signed-off-by: Will Wagner <will_wagner@carallon.com>
Indeed. Thanks for spotting the mistake!
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] opengl: correct detection of virtual packages having no dependencies
2013-05-30 13:08 [Buildroot] [PATCH] opengl: correct detection of virtual packages having no dependencies Will Wagner
2013-05-30 13:26 ` Thomas Petazzoni
@ 2013-05-30 13:43 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-05-30 13:43 UTC (permalink / raw)
To: buildroot
>>>>> "Will" == Will Wagner <will_wagner@carallon.com> writes:
Will> I believe the original intent was to make it that the configure step
Will> for the opengl virtual packages fails if there is not at least one
Will> dependency. This patch fixes the logic so that it actually fails if
Will> dependency list is empty
Will> Signed-off-by: Will Wagner <will_wagner@carallon.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-30 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-30 13:08 [Buildroot] [PATCH] opengl: correct detection of virtual packages having no dependencies Will Wagner
2013-05-30 13:26 ` Thomas Petazzoni
2013-05-30 13:43 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox