[Buildroot] [PATCH] package/libbsd: depends on architectures providing a.out.h

[Buildroot] [PATCH] package/libbsd: depends on architectures providing a.out.h

[Yann E. MORIN]

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

libbsd requires a.out.h, which is only available in a select subset
of the architectures Buildroot supports.

This means libedit can no longer 'select' libbsd, so turn the 'select'
into a 'depends on'. And the dependency chain ends there.

Fixes:
    http://autobuild.buildroot.org/results/019/019091312ec547520370ffad967b53e23f54a14b
    http://autobuild.buildroot.org/results/87c/87c3a8bf2248606d80ddcfd96132de4c5fe869ed
    http://autobuild.buildroot.org/results/589/5891f539ce3f3ff2e3411228472c8833fdd0d7c0
    [...]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/libbsd/Config.in  | 3 +++
 package/libedit/Config.in | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/libbsd/Config.in b/package/libbsd/Config.in
index 0ed9dac..915a4bd 100644
--- a/package/libbsd/Config.in
+++ b/package/libbsd/Config.in
@@ -1,5 +1,8 @@
 config BR2_PACKAGE_LIBBSD
 	bool "libbsd"
+	# libbsd requires a.out.h, which is only available for those
+	# architectures: arm, m68k, x86 (and alpha, but we don't care.)
+	depends on ( BR2_arm || BR2_armeb || BR2_m68k || BR2_i386 || BR2_x86_64 )
 	help
 	  This library provides useful functions commonly found on BSD
 	  systems, and lacking on others like GNU systems, thus making
diff --git a/package/libedit/Config.in b/package/libedit/Config.in
index b49c23c..86a70b4 100644
--- a/package/libedit/Config.in
+++ b/package/libedit/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_LIBEDIT
 	bool "libedit"
-	select BR2_PACKAGE_LIBBSD
+	depends on BR2_PACKAGE_LIBBSD
 	select BR2_PACKAGE_NCURSES
 	help
 	  The editline library (from BSD) provides generic line editing
-- 
1.8.1.2

[Buildroot] [PATCH] package/libbsd: depends on architectures providing a.out.h

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 Yann> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 Yann> libbsd requires a.out.h, which is only available in a select subset
 Yann> of the architectures Buildroot supports.

 Yann> This means libedit can no longer 'select' libbsd, so turn the 'select'
 Yann> into a 'depends on'. And the dependency chain ends there.

Why? You can just propagate the arch dependencies to libedit as well.
I don't like dependencies for libraries, it isn't obvious to people that
we actually have a libedit package.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] package/libbsd: depends on architectures providing a.out.h

[Yann E. MORIN]

Peter, All,

On 2013-06-05 21:00 +0200, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> 
>  Yann> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>  Yann> libbsd requires a.out.h, which is only available in a select subset
>  Yann> of the architectures Buildroot supports.
> 
>  Yann> This means libedit can no longer 'select' libbsd, so turn the 'select'
>  Yann> into a 'depends on'. And the dependency chain ends there.
> 
> Why? You can just propagate the arch dependencies to libedit as well.

Sure, will do.

> I don't like dependencies for libraries, it isn't obvious to people that
> we actually have a libedit package.

I don't like propagating the dependencies. ;-)

I wonder if I should revive the _AVAILABLE stuff from last year? But
that's for another thread.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'