* [Buildroot] [PATCH] Install DTB as part of images install command
@ 2013-03-27 23:01 Reuben Dowle
2013-04-04 11:12 ` Arnout Vandecappelle
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Reuben Dowle @ 2013-03-27 23:01 UTC (permalink / raw)
To: buildroot
From: Reuben Dowle <reuben.dowle@4rf.com>
When installing DTB to the images directory, do this as part of the image
install commands rather than the target install commands.
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com.az>
---
linux/linux.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux/linux.mk b/linux/linux.mk
index 8a73767..f0d793b 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -261,11 +261,11 @@ endef
define LINUX_INSTALL_IMAGES_CMDS
cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
+ $(LINUX_INSTALL_DTB)
endef
define LINUX_INSTALL_TARGET_CMDS
$(LINUX_INSTALL_KERNEL_IMAGE_TO_TARGET)
- $(LINUX_INSTALL_DTB)
# Install modules and remove symbolic links pointing to build
# directories, not relevant on the target
@if grep -q "CONFIG_MODULES=y" $(@D)/.config; then \
--
1.7.10.4
The information in this email communication (inclusive of attachments) is confidential to 4RF Limited and the intended recipient(s). If you are not the intended recipient(s), please note that any use, disclosure, distribution or copying of this information or any part thereof is strictly prohibited and that the author accepts no liability for the consequences of any action taken on the basis of the information provided. If you have received this email in error, please notify the sender immediately by return email and then delete all instances of this email from your system. 4RF Limited will not accept responsibility for any consequences associated with the use of this email (including, but not limited to, damages sustained as a result of any viruses and/or any action or lack of action taken in reliance on it).
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Install DTB as part of images install command
2013-03-27 23:01 [Buildroot] [PATCH] Install DTB as part of images install command Reuben Dowle
@ 2013-04-04 11:12 ` Arnout Vandecappelle
2013-04-04 11:38 ` Arnout Vandecappelle
2013-06-09 17:34 ` Maxime Ripard
2013-08-01 16:01 ` Thomas Petazzoni
2 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-04-04 11:12 UTC (permalink / raw)
To: buildroot
On 28/03/13 00:01, Reuben Dowle wrote:
> From: Reuben Dowle <reuben.dowle@4rf.com>
>
> When installing DTB to the images directory, do this as part of the image
> install commands rather than the target install commands.
>
> Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com.az>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(untested)
> ---
> linux/linux.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 8a73767..f0d793b 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -261,11 +261,11 @@ endef
>
> define LINUX_INSTALL_IMAGES_CMDS
> cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
> + $(LINUX_INSTALL_DTB)
I prefer the indentation to be with a tab, but since the original has
spaces it's OK.
Regards,
Arnout
> endef
>
> define LINUX_INSTALL_TARGET_CMDS
> $(LINUX_INSTALL_KERNEL_IMAGE_TO_TARGET)
> - $(LINUX_INSTALL_DTB)
> # Install modules and remove symbolic links pointing to build
> # directories, not relevant on the target
> @if grep -q "CONFIG_MODULES=y" $(@D)/.config; then \
> --
> 1.7.10.4
>
> The information in this email communication (inclusive of attachments) is confidential to 4RF Limited and the intended recipient(s). If you are not the intended recipient(s), please note that any use, disclosure, distribution or copying of this information or any part thereof is strictly prohibited and that the author accepts no liability for the consequences of any action taken on the basis of the information provided. If you have received this email in error, please notify the sender immediately by return email and then delete all instances of this email from your system. 4RF Limited will not accept responsibility for any consequences associated with the use of this email (including, but not limited to, damages sustained as a result of any viruses and/or any action or lack of action taken in reliance on it).
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Install DTB as part of images install command
2013-04-04 11:12 ` Arnout Vandecappelle
@ 2013-04-04 11:38 ` Arnout Vandecappelle
2013-04-04 19:03 ` Reuben Dowle
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-04-04 11:38 UTC (permalink / raw)
To: buildroot
On 04/04/13 13:12, Arnout Vandecappelle wrote:
>>
>> define LINUX_INSTALL_IMAGES_CMDS
>> cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
>> + $(LINUX_INSTALL_DTB)
>
> I prefer the indentation to be with a tab, but since the original has
> spaces it's OK.
Scratch that, the patch is whitespace-modified and doesn't apply (the
original _does_ have tabs). Could you resend with git send-email?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Install DTB as part of images install command
2013-04-04 11:38 ` Arnout Vandecappelle
@ 2013-04-04 19:03 ` Reuben Dowle
0 siblings, 0 replies; 6+ messages in thread
From: Reuben Dowle @ 2013-04-04 19:03 UTC (permalink / raw)
To: buildroot
Sorry about that. It looks like my corporate mail server has replaced the tabs with spaces when it inserted the corporate warning. The email in my sent items definitely had the tabs. I will try and figure a better way to send it.
Reuben
> -----Original Message-----
> From: Arnout Vandecappelle [mailto:arnout at mind.be]
> Sent: Friday, 5 April 2013 12:38 a.m.
> To: Arnout Vandecappelle
> Cc: Reuben Dowle; buildroot at busybox.net
> Subject: Re: [Buildroot] [PATCH] Install DTB as part of images install
> command
>
> On 04/04/13 13:12, Arnout Vandecappelle wrote:
> >>
> >> define LINUX_INSTALL_IMAGES_CMDS
> >> cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
> >> + $(LINUX_INSTALL_DTB)
> >
> > I prefer the indentation to be with a tab, but since the original
> has
> > spaces it's OK.
>
> Scratch that, the patch is whitespace-modified and doesn't apply (the
> original _does_ have tabs). Could you resend with git send-email?
>
> Regards,
> Arnout
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
The information in this email communication (inclusive of attachments) is confidential to 4RF Limited and the intended recipient(s). If you are not the intended recipient(s), please note that any use, disclosure, distribution or copying of this information or any part thereof is strictly prohibited and that the author accepts no liability for the consequences of any action taken on the basis of the information provided. If you have received this email in error, please notify the sender immediately by return email and then delete all instances of this email from your system. 4RF Limited will not accept responsibility for any consequences associated with the use of this email (including, but not limited to, damages sustained as a result of any viruses and/or any action or lack of action taken in reliance on it).
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Install DTB as part of images install command
2013-03-27 23:01 [Buildroot] [PATCH] Install DTB as part of images install command Reuben Dowle
2013-04-04 11:12 ` Arnout Vandecappelle
@ 2013-06-09 17:34 ` Maxime Ripard
2013-08-01 16:01 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2013-06-09 17:34 UTC (permalink / raw)
To: buildroot
Hi,
On Wed, Mar 27, 2013 at 11:01:15PM +0000, Reuben Dowle wrote:
> From: Reuben Dowle <reuben.dowle@4rf.com>
>
> When installing DTB to the images directory, do this as part of the
> image install commands rather than the target install commands.
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Peter, could you apply this patch?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] Install DTB as part of images install command
2013-03-27 23:01 [Buildroot] [PATCH] Install DTB as part of images install command Reuben Dowle
2013-04-04 11:12 ` Arnout Vandecappelle
2013-06-09 17:34 ` Maxime Ripard
@ 2013-08-01 16:01 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2013-08-01 16:01 UTC (permalink / raw)
To: buildroot
Dear Reuben Dowle,
On Wed, 27 Mar 2013 23:01:15 +0000, Reuben Dowle wrote:
> From: Reuben Dowle <reuben.dowle@4rf.com>
>
> When installing DTB to the images directory, do this as part of the image
> install commands rather than the target install commands.
>
> Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com.az>
> ---
> linux/linux.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-01 16:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-27 23:01 [Buildroot] [PATCH] Install DTB as part of images install command Reuben Dowle
2013-04-04 11:12 ` Arnout Vandecappelle
2013-04-04 11:38 ` Arnout Vandecappelle
2013-04-04 19:03 ` Reuben Dowle
2013-06-09 17:34 ` Maxime Ripard
2013-08-01 16:01 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox