Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: unset MAKEFLAGS
Date: Thu, 11 Jul 2013 13:01:13 +0200	[thread overview]
Message-ID: <20130711130113.02ef2730@skate> (raw)
In-Reply-To: <CAAXf6LVC=vqL0mCFVMpKs2A99QtBviHXsmXZp3B+fo+32-+dXA@mail.gmail.com>

Dear Thomas De Schampheleire,

On Thu, 11 Jul 2013 11:37:10 +0200, Thomas De Schampheleire wrote:

> What is the strategy with respect to cleaning up the user's
> environment when building buildroot?
> Because there are a number of other variables that users can have (and
> do have) that corrupt the build, for example:
> 
> C_INCLUDE_PATH
> CPLUS_INCLUDE_PATH
> LIBRARY_PATH
> LD_LIBRARY_PATH
> PERL5LIB
> GCC_EXEC_PREFIX
> 
> In the twisted environments that I'm working in, I'm unsetting these
> from a wrapper around buildroot make. However, it seems that there
> already are a number of cleanups done inside buildroot itself, so it
> makes sense to add the above variables to the list.
> 
> What do you think?

We have are a bit inconsistent on this. Some variables are unset from
the main Makefile, and a bunch of others are checked in
support/dependencies/dependencies.sh. For example, LD_LIBRARY_PATH
which you mentioned get checked in support/dependencies/dependencies.sh.

Looks like a bit of cleanup in this area might be useful.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2013-07-11 11:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07 18:42 [Buildroot] [PATCH] Makefile: unset MAKEFLAGS Samuel Martin
2013-07-07 19:38 ` Thomas Petazzoni
2013-07-07 20:09   ` Samuel Martin
2013-07-07 19:58 ` Peter Korsgaard
2013-07-07 20:14   ` Samuel Martin
2013-07-11  9:37 ` Thomas De Schampheleire
2013-07-11 10:33   ` Bjørn Forsman
2013-07-11 11:24     ` Thomas De Schampheleire
2013-07-11 11:46     ` Thomas Petazzoni
2013-07-11 12:02       ` Yann E. MORIN
2013-07-11 12:08         ` Thomas De Schampheleire
2013-07-11 12:17           ` Gustavo Zacarias
2013-07-12 17:07         ` Bjørn Forsman
2013-07-13 14:07           ` Thomas Petazzoni
2013-07-13 14:57             ` Bjørn Forsman
2013-07-11 11:01   ` Thomas Petazzoni [this message]
2013-07-11 11:36     ` Thomas De Schampheleire
2013-07-11 13:32       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130711130113.02ef2730@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox