Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: unset MAKEFLAGS
Date: Thu, 11 Jul 2013 09:17:09 -0300	[thread overview]
Message-ID: <51DEA245.2060109@zacarias.com.ar> (raw)
In-Reply-To: <CAAXf6LUbO+PyKHw7zDDG3bfpjwYzjoahiiO-d+wx2WJdNJW6tw@mail.gmail.com>

On 07/11/2013 09:08 AM, Thomas De Schampheleire wrote:

> But with this policy, all existing 'unexports' in the Makefile should
> be removed, and it's up to the user to fix his stuff.
> In corporate environments, for one, this is not always feasible. Many
> developers will build with buildroot as part of an overall build
> process, and will not know anything about buildroot itself nor its
> requirements. So either the overall build process should clear the
> user's environment before starting the buildroot build, or buildroot
> itself should clean up what it knows is problematic.
> 
> Since there already are several variables cleared in that way, I'm
> more in favor in going down that path and adding some more troublesome
> variables, rather than removing these bits altogether.

I agree.
At the moment it's working quite well as it is, maybe we should add some
extra unexports in the main Makefile for things that are known to be
troublesome.
For instance on Gentoo RUBYOPT is set, and when buildroot builds
host-ruby this causes problems.
The best solution would be to unexport RUBYOPT (and RUBYLIB while at
it), i just didn't send a patch yet because i'm looking at the thread to
see how it pans out :)
Regards.

  reply	other threads:[~2013-07-11 12:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07 18:42 [Buildroot] [PATCH] Makefile: unset MAKEFLAGS Samuel Martin
2013-07-07 19:38 ` Thomas Petazzoni
2013-07-07 20:09   ` Samuel Martin
2013-07-07 19:58 ` Peter Korsgaard
2013-07-07 20:14   ` Samuel Martin
2013-07-11  9:37 ` Thomas De Schampheleire
2013-07-11 10:33   ` Bjørn Forsman
2013-07-11 11:24     ` Thomas De Schampheleire
2013-07-11 11:46     ` Thomas Petazzoni
2013-07-11 12:02       ` Yann E. MORIN
2013-07-11 12:08         ` Thomas De Schampheleire
2013-07-11 12:17           ` Gustavo Zacarias [this message]
2013-07-12 17:07         ` Bjørn Forsman
2013-07-13 14:07           ` Thomas Petazzoni
2013-07-13 14:57             ` Bjørn Forsman
2013-07-11 11:01   ` Thomas Petazzoni
2013-07-11 11:36     ` Thomas De Schampheleire
2013-07-11 13:32       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DEA245.2060109@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox